Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 12:29 PM, Arnaud Charlet wrote: > Committed on trunk now. Sorry for the breakage, my build was incremental > and missed this missing part. Great. Thanks for the quick fix! Diego.

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> Testing the patch below, will commit if success. > > 2012-10-29 Arnaud Charlet > >* gcc-interface/Makefile.in (s-oscons.ads): Adjust call to >xoscons. Committed on trunk now. Sorry for the breakage, my build was incremental and missed this missing part. Arno

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> > We chatted about this on IRC, and Richi is seeing the same problem on > > his builds. > > Very strange. I'm looking at it. OK, this comes from code duplicated between gcc-interface/Makefile.in and Make-generated.in, pretty messy. Testing the patch below, will commit if success. 2012-10-29

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> I have no directory called gcc/ada/bldtools/oscons/xoscons. That's an > executable. Yes, that's as expected, I asked you to check the timestamp of this file. > Still happens with -j1 (after starting from scratch), so it's probably > not a parallel make issue. Right, no surprise here. > We ch

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:51 AM, Arnaud Charlet wrote: >> Yup, it does: > > OK then can you check the timestamp of ./gcc/ada/bldtools/oscons/xoscons > vs e.g. ./gcc/ada/bldtools/oscons/xoscons/xoscons.adb and > $(srcdir)/gcc/ada/xoscons.adb? I have no directory called gcc/ada/bldtools/oscons/xos

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> Yup, it does: OK then can you check the timestamp of ./gcc/ada/bldtools/oscons/xoscons vs e.g. ./gcc/ada/bldtools/oscons/xoscons/xoscons.adb and $(srcdir)/gcc/ada/xoscons.adb? Arno

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:48 AM, Diego Novillo wrote: > On Mon, Oct 29, 2012 at 10:44 AM, Arnaud Charlet wrote: >>> >> Well, this was a build from scratch. Maybe there is a parallel make >>> >> bug in the new ada changes? Some undeclared dependency? >>> > >>> > There is not in the recent chang

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:44 AM, Arnaud Charlet wrote: >> >> Well, this was a build from scratch. Maybe there is a parallel make >> >> bug in the new ada changes? Some undeclared dependency? >> > >> > There is not in the recent changes. Maybe there's a latent bug, although I >> > have never exp

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> >> Well, this was a build from scratch. Maybe there is a parallel make > >> bug in the new ada changes? Some undeclared dependency? > > > > There is not in the recent changes. Maybe there's a latent bug, although I > > have never experienced it. > > > > At which revision are you? > > rev 19294

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:39 AM, Arnaud Charlet wrote: >> Well, this was a build from scratch. Maybe there is a parallel make >> bug in the new ada changes? Some undeclared dependency? > > There is not in the recent changes. Maybe there's a latent bug, although I > have never experienced it. >

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> Well, this was a build from scratch. Maybe there is a parallel make > bug in the new ada changes? Some undeclared dependency? There is not in the recent changes. Maybe there's a latent bug, although I have never experienced it. At which revision are you? Arno

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
On Mon, Oct 29, 2012 at 10:36 AM, Arnaud Charlet wrote: >> After updating my tree to rev 192942 this morning, I'm getting a >> bootstrap failure with ada enabled: > > Looks like make did not rebuild (or too late?) xoscons. > > I'd suggest doing a rm -rf gcc/ada/bldtools from your obj directory and

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
> After updating my tree to rev 192942 this morning, I'm getting a > bootstrap failure with ada enabled: Looks like make did not rebuild (or too late?) xoscons. I'd suggest doing a rm -rf gcc/ada/bldtools from your obj directory and see if this fixes the error. If not, you might need to do a mak

Re: [Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Diego Novillo
Arnaud, After updating my tree to rev 192942 this morning, I'm getting a bootstrap failure with ada enabled: raised CONSTRAINT_ERROR : a-comlin.adb:65 explicit raise make[6]: *** [rts/s-oscons.ads] Error 1 make[6]: Leaving directory `bld-gcc/gcc/ada' make[5]: *** [gnatlib-shared-default] Error 2

[Ada] Ignore Optimize_Alignment (Space) for packed variable length record

2012-10-29 Thread Arnaud Charlet
Normally pragma Optimize_Alignment (Space) forces an alignment of 1 for any packed record, but we can't do that for a variable length record, since we can't implement that case, so ignore the pragma in this case with a warning. The following test program shows the patch in action: 1. pragma