[Ada] Fix code quality issues reported by CodePeer at level 3

2017-11-09 Thread Pierre-Marie de Rodat
Rerunning CodePeer at level 3 revealed further missing initializations (not errors, but good to add for maintenance and to improve analysis results) and missing No_Return pragmas. Now fixed. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-11-09 Yannick Moy * sem_attr.adb (Analy

[Ada] Fix code quality issues reported by CodePeer

2017-11-09 Thread Pierre-Marie de Rodat
Running CodePeer on GNAT frontend codebase revealed a number of code quality issues. For the most part, these are not bugs, but could lead to bugs during maintenance. A few could lead to reads of uninitialized variables. This patch fixes these issues in various ways: - add initialization in cases