Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-23 Thread Christophe Lyon
a test used to pass and now fails. It looks like you have to update it to take into account the new, better code. Christophe > -Original Message- > From: Christophe Lyon [mailto:christophe.l...@linaro.org] > Sent: Wednesday, November 23, 2016 6:42 AM > To: James Greenhalgh >

RE: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-23 Thread Michael Collison
and x0, x0, 268434944 and x0, x0, -2031617 ret -Original Message- From: Christophe Lyon [mailto:christophe.l...@linaro.org] Sent: Wednesday, November 23, 2016 6:42 AM To: James Greenhalgh Cc: Michael Collison; gcc-patches@gcc.gnu.org; nd Subject: Re: [Aarch64][PA

Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-23 Thread Christophe Lyon
Hi Michael, On 21 November 2016 at 10:52, James Greenhalgh wrote: > On Fri, Nov 18, 2016 at 07:41:58AM +, Michael Collison wrote: >> James, >> >> I incorporated all your suggestions, and successfully bootstrapped and re-ran >> the testsuite. >> >> Okay for trunk? >> >> 2016-11-18 Michael Co

Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-21 Thread James Greenhalgh
On Fri, Nov 18, 2016 at 07:41:58AM +, Michael Collison wrote: > James, > > I incorporated all your suggestions, and successfully bootstrapped and re-ran > the testsuite. > > Okay for trunk? > > 2016-11-18 Michael Collison > > * config/aarch64/aarch64-protos.h > (aarch64_and_s

RE: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-17 Thread Michael Collison
onst2.c: New test to verify additional constants are recognized and fewer instructions generated. -Original Message- From: James Greenhalgh [mailto:james.greenha...@arm.com] Sent: Thursday, November 17, 2016 9:26 AM To: Michael Collison Cc: gcc-patches@gcc.gnu.org; nd Subject: Re: [Aarch

Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-17 Thread James Greenhalgh
On Thu, Oct 27, 2016 at 08:44:02PM +, Michael Collison wrote: > This patch is designed to improve code generation for "and" instructions with > certain immediate operands. > > For the following test case: > > int f2(int x) > { >x &= 0x0ff8; > >x &= 0xff001fff; > >return x; >

[Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-10-27 Thread Michael Collison
This patch is designed to improve code generation for "and" instructions with certain immediate operands. For the following test case: int f2(int x) { x &= 0x0ff8; x &= 0xff001fff; return x; } the trunk aarch64 compiler generates: mov w1, 8184 movkw1, 0xf00, lsl 16 and