Re: [ARM] PR target/49030: ICE in get_arm_condition_code

2011-09-07 Thread Richard Earnshaw
On 02/09/11 16:01, Richard Sandiford wrote: > CC_NCV rightly only allows GE(U) and LT(U). GT(U) and LE(U) have to > implemented by reversing the condition. This is handled correctly when > the condition is first expanded, but nothing stops later optimisers from > producing invalid forms. > > Thi

Re: [ARM] PR target/49030: ICE in get_arm_condition_code

2011-09-07 Thread Ramana Radhakrishnan
> > My patch has now survived a Thumb-2 bootstrap, and it sounds like Ramana > has also successfully bootstrapped your original patch. I'd rather take the version that handles the cases for the dominance modes as well. RichardE, do you think you could have a look at this one ? cheers Ramana

Re: [ARM] PR target/49030: ICE in get_arm_condition_code

2011-09-06 Thread Richard Sandiford
Chung-Lin Tang writes: > Hi Richard, this looks very similar to this patch, originally for LP:689887: > http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00794.html > Apart from your additional handling in the dominance modes cases. Indeed. Sorry about that. It must look odd that I've posted such a

Re: [ARM] PR target/49030: ICE in get_arm_condition_code

2011-09-02 Thread Chung-Lin Tang
Hi Richard, this looks very similar to this patch, originally for LP:689887: http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00794.html Apart from your additional handling in the dominance modes cases. I remember that last patch was held down because Thumb-2 native bootstrap failed. Did you try that

[ARM] PR target/49030: ICE in get_arm_condition_code

2011-09-02 Thread Richard Sandiford
CC_NCV rightly only allows GE(U) and LT(U). GT(U) and LE(U) have to implemented by reversing the condition. This is handled correctly when the condition is first expanded, but nothing stops later optimisers from producing invalid forms. This patch makes arm_comparison_operator check that the con