Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Eric Botcazou
> > /* { dg-do run } */ > > /* { dg-require-effective-target arm_neon_hw } */ > > /* { dg-options "-fno-omit-frame-pointer -mapcs-frame -O" } */ > > /* { dg-add-options arm_neon } */ > > Yes, something like that. OK, installed after checking that this doesn't change the test, thanks. -- Eric Bo

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Richard Earnshaw
On 10/01/14 12:28, Eric Botcazou wrote: >> Can you not use (or add something similar to) { dg-add-options arm_neon }? > > Probably, yes, something like: > > /* { dg-do run } */ > /* { dg-require-effective-target arm_neon_hw } */ > /* { dg-options "-fno-omit-frame-pointer -mapcs-frame -O" } */ > /

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Eric Botcazou
> Can you not use (or add something similar to) { dg-add-options arm_neon }? Probably, yes, something like: /* { dg-do run } */ /* { dg-require-effective-target arm_neon_hw } */ /* { dg-options "-fno-omit-frame-pointer -mapcs-frame -O" } */ /* { dg-add-options arm_neon } */ -- Eric Botcazou

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Richard Earnshaw
On 10/01/14 11:48, Eric Botcazou wrote: >> Some tests can do it because they don't produce an executable. > > OK, there is some related dg-skip-if magic in 20090811-1.c, maybe Christophe > can try that too. > Can you not use (or add something similar to) { dg-add-options arm_neon }? R.

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Eric Botcazou
> Some tests can do it because they don't produce an executable. OK, there is some related dg-skip-if magic in 20090811-1.c, maybe Christophe can try that too. -- Eric Botcazou

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Richard Earnshaw
On 10/01/14 09:46, Eric Botcazou wrote: >> This new test fails when GCC is configured as target >> arm-none-linux-gnueabihf and --with-float=hard: >> tools/arm-none-linux-gnueabihf/bin/ld: error: ./neon-nested-apcs.exe >> uses VFP register arguments, /tmp/cc9LLqES.o does not >> tools/arm-none-linux

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Eric Botcazou
> This new test fails when GCC is configured as target > arm-none-linux-gnueabihf and --with-float=hard: > tools/arm-none-linux-gnueabihf/bin/ld: error: ./neon-nested-apcs.exe > uses VFP register arguments, /tmp/cc9LLqES.o does not > tools/arm-none-linux-gnueabihf/bin/ld: failed to merge target spe

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-10 Thread Christophe Lyon
Hi, > > 2013-12-22 Eric Botcazou > > * gcc.target/arm/neon-nested-apcs.c: New test. > This new test fails when GCC is configured as target arm-none-linux-gnueabihf and --with-float=hard: tools/arm-none-linux-gnueabihf/bin/ld: error: ./neon-nested-apcs.exe uses VFP register arguments, /tm

Re: [ARM] Fix incorrect restore of FP registers in nested APCS frame

2014-01-03 Thread Richard Earnshaw
On 22/12/13 17:42, Eric Botcazou wrote: > Hi, > > this is the last issue with nested APCS frames according to our testing. > When > the IP register needs to be preserved on entry and r3 isn't free and there are > no arguments to push, the prologue creates a slot above the frame, so various > i

[ARM] Fix incorrect restore of FP registers in nested APCS frame

2013-12-22 Thread Eric Botcazou
Hi, this is the last issue with nested APCS frames according to our testing. When the IP register needs to be preserved on entry and r3 isn't free and there are no arguments to push, the prologue creates a slot above the frame, so various internal offsets need to be adjusted. One has been miss