Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-06-14 Thread Evandro Menezes
On 06/14/16 03:28, Christophe Lyon wrote: On 13 June 2016 at 21:06, Evandro Menezes wrote: On 06/13/16 05:15, James Greenhalgh wrote: Thanks for your patience on this patch series. Just checked the series in. If I'm not mistaken, it looks like you forgot to update the ChangeLog files in yo

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-06-14 Thread Christophe Lyon
On 13 June 2016 at 21:06, Evandro Menezes wrote: > On 06/13/16 05:15, James Greenhalgh wrote: >> >> Thanks for your patience on this patch series. > > > Just checked the series in. > Hi Evandro, If I'm not mistaken, it looks like you forgot to update the ChangeLog files in your commits. Christoph

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-06-13 Thread Evandro Menezes
On 06/13/16 05:15, James Greenhalgh wrote: Thanks for your patience on this patch series. Just checked the series in. Thank y'all for your assistance and patience. Cheers, -- Evandro Menezes

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-06-13 Thread James Greenhalgh
nks for your patience on this patch series. Thanks, James > From d791090aae6a29fa94d8fc10894ee1053b05bcc2 Mon Sep 17 00:00:00 2001 > From: Evandro Menezes > Date: Mon, 4 Apr 2016 14:02:24 -0500 > Subject: [PATCH 3/3] [AArch64] Emit division using the Newton series > > 2016-04-04 Evandro Menezes

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-06-03 Thread Evandro Menezes
Rebasing the patch... -- Evandro Menezes >From d791090aae6a29fa94d8fc10894ee1053b05bcc2 Mon Sep 17 00:00:00 2001 From: Evandro Menezes Date: Mon, 4 Apr 2016 14:02:24 -0500 Subject: [PATCH 3/3] [AArch64] Emit division using the Newton series 2016-04-04 Evandro Menezes Wi

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-05-31 Thread Evandro Menezes
oid) Thank you, -- Evandro Menezes >From e598b0df2e43f2e64254a0e1ddec608fd78025b1 Mon Sep 17 00:00:00 2001 From: Evandro Menezes Date: Mon, 4 Apr 2016 14:02:24 -0500 Subject: [PATCH 3/3] [AArch64] Emit division using the Newton series 2016-04-04 Evandro Menezes Wilco Dijkst

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-05-31 Thread James Greenhalgh
On Fri, May 27, 2016 at 05:57:30PM -0500, Evandro Menezes wrote: > On 05/25/16 11:16, James Greenhalgh wrote: > >On Wed, Apr 27, 2016 at 04:15:53PM -0500, Evandro Menezes wrote: > >>gcc/ > >> * config/aarch64/aarch64-protos.h > >> (tune_params): Add new member "approx_div_modes"

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-05-27 Thread Evandro Menezes
register_operand" "w") +(match_operand:GPF 2 "register_operand" "w")))] "TARGET_FLOAT" "fdiv\\t%0, %1, %2" [(set_attr "type" "fdiv")] Thank you, -- Evandro Menezes >From a7d49bfa27cd3ae32

Re: [PATCH 3/3][AArch64] Emit division using the Newton series

2016-05-25 Thread James Greenhalgh
On Wed, Apr 27, 2016 at 04:15:53PM -0500, Evandro Menezes wrote: >gcc/ > * config/aarch64/aarch64-protos.h > (tune_params): Add new member "approx_div_modes". > (aarch64_emit_approx_div): Declare new function. > * config/aarch64/aarch64.c > (generic_tunin

[PATCH 3/3][AArch64] Emit division using the Newton series

2016-04-27 Thread Evandro Menezes
new option. -- Evandro Menezes >From 0bdd18af83a82377dd6b954c4e64904f6022a2b2 Mon Sep 17 00:00:00 2001 From: Evandro Menezes Date: Mon, 4 Apr 2016 14:02:24 -0500 Subject: [PATCH 3/3] [AArch64] Emit division using the Newton series 2016-04-04 Evandro Menezes Wilco Dijkstra gcc/ * config/aarch

Re: [AArch64] Emit division using the Newton series

2016-04-27 Thread Evandro Menezes
On 04/27/16 09:15, James Greenhalgh wrote: So this is off for all cores currently supported by GCC? I'm not sure I understand why we should take this if it will immediately be dead code? Excuse me? Not only are other target maintainers free to evaluate if this code is useful to them, but so

Re: [AArch64] Emit division using the Newton series

2016-04-27 Thread Wilco Dijkstra
James Greenhalgh wrote: > So this is off for all cores currently supported by GCC? > > I'm not sure I understand why we should take this if it will immediately > be dead code? I presume it was meant to have the vector variants enabled with -mcpu=exynos-m1 as that is where you can get a good gain

Re: [AArch64] Emit division using the Newton series

2016-04-27 Thread James Greenhalgh
> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index b7086dd..21af809 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -414,7 +414,8 @@ static const struct tune_params generic_tunings = >0, /* max_case_values. */ >0, /* cac

RE: [AArch64] Emit division using the Newton series

2016-04-21 Thread Evandro Menezes
gt;>> Ie. we saved > >>> a multiply. > >>> > >>> In principle this could be done as a separate optimization pass that > >>> tries to reassociate to reduce latency. However I'm not too > >>> convinced this would b

Re: [AArch64] Emit division using the Newton series

2016-04-12 Thread Evandro Menezes
x27;s best to do it explicitly. I think that I see what you mean. I'll hack something tomorrow. [AArch64] Emit division using the Newton series 2016-04-04 Evandro Menezes Wilco Dijkstra gcc/ * config/aarch64/aarch64-tuning-flags.def

Re: [AArch64] Emit division using the Newton series

2016-04-04 Thread Evandro Menezes
hat I see what you mean. I'll hack something tomorrow. [AArch64] Emit division using the Newton series 2016-04-04 Evandro Menezes Wilco Dijkstra gcc/ * config/aarch64/aarch64-tuning-flags.def * config/aarch64/aarch64-protos.h

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Evandro Menezes
On 04/01/16 17:45, Wilco Dijkstra wrote: Evandro Menezes wrote: However, I don't think that there's the need to handle any special case for division. The only case when the approximation differs from division is when the numerator is infinity and the denominator, zero, when the approximation r

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Wilco Dijkstra
Evandro Menezes wrote: > However, I don't think that there's the need to handle any special case > for division. The only case when the approximation differs from > division is when the numerator is infinity and the denominator, zero, > when the approximation returns infinity and the division, NA

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Evandro Menezes
On 04/01/16 16:22, Wilco Dijkstra wrote: Evandro Menezes wrote: The division variant should use the same latency reduction trick I mentioned for sqrt. I don't think that it applies here, since it doesn't have to deal with special cases. No it applies as it's exactly the same calculation: x *

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Wilco Dijkstra
Evandro Menezes wrote: > > The division variant should use the same latency reduction trick I > > mentioned for sqrt. > > I don't think that it applies here, since it doesn't have to deal with > special cases. No it applies as it's exactly the same calculation: x * rsqrt(y) and x * recip(y). In

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Evandro Menezes
On 04/01/16 08:58, Wilco Dijkstra wrote: Evandro Menezes wrote: On 03/23/16 11:24, Evandro Menezes wrote: On 03/17/16 15:09, Evandro Menezes wrote: This patch implements FP division by an approximation using the Newton series. With this patch, DF division is sped up by over 100% and SF divisio

Re: [AArch64] Emit division using the Newton series

2016-04-01 Thread Wilco Dijkstra
Evandro Menezes wrote: On 03/23/16 11:24, Evandro Menezes wrote: > On 03/17/16 15:09, Evandro Menezes wrote: >> This patch implements FP division by an approximation using the Newton >> series. >> >> With this patch, DF division is sped up by over 100% and SF division, >> zilch, both on A57 and on

Re: [AArch64] Emit division using the Newton series

2016-03-31 Thread Evandro Menezes
On 03/23/16 11:24, Evandro Menezes wrote: On 03/17/16 15:09, Evandro Menezes wrote: This patch implements FP division by an approximation using the Newton series. With this patch, DF division is sped up by over 100% and SF division, zilch, both on A57 and on M1. gcc/ * con

Re: [AArch64] Emit division using the Newton series

2016-03-23 Thread Evandro Menezes
On 03/17/16 15:09, Evandro Menezes wrote: This patch implements FP division by an approximation using the Newton series. With this patch, DF division is sped up by over 100% and SF division, zilch, both on A57 and on M1. gcc/ * config/aarch64/aarch64-tuning-flags.def

Re: [AArch64] Emit division using the Newton series

2016-03-23 Thread Evandro Menezes
1.0. Again, I look forward to your feedback. Thank you, -- Evandro Menezes >From 5cd2a628086af3656b3242f0c4f41784646f52b1 Mon Sep 17 00:00:00 2001 From: Evandro Menezes Date: Thu, 17 Mar 2016 14:44:55 -0500 Subject: [PATCH] [AArch64] Emit division using the Newton series 2016-03-17 Evandro Me

[AArch64] Emit division using the Newton series

2016-03-19 Thread Evandro Menezes
Emit division using the Newton series 2016-03-17 Evandro Menezes gcc/ * config/aarch64/aarch64-tuning-flags.def (AARCH64_EXTRA_TUNE_APPROX_DIV_{SF,DF}: New tuning macros. * config/aarch64/aarch64-protos.h (AARCH64_EXTRA_T