Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-18 Thread Richard Sandiford
Eric Botcazou writes: >> OK. The current recursive force-mem-to-reg cases in store_bit_field_1 >> and extract_bit_field_1 don't handle -fstrict-volatile-bitfields at all, >> so this patch was trying to fix what seemed like an oversight. Is it OK >> to leave the code as-is (not handling -fstrict-

Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-15 Thread Eric Botcazou
> OK. The current recursive force-mem-to-reg cases in store_bit_field_1 > and extract_bit_field_1 don't handle -fstrict-volatile-bitfields at all, > so this patch was trying to fix what seemed like an oversight. Is it OK > to leave the code as-is (not handling -fstrict-volatile-bitfields), > or d

Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-15 Thread Richard Sandiford
Eric Botcazou writes: >> The idea was to centralise the knowledge about what modes are valid >> rather than requiring every client to know the rules. From that point >> of view it seems inconsistent for the new interface to handle the >> bitregion_{start,end} restrictions (a correctness issue) bu

Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-15 Thread Eric Botcazou
> The idea was to centralise the knowledge about what modes are valid > rather than requiring every client to know the rules. From that point > of view it seems inconsistent for the new interface to handle the > bitregion_{start,end} restrictions (a correctness issue) but not the > volatility rest

Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-15 Thread Richard Sandiford
Thanks for the reviews. Eric Botcazou writes: >> This patch makes bit_field_mode_iterator take -fstrict-volatile-bitfields >> into account, in cases where the size of the underlying object is known. >> This is used in the next patch. > > Do we really need to add that to the iterator? The -fstric

Re: [6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-13 Thread Eric Botcazou
> This patch makes bit_field_mode_iterator take -fstrict-volatile-bitfields > into account, in cases where the size of the underlying object is known. > This is used in the next patch. Do we really need to add that to the iterator? The -fstrict-volatile- bitfields implementation is still controve

[6/8] Add strict volatile handling to bit_field_mode_iterator

2012-11-03 Thread Richard Sandiford
This patch makes bit_field_mode_iterator take -fstrict-volatile-bitfields into account, in cases where the size of the underlying object is known. This is used in the next patch. Tested as described in the covering note. OK to install? Richard gcc/ * machmode.h (bit_field_mode_iterator