Re: Named address spaces broken (Re: [2/5] Add a set_mem_attrs function)

2011-07-20 Thread Ulrich Weigand
Richard Guenther wrote: > Ok. Checked in, thanks. > Do we have any chance of adding generic testcases for named-address-space > support that would show these issues? Not really; named address space are fundamentally target-specific. It certainly would help if a more common target provided some

Re: Named address spaces broken (Re: [2/5] Add a set_mem_attrs function)

2011-07-20 Thread Richard Guenther
On Wed, 20 Jul 2011, Ulrich Weigand wrote: > Richard Sandiford wrote: > > >/* Now set the attributes we computed above. */ > > - MEM_ATTRS (ref) > > -= find_mem_attrs (alias, expr, offset, size, align, > > - TYPE_ADDR_SPACE (type), GET_MODE (ref)); > > + set_mem_attrs (

Named address spaces broken (Re: [2/5] Add a set_mem_attrs function)

2011-07-20 Thread Ulrich Weigand
Richard Sandiford wrote: >/* Now set the attributes we computed above. */ > - MEM_ATTRS (ref) > -= find_mem_attrs (alias, expr, offset, size, align, > - TYPE_ADDR_SPACE (type), GET_MODE (ref)); > + set_mem_attrs (ref, &attrs); This removes the bit where the MEM's addr

Re: [2/5] Add a set_mem_attrs function

2011-07-18 Thread Richard Guenther
On Sun, Jul 17, 2011 at 4:29 PM, Richard Sandiford wrote: > Internally, emit-rtl.c uses the idiom: > >  MEM_ATTRS (mem) = get_mem_attrs (MEM_ALIAS_SET (mem), MEM_EXPR (mem), >                                   MEM_OFFSET (mem), size, MEM_ALIGN (mem), >                                   MEM_ADDR_SP

[2/5] Add a set_mem_attrs function

2011-07-17 Thread Richard Sandiford
Internally, emit-rtl.c uses the idiom: MEM_ATTRS (mem) = get_mem_attrs (MEM_ALIAS_SET (mem), MEM_EXPR (mem), MEM_OFFSET (mem), size, MEM_ALIGN (mem), MEM_ADDR_SPACE (mem), GET_MODE (mem)); where we're reiterating most of the