Re: [13/13] hash-map: reject empty-looking insertions

2022-12-27 Thread David Malcolm via Gcc-patches
On Tue, 2022-12-27 at 01:39 -0300, Alexandre Oliva via Gcc-patches wrote: > > Check, after inserting entries, that they don't look empty. Thanks for working on this - I often get this stuff wrong. Would it make sense to also add assertions that such entries aren't Traits::is_deleted? (both for

Re: [13/13] hash-map: reject empty-looking insertions

2022-12-27 Thread Jeff Law via Gcc-patches
On 12/26/22 21:39, Alexandre Oliva via Gcc-patches wrote: Check, after inserting entries, that they don't look empty. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * hash-map.h (put, get_or_insert): Check that entry does not look empty after insertion

[13/13] hash-map: reject empty-looking insertions

2022-12-26 Thread Alexandre Oliva via Gcc-patches
Check, after inserting entries, that they don't look empty. Regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog * hash-map.h (put, get_or_insert): Check that entry does not look empty after insertion. --- gcc/hash-map.h |4 +++- 1 file changed, 3 insertion