Re: [1/8] Remove redundant BLKmode test

2012-10-31 Thread Richard Biener
On Tue, Oct 30, 2012 at 11:00 PM, Eric Botcazou wrote: >> gcc/ >> * expmed.c (store_bit_field_1): Remove test for BLKmode values. > > This looks fine to me. Btw, I consider Eric the best person to approve changes in this area. Thus if there is any doubt all patches in this series are ok if

Re: [1/8] Remove redundant BLKmode test

2012-10-30 Thread Eric Botcazou
> gcc/ > * expmed.c (store_bit_field_1): Remove test for BLKmode values. This looks fine to me. -- Eric Botcazou

[1/8] Remove redundant BLKmode test

2012-10-30 Thread Richard Sandiford
This patch removes what I believe is a redundant check in store_bit_field_1 for whether the value to insert (i.e. the rhs) has BLKmode. We shouldn't see BLKmode values here, and even if we did, the only effect of the test is to fall through to store_fixed_bit_field, which can't handle BLKmode eith