Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-11 Thread Eric Botcazou
> Now bootstrapped & regression-tested on x86_64-linux-gnu. OK to install? Sure, modulo... > Thanks, > Richard > > > gcc/ > * simplify-rtx.c (simplify_unary_operation_1): Use simplify_gen_binary > for (not (neg ...)) and (neg (not ...)) casees. 'cases' -- Eric Botcazou

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-11 Thread Richard Sandiford
James Greenhalgh writes: > On Tue, Sep 10, 2013 at 08:09:42PM +0100, Richard Sandiford wrote: >> Sorry for the breakage. gen_int_mode and GEN_INT really are only for >> scalar integers though. (So is plus_constant.) Vector constants should >> be CONST_VECTORs rather than CONST_INTs. >> >> I th

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-10 Thread James Greenhalgh
On Tue, Sep 10, 2013 at 08:09:42PM +0100, Richard Sandiford wrote: > Sorry for the breakage. gen_int_mode and GEN_INT really are only for > scalar integers though. (So is plus_constant.) Vector constants should > be CONST_VECTORs rather than CONST_INTs. > > I think the gcc.target/aarch64/vect-f

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-10 Thread Richard Sandiford
James Greenhalgh writes: > This seems to have caused PR58373. The bug occurs where GEN_INT would > previously have then been used to build a constant of vector mode. > > These pop in a few places when building for AArch64, though I did > the debugging using gcc.target/aarch64/vect-fcm-eq-d.c > > H

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-10 Thread James Greenhalgh
Hi, This seems to have caused PR58373. The bug occurs where GEN_INT would previously have then been used to build a constant of vector mode. These pop in a few places when building for AArch64, though I did the debugging using gcc.target/aarch64/vect-fcm-eq-d.c Here we could get in to the situa

Re: [1/4] Using gen_int_mode instead of GEN_INT

2013-09-09 Thread Richard Biener
On Mon, Sep 9, 2013 at 12:21 PM, Richard Sandiford wrote: > These four patches are the result of going through gcc/* looking for > places where there was an obvious mode associated with a GEN_INT and > where gen_int_mode could therefore be used instead. Some of the GEN_INTs > did create noncanoic

[1/4] Using gen_int_mode instead of GEN_INT

2013-09-09 Thread Richard Sandiford
These four patches are the result of going through gcc/* looking for places where there was an obvious mode associated with a GEN_INT and where gen_int_mode could therefore be used instead. Some of the GEN_INTs did create noncanoical rtl before, and were trapped by Kenny's assert on the wide-int b