Re: [1/3] OpenACC reductions

2021-08-09 Thread Thomas Schwinge
Hi! On 2015-11-02T11:18:37-0500, Nathan Sidwell wrote: > This is the core execution bits of OpenACC reductions. > > We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook > goacc.reduction, to lower it on the target compiler. Yay for proper abstraction! Long ago committed in r229

[gomp4] Re: [1/3] OpenACC reductions

2015-11-06 Thread Thomas Schwinge
Hi Nathan! On Mon, 2 Nov 2015 11:18:37 -0500, Nathan Sidwell wrote: > This is the core execution bits of OpenACC reductions. > One thing not handled by this patch are reductions of variables of reference > type. We have an implementation on gomp4 branch [...] Trying to keep the existing code

Re: [1/3] OpenACC reductions

2015-11-04 Thread Jakub Jelinek
On Wed, Nov 04, 2015 at 08:58:26AM -0500, Nathan Sidwell wrote: > On 11/04/15 05:31, Jakub Jelinek wrote: > >On Tue, Nov 03, 2015 at 11:01:57AM -0500, Nathan Sidwell wrote: > >>On 11/03/15 10:46, Jakub Jelinek wrote: > >>>On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: > This is

Re: [1/3] OpenACC reductions

2015-11-04 Thread Nathan Sidwell
On 11/04/15 05:31, Jakub Jelinek wrote: On Tue, Nov 03, 2015 at 11:01:57AM -0500, Nathan Sidwell wrote: On 11/03/15 10:46, Jakub Jelinek wrote: On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: This is the core execution bits of OpenACC reductions. We have a new internal fn 'IFN

Re: [1/3] OpenACC reductions

2015-11-04 Thread Jakub Jelinek
On Tue, Nov 03, 2015 at 11:01:57AM -0500, Nathan Sidwell wrote: > On 11/03/15 10:46, Jakub Jelinek wrote: > >On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: > >>This is the core execution bits of OpenACC reductions. > >> > >>We have a new internal fn 'IFN_GOACC_REDUCTION' and a new

Re: [1/3] OpenACC reductions

2015-11-04 Thread Jakub Jelinek
On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: > 2015-11-02 Nathan Sidwell > Cesar Philippidis > > * internal-fn.def (GOACC_REDUCTION): New. > * internal-fn.h (enum ifn_goacc_reduction_kind): New. > * internal-fn.c (expand_GOACC_REDUCTION): New. >

Re: [1/3] OpenACC reductions

2015-11-03 Thread Nathan Sidwell
On 11/03/15 10:46, Jakub Jelinek wrote: On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: This is the core execution bits of OpenACC reductions. We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook goacc.reduction, to lower it on the target compiler. So, let me

Re: [1/3] OpenACC reductions

2015-11-03 Thread Jakub Jelinek
On Mon, Nov 02, 2015 at 11:18:37AM -0500, Nathan Sidwell wrote: > This is the core execution bits of OpenACC reductions. > > We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook > goacc.reduction, to lower it on the target compiler. So, let me start with a few questions: 1) does

Re: [1/3] OpenACC reductions

2015-11-02 Thread Nathan Sidwell
This is the core execution bits of OpenACC reductions. We have a new internal fn 'IFN_GOACC_REDUCTION' and a new target hook goacc.reduction, to lower it on the target compiler. The omp-low changes are: 1) remove all the existing OpenACC reduction handling 2) when emitting an openacc loop hea