Re: [05/13] Add nofree_ptr_hash

2015-06-25 Thread Jeff Law
On 06/25/2015 11:33 AM, Richard Sandiford wrote: Jeff Law writes: On 06/25/2015 03:49 AM, Richard Biener wrote: On Thu, Jun 25, 2015 at 5:19 AM, Jeff Law wrote: On 06/24/2015 02:23 AM, Richard Sandiford wrote: Jeff Law writes: So I'm holding off on approving this one pending further dis

Re: [05/13] Add nofree_ptr_hash

2015-06-25 Thread Richard Sandiford
Jeff Law writes: > On 06/25/2015 03:49 AM, Richard Biener wrote: >> On Thu, Jun 25, 2015 at 5:19 AM, Jeff Law wrote: >>> On 06/24/2015 02:23 AM, Richard Sandiford wrote: Jeff Law writes: > > So I'm holding off on approving this one pending further discussion of > the use of

Re: [05/13] Add nofree_ptr_hash

2015-06-25 Thread Jeff Law
On 06/25/2015 03:49 AM, Richard Biener wrote: On Thu, Jun 25, 2015 at 5:19 AM, Jeff Law wrote: On 06/24/2015 02:23 AM, Richard Sandiford wrote: Jeff Law writes: So I'm holding off on approving this one pending further discussion of the use of multiple inheritance for nofree_ptr_hash. I

Re: [05/13] Add nofree_ptr_hash

2015-06-25 Thread Richard Biener
On Thu, Jun 25, 2015 at 5:19 AM, Jeff Law wrote: > On 06/24/2015 02:23 AM, Richard Sandiford wrote: >> >> Jeff Law writes: >>> >>> So I'm holding off on approving this one pending further discussion of >>> the use of multiple inheritance for nofree_ptr_hash. >> >> >> I thought that might be contr

Re: [05/13] Add nofree_ptr_hash

2015-06-24 Thread Jeff Law
On 06/24/2015 02:23 AM, Richard Sandiford wrote: Jeff Law writes: So I'm holding off on approving this one pending further discussion of the use of multiple inheritance for nofree_ptr_hash. I thought that might be controversial. :-) My two main defences are: 1) This is multiple inheritance

Re: [05/13] Add nofree_ptr_hash

2015-06-24 Thread Richard Sandiford
Jeff Law writes: > On 06/16/2015 02:55 AM, Richard Sandiford wrote: >> This patch stops pointer_hash from inheriting typed_noop_remove and >> instead creates a new class nofree_ptr_hash that inherits from both. >> It then updates all uses of typed_noop_remove (which are all pointers) >> and pointe

Re: [05/13] Add nofree_ptr_hash

2015-06-23 Thread Jeff Law
On 06/16/2015 02:55 AM, Richard Sandiford wrote: This patch stops pointer_hash from inheriting typed_noop_remove and instead creates a new class nofree_ptr_hash that inherits from both. It then updates all uses of typed_noop_remove (which are all pointers) and pointer_hash so that they use this n

[05/13] Add nofree_ptr_hash

2015-06-16 Thread Richard Sandiford
This patch stops pointer_hash from inheriting typed_noop_remove and instead creates a new class nofree_ptr_hash that inherits from both. It then updates all uses of typed_noop_remove (which are all pointers) and pointer_hash so that they use this new class instead. gcc/ * hash-table.h: Upd