Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-25 Thread Richard Biener via Gcc-patches
On Thu, Jun 24, 2021 at 5:31 PM Jason Merrill via Gcc-patches wrote: > > On 6/24/21 11:13 AM, Jose E. Marchesi wrote: > > > > This patch introduces a dwarf2int.h header, to be used by code that > > needs access to the internal DIE structures and their attributes. > > Why not put

Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-24 Thread Jason Merrill via Gcc-patches
On 6/24/21 11:13 AM, Jose E. Marchesi wrote: This patch introduces a dwarf2int.h header, to be used by code that needs access to the internal DIE structures and their attributes. Why not put these bits in dwarf2out.h? We think that it makes sense to have a separated interface file for the im

Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-24 Thread Jose E. Marchesi via Gcc-patches
This patch introduces a dwarf2int.h header, to be used by code that needs access to the internal DIE structures and their attributes. >>> >>> Why not put these bits in dwarf2out.h? >> We think that it makes sense to have a separated interface file for >> the >> implementation of DWARF-b

Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-24 Thread Jason Merrill via Gcc-patches
On 6/24/21 9:52 AM, Jose E. Marchesi wrote: On 5/31/21 12:57 PM, Jose E. Marchesi via Gcc-patches wrote: This patch introduces a dwarf2int.h header, to be used by code that needs access to the internal DIE structures and their attributes. Why not put these bits in dwarf2out.h? We think that

Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-24 Thread Jose E. Marchesi via Gcc-patches
Hi Jason. > On 5/31/21 12:57 PM, Jose E. Marchesi via Gcc-patches wrote: >> This patch introduces a dwarf2int.h header, to be used by code that >> needs access to the internal DIE structures and their attributes. > > Why not put these bits in dwarf2out.h? We think that it makes sense to have a

Re: [[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-06-22 Thread Jason Merrill via Gcc-patches
On 5/31/21 12:57 PM, Jose E. Marchesi via Gcc-patches wrote: This patch introduces a dwarf2int.h header, to be used by code that needs access to the internal DIE structures and their attributes. Why not put these bits in dwarf2out.h? The following functions which were previously defined as st

[[PATCH V9] 1/7] dwarf: add a dwarf2int.h internal interface

2021-05-31 Thread Jose E. Marchesi via Gcc-patches
This patch introduces a dwarf2int.h header, to be used by code that needs access to the internal DIE structures and their attributes. The following functions which were previously defined as static in dwarf2out.c are now non-static, and extern prototypes for them have been added to dwarf2int.h: -