Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-20 Thread Richard Biener
On Thu, Nov 20, 2014 at 4:34 PM, Michael Matz wrote: > Hi, > > On Thu, 20 Nov 2014, Richard Biener wrote: > >> > I don't think this API will make the non-C++-fans happier; I think the >> > objection to the work I just merged is that it's adding more C++ than >> > those people are comfortable with.

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-20 Thread Michael Matz
Hi, On Thu, 20 Nov 2014, Richard Biener wrote: > > I don't think this API will make the non-C++-fans happier; I think the > > objection to the work I just merged is that it's adding more C++ than > > those people are comfortable with. > > How so? It's already super-ugly in those views. We deci

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-20 Thread Andrew MacLeod
On 11/20/2014 08:08 AM, Richard Biener wrote: On Thu, Nov 20, 2014 at 12:05 AM, Andrew MacLeod wrote: On 11/19/2014 05:24 PM, David Malcolm wrote: On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: On November 19, 2014 10:09:56 PM CET, Andrew MacLeod wrote: On 11/19/2014 03:43 PM, Ric

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-20 Thread Richard Biener
On Wed, Nov 19, 2014 at 11:24 PM, David Malcolm wrote: > On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: >> On November 19, 2014 10:09:56 PM CET, Andrew MacLeod >> wrote: >> >On 11/19/2014 03:43 PM, Richard Biener wrote: >> >> On November 19, 2014 8:26:23 PM CET, Andrew MacLeod >> > wro

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-20 Thread Richard Biener
On Thu, Nov 20, 2014 at 12:05 AM, Andrew MacLeod wrote: > On 11/19/2014 05:24 PM, David Malcolm wrote: >> >> On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: >>> >>> On November 19, 2014 10:09:56 PM CET, Andrew MacLeod >>> wrote: On 11/19/2014 03:43 PM, Richard Biener wrote: >>>

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Andrew MacLeod
On 11/19/2014 05:24 PM, David Malcolm wrote: On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: On November 19, 2014 10:09:56 PM CET, Andrew MacLeod wrote: On 11/19/2014 03:43 PM, Richard Biener wrote: On November 19, 2014 8:26:23 PM CET, Andrew MacLeod wrote: On 11/19/2014 01:12 PM

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Andrew MacLeod
On 11/19/2014 05:28 PM, David Malcolm wrote: On Wed, 2014-11-19 at 17:24 -0500, David Malcolm wrote: On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: On November 19, 2014 10:09:56 PM CET, Andrew MacLeod wrote: On 11/19/2014 03:43 PM, Richard Biener wrote: On November 19, 2014 8:26:2

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread David Malcolm
On Wed, 2014-11-19 at 17:24 -0500, David Malcolm wrote: > On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: > > On November 19, 2014 10:09:56 PM CET, Andrew MacLeod > > wrote: > > >On 11/19/2014 03:43 PM, Richard Biener wrote: > > >> On November 19, 2014 8:26:23 PM CET, Andrew MacLeod > >

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread David Malcolm
On Wed, 2014-11-19 at 22:36 +0100, Richard Biener wrote: > On November 19, 2014 10:09:56 PM CET, Andrew MacLeod > wrote: > >On 11/19/2014 03:43 PM, Richard Biener wrote: > >> On November 19, 2014 8:26:23 PM CET, Andrew MacLeod > > wrote: > >>> On 11/19/2014 01:12 PM, David Malcolm wrote: > >>> >

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Richard Biener
On November 19, 2014 10:09:56 PM CET, Andrew MacLeod wrote: >On 11/19/2014 03:43 PM, Richard Biener wrote: >> On November 19, 2014 8:26:23 PM CET, Andrew MacLeod > wrote: >>> On 11/19/2014 01:12 PM, David Malcolm wrote: >>> (A) could become: greturn *stmt = gsi->as_a_greturn ()

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Andrew MacLeod
On 11/19/2014 03:43 PM, Richard Biener wrote: On November 19, 2014 8:26:23 PM CET, Andrew MacLeod wrote: On 11/19/2014 01:12 PM, David Malcolm wrote: (A) could become: greturn *stmt = gsi->as_a_greturn (); (B) could become: stmt = gsi->dyn_cast (); if (!stmt) or: stmt = g

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Richard Biener
On November 19, 2014 8:26:23 PM CET, Andrew MacLeod wrote: >On 11/19/2014 01:12 PM, David Malcolm wrote: > >> >> (A) could become: >> >>greturn *stmt = gsi->as_a_greturn (); >> >> (B) could become: >> >>stmt = gsi->dyn_cast (); >>if (!stmt) > >> or: >> >>stmt = gsi->dyn_cast_gcall

Re: "gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread Andrew MacLeod
On 11/19/2014 01:12 PM, David Malcolm wrote: (A) could become: greturn *stmt = gsi->as_a_greturn (); (B) could become: stmt = gsi->dyn_cast (); if (!stmt) or: stmt = gsi->dyn_cast_gcall (); if (!stmt) or maybe: stmt = gsi->is_a_gcall (); if (!stmt) An earlier ver

"gimple-classes-v2-option-3" git branch committed to svn trunk as r217787

2014-11-19 Thread David Malcolm
I've committed the cut-down version of the gimple statement subclasses work to svn trunk [specifically the gimple-classes-v2-option-3 git branch, having bootstrapped®rested it on x86_64-unknown-linux-gnu (Fedora 20)]. This is the the 89-patch kit from https://gcc.gnu.org/ml/gcc-patches/2014-04/