Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest'

2024-12-08 Thread Sam James
Thomas Schwinge writes: > Hi Sam! Hi! > > On 2024-12-06T09:34:32+, Sam James wrote: >> The script has #!/bin/sh shebang (and hence must have POSIX shell >> compatibility), but the patch introduces uses of the 'local' keyword >> which isn't in POSIX. >> >> While many shells do have the 'loca

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest' (was: 'gcc/config/nvptx/t-nvptx': Don't use the 'shell' function of 'make' (was: nvptx: Allow '--with-arch' to override the default

2024-12-06 Thread Thomas Schwinge
Hi Sam! On 2024-12-06T09:34:32+, Sam James wrote: > The script has #!/bin/sh shebang (and hence must have POSIX shell > compatibility), but the patch introduces uses of the 'local' keyword > which isn't in POSIX. > > While many shells do have the 'local' keyword, its behaviour isn't > portabl

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest' (was: 'gcc/config/nvptx/t-nvptx': Don't use the 'shell' function of 'make' (was: nvptx: Allow '--with-arch' to override the default

2024-12-06 Thread Sam James
Hi! The script has #!/bin/sh shebang (and hence must have POSIX shell compatibility), but the patch introduces uses of the 'local' keyword which isn't in POSIX. While many shells do have the 'local' keyword, its behaviour isn't portable across those either, which is why it's likely it'll never be

Re: 'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest'

2024-12-06 Thread Sam James
Sam James writes: > Hi! > > The script has #!/bin/sh shebang (and hence must have POSIX shell > compatibility), but the patch introduces uses of the 'local' keyword > which isn't in POSIX. > > While many shells do have the 'local' keyword, its behaviour isn't > portable across those either, which

'gcc/config/nvptx/gen-multilib-matches.sh': Support '--selftest' (was: 'gcc/config/nvptx/t-nvptx': Don't use the 'shell' function of 'make' (was: nvptx: Allow '--with-arch' to override the default '-m

2024-12-06 Thread Thomas Schwinge
ib_options_isa_default := $(word 1,$(multilib_options_isa_list)) > multilib_options_misa_list := $(addprefix misa=,$(multilib_options_isa_list)) > + > +t-nvptx-gen-multilib-matches: $(srcdir)/config/nvptx/gen-multilib-matches.sh > \ > + $(srcdir)/config/nvptx/t-nvptx \ > + Makefile \ >