Thank you everyone.
I have pushed the changes.
Thanks,
Sangamesh
On Mon, Dec 9, 2024 at 12:48 PM swamy sangamesh
wrote:
> Hi David,
>
> I don't have write privileges for GCC repo.
> I have raised a request for write access and provided your email address
> as approver.
are listed in the FSF copyrights file for GCC GDB GLIBC BINUTILS, but
> do you have write privileges for the GCC repo? You are not listed in
> gcc/MAINTAINERS for write-after-approval.
>
> Thanks, David
>
> On Sun, Dec 8, 2024 at 10:49 AM swamy sangamesh
> wrote:
>
>&g
Thank you all for the review and comments.
David, I have tested the changes against the latest master and ran default
test cases.
I have also built and ran the default test cases on RHEL9.0 ppc64le.
Please let me know if any other testing needs to be covered.
Please find the latest patch attached
Dear Community,
Please let me know if the attached patch is fine.
Thanks,
Sangamesh
On Tue, Dec 3, 2024 at 11:19 PM swamy sangamesh
wrote:
> Hi Eric,
>
> Thanks for the review.
>
> I too think removing the define is a better approach and seems these won't
> be needed
en i can send a final patch.
Thanks,
Sangamesh
On Tue, Dec 3, 2024 at 9:11 AM Eric Gallager wrote:
> On Mon, Dec 2, 2024 at 1:01 PM swamy sangamesh
> wrote:
> >
> > Dear Community,
> >
> > Please let me know your comment.
> > Or is it more appropriate
Dear Community,
Please let me know your comment.
Or is it more appropriate to have changes with header guard like this ?
--- a/libiberty/getopt.c
+++ b/libiberty/getopt.c
@@ -25,9 +25,11 @@
^L
/* This tells Alpha OSF/1 not to define a getopt prototype in .
Ditto for AIX 3.2 and . */
+#ifnd
