RE: patch fortran, pr 59746, internal compiler error : segmentation fault

2014-03-09 Thread jimmie.davis
From: Mikael Morin [mikael.mo...@sfr.fr] Sent: Sunday, March 09, 2014 3:40 PM To: Davis, Bud @ SSG - Link; gcc-patches@gcc.gnu.org; fort...@gcc.gnu.org Subject: Re: patch fortran, pr 59746, internal compiler error : segmentation fault > - if (p->

RE: patch fortran, pr 59746, internal compiler error : segmentation fault

2014-03-09 Thread jimmie.davis
Comments from Mikael: #1. Please merge the two ifs; it seems they have exactly the same scope after the patch. #2. This comment applies to the TOUPPER thing below... .. so it should be put here. Also the indentation is wrong. #3.This is unnecessary. === All corre

patch fortran, pr 59746, internal compiler error : segmentation fault

2014-03-09 Thread jimmie.davis
The code would only remove a variable from a common block if it was just defined in the previous statement. The PR showed a case where a pre-existing variable was put in the common block. When it was not removed, the common block list was wrong and segfaulted (or infinite looped) when used la