Thanks, Rainer.
Committed as r248916.
Thanks for suggesting a backport, Renlin.
Regards,
Toma
Hi Renlin,
>
> Thanks for fixing this! Do you have plan to backport the fix to gcc-6 branch?
>
I am happy to backport it.
I've rebased the patch on top of the gcc-6 branch and attached it below.
Rainer, is this OK for gcc-6?
Regards,
Toma Tabacu
gcc/ChangeLog:
B
From: Jeff Law
> On 05/16/2017 10:01 AM, Toma Tabacu wrote:
>> Hello Paul,
>>
>> You're seeing this problem because mips.exp can't handle -O* in dg-options.
>> The other tests in gcc.target/mips use a dg-skip-if to skip for -O0 and -O1
>> instead of ha
s possible.
I believe that Matthew can confirm this.
Regards,
Toma Tabacu
> -Original Message-
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On
> Behalf Of Paul Hua
> Sent: 16 May 2017 10:11
> To: Jeff Law
> Cc: gcc-patches
> Sub
Hi,
The gcc.dg/ipa/iinline-attr.c test has been failing for MIPS when using the n32
and n64 ABIs.
These two ABIs imply a 64-bit target, which means that the align_loops,
align_jumps, and align_functions flags are set to 8 by default.
Because the MIPS backend doesn't use the TARGET_OVERRIDE_OPTIO
> From: Matthew Fortune
>
> Given the acceptance that MIPS PIC behaviour is semi-unique then checking
> MIPS
> complies with the rules around pre-processor behaviour doesn't add much
> value.
> I'm happy to skip these tests on the basis that software can't make the same
> assumptions about MIPS an
Hi,
The pic-3,4.c and pie-3,4.c tests are failing for some configurations of
mips*-*-linux-*.
This is because PIC is always on for MIPS Linux by default, except when the
compiler is built with --with-mips-plt, in which case PIC is on by default only
for the n64 ABI, because in this case -mplt "ha
Hi,
> From: Segher Boessenkool
> On Mon, Mar 20, 2017 at 10:08:25PM +, Moore, Catherine wrote:
> > I'm okay with the workaround for stage 4, but would like to see the pr
> > remain
> open until a proper fix is installed on trunk.
>
> Yeah.
>
Sure, I'll keep it open.
> > Toma, would you be
> > From: Matthew Fortune
> >
> > I think the skip is OK here. I'd like to get Catherine's opinion on
> > this though too. I don't think we should change the definition of __PIC__
> > for -fPIC on MIPS as multi-got solves 'most' issues. If we start trying to
> > figure out what __PIC__ should mean
Hi,
The gcc.dg/pic-2.c and gcc.dg/pie-2.c tests are failing for MIPS targets
because __PIC__ is always set to 1 for MIPS.
This patch makes the testsuite skip those two tests for all MIPS targets.
Tested with mips-mti-elf and mips-mti-linux-gnu.
Should I have fixed this in target-supports.exp in
>
> I just noticed that nothing has happened at all in a month, so anything
> is better than the tests XPASSing on a number of targets.
>
> So the patch is ok for mainline with sparc*-*-* added to the target
> lists and a reference to PR testsuite/79356 in the comment.
>
> I'd still be very grat
>
> Ok for mainline with that fixed.
>
> Thanks.
> Rainer
>
Committed as r246004.
Thanks,
Toma
optimize)
{
mips_block_move_loop (dest, src, INTVAL (length),
MIPS_MAX_MOVE_BYTES_PER_LOOP_ITER);
return true;
}
Tested with mips-mti-elf.
Regards,
Toma Tabacu
gcc/
* config/mips/mips.c (mips_block_move_loop): Emit a NOP after the
Hi,
g++.dg/lto/pr69589_0.C is currently failing for mips-mti-elf with the following
error:
xg++: error: unrecognized command line option '-rdynamic'
However, it passes just fine for mips-mti-linux-gnu.
I think that we should skip this test for mips-mti-elf.
This patch achieves this by adding s
> From: Catherine Moore
>
> This patch fixes my original objection. Thanks.
>
Committed as r245921.
Thanks,
Toma
> From: Matthew Fortune
>
> Toma Tabacu writes:
> > gcc/testsuite/
> >
> > * gcc.target/mips/inline-memcpy-3.c (dg-options): Add -mabi=32.
>
> OK, thanks. Sorry for the slow reply.
>
> Matthew
Committed as r245914.
Thanks,
Toma
> From: Matthew Fortune
> >
> > gcc/testsuite/
> >
> > * gcc.target/mips/pr68273.c (dg-final): Match SImode registers only for
> > ilp32 targets and match DImode registers for lp64 targets.
>
> OK, thanks.
>
> Matthew
Committed as r245874.
Thanks,
Toma
Hi,
pr68273.c currently fails when targeting MIPS64 with the n64 ABI.
This is because it is checking for some registers in SImode, but, because of
n64, they will actually be in DImode.
This patch restricts matching for SImode registers to ilp32 targets and adds
matching for DImode registers for l
Hi,
> From: Rainer Orth
> >
> > gcc/testsuite/
> >
> > * gcc.dg/lto/pr60449_0.c: Add dg-require-effective-target for
> > gettimeofday. Remove dg-skip-if for AVR.
>
> Two spaces after period.
>
Fixed.
> > * lib/target-supports.exp (check_effective_target_gettimeofday): New.
>
> Bet
Hi,
> From: Rainer Orth
>
> that's not what I suggested (or at least meant to suggest): having
> gettimeofday as an effective-target keyword (like setrlimit, mmap, and
> others) is the way to go, just your previous implementation of
> check_effective_target_gettimeofday was problematic/unreliable
Hi Rainer,
Thank you for the feedback.
As you suggested, I have added a check_gettimeofday_available proc in
target-supports.exp and a dg-require-gettimeofday proc in target-supports-dg.exp
which check for gettimeofday using the existing check_function_available proc.
The test still runs and pas
Hi,
inline-memcpy-3.c fails when using -mabi=n64 and -mabi=n32 as a test-run option
because it does not impose a specific ABI in its test options.
As there already are variants of this test which force a specific ABI (N64 in
inline-memcpy-4.c and N32 in inline-memcpy-5.c), inline-memcpy-3.c shoul
> From: Catherine Moore
>
> Hi Toma,
> There are some MIPS ELF targets that do support gettimeofday. Perhaps you
> could handle this with a dg_require_effective_target entry for gettimeofday.
> Thanks,
> Catherine
>
Hi,
Thank you for your quick reply.
The patch below adds a dg_require_effect
Hi,
The gcc.dg/lto/pr60449_0.c is failing for mips*-*-elf* targets because they do
not support gettimeofday, which is used in this test case.
This patch changes the test so that it is skipped for mips*-*-elf* targets.
Regards,
Toma
gcc/testsuite/
* gcc.dg/lto/pr60449_0.c (dg-skip-if):
> From: Jeff Law
>
> I don't think using !logical_op_short_circuit is too heavy handed here.
>
> We get good coverage from the x86 target, so I don't mind losing
> coverage from avr/s390 as the target selector is a lot more likely to be
> correct after your change for the various targets now and
gzilla
thread).
Here are some links, for your convenience:
PR71314 on Bugzilla:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71314
The patch submission for fixing PR71314:
https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02359.html
Does this look OK ?
Is the !logical_op_short_circuit too heavy-hande
Matthew Fortune writes:
>
> Almost but not quite. There is a force_reg helper that takes care of
> this i.e. can get rid of the qireg local and the whole if statement.
>
> emit_insn (gen_zero_extendqisi2 (sireg, force_reg (ops[2].value)));
>
> OK with that change.
>
> Thanks,
> Matthew
C
Matthew Fortune writes:
>
> That's not what I hoped but is what I was concerned about as I believe it
> means we have a change of behaviour. It boils down to simply ignoring the
> argument type of unsigned char. My guess is that a zero extension is
> created but then immediately eliminated becau
> From: Matthew Fortune
> > +/* The third argument needs to be in SImode in order to succesfully
> > match
> > + the operand from the insn definition. */
>
> Please refer to operand here not argument as it is the second argument
> to the builtin but third operand of the instruction. Al
Hi,
The builtins for the pshufh, psllh, psllw, psrah, psraw, psrlh, psrlw Loongson
instructions have the third argument's type set to UQI while its corresponding
insn operand is in SImode.
This results in the following error when matching insn operands:
../gcc/gcc/include/loongson.h: In function
> From: Matthew Fortune
>
> Apart from those changes this looks OK to me.
>
> Matthew
Thanks.
Committed as r244570.
Regards,
Toma
> Maciej Rozycki writes:
> > This ought to be handled then, likely by adding Loongson-specific RTL
> > insns matching the `divmod4' and `udivmod4' expanders. It
> > may be as simple as say (conceptually, untested):
> >
> > (define_insn "divmod4_loongson"
> > [(set (match_operand:GPR 0 "register
After searching through the archives, I have found an interesting bit of
information about DIV.G/MOD.G in the original submission thread:
> > Ruan Beihong 23 July 2008:
> >
> > I've seen the Loongson 2F manual carefully. The (d)div(u) is
> > internally splited into one (d)div(u).g and one (d)mod
> Maciej Rozycki writes:
>
> >
> > Unfortunately, this interferes with the generation of DIV.G and MOD.G
> > (the div3 and mod3 patterns) for Loongson targets,
> which
> > causes test failures.
>
> What test failures? Details please.
>
It's
gcc.target/mips/loongson-muldiv-1.c
gcc.target/mips/
Hi,
The expand_DIVMOD function, introduced in r241660, will pick the divmod4
(or the udivmod4) pattern when it checks for the presence of hardware
div/mod instructions, which results in the generation of the old DIV
instruction.
Unfortunately, this interferes with the generation of DIV.G and MOD.
> From: Catherine Moore
>
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/mips/oddspreg-2.c (dg-options): Remove dg-skip-if
> > for
> > -fno-fat-lto-objects and add the -ffat-lto-objects option, along
> > with
> > an explanation for its purpose.
> > * gcc.target/mips/oddspreg
> Catherine Moore writes:
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/mips/msa-builtins.c (dg-final): Tweak regex for the
> > 32-bit
> > insert.d case.
>
> Please change to:
> * gcc.target/mips-msa-builtins.c (msa_insert_d): Tweak expected
> output.
>
> Okay with that chan
Hi,
The 32-bit insert.d case in msa-builtins.c is failing with O2 and Os because
the order of the emitted instructions is slightly different compared to the
other optimization levels.
This patch tweaks the regular expression for 32-bit insert.d to accept the
alternate instruction order.
Tested
Committed as r243687.
Regards,
Toma
> Toma Tabacu writes:
> > microMIPS is not supported on pre-R2 architectures, but the testsuite allows
> > it to be used on pre-R2 architectures, which results in test failures.
> >
> > This patch makes the testsuite upgrade to R2
Hi,
Some error tests were forcing assembly output incorrectly, and none of them had
an explanation for why they were using -ffat-lto-objects.
This patch removes dg-skip-if's for -fno-fat-lto-objects and
adds -ffat-lto-objects to the test options instead.
It also adds an explanation for the purpos
Committed as r243649.
Regards,
Toma
> Toma Tabacu writes:
> > In the case of mips16-attributes.c, even though the (-mips16) option ensures
> > that -mmicromips will be overriden, there still is a dg-skip-if for
> > -mmicromips.
> >
> > I think that it is not ne
Hi,
microMIPS is not supported on pre-R2 architectures, but the testsuite allows
it to be used on pre-R2 architectures, which results in test failures.
This patch makes the testsuite upgrade to R2 if -mmicromips is used in a test.
Tested with mips-mti-elf.
Regards,
Toma
gcc/testsuite/ChangeLog
Hi,
In the case of mips16-attributes.c, even though the (-mips16) option ensures
that -mmicromips will be overriden, there still is a dg-skip-if for -mmicromips.
I think that it is not necessary and it actually decreases test coverage,
because it will cause the testsuite to skip this test instead
Committed as r243639.
Regards,
Toma
> -Original Message-
> From: Matthew Fortune
> Sent: 13 December 2016 13:46
> To: Toma Tabacu; gcc-patches@gcc.gnu.org
> Cc: catherine_mo...@mentor.com
> Subject: RE: [PATCH, testsuite] MIPS: Skip msa-builtins-err.c if there is no
>
> It's a shame this is the only way to deal with this but I see aarch64 have
> to resort to the same thing for error checking tests.
>
I have looked into this some more and I 've found that the solution I proposed
is incomplete.
The problem is that if no linker plugin is found, -fno-fat-lto-o
8 and -mabs=2008
> are
> > used as test options.
> >
> > Tested with mips-mti-elf.
> >
> > Regards,
> > Toma Tabacu
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/mips/mips.exp (mips-dg-options): Upgrade to R2 for
> > -mnan=2008 and -mabs=2008.
>
> OK, thanks.
>
> Matthew
Committed as r243542.
Regards,
Toma
-mti-elf.
Regards,
Toma Tabacu
gcc/testsuite/ChangeLog:
* gcc.target/mips/mips.exp (mips-dg-options): Upgrade to R2 for
-mnan=2008 and -mabs=2008.
diff --git a/gcc/testsuite/gcc.target/mips/mips.exp
b/gcc/testsuite/gcc.target/mips/mips.exp
index c0b9680..3d04d2f 100644
--- a/gcc
-if for -fno-fat-lto-objects.
Tested with mips-mti-elf.
Regards,
Toma Tabacu
gcc/testsuite/ChangeLog:
* gcc.target/mips/msa-builtins-err.c (dg-skip-if): Do not run the test
if -fno-fat-lto-objects is present.
diff --git a/gcc/testsuite/gcc.target/mips/msa-builtins-err.c
b/gcc
ions.
Tested with mips-mti-elf.
Regards,
Toma Tabacu
gcc/testsuite/ChangeLog:
2016-11-21 Toma Tabacu
* gcc.target/mips/interrupt_handler-bug-1.c (dg-options): Add
isa_rev>=2.
diff --git a/gcc/testsuite/gcc.target/mips/interrupt_handler-bug-1.c
b/gcc/testsuite/gcc.target/m
Committed as r242595.
Thanks,
Toma Tabacu
Index: ChangeLog
===
--- ChangeLog (revision 242594)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2016-11-18 Toma Tabacu
+
+ * MAINTAINERS (Write After Approval): Add myself
> From: Moore, Catherine [mailto:catherine_mo...@mentor.com]
> Sent: 17 November 2016 21:53
> To: Matthew Fortune; Toma Tabacu; Andrew Bennett; 'gcc-
> patc...@gcc.gnu.org'
> Cc: Moore, Catherine
> Subject: RE: [PATCH] MIPS: If a test in the MIPS testsuite requires stan
set do_what [lreplace $do_what 1 1 "N"]
> > + }
> > + }
> > +
> > # If the test is MIPS16-compatible, provide a counterpart to the
> > # NOMIPS16 convenience macro.
> > if { [mips_have_test_option_p options "-mips1
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-
> ow...@gcc.gnu.org] On Behalf Of Toma Tabacu
> Sent: 15 November 2016 14:00
> To: gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune; catherine_mo...@mentor.com
> Subject: [PATCH,testsuite] MIPS: Downgrade from R6 to R5 to p
ecking for the
absence of MOVN/MOVZ, but it is redundant.
This patch fixes this by replacing isa>=4 with (HAS_MOVN), which will only
accept targets in the [MIPS IV, R5] interval.
Tested with mips-img-linux-gnu.
Regards,
Toma Tabacu
gcc/testsuite/ChangeLog:
2016-11-15 To
> From: Moore, Catherine [mailto:catherine_mo...@mentor.com]
> Sent: 08 November 2016 20:47
> To: Toma Tabacu; gcc-patches@gcc.gnu.org
> Cc: Matthew Fortune
> Subject: RE: [PATCH,testsuite] MIPS: Upgrade to MIPS IV if using (HAS_MOVN)
> with MIPS III.
>
>
>
cost-2.c tests
when the target is MIPS III.
This patch fixes the condition to include MIPS III.
Tested with mips-mti-elf.
Regards,
Toma Tabacu
gcc/testsuite/ChangeLog:
2016-11-07 Toma Tabacu
* gcc.target/mips/mips.exp (mips-dg-options): Upgrade to MIPS IV if
using
(HAS_MOVN) wit
> From: Matthew Fortune
> Sent: 04 November 2016 16:49
> To: Toma Tabacu; gcc-patches@gcc.gnu.org
> Cc: catherine_mo...@mentor.com
> Subject: RE: [PATCH,testsuite] MIPS: Downgrade R6 to R5 if tests need branch-
> likely instructions.
>
> Toma Tabacu writes:
&g
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-
> ow...@gcc.gnu.org] On Behalf Of Toma Tabacu
> Sent: 04 November 2016 15:25
> To: Matthew Fortune; gcc-patches@gcc.gnu.org
> Cc: catherine_mo...@mentor.com
> Subject: RE: [PATCH,testsuite] MIPS: Downgrade R6 to R5 if
> From: Matthew Fortune
> Sent: 03 November 2016 13:07
> To: Toma Tabacu; gcc-patches@gcc.gnu.org
> Cc: catherine_mo...@mentor.com
> Subject: RE: [PATCH,testsuite] MIPS: Downgrade R6 to R5 if tests need
> branch-likely instructions.
>
> Toma Tabacu writes:
> > Th
MIPS: If a test in the MIPS testsuite requires standard
> library support check the sysroot supports the required test options.
>
> Ping.
>
>
> Regards,
>
>
>
> Andrew
>
Hi Andrew,
I believe the inline-memcpy-{1,2,3,4,5}.c tests also qualify for the
(RE
ng R6.
Tested with mips-img-elf and mips-img-linux-gnu.
Regards,
Toma Tabacu
gcc/testsuite/
* gcc.target/mips/mips.exp: Add check for -mbranch-likely in
condition for R5 downgrade.
diff --git a/gcc/testsuite/gcc.target/mips/mips.exp
b/gcc/testsuite/gcc.target/mips/mips.exp
61 matches
Mail list logo
