Re: [f...@deneb.enyo.de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]

2016-09-19 Thread Thomas Quinot
* Thomas Quinot, 2016-09-18 : > Sorry for the delay in reviewing your patch. It looks good on the > surface; we're QAing it internally to make sure it does not break > PolyORB (which is the primary consumer of g-pehage). I'll let you know > as soon as I have the results f

Re: [f...@deneb.enyo.de: [PATCH] ada/77535: GNAT.Perfect_Hash_Generators for non-1-based strings]

2016-09-18 Thread Thomas Quinot
sumer of g-pehage). I'll let you know as soon as I have the results from that run. In any case it would be good to include a regression test for this issue. Thanks! Thomas. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** IT Lead Engineer AdaCore -- Paris, France -- New York, USA

Re: [Ada] Add DragonFly support to System.OS_Constants template

2015-07-06 Thread Thomas Quinot
* John Marino, 2015-07-06 : > The System.OS_Constants templates for GNAT has three preprocessor checks > for FreeBSD. In all three cases, DragonFly BSD needs to be treated the > same as FreeBSD. The attached patch accomplishes this. Thanks John, looks good to me! Thomas.

Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD

2015-06-03 Thread Thomas Quinot
ng approach. However if we aim for integration in GCC, then maybe a more straightforward approach (replacing the macro with a variable that would be initialized by some back-end-specific startup routine?) is in order. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New York, USA

Re: [patch] Implement Ada support for DragonFly, improve it for FreeBSD

2015-06-03 Thread Thomas Quinot
). > > OK, as long as this happens and the files do not bitrot, that's fine with me. > What I want to avoid is a one time submit and no follow ups afterwards, and > files which no longer work after some time, with nobody bothering fixing > them. John has been actively maintaining

[PATCH] gcc/tree-complex.c: Fix minor typo in comment

2013-07-05 Thread Thomas Quinot
2013-07-06 Thomas Quinot gcc/ * tree-complex.c: Fix minor typo in comment OK to commit? diff --git a/gcc/tree-complex.c b/gcc/tree-complex.c index c45ba19..acd0169 100644 --- a/gcc/tree-complex.c +++ b/gcc/tree-complex.c @@ -1476,7 +1476,7 @@ expand_complex_operations_1

Re: [PATCH] Instance information in DWARF discriminators

2012-12-05 Thread Thomas Quinot
* Tom Tromey, 2012-11-29 : > Thomas> Now, an alternative might be to have an array of instance IDs stored > at > Thomas> the struct line_maps level, with the same indices at the set of > ordinary > Thomas> maps, which would be allocated only when flag_debug_instances is used; > Thomas> when it i

Re: [PATCH] Instance information in DWARF discriminators

2012-11-29 Thread Thomas Quinot
ec.h cannot currently be used from within libcpp. So, I'll have to either change that (but that seems like a pretty significant change) or else manually manage this array through xrealloc. Thomas. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCo

[PATCH] Instance information in DWARF discriminators

2012-11-28 Thread Thomas Quinot
order to allow per-instance source coverage analysis of generics. However this might also be useful for other language front-ends, e.g. with C++ templates. Change tested on x86_64-linux. OK to commit? 2012-08-08 Thomas Quinot gcc/ * common.opt (flag_debug_instances): Define new internal

Re: [PATCH] New command line switch -fada-spec-parent

2012-09-07 Thread Thomas Quinot
elp@r{[}=@var{class}@r{[},@dots{}@r{]]} --target-help @gol --version -wrapper @@@var{file} -fplugin=@var{file} -fplugin-arg-@var{name}=@var{arg} @gol --fdump-ada-spec@r{[}-slim@r{]} -fdump-go-spec=@var{file}} +-fdump-ada-spec@r{[}-slim@r{]} -fada-spec-parent=@var{arg} -fdump-go-spec=@var{file

Re: [PATCH] New command line switch -fada-spec-parent

2012-08-31 Thread Thomas Quinot
* Steven Bosscher, 2012-08-24 : > > * common.opt (-fada-spec-parent): Define new command line switch. > Why here instead of in c-family/c.opt? Makes sense indeed, I'll move the definition there. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Sof

[PATCH] New command line switch -fada-spec-parent

2012-08-24 Thread Thomas Quinot
nguage} -v -### --help@r{[}=@var{class}@r{[},@dots{}@r{]]} --target-help @gol --version -wrapper @@@var{file} -fplugin=@var{file} -fplugin-arg-@var{name}=@var{arg} @gol --fdump-ada-spec@r{[}-slim@r{]} -fdump-go-spec=@var{file}} +-fdump-ada-spec@r{[}-slim@r{]} -fada-spec-parent=@var{arg}

Re: [PATCH] GCC Ada/GNAT configuration for GNU/Hurd

2012-08-08 Thread Thomas Quinot
> In fact, should that perhaps (unverified) simply say »For glibc, > > _XOPEN_SOURCE must be defined [...]« -- or is this code meant to be > > usable on GNU/Linux with a C library different from glibc? > > Posibly yes. Thomas (Quinot), any comment on the above? No strong o

Re: PING 1 [Patch Ada RFA] make sure that multilibs are built with correct s-oscons.ads

2011-11-09 Thread Thomas Quinot
* Iain Sandoe, 2011-11-07 : > Subject: PING 1 [Patch Ada RFA] make sure that multilibs are built with > correct s-oscons.ads Patch looks fine to me. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New York, USA

Re: [patch ada]: Fix MSG_WAITALL handling for windows native targets

2011-04-04 Thread Thomas Quinot
* Kai Tietz, 2011-04-04 : > So here is the patch without the part in g-socthi-mingw.adb. Thanks, OK for me. -- Thomas Quinot, Ph.D. ** qui...@adacore.com ** Senior Software Engineer AdaCore -- Paris, France -- New York, USA