Re: [PATCH] favor bcrypt over wincrypt for the random generator on Windows

2020-06-02 Thread Steve Lhomme
Actually I found a but in the patch. The BCryptGenRandom() doesn't return a BOOL like CryptGenRandom so the success needs to be checked differently. I'm sending an updated patch with the wincrypt name change as well. On 2020-06-01 18:30, Richard Sandiford wrote: Steve Lhomme writ

[PATCH v2] favor bcrypt over CryptoAPI for the random generator on Windows

2020-06-02 Thread Steve Lhomme
BCrypt is more modern and supported in Universal Apps. CryptoAPI is not and CryptGenRandom is deprecated: https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom BCrypt is available since Vista https://docs.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcryp

Re: [PATCH] favor bcrypt over wincrypt for the random generator on Windows

2020-05-25 Thread Steve Lhomme
Hello, Any update on this ? This prevents libssp from being usable in UWP apps. (BTW the name of the old API is not wincrypt, the header, but CryptoAPI or CAPI) On 2020-04-21 9:48, Steve Lhomme wrote: BCrypt is more modern and supported in Universal Apps, Wincrypt is not and CryptGenRandom

[PATCH] favor bcrypt over wincrypt for the random generator on Windows

2020-04-21 Thread Steve Lhomme
BCrypt is more modern and supported in Universal Apps, Wincrypt is not and CryptGenRandom is deprecated: https://docs.microsoft.com/en-us/windows/win32/api/wincrypt/nf-wincrypt-cryptgenrandom BCrypt is available since Vista https://docs.microsoft.com/en-us/windows/win32/api/bcrypt/nf-bcrypt-bcrypt