Re: [pushed][LRA]: Spill pseudos assigned to fp when fp->sp elimination became impossible

2023-08-17 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Wed, 2023-08-16 at 12:13 -0400, Vladimir Makarov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The attached patch fixes recently found wrong insn removal in LRA port > for AVR. > > The patch was successfully tested and bootstrapped o

Re: [pushed][LRA] Check input insn pattern hard regs against early clobber hard regs for live info

2023-08-09 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Fri, 2023-08-04 at 09:16 -0400, Vladimir Makarov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > The following patch fixes a problem found by LRA port for avr target. > The problem description is in the commit message. > > The patch wa

[IRA] Skip empty register classes in setup_reg_class_relations

2023-07-12 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, I've been spending some (spare) time trying to get LRA working for the avr target. After making a couple of changes to get libgcc going, I'm now hitting an assert at lra-constraints.cc:4423 for a subarch (avrtiny) that has a couple of regclasses with no available registers. The as

Re: [PATCH] Update array address space in c_build_qualified_type

2023-06-22 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Wed, 2023-06-21 at 18:37 +, Joseph Myers wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Wed, 21 Jun 2023, Richard Biener via Gcc-patches wrote: > > > > This patch sets the address space of the array type to that of the > > >

[PATCH] Update array address space in c_build_qualified_type

2023-06-20 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, When c-typeck.cc:c_build_qualified_type builds an array type from its element type, it does not copy the address space of the element type to the array type itself. This is unlike tree.cc:build_array_type_1, which explicitly does TYPE_ADDR_SPACE (t) = TYPE_ADDR_SPACE (elt_type); Th

[Ping] Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-16 Thread SenthilKumar.Selvaraj--- via Gcc-patches
, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches > > > > > mailto:gcc-patches@gcc.gnu.org>> wrote: > > > > > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > > > > > > mailto:richard.guent...@gmail.com>> > > > > >

[PATCH, PR110086] avr: Fix ICE on optimize attribute

2023-06-02 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, This patch fixes an ICE when an optimize attribute changes the prevailing optimization level. I found https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105069 describing the same ICE for the sh target, where the fix was to enable save/restore of target specific options modified via TARGET_OPTIMIZA

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-06-02 Thread SenthilKumar.Selvaraj--- via Gcc-patches
rote: > > > > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > > > > > mailto:richard.guent...@gmail.com>> > > > > > wrote: > > > > > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > > > > >

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-18 Thread SenthilKumar.Selvaraj--- via Gcc-patches
t; > mailto:gcc-patches@gcc.gnu.org>> wrote: > > > > > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > > > mailto:richard.guent...@gmail.com>> wrote: > > > > > > > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > > >

[Testsuite] Skip -fdelete-null-pointer-check tests if target keeps_null_pointer_checks

2023-05-14 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, When running regression tests related to https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616772.html, I noticed a bunch of failures because some tests explicitly pass in -fdelete-null-pointer-checks, even if the target is configured to keep them. This patch skips such failing tests by a

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread SenthilKumar.Selvaraj--- via Gcc-patches
On Wed, Apr 26, 2023 at 3:15 PM Richard Biener via Gcc-patches wrote: > > On Wed, Apr 26, 2023 at 11:42 AM Richard Biener > wrote: > > > > On Wed, Apr 26, 2023 at 11:01 AM SenthilKumar.Selvaraj--- via > > Gcc-patches wrote: > > > > > > Hi, >

[PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-04-26 Thread SenthilKumar.Selvaraj--- via Gcc-patches
Hi, This patch fixes PR 105523 by setting param_min_pagesize to 0 for the avr target. For this target, zero and offsets from zero are perfectly valid addresses, and the default value of param_min_pagesize ends up triggering warnings on valid memory accesses. Ok for trunk and backporting to 13 and

[Patch, ira] Invalid assert in reload1.c::finish_spills?

2019-08-07 Thread SenthilKumar.Selvaraj
Hi, gcc/testsuite/c-c++-common/pr60101.c fails with an ICE for the avr target, because of a gcc_assert firing at reload1.c:4233 The assert (in the patch below) looks bogus to me, as it's in the if block of if (! ira_conflicts_p || reg_renumber[i] >= 0) For this testcase and for

[Patch, DWARF] Ignore address spaces for get_nearest_type_subqualifiers

2019-08-06 Thread SenthilKumar.Selvaraj
Hi, r254484 explicitly added previously ignored address space qualifiers, when emitting DWARF dies for types. Adding address spaces to cv_qual_mask, however, breaks nearest_type_subqualifier, which uses the number of bits set (i.e popcount_hwi) to find the type variant that has th

Re: [Patch, testsuite, committed] Fix bogus gcc.dg/torture/ssa-fre-{5,7}.c failures for avr

2019-08-02 Thread SenthilKumar.Selvaraj
Rainer Orth writes: > External E-Mail > > > Hi Senthil, > >> This patch prevents gcc.dg/torture/ssa-fre-{5,7}.c from failing >> for the avr >> target, by requiring effective-target int32. >> >> Committed as obvious to trunk. >> >> Regards >> Senthil >> >> 2019-08-02 Senthil Kumar Selvaraj >>

[Patch, testsuite, committed] Fix bogus gcc.dg/torture/ssa-fre-{5,7}.c failures for avr

2019-08-02 Thread SenthilKumar.Selvaraj
This patch prevents gcc.dg/torture/ssa-fre-{5,7}.c from failing for the avr target, by requiring effective-target int32. Committed as obvious to trunk. Regards Senthil 2019-08-02 Senthil Kumar Selvaraj * gcc.dg/torture/ssa-fre-5.c: Add dg-require-effective-target int32. * gcc.dg/tortur

Re: [ira,reload] Invalid assert in reload1.c::finish_spills?

2019-08-01 Thread SenthilKumar.Selvaraj
Apologies for the messed up formatting in the previous email. Hi, gcc/testsuite/c-c++-common/pr60101.c fails with an ICE for the avr target, because of a gccassert firing at reload1.c:4233. The assert looks bogus to me, as it's in the if block of if (! iraconflictsp || regrenumber[i] >= 0) For

[ira,reload] Invalid assert in reload1.c::finish_spills?

2019-08-01 Thread SenthilKumar.Selvaraj
Hi, gcc/testsuite/c-c++-common/pr60101.c fails with an ICE for the avr target, because of a gccassert firing at reload1.c:4233. The assert looks bogus to me, as it's in the if block of if (! iraconflictsp || regrenumber[i] >= 0) For this testcase and for the avr target, iraconflictsp is false be

[Patch, testsuite, committed] Fix bogus gcc.dg/torture/ssa-fre-6.c failure for avr

2019-08-01 Thread SenthilKumar.Selvaraj
Hi, This patch fixes gcc.dg/torture/ssa-fre-6.c failing for the avr target, by requiring effective-target int32. Committed as obvious to trunk. Regards Senthil gcc/testsuite/ChangeLog 2019-08-02 Senthil Kumar Selvaraj * gcc.dg/torture/ssa-fre-6.c: Add dg-require-effective-target int32.

[Patch, PR 88253, combine] Prevent combine simplification to zero if side_effects_p

2018-12-14 Thread SenthilKumar.Selvaraj
Hi, This patch fixes PR 88253 by preventing combine_simplify_rtx from folding an rtx with side_effects_p to const0_rtx. Without the patch, combine deletes volatile loads from memory in certain cases. When combine_simplify_rtx is called with op0_mode = E_HImode and rtx like (subreg:QI (ashift:HI