Re: [PATCHv2] do not throw in std::make_exception_ptr

2016-10-20 Thread Ryan Burn
Are exception classes required to support emplace new construction like that? With this change, Intel's TBB library no longer compiles because its exception class declares it's own new operator (see https://github.com/wjakob/tbb/blob/master/include/tbb/tbb_exception.h): class tbb_exception : publ

[cilkplus] Fix precompiled header bug (PR cilkplus/70865)

2016-05-19 Thread Ryan Burn
to GTFILES and gengtype.c. Bootstrapped and regression tested on x86_64-linux. 2016-05-16 Ryan Burn * Makefile.in (GTFILES): Add cilk.h and cilk-common.c. * gengtype.c (open_base_files): Add cilk.h to ifiles. pr70865.patch Description: Binary data

Re: [PATCH][cilkplus] fix c++ implicit conversions with cilk_spawn (PR/69024, PR/68997)

2016-04-20 Thread Ryan Burn
Can we push this now that the gcc 7 branch is open? On Wed, Feb 10, 2016 at 1:00 PM, Jeff Law wrote: > On 01/20/2016 10:57 AM, Ryan Burn wrote: >> >> This patch follows on from >> https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02142.html >> >> As discusse

Re: [PATCH] fix gimplification of call parameters (PR cilkplus/69267)

2016-01-25 Thread Ryan Burn
ping On Tue, Jan 19, 2016 at 9:28 AM, Ryan Burn wrote: > Does this look ok? > >> On Jan 15, 2016, at 5:41 PM, Ryan Burn wrote: >> >> This patch changes the function cilk_gimplify_call_params_in_spawned_fn to >> use gimplify_arg instead of gimplify_expr.

[PATCH][cilkplus] fix c++ implicit conversions with cilk_spawn (PR/69024, PR/68997)

2016-01-20 Thread Ryan Burn
. Bootstrapped and regression tested on x86_64-linux. gcc/c-family/ChangeLog: 2015-01-20 Ryan Burn PR c++/69024 PR c++/68997 * cilk.c (cilk_ignorable_spawn_rhs_op): Change to have external linkage. * cilk.c (recognize_spawn): Rename to cilk_recognize_spawn. Change to have external linkage

Re: [PATCH] fix gimplification of call parameters (PR cilkplus/69267)

2016-01-19 Thread Ryan Burn
Does this look ok? > On Jan 15, 2016, at 5:41 PM, Ryan Burn wrote: > > This patch changes the function cilk_gimplify_call_params_in_spawned_fn to > use gimplify_arg instead of gimplify_expr. It fixes an ICE when calling a > function with a constructed empty class

[PATCH] fix gimplification of call parameters (PR cilkplus/69267)

2016-01-15 Thread Ryan Burn
This patch changes the function cilk_gimplify_call_params_in_spawned_fn to use gimplify_arg instead of gimplify_expr. It fixes an ICE when calling a function with a constructed empty class as the argument. Bootstrapped and regression tested on x86_64-linux. 2016-01-15 Ryan Burn PR

Re: [PATCH] Fix PR c++/21802 (two-stage name lookup fails for operators)

2016-01-14 Thread Ryan Burn
Also caused https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69091 On Wed, Dec 16, 2015 at 4:46 PM, Markus Trippelsdorf wrote: > On 2015.12.14 at 19:34 -0500, Jason Merrill wrote: >> OK. > > This patch caused https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68936 > > -- > Markus

Re: [cilkplus] Fix cilk_spawn gimplification bug (PR cilkplus/69048)

2016-01-14 Thread Ryan Burn
On Thu, Jan 14, 2016 at 5:34 PM, Jakub Jelinek wrote: > On Thu, Jan 14, 2016 at 02:57:06PM -0700, Jeff Law wrote: >> On 01/14/2016 02:19 PM, Ryan Burn wrote: >> >This patch adds a missing cleanup point to cilk_spawn expressions to >> >prevent an ICE when calling funct

Re: [cilkplus] Fix cilk_spawn gimplification bug (PR cilkplus/69048)

2016-01-14 Thread Ryan Burn
Could you push please? I don't have write access. Thanks - Ryan. On Thu, Jan 14, 2016 at 4:57 PM, Jeff Law wrote: > On 01/14/2016 02:19 PM, Ryan Burn wrote: >> >> This patch adds a missing cleanup point to cilk_spawn expressions to >> prevent an ICE when calling functi

[cilkplus] Fix cilk_spawn gimplification bug (PR cilkplus/69048)

2016-01-14 Thread Ryan Burn
This patch adds a missing cleanup point to cilk_spawn expressions to prevent an ICE when calling functions that return types with non-trivial destructors. Bootstrapped and regression tested on x86_64-linux. 2015-01-14 Ryan Burn PR c++/69048 * cilk.c (create_cilk_wrapper_body

Re: [CilkPlus] fix issues when cilk_spawn is used with nontrivial expressions

2016-01-06 Thread Ryan Burn
On Tue, Jan 5, 2016 at 2:35 PM, Jeff Law wrote: > On 12/25/2015 09:08 AM, Ryan Burn wrote: >> >> This patch fixes issues with cilk_spawn where bad diagnostics are >> emitted for expressions invoking conversion operators or constructor >> calls (PR69024, PR68997). >&g

[CilkPlus] fix issues when cilk_spawn is used with nontrivial expressions

2015-12-25 Thread Ryan Burn
destructor (PR69048) Bootstrapped and regression tested on x86_64-linux 2015-12-25 Ryan Burn PR cilkplus/69024, PR cilkplus/68997, PR cilkplus/PR69048 * cilk.c (cilk_detect_spawn_and_unwrap): Use recursive function find_spawn to search for the CILK_SPAWN_STMT

[C++ PATCH] fix canonical type node ICE when from satisfy_argument_deduction_constraint function (PR c++/68683)

2015-12-03 Thread Ryan Burn
s original value when the PLACEHOLDER_TYPE_CONSTRAINTS value are changed back so that erroneous canonical type comparisons aren't made. Bootstrapped and regression tested on x86_64-linux 2015-12-03 Ryan Burn PR c++/68683 * constraint.cc (satisfy_argument_deduction_constraint): Set

[C++ PATCH] Fix same canonical type node ICE for constrained functions (PR c++/68434)

2015-11-24 Thread Ryan Burn
ion tested on x86_64-linux 2015-11-19 Ryan Burn PR c++/68434 * pt.c (tsubst): Set PLACEHOLDER_TYPE_CONSTRAINTS before calling canonical_type_parameter. * g++.dg/concepts/pr68434.C: New test Index: g

[C++ PATCH] Fix unexpanded pack error with auto-deduced functions (PR c++/68396)

2015-11-19 Thread Ryan Burn
e the classification of any auto types as parameter packs. Bootstrapped and regression tested on x86_64-linux 2015-11-19 Ryan Burn PR c++/68396 * pt.c (find_parameter_packs_r): Add case statement to handle DECLTYPE_TYPE. When traversing the DECLTYPE_TYPE_EXPR