Re: patches to detect GCC diagnostics

2019-05-17 Thread Roland Illig
Am 16.05.2019 um 22:24 schrieb Martin Sebor: > On 5/16/19 8:58 AM, Roland Illig wrote: >> -  error ("#pragma GCC target string... is badly formed"); >> +  error ("%<#pragma GCC target%> string is badly formed"); >> -  error (

patches to detect GCC diagnostics

2019-05-16 Thread Roland Illig
Hi Martin, I'm impressed how much work you have put into the patches for detecting nonoptimal diagnostics. It takes a long time to read through the patches, but it's worth it, knowing that it took much longer for you to prepare the patch, and that I won't have to submit i18n bug reports in the for

[PATCH] improve linter for diagnostics

2019-05-14 Thread Roland Illig
The linter in contrib/ checks all messages that the GCC user may see whether they conform roughly to the GCC Guidelines for Diagnostics. * contrib/check-internal-format-escaping.py: improve output of the linter by providing short rationales for the warnings; detect space be

[PATCH] Add myself to MAINTAINERS

2019-05-04 Thread Roland Illig
Already committed, as per https://www.gnu.org/software/gcc/svnwrite.html. 2019-05-04 Roland Illig * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (Revision 270868) +++ MAINTAINERS

Replacement for diagnostics linter

2019-04-25 Thread Roland Illig
There's a linter in contrib/check-internal-format-escaping.py that checks whether the base file for translations (such as French or German) conform to some basic style rules. This mostly affects the diagnostics emitted by GCC. As the German translation I have added several checks to the linter and

Re: [PATCH 1/7] Add missing punctuation to message (PR driver/79875)

2017-03-11 Thread Roland Illig
Am 10.03.2017 um 05:12 schrieb Martin Sebor: > I have just an observation/question here for future consideration. > If this sort of diagnostic is common (I count 23 instances of it) > or if it is expected to become common, would it make sense to add > a directive for it to the pretty printer to ens