Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-18 Thread Mike Stump
On Apr 10, 2025, at 6:38 AM, Christophe Lyon wrote: > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: >> >>> From: Christophe Lyon >>> Date: Thu, 10 Apr 2025 15:21:23 +0200 >> >> Not sure why I'm CC:ed on this one, not being a maintainer >> of the testsuite or targets where gcov tes

Re: [PATCH] testsuite: Fix up strub-internal-pr112938.C test for C++2{0,3,6}

2025-03-27 Thread Mike Stump
On Mar 27, 2025, at 12:29 PM, Jakub Jelinek wrote: > > On Thu, Mar 27, 2025 at 12:05:21AM +, Sam James wrote: >> The test was being ignored because dg.exp looks for .C in g++.dg/. >> >> gcc/testsuite/ChangeLog: >> PR middle-end/112938 >> >> * g++.dg/strub-internal-pr112938.cc: Mov

Re: [PATCH 00/12] Implement a new dg-lint tool and use on our testsuite

2025-03-27 Thread Mike Stump
On Mar 26, 2025, at 11:34 AM, David Malcolm wrote: > > This patch kit: > * adds minimal Python bindings for libgdiagnostics.so (below contrib) > * implements a new dg-lint tool (below contrib) to detect for >common mistakes in our testsuite, using Python 3 (and the above >bindings) > *

Re: [PATCH][PUSHED] hwasan: support new dg-output format.

2025-03-27 Thread Mike Stump
On Mar 20, 2025, at 8:11 AM, Alex Coplan wrote: > On 09/02/2024 15:32, Alex Coplan wrote: >> On 04/05/2022 09:59, Martin Liška wrote: >>> Supports change in libsanitizer where it newly reports: >>> READ of size 4 at 0xc3d4 tags: 02/01(00) (ptr/mem) in thread T0 >>> >>> So the 'tags' conta

Re: [PATCH] [testsuite] adjust expectations of x86 vect-simd-clone tests

2025-02-24 Thread Mike Stump
On Feb 13, 2025, at 1:51 AM, Alexandre Oliva wrote: > > Some vect-simd-clone tests fail when targeting ancient x86 variants, > because the expected transformations only take place with -msse4 or > higher. > > So arrange for these tests to take an -msse4 option on x86, so that > the expected vect

Re: [PATCH] testsuite: Only run test if alarm is available

2025-01-22 Thread Mike Stump
On Jan 19, 2025, at 12:47 PM, Torbjorn SVENSSON wrote: > > On 2025-01-19 21:20, Andrew Pinski wrote: >> On Sun, Jan 19, 2025 at 12:17 PM Torbjörn SVENSSON >> wrote: >>> >>> Ok for trunk? >>> >>> -- >>> >>> Most baremetal toolchains will not have an implementation for alarm and >>> sigaction

Re: [PATCH] [testsuite] [arm] adjust wmul expectations [PR113560]

2025-01-16 Thread Mike Stump
On Jan 16, 2025, at 11:46 AM, Alexandre Oliva wrote: > > Since the machine-independent widening multiply logic was improved > PR113560, ARM's wmul-[567].c fail. AFAICT the logic takes advantage > of the fact that, after zero-extending a narrow integral type to a > wider type, further zero- or si

Re: [PATCH] [testsuite] [arm] multilibs.exp: adjust float abi opt matching

2025-01-16 Thread Mike Stump
On Jan 16, 2025, at 11:43 AM, Alexandre Oliva wrote: > > The regexp that matches options that mess with multilibs matches > -mfloat=abi=, but that's probably a typo for -mfloat-abi=. Fix that, > and add -msoft-float and -mhard-float. > > Regstrapped on x86_64-linux-gnu, also tested on arm-eabi

Re: [PATCH] [testsuite] skip test on non-hosted libstdc++ [PR113994]

2025-01-16 Thread Mike Stump
On Jan 16, 2025, at 11:42 AM, Alexandre Oliva wrote: > > Tests that include need to be skipped when libstdc++ is built > in freestanding mode. Ok. > for gcc/testsuite/ChangeLog > > PR rtl-optimization/113994 > * g++.dg/pr113994.C: Require hosted libstdc++.

Re: [PATCH #2/2] [testsuite] drop explicit run overrider in more dfp tests

2025-01-16 Thread Mike Stump
On Jan 16, 2025, at 11:39 AM, Alexandre Oliva wrote: > > A few more dfp tests that recently got backported to gcc-14 override > dfp.exp's selection of default action depending on dfprt. Let the > default stand. > > This is a followup of the patch I've just pinged. Regstrapped on > x86_64-linux

Re: [PATCH] [testsuite] rearrange requirements for dfp bitint run tests

2025-01-16 Thread Mike Stump
On Jan 9, 2025, at 10:25 PM, Alexandre Oliva wrote: > > dfp.exp sets the default to compile when dfprt is not available, but > some dfp bitint tests override the default without that requirement, > and try to run even when dfprt is not available. > > Instead of overriding the default, rewrite th

Re: [PATCH] testsuite: generalized field-merge tests for <32-bit int [PR118025]

2025-01-06 Thread Mike Stump
On Jan 6, 2025, at 3:05 PM, Alexandre Oliva wrote: > > On Dec 22, 2024, Alexandre Oliva wrote: > >> for gcc/testsuite/ChangeLog > >> PR testsuite/118025 >> * gcc.dg/field-merge-1.c: Convert constants to desired types. >> * gcc.dg/field-merge-3.c: Likewise. >> * gcc.dg/fiel

Re: [PATCH] testsuite: torture: add LLVM testcase for DSE vs. -ftrivial-auto-var-init=

2025-01-03 Thread Mike Stump
On Jan 2, 2025, at 4:00 PM, Sam James wrote: > > This testcase came up in a recent LLVM bug report [0] for DSE vs > -ftrivial-auto-var-init=. Add it to our testsuite given that area > could do with better coverage. > > [0] https://github.com/llvm/llvm-project/issues/119646 > > gcc/testsuite/Cha

Re: [PATCH] testsuite: Mark gcc.c-torture/execute/memcpy-a?.c tests expensive

2024-12-03 Thread Mike Stump
On Dec 2, 2024, at 4:27 AM, Maciej W. Rozycki wrote: > > These tests can take several seconds per compilation to complete, taking > total elapsed time measured in minutes. Mark them as expensive so as to > let people skip them where they want to save on testing time. > > gcc/testsuite/

Re: [patch,testsuite] Rectify some tests

2024-12-03 Thread Mike Stump
On Dec 3, 2024, at 3:08 AM, Georg-Johann Lay wrote: > > This patch fixes some unrelated tests that were failing. > In most cases, bad tests are slipping in because they > are preprocessed like: > > size_t -> long unsigned int -> breaks when size_t is smaller etc. > > Other reason is that they a

Re: PING^3: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-11-26 Thread Mike Stump
On Nov 26, 2024, at 11:55 AM, David Malcolm wrote: > > Ping Ok. I'll punt on the diff documentation bits. > On Mon, 2024-11-18 at 16:22 -0500, David Malcolm wrote: >> Another ping for this patch; any pex experts out there? >> >> Thanks! >> Dave >> >> On Wed, 2024-05-29 at 17:06 -0400, David M

Re: Ping: Re: [PATCH] testsuite: rename plugins from .c to .cc

2024-11-26 Thread Mike Stump
On Nov 26, 2024, at 11:56 AM, David Malcolm wrote: > > Ping for this patch; thanks! Ok. > On Fri, 2024-11-15 at 20:05 -0500, David Malcolm wrote: >> In r12-6650-g5c69acb32329d4 we updated our sources from .c to .cc >> since for some time GCC has been implemented in C++, not C. >> >> GCC plugin

Re: [PATCH] rs6000, fix test builtins-1-p10-runnable.c

2024-11-23 Thread Mike Stump
On Nov 21, 2024, at 7:49 AM, Carl Love wrote: > > Ping 6 > > On 11/14/24 1:36 PM, Carl Love wrote: >> Ping 5 >> >> On 11/5/24 8:27 AM, Carl Love wrote: >>> Ping 4 >>> >>> On 10/28/24 4:28 PM, Carl Love wrote: Ping 3 On 10/17/24 1:31 PM, Carl Love wrote: > Ping 2 >

Re: PING Re: [PATCH] testsuite: add print-stack.exp

2024-11-20 Thread Mike Stump
On Nov 18, 2024, at 1:25 PM, David Malcolm wrote: > > Ping for this testsuite patch; I've occasionally found it *very* > helpful when debugging DejaGnu. Ok. Do put a comment that this is for debugging so no one removes it.

Re: [PATCH] [testsuite] disable PIE on ia32 on more tests

2024-11-04 Thread Mike Stump
On Oct 29, 2024, at 4:15 PM, Alexandre Oliva wrote: > > Multiple tests fail on ia32 with -fPIE enabled by default because of > different call sequences required by the call-saved PIC register > (no-callee-saved-*.c), uses of the constant pool instead of computing > constants (pr100865-*.c), and u

Re: [PATCH] [testsuite] fix pr70321.c PIC expectations

2024-11-04 Thread Mike Stump
On Oct 29, 2024, at 4:08 PM, Alexandre Oliva wrote: > > When we select a non-bx get_pc_thunk, we get an extra mov to set up > the PIC register before the abort call. Expect that mov or a > get_pc_thunk.bx call. > > Regstrapped on x86_64-linux-gnu; also tested on i686-linux-gnu with > -fPIE. Ok

Re: [PATCH 0/3] Move some single-file LTO tests to torture

2024-10-31 Thread Mike Stump
On Oct 31, 2024, at 1:56 PM, Sam James wrote: > > Sam James writes: > >> Andrew pointed this out when committing those testsuite fixes earlier. We >> may as well make these proper torture tests rather than having them >> unnecessarily in the special lto/ dir which is meant for multiple files >>

Re: [PATCH] testsuite: add testcase for fixed PR107467

2024-10-28 Thread Mike Stump
On Oct 25, 2024, at 12:47 PM, Sam James wrote: > > PR107467 ended up being fixed by the fix for PR115110, but let's > add the testcase on top. > > gcc/testsuite/ChangeLog: > PR tree-optimization/107467 > PR middle-end/115110 > > * g++.dg/lto/pr107467_0.C: New test. > --- > OK?

Re: [patch,testsuite] Some float64 and float32x test require double64plus.

2024-10-04 Thread Mike Stump
On Oct 4, 2024, at 9:40 AM, Georg-Johann Lay wrote: > > Some of the float64 and float32x test cases are using double built-ins > and hence require double64plus resp. double_float32xplus, i.e. double > is at least as good as float32x. > > This patch adds according dg-require-effective-target filt

Re: [PATCH] testsuite: Prevent unrolling of main in LTO test [PR116683]

2024-09-26 Thread Mike Stump
On Sep 26, 2024, at 11:47 AM, Alex Coplan wrote: > > In r15-3585-g9759f6299d9633cabac540e5c893341c708093ac I added a test which > started failing on PowerPC. The test checks that we unroll exactly one loop > three times with the following: > > // { dg-final { scan-ltrans-rtl-dump-times "Unrolle

Re: [committed] libstdc++: Add .editorconfig files

2024-09-16 Thread Mike Stump
On Sep 16, 2024, at 2:23 AM, Jonathan Wakely wrote: > > Arsen mentioned that he has some similar emacs config for formatting > libstdc++ code which should probably be added to the repo somewhere (I > don't know enough about emacs to know where that should be, or how to > make it only apply to the

Re: [PATCH] testsuite: a few more hostedlib adjustments

2024-09-13 Thread Mike Stump
On Sep 12, 2024, at 6:08 PM, Alexandre Oliva wrote: > > On Sep 12, 2024, Mike Stump wrote: > >> On Sep 3, 2024, at 11:44 PM, Alexandre Oliva wrote: >>> >>> Here's an updated and refreshed version that gets trunk built with >>> --disable-host

Re: [PATCH v2] testsuite: introduce hostedlib effective target

2024-09-12 Thread Mike Stump
On Sep 3, 2024, at 11:44 PM, Alexandre Oliva wrote: > > Here's an updated and refreshed version that gets trunk built with > --disable-hosted-libstdcxx on x86_64-linux-gnu to not get any spurious > fails during in-tree testing. Also bootstrapped on hosted > x86_64-linux-gnu. Ok to install? Ok.

Re: [PATCH] Make 'target-supports.exp' additions for nvptx target generally available

2024-09-09 Thread Mike Stump
Ok. Though, some of these files are so littered with target bits that essentially it doesn't make too much a difference. On Jul 18, 2024, at 4:44 AM, Thomas Schwinge wrote: > > OK to push (once testing completes) the attached > "Make 'target-supports.exp' additions for nvptx target generally a

Re: [PATCH v2] testsuite: introduce hostedlib effective target

2024-09-04 Thread Mike Stump
On Sep 3, 2024, at 11:44 PM, Alexandre Oliva wrote: > > On Nov 9, 2023, Mike Stump wrote: > >> On Nov 8, 2023, at 8:29 AM, Alexandre Oliva wrote: >>> >>> On Nov 5, 2023, Mike Stump wrote: >>> >>>> that, otherwise, I'll approve th

Re: [PING^3] [PATCH] PR116080: Fix test suite checks for musttail

2024-09-03 Thread Mike Stump
On Sep 2, 2024, at 4:23 PM, Andi Kleen wrote: > > Andi Kleen writes: > > PING^3 Ok. >> Andi Kleen writes: >> >> PING^2 for https://gcc.gnu.org/pipermail/gcc-patches/2024-July/658602.html >> >> This fixes some musttail related test suite failures that cause noise on >> various targets. >>

Re: [PATCH] testsuite: Prune compilation messages for modules tests

2024-08-31 Thread Mike Stump
On Aug 18, 2024, at 3:28 PM, Hans-Peter Nilsson wrote: > > As noticed when verifying the dejagnu fix. Tested cris-elf > with a new newlib that arranges to emit the mentioned > warning, with/without the update in dejagnu to handle the > miniscule "in". Ok to commit? Ok.

Re: [PATCH v2] [testsuite] add linkonly to dg-additional-sources [PR115295]

2024-08-31 Thread Mike Stump
On Jun 11, 2024, at 10:56 PM, Alexandre Oliva wrote: > > On Jun 11, 2024, Andrew Pinski wrote: > >> I think we should just fully revert the changes to >> dg-additional-sources and add an explicit `dg-do run` to pr95401.cc > > I don't suppose an explicit "dg-do run" would make things work relia

Re: [PATCH] testsuite: Rename scanltranstree.exp -> scanltrans.exp

2024-08-31 Thread Mike Stump
On Aug 29, 2024, at 9:07 AM, Alex Coplan wrote: > > Since r15-3254-g3f51f0dc88ec21c1ec79df694200f10ef85915f4 > added scan-ltrans-rtl* variants to scanltranstree.exp, it no longer > makes sense to have "tree" in the name. This renames the file > accordingly and updates users. > > Tested on aarch

Re: More variants of C/C++ test cases for 'constructor', 'destructor' function attributes with priority

2024-06-04 Thread Mike Stump
On Jun 4, 2024, at 11:30 AM, Thomas Schwinge wrote: > > For my recent work on > "nvptx target: Global constructor, destructor support, via nvptx-tools 'ld'", > I needed more variants of C/C++ test cases for 'constructor', > 'destructor' function attributes with priority: in particular, split into

Re: [PATCH] [testsuite] conditionalize dg-additional-sources on target and type

2024-05-29 Thread Mike Stump
On May 23, 2024, at 6:28 AM, Alexandre Oliva wrote; > I came up with an entirely different approach: > > > g++.dg/vect/pr95401.cc has dg-additional-sources, and that fails when > check_vect_support_and_set_flags finds vector support lacking for > execution tests: tests decay to compile tests, an

Re: [PATCH] vax: resolve long-standing documentation bugs re floating-point codegen [PR79646]

2024-04-26 Thread Mike Stump
On Apr 26, 2024, at 11:17 AM, Abe Skolnik wrote: You never need to do any work in .po files, omit that part and repost.

Re: [PATCH v2] [testsuite] require sqrt_insn effective target where needed

2024-04-23 Thread Mike Stump
On Apr 22, 2024, at 2:56 AM, Alexandre Oliva wrote: > > This patch takes feedback received for 3 earlier patches, and adopts a > simpler approach to skip the still-failing tests, that I believe to be > in line with ppc maintainers' expressed preferences. > https://gcc.gnu.org/pipermail/gcc-patche

Re: [PATCH] [testsuite] introduce strndup effective target

2024-04-18 Thread Mike Stump
On Apr 18, 2024, at 4:32 AM, Alexandre Oliva wrote: > > On Apr 16, 2024, Alexandre Oliva wrote: > >> * gcc.dg/builtin-dynamic-object-size-1.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-2.c: Likewise. >> * gcc.dg/builtin-dynamic-object-size-3.c: Likewise. >> * gcc.dg/

Re: [PATCH] [testsuite] [arm] accept empty init for bfloat16

2024-04-16 Thread Mike Stump
On Apr 15, 2024, at 8:50 PM, Alexandre Oliva wrote: > > Complete r13-2205, adjusting an arm-specific test that expects a > no-longer-issued error at an empty initializer. > > Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, > aarch64-, x86- and x86_64-vxworks7r2. Ok to install

Re: [PATCH] [c++] [testsuite] adjust contracts9.C for negative addresses

2024-04-16 Thread Mike Stump
On Apr 15, 2024, at 8:20 PM, Alexandre Oliva wrote: > > The test expected the address of a literal string, converted to long > long, to yield a positive value. That expectation doesn't necessarily > hold, and the test fails where it doesn't. > > Adjust the test to use a pointer that will compar

Re: [PATCH] testsuite: Define _POSIX_C_SOURCE for test

2024-03-17 Thread Mike Stump
On Mar 10, 2024, at 10:26 AM, Torbjörn SVENSSON wrote: > > Ok for trunk? Ok. > As the tests assume that strndup() is visible (only part of > POSIX.1-2008) define the guard to ensure that it's visible. Currently, > glibc appears to always have this defined in C++, newlib does not. > > Without

Re: [PATCH] c-c++-common/Wrestrict.c: fix some typos and enable for LLP64

2024-03-17 Thread Mike Stump
On Feb 15, 2024, at 6:08 AM, Jonathan Yong <10wa...@gmail.com> wrote: > > Attached patch OK? Ok. > Copy/pasted for review convenience. > > diff --git a/gcc/testsuite/c-c++-common/Wrestrict.c > b/gcc/testsuite/c-c++-common/Wrestrict.c > index 4d005a618b3..57a3f67e21e 100644 > --- a/gcc/testsuit

Re: [PATCH v5 RESEND] C, ObjC: Add -Wunterminated-string-initialization

2024-02-26 Thread Mike Stump
On Feb 26, 2024, at 7:56 AM, Alejandro Colomar wrote: > > I don't see an obvious order in that file. Where would you put the > option? The best place, would be to put it just after: -Warray-bounds -Warray-bounds=n This is a functional style grouping that best mirrors the existing orde

Re: [PATCH v5 RESEND] C, ObjC: Add -Wunterminated-string-initialization

2024-02-25 Thread Mike Stump
On Feb 6, 2024, at 2:45 AM, Alejandro Colomar wrote: > > Warn about the following: > >char s[3] = "foo"; No ObjC specific impact here, so no need for ObjC review. As a member of the peanut gallery, I like the patch. Joseph, this is been submitted 5 times over the past year. Any thoughts

Re: [PATCH] testsuite: Fix up lra effective target

2024-02-16 Thread Mike Stump
On Feb 16, 2024, at 2:16 AM, Jakub Jelinek wrote: > > There is one special case, NVPTX, which is a TARGET_NO_REGISTER_ALLOCATION > target. I think claiming for it that it is a lra target is strange (even > though it effectively returns true for targetm.lra_p ()), unsure if it > supports asm goto

Re: [PATCH] testsuite: Fix up lra effective target

2024-02-16 Thread Mike Stump
On Feb 16, 2024, at 2:16 AM, Jakub Jelinek wrote: > > Given the recent discussions on IRC started with Andrew P. mentioning that > an asm goto outputs test should have { target lra } and the lra effective > target in GCC 11/12 only returning 0 for PA and in 13/14 for PA/AVR, while > we clearly ha

Re: [PATCH] testsuite: Add support for scanning assembly with comparitor

2024-02-15 Thread Mike Stump
On Feb 12, 2024, at 11:38 AM, Edwin Lu wrote: > > There is currently no support for matching at least x lines of assembly > (only scan-assembler-times). This patch would allow setting upper or lower > bounds. > > Use case: using different scheduler descriptions and/or cost models will > change

Re: [PATCH] testsuite: Define _POSIX_SOURCE for tests [PR113278]

2024-02-15 Thread Mike Stump
On Feb 15, 2024, at 9:03 AM, Torbjörn SVENSSON wrote: > > Ok for trunk? Ok. > gcc/testsuite/ChangeLog: > PR113278 > * c-c++-common/analyzer/fileno-1.c: Define _POSIX_SOURCE. > * c-c++-common/analyzer/flex-with-call-summaries.c: Same. > * c-c++-common/analyzer/flex-witho

Re: Unreviewed c++ and libgomp testsuite patches

2024-02-12 Thread Mike Stump
> On Feb 12, 2024, at 5:27 AM, Rainer Orth > wrote: > > The following patches have remained unreviewed for a week or more: > > testsuite: Fix c-c++-common/pr103798-2.c on Solaris [PR113706] >https://gcc.gnu.org/pipermail/gcc-patches/2024-February/644842.html Jason commented.

Re: [PATCH] i386, testsuite: adjust asm patterns

2024-02-11 Thread Mike Stump
On Feb 10, 2024, at 10:07 AM, FX Coudert wrote: > > The new testcase gcc.target/i386/asm-raw-symbol.c fails on darwin. This is > partly because symbols are prefixed with underscore, and also because the > order of operands in the addition is reversed (but I think it’s valid still). > The code

Re: [PATCH] testsuite: Update test case to comply with GCC14 changes

2024-02-11 Thread Mike Stump
On Feb 10, 2024, at 7:21 AM, Torbjörn SVENSSON wrote: > > I have confirmed that this updated pr97969.c file still hangs with > gcc-arm-none-eabi-9-2020-q2-update as mentioned in comment 2 of PR97969. > > Ok for trunk? Ok.

Re: [PATCH v2] testsuite: Pattern does not match when using --specs=nano.specs

2024-02-08 Thread Mike Stump
On Feb 8, 2024, at 9:44 AM, Torbjörn SVENSSON wrote: > > Changes since v1: > - Replaced .* with [^\r\n]* to avoid matching newline. > > Ok for trunk and releases/gcc-13? Ok.

Re: [PATCH] testsuite: Pattern does not match when using --specs=nano.specs

2024-02-07 Thread Mike Stump
On Feb 6, 2024, at 8:58 AM, Torbjörn SVENSSON wrote: > > Ok for trunk and releases/gcc-13? Ok. If .* goes across newlines, you might want to not use .. > -if {![regexp -- "/${compiler}(\\.exe)? -quiet.*$compiler_pattern" > $gcc_output]} { > +if {![regexp -- "/${compiler}(\\.exe)? .*-

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pr70321.c on 32-bit Solaris/x86

2024-02-01 Thread Mike Stump
On Jan 24, 2024, at 1:01 AM, Rainer Orth wrote: > > gcc.target/i386/pr70321.c FAILs on 32-bit Solaris/x86 since its > introduction in > > commit 43201f2c2173894bf7c423cad6da1c21567e06c0 > Author: Roger Sayle > Date: Mon May 30 21:20:09 2022 +0100 > >PR target/70321: Split double word equ

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/avx512vl-stv-rotatedi-1.c on 32-bit Solaris/x86

2024-02-01 Thread Mike Stump
On Jan 24, 2024, at 1:12 AM, Rainer Orth wrote: > > gcc.target/i386/avx512vl-stv-rotatedi-1.c FAILs on 32-bit Solaris/x86 > since its introduction in > > commit 4814b63c3c2326cb5d7baa63882da60ac011bd97 > Author: Roger Sayle > Date: Mon Jul 10 09:04:29 2023 +0100 > >i386: Add AVX512 suppo

Re: [PATCH] testsuite, asan, hwsan: Add libstdc++ deps where required.

2024-02-01 Thread Mike Stump
On Jan 30, 2024, at 2:30 AM, Iain Sandoe wrote: > > tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, > OK for trunk? Ok. If asan people want to chime in...

Re: [PATCH] testsuite, ubsan: Add libstdc++ deps where required.

2024-02-01 Thread Mike Stump
On Jan 30, 2024, at 2:31 AM, Iain Sandoe wrote: > > tested on i686, x86_64 (and aarch64) Darwin, x86_64, aarch64 Linux, > OK for trunk? Ok. If the ubsan people want to review this, certainly, happy to have them chime in.

Re: [PATCH] testsuite, Objective-C++: Update link flags [PR112863].

2024-02-01 Thread Mike Stump
On Jan 28, 2024, at 7:03 AM, Iain Sandoe wrote: > > Tested on i686, x86_64, aarch64 Darwin, x86_64, aarch64 Linux, > OK for trunk? Ok. If you discover needed updates, please feel free to drop them in.

Re: Ping [PATCH] testsuite: Reduce gcc.dg/torture/inline-mem-cpy-1.c by 11 for simulators

2024-01-12 Thread Mike Stump
On Jan 12, 2024, at 2:52 AM, Hans-Peter Nilsson wrote: > > Ping. (Don't miss the gcc.dg/torture/inline-mem-cpy-1.c part.) > > On Mon, 1 Jan 2024, Hans-Peter Nilsson wrote: > >> Tested mmix-knuth-mmixware (where all torture-variants of >> gcc.dg/torture/inline-mem-cpy-1.c now pass) and native >

Re: [PATCH] Allow overriding EXPECT

2023-12-21 Thread Mike Stump
On Dec 21, 2023, at 8:49 AM, Christophe Lyon wrote: > > While investigating possible race conditions in the GCC testsuites > caused by bufferization issues, I wanted to investigate workarounds > similar to GDB's READ1 [1], and I noticed it was not always possible > to override EXPECT when running

Re: [PATCH] Testsuite: restrict test to nonpic targets

2023-12-11 Thread Mike Stump
On Dec 11, 2023, at 12:29 AM, FX Coudert wrote: > > The test is currently failing on x86_64-apple-darwin. This patch requires > nonpic, as suggested in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112297 > by Andrew Pinski. > > OK to commit? Ok.

Re: [PATCH] testsuite: require avx_runtime for some tests

2023-12-01 Thread Mike Stump
On Nov 6, 2023, at 2:59 AM, Marc Poulhiès wrote: > > These 3 tests fails parsing the 'vect' dump when not using -mavx. Make > the dependency explicit. > > gcc/testsuite/ChangeLog: > > * gcc.dg/vect/vect-ifcvt-18.c: Add dep on avx_runtime. > * gcc.dg/vect/vect-simd-clone-16f.c: Likew

Re: [PATCH] testsuite: refine gcc.dg/analyzer/fd-4.c test for newlib

2023-12-01 Thread Mike Stump
On Nov 6, 2023, at 3:01 AM, Marc Poulhiès wrote: > > Contrary to glibc, including stdio.h from newlib defines mode_t which > conflicts with the test's type definition. > > .../gcc/testsuite/gcc.dg/analyzer/fd-4.c:19:3: error: redefinition of typedef > 'mode_t' with different type > ... > .../in

Re: [PATCH] testsuite: skip gcc.target/i386/pr106910-1.c test when using newlib

2023-12-01 Thread Mike Stump
On Nov 6, 2023, at 2:57 AM, Marc Poulhiès wrote: > > Using newlib produces a different codegen because the support for c99 > differs (see libc_has_function hook). > > gcc/testsuite/ChangeLog: > > * gcc.target/i386/pr106910-1.c: Disable for newlib. > --- > Tested on x86_64-linux and x86_64

Re: [PATCH] testsuite/gcc.dg/uninit-pred-9_b.c:20: Fix XPASS for various targets

2023-11-26 Thread Mike Stump
On Nov 24, 2023, at 7:15 PM, Hans-Peter Nilsson wrote: > > While looking at the various targets, I found that the m32r > target has two options implemented as opposites: > -mbranch-cost=1 and -mbranch-cost=2, that have a bug that > makes them yield their functionally opposite effect; > i.e. -mbra

Re: [PATCH #4/4] testsuite: discard c++ exclusion on underaligned pointer warning

2023-11-23 Thread Mike Stump
On Nov 19, 2023, at 6:34 PM, Alexandre Oliva wrote: > > Having extended check_and_warn_address_or_pointer_of_packed_member to > find the packed (short) enum pointer in the cast expression coming > from the C++ front-end, and amended the C++ front end to mark short > enums as TYPE_PACKED, C++ issu

Re: [PATCH] testsuite: tsan: add fallback overload for pthread_cond_clockwait

2023-11-09 Thread Mike Stump
On Nov 8, 2023, at 5:49 PM, Alexandre Oliva wrote: > > LTS GNU/Linux distros from 2018, still in use, don't have > pthread_cond_clockwait. There's no trivial way to detect it so as to > make the test conditional, but there's an easy enough way to silence > the fail due to lack of the function in

Re: testsuite: introduce hostedlib effective target

2023-11-09 Thread Mike Stump
On Nov 8, 2023, at 8:29 AM, Alexandre Oliva wrote: > > On Nov 5, 2023, Mike Stump wrote: > >> that, otherwise, I'll approve this version. > > FWIW, this version is not usable as is. Something went wrong in my > testing, and several regressions only visib

Re: [PATCH] testsuite: arg-pushing reqs -mno-accumulate-outgoing-args

2023-11-09 Thread Mike Stump
On Nov 8, 2023, at 7:55 AM, Alexandre Oliva wrote: > > gcc.target/i386/pr95126-m32-[34].c expect push instructions that are > only present with -mno-accumulate-outgoing-args, so make that option > explicit rather than dependent on tuning. > > Regstrapped on x86_64-linux-gnu, also tested with gcc

Re: [PATCH] Testsuite, i386: Mark test as requiring dfp

2023-11-05 Thread Mike Stump
On Nov 5, 2023, at 12:33 PM, FX Coudert wrote: > > kind ping for this easy patch > > >> Le 30 oct. 2023 à 15:19, FX Coudert a écrit : >> >> Hi, >> >> The test is currently failing on x86_64-apple-darwin with "decimal >> floating-point not supported for this target”. >> Marking the test as r

Re: [PATCH] testsuite: check for and use -mno-strict-align where needed

2023-11-05 Thread Mike Stump
On Oct 19, 2023, at 8:16 PM, Alexandre Oliva wrote: > > On Mar 10, 2021, Alexandre Oliva wrote: > >> ppc configurations that have -mstrict-align enabled by default fail >> gcc.dg/strlenopt-80.c, because some memcpy calls don't get turned into >> MEM_REFs, which defeats the tested-for strlen opt

Re: [PATCH 1/2] testsuite: Add and use thread_fence effective-target

2023-11-05 Thread Mike Stump
On Oct 2, 2023, at 1:24 AM, Christophe Lyon wrote: > > ping? > > On Sun, 10 Sept 2023 at 21:31, Christophe Lyon > wrote: > Some targets like arm-eabi with newlib and default settings rely on > __sync_synchronize() to ensure synchronization. Newlib does not > implement it by default, to make u

Re: testsuite: introduce hostedlib effective target

2023-11-05 Thread Mike Stump
On Nov 1, 2023, at 6:11 PM, Alexandre Oliva wrote: > > Several C++ tests fail with --disable-hosted-libstdcxx, whether > because stdc++ext gets linked in despite not being built, because > standard headers are included but that are unavailable in this mode, > or because headers are (mistakenly?)

Re: [PATCH] testsuite: Force use of -c when precompiling headers

2023-11-05 Thread Mike Stump
On Oct 27, 2023, at 8:11 AM, Christophe Lyon wrote: > > In some configurations of our validation setup, we always call the > compiler with -Wl,-rpath=XXX, which instructs the driver to invoke the > linker if none of -c, -S or -E is used. > > This happens to be the case in the PCH tests, where dg

Re: [PATCH] testsuite: Allow general skips/requires in PCH tests

2023-10-26 Thread Mike Stump
On Oct 26, 2023, at 5:34 AM, Richard Sandiford wrote: > dg-pch.exp handled dg-require-effective-target pch_supported_debug > as a special case, by grepping the source code. This patch tries > to generalise it to other dg-require-effective-targets, and to > dg-skip-if. > > There also seemed to b

Re: [testsuite] note pitfall in how outputs.exp sets gld

2023-06-27 Thread Mike Stump via Gcc-patches
On Jun 22, 2023, at 10:35 PM, Alexandre Oliva wrote: > > This patch documents a glitch in gcc.misc-tests/outputs.exp: it checks > whether the linker is GNU ld, and uses that to decide whether to > expect collect2 to create .ld1_args files under -save-temps, but > collect2 bases that decision on w

Re: PING^2: Re: [PATCH 1/3] testsuite: move handle-multiline-outputs to before check for blank lines

2023-06-21 Thread Mike Stump via Gcc-patches
On Jun 20, 2023, at 10:21 AM, David Malcolm wrote: > Does this testsuite patch look OK? > > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620275.html > > Thanks > David > > On Mon, 2023-06-12 at 19:11 -0400, David Malcolm wrote: >> Please can someone review this testsuite patch: >> http

Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long)

2023-06-12 Thread Mike Stump via Gcc-patches
On Jun 12, 2023, at 1:35 AM, Bernhard Reutner-Fischer wrote: > > On Sat, 10 Jun 2023 11:29:36 -0700 > Mike Stump wrote: > >> On Jun 9, 2023, at 2:47 PM, Bernhard Reutner-Fischer >> wrote: > >>>But well. Either way, wh

Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long)

2023-06-10 Thread Mike Stump via Gcc-patches
On Jun 9, 2023, at 2:47 PM, Bernhard Reutner-Fischer wrote: > > On 9 June 2023 19:18:45 CEST, Mike Stump via Gcc-patches > wrote: >> simulation ports. Maybe a 20-100x speedup? If you want to go this way I'd >> say do it in python at the bottom as it would

Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long)

2023-06-09 Thread Mike Stump via Gcc-patches
On Jun 9, 2023, at 9:20 AM, Hans-Peter Nilsson via Gcc-patches wrote: > > The test 27_io/basic_istream/ignore/wchar_t/94749.cc takes > about 10 minutes to run for cris-elf in the "gdb simulator" I'd let the libstdc++ people comment on specific things. I'll comment on general things. We could

Re: Tighten 'dg-warning' alternatives in 'c-c++-common/Wfree-nonheap-object{,-2,-3}.c' (was: [PATCH] correct -Wmismatched-new-delete (PR 98160, 98166))

2023-06-07 Thread Mike Stump via Gcc-patches
On Jun 7, 2023, at 8:01 AM, Thomas Schwinge wrote: > On 2020-12-08T13:46:32-0700, Martin Sebor via Gcc-patches > wrote: >> The attached changes [...] > > ... eventually became commit fe7f75cf16783589eedbab597e6d0b8d35d7e470 > "Correct/improve maybe_emit_free_warning (PR middle-end/98166, PR c++

Re: Remove 'gcc/testsuite/g++.dg/warn/Wfree-nonheap-object.s' (was: [PATCH] add -Wmismatched-new-delete to middle end (PR 90629))

2023-06-07 Thread Mike Stump via Gcc-patches
On Jun 7, 2023, at 7:54 AM, Thomas Schwinge wrote: > > On 2020-11-03T16:56:48-0700, Martin Sebor via Gcc-patches > wrote: >> Attached is a simple middle end implementation of detection of >> mismatched pairs of calls to C++ new and delete, along with >> a substantially enhanced implementation o

Re: [testsuite] bump some tsvc timeouts

2023-06-07 Thread Mike Stump via Gcc-patches
On Jun 7, 2023, at 1:12 AM, Alexandre Oliva wrote: > > Several tests are timing out when targeting x86-*-vxworks with qemu. > > Bump their timeout factor. Ok. I think these are obvious to people that have to work with simulators and the testsuite so if you want to self approve you can.

Re: [PATCH] [i386] Support type _Float16/__bf16 independent of SSE2.

2023-04-19 Thread Mike Stump via Gcc-patches
LLM, machine learning and AI likes coding with data types that are weird, float16, bf16, 8 bit float and 4 bit floats. Longer term, would be nice to natively support these everywhere. Would be nice to trial run them in the compiler, sort it all out, so that the implementation experience can driv

Re: 'g++.dg/modules/modules.exp': don't leak local 'unsupported' proc [PR108899]

2023-04-01 Thread Mike Stump via Gcc-patches
On Mar 30, 2023, at 6:51 AM, Alexandre Oliva wrote: > > On Mar 30, 2023, Alexandre Oliva wrote: > >> If we're dropping the renaming, I suppose we could also revert Jakub's >> change. I suppose this patch will take care of it, pending testing... > > Regstrapped on x86_64-linux-gnu and also tes

Re: [Patch] c-c++-common/Warray-bounds.c: fix excess warnings on LLP64

2023-03-30 Thread Mike Stump via Gcc-patches
On Feb 27, 2023, at 2:29 AM, Jonathan Yong via Gcc-patches wrote: > > Attached patch OK? Ok. >* c-c++-common/Warray-bounds.c: Fix excess warnings on > > LLP64.<0001-c-c-common-Warray-bounds.c-fix-excess-warnings-on-LL.patch>

Re: [PATCH] [testsuite] enable -maltivec like vect_int for signbit-2.c

2023-03-25 Thread Mike Stump via Gcc-patches
On Mar 25, 2023, at 1:33 AM, Alexandre Oliva wrote: > > Explicitly enable altivec if it's supported. vect_int tests for > powerpc_altivec_ok, but without the explicit option, if altivec is not > enabled by default, we end up expecting vectorization that doesn't > occur. > > Regstrapped on ppc64

Re: [PATCH] testsuite: always use UTF-8 in scan-sarif-file[-not] [PR105959]

2023-03-22 Thread Mike Stump via Gcc-patches
On Mar 20, 2023, at 3:06 PM, David Malcolm via Gcc-patches wrote: > > c-c++-common/diagnostic-format-sarif-file-4.c is a test case for > quoting non-ASCII source code in a SARIF diagnostic log. > > The SARIF standard mandates that .sarif files are UTF-8 encoded. > > PR testsuite/105959 notes t

Re: [PATCH] [testsuite] test for weak_undefined support and add options

2023-03-18 Thread Mike Stump via Gcc-patches
On Mar 15, 2023, at 11:40 PM, Alexandre Oliva wrote: > > On Mar 15, 2023, Alexandre Oliva wrote: > >> Regstrapped on ppc64-linux-gnu. Also tested (with gcc-12) on multiple >> *-vxworks7r2 targets (arm, aarch64, ppc64, x86, x86_64). Ok to install? > > Further testing revealed a problem in my

Re: [PATCH] testsuite: Support scanning tree-dumps

2023-03-06 Thread Mike Stump via Gcc-patches
On Mar 6, 2023, at 10:52 AM, Hans-Peter Nilsson via Gcc-patches wrote: > > Ok to apply? Ok. > * lib/target-supports.exp (check_compile): Support scanning tree-dumps.

Re: [PATCH 1/3] testsuite: Add tail_call effective target

2023-03-06 Thread Mike Stump via Gcc-patches
On Mar 6, 2023, at 10:45 AM, Hans-Peter Nilsson via Gcc-patches wrote: > > Ok to commit? Ok. > -- >8 -- > The RTL "expand" dump is the first RTL dump, and it also appears to be > the earliest trace of the target having implemented sibcalls. > Including the "," in the pattern searched for, to t

Re: Ping: [PATCH 1/2] testsuite: Provide means to regexp in multiline patterns

2023-03-06 Thread Mike Stump via Gcc-patches
Ok On Mar 3, 2023, at 5:58 PM, Hans-Peter Nilsson wrote: > > Ping... > >> From: Hans-Peter Nilsson >> Date: Fri, 24 Feb 2023 20:16:03 +0100 >> >> Ok to commit?

Re: [PATCH 0/2] LoongArch: testsuite: Fix tests related to stack

2023-03-03 Thread Mike Stump via Gcc-patches
On Mar 3, 2023, at 12:40 AM, Xi Ruoyao via Gcc-patches wrote: > > Some trivial test case fixes. Ok for trunk? Ok.

Re: Ping: [PATCH] testsuite: Tweak gcc.dg/attr-aligned.c for CRIS

2023-03-02 Thread Mike Stump via Gcc-patches
On Feb 27, 2023, at 5:54 PM, Hans-Peter Nilsson via Gcc-patches wrote: > > Ping... Ok. > >> From: Hans-Peter Nilsson >> Date: Thu, 16 Feb 2023 21:05:29 +0100 > >> Asking for the lines outside the "#if __CRIS__" part. >> Ok to commit? >> >> -- >8 -- >> tm.texi says for BIGGEST_ALIGNMENT (fr

Re: [PATCH] testsuite: Don't include multiline regexps in the the pass/fail log

2023-02-27 Thread Mike Stump via Gcc-patches
On Feb 27, 2023, at 9:59 AM, Hans-Peter Nilsson wrote: > >> From: Mike Stump >> Date: Mon, 27 Feb 2023 09:41:18 -0800 > >>> diff --git a/gcc/testsuite/lib/multiline.exp >>> b/gcc/testsuite/lib/multiline.exp >>> index 84ba9216642e..5eccf2bbebc1 100

Re: [PR100127] Test for coroutine header in clang-compatible tests

2023-02-27 Thread Mike Stump via Gcc-patches
On Feb 22, 2023, at 12:04 PM, Alexandre Oliva wrote: > > That would change what gets tested with clang, I suppose, but I hope > that's for the better. I wondered what to do at the #else above, and > decided to spell it a little differently. Retested on x86_64-linux-gnu > (trunk) and arm-vxworks

Re: [PATCH] testsuite: Don't include multiline regexps in the the pass/fail log

2023-02-27 Thread Mike Stump via Gcc-patches
On Feb 24, 2023, at 9:54 AM, Hans-Peter Nilsson via Gcc-patches wrote: > > Ok to commit? Ok. Thanks. > diff --git a/gcc/testsuite/lib/multiline.exp b/gcc/testsuite/lib/multiline.exp > index 84ba9216642e..5eccf2bbebc1 100644 > --- a/gcc/testsuite/lib/multiline.exp > +++ b/gcc/testsuite/lib/mul

Re: [PATCH] Drop need for constant I in ctf test

2023-02-17 Thread Mike Stump via Gcc-patches
On Feb 16, 2023, at 10:59 PM, Alexandre Oliva wrote: > > Though I is supposed to be a constant expression, this is not the case > on vxworks, but this is not what this debug information format test is > testing for, so use real constants to initialize complex variables. > > Regstrapped on x86_64

Re: [PATCH] [arm] xfail fp-uint64-convert-double-* on all arm targets

2023-02-17 Thread Mike Stump via Gcc-patches
On Feb 16, 2023, at 10:20 PM, Alexandre Oliva wrote: > > It wasn't long ago that I xfailed these tests on arm-*-eabi, but the > fail is expected on all other arm targets: even when hard float is > available, conversions between 64-bit integers and double are always > emulated on ARM, and the emul

  1   2   3   4   5   6   7   8   9   10   >