DJ Delorie wrote:
Bizzare, the problem isn't the hash loop, it's the error handler at
the end! It never uses [30] for the main loop, only if you give it a
number between 0xfffb and 0x - and in the case where it
would use [30], it's supposed to abort anyway.
I couldn't figure out why
I know the callers of save_string check its return value for null, but
by then it's too late -- we've memcpy'd over a null pointer.
OK?
2011-03-06 Michael Snyder
* make-relative-prefix.c (save_string): Use xmalloc over malloc.
Index: make-re
OK?
2011-03-06 Michael Snyder
* argv.c (expandargv): Close memory leak.
Index: argv.c
===
RCS file: /cvs/src/src/libiberty/argv.c,v
retrieving revision 1.22
diff -u -p -r1.22 argv.c
--- argv.c 13 Aug 2010 11:36:10
Tom Tromey wrote:
"Michael" == Michael Snyder writes:
Michael> Are you sure? There is a path to "goto unknown" from before the
Michael> call to the alloc function. It might actually be null. Some
Michael> versions of 'free' don't like that.
Tristan Gingold wrote:
On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote:
Jakub Jelinek wrote:
On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote:
2011-03-03 Michael Snyder
* libiberty/cplus-dem.c (ada_demangle): Stop memory leak.
Also fix a one line indent
Mike Stump wrote:
On Mar 3, 2011, at 2:26 PM, Michael Snyder wrote:
DJ Delorie wrote:
As written, the function will access element [30] of a 30-element array.
Um, no?
Y-uh-huh!
fight fight fight... :-) There can be only one.
Oh, did I forget the smiley? ;-)
DJ Delorie wrote:
As written, the function will access element [30] of a 30-element array.
Um, no?
unsigned int mid = low + (high - low) / 2;
This can never give mid == high unless low == high, which won't happen
in that loop.
The math wants to search everything from (including) low to
DJ Delorie wrote:
As written, the function will access element [30] of a 30-element array.
Um, no?
Y-uh-huh!
unsigned int mid = low + (high - low) / 2;
This can never give mid == high unless low == high, which won't happen
in that loop.
The math wants to search everything from (incl
As written, the function will access element [30] of a 30-element array.
OK?
2011-03-03 Michael Snyder
* hashtab.c (higher_prime_index): Prevent array overrun.
Index: hashtab.c
===
RCS file: /cvs/src/src/libiberty
Jakub Jelinek wrote:
On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote:
2011-03-03 Michael Snyder
* libiberty/cplus-dem.c (ada_demangle): Stop memory leak.
Also fix a one line indent problem.
No libiberty/ in libiberty/ChangeLog.
@@ -1129,10 +1129,11
We don't have a separate libiberty list, do we?
2011-03-03 Michael Snyder
* libiberty/cplus-dem.c (ada_demangle): Stop memory leak.
Also fix a one line indent problem.
Index: cplus-dem.c
===
RCS file: /cv
11 matches
Mail list logo
