Re: [gofrontend-dev] Re: Go patch committed: Fix error reporting for invalid builtin calls

2015-08-03 Thread Michael Hudson-Doyle
Now I get ../../../gcc/libgo/runtime/mprof.goc: In function ‘runtime_Stack’: ../../../gcc/libgo/runtime/mprof.goc:437:19: error: ‘enablegc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] mstats.enablegc = enablegc; ^ ../../../gcc/libgo/runtime/mprof.

Re: [gofrontend-dev] [PATCH 1/2, libgo] Add reflection support to gccgo for ppc64, ppc64le in gcc 4.9

2015-01-07 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Wed, Jan 7, 2015 at 9:26 AM, Lynn A. Boger > wrote: >> >> In libgo/go/reflect/makefunc.go, calls to MakeFunc, makeMethodValue and >> makeValueMethod will panic if called when GOARCH is ppc64 or ppc64le. > > Right, I'm just saying that almost no code actually does th

Re: [gofrontend-dev] [PATCH 4/4] Gccgo port to s390[x] -- part II

2014-11-09 Thread Michael Hudson-Doyle
Ian Taylor writes: > I don't know what's up with the complex number change. In general the > Go compiler and libraries go to some effort to produce the same > answers on all platforms. We need to understand why we get different > answers on s390 (you may understand the differences, but I don't)

Re: [gofrontend-dev] gccgo and syscall.SysProcAttr.Cloneflags

2014-09-06 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Mon, Sep 1, 2014 at 4:18 AM, Michael Hudson-Doyle > wrote: >> >> It's late for me and I don't have a proper test case but it seems to me >> that while gccgo's syscall lets you set Cloneflags on its SysProcAttr, >> but

Re: [gofrontend-dev] libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-27 Thread Michael Hudson-Doyle
"'Ian Lance Taylor ' via gofrontend-dev" writes: > This patch from Anton Blanchard fixes libgo to adjust to the system page > size when calling madvise. Bootstrapped and ran Go testsuite on > x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Hi, I think this patch will make my Ca

Re: libgo patch committed: Compile math library with -ffp-contract=off

2014-03-16 Thread Michael Hudson-Doyle
Michael Hudson-Doyle writes: > Ian Lance Taylor writes: > >> On Thu, Mar 13, 2014 at 6:27 PM, Michael Hudson-Doyle >> wrote: >>> Ian Lance Taylor writes: >>> >>>> The bug report http://golang.org/issue/7074 shows that math.Log2(1) >>>&g

Re: libgo patch committed: Compile math library with -ffp-contract=off

2014-03-13 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Thu, Mar 13, 2014 at 6:27 PM, Michael Hudson-Doyle > wrote: >> Ian Lance Taylor writes: >> >>> The bug report http://golang.org/issue/7074 shows that math.Log2(1) >>> produces the wrong result on Aarch64, because the Go math pa

Re: libgo patch committed: Compile math library with -ffp-contract=off

2014-03-13 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > The bug report http://golang.org/issue/7074 shows that math.Log2(1) > produces the wrong result on Aarch64, because the Go math package is > compiled to use a fused multiply-add instruction. This patch to the > libgo configure script will use -ffp-contract=off when com

Re: Allow passing arrays in registers on AArch64

2014-02-18 Thread Michael Hudson-Doyle
Jakub Jelinek writes: > On Tue, Feb 11, 2014 at 02:51:08PM +, Marcus Shawcroft wrote: >> On 6 February 2014 22:51, Michael Hudson-Doyle >> wrote: >> >> > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >> > index 16c51a

Re: Allow passing arrays in registers on AArch64

2014-02-06 Thread Michael Hudson-Doyle
Ramana Radhakrishnan writes: > On Tue, Feb 4, 2014 at 2:12 AM, Michael Hudson-Doyle > wrote: >> Ping? I'm attaching a marginally cleaner version of the test. I've had >> a look at integrating this into aapcs64.exp but got defeated in the >> end. If go-tort

Re: Allow passing arrays in registers on AArch64

2014-02-03 Thread Michael Hudson-Doyle
et up before go-torture-execute can be called that I don't really understand and I also also don't know how to avoid executing this test if gccgo hasn't been built. All that said, is there any chance of getting the original ABI fix committed? It would be nice to have it in 4.9. Che

fix inconsistent install paths between gccgo and go tool

2014-01-21 Thread Michael Hudson-Doyle
Hi, This patch for the 4.8 branch fixes an inconsistency between gccgo's libgo and the go tool over where libraries installed with "go install -compiler gccgo" end up. Even if it's not strictly required, it makes sense to me that as gccgo implements go 1.1 it should match the go tool from that pa

Re: Allow passing arrays in registers on AArch64

2014-01-20 Thread Michael Hudson-Doyle
Richard Earnshaw writes: > On 17/01/14 23:56, Michael Hudson-Doyle wrote: >> Ian Lance Taylor writes: >> >>> On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle >>> wrote: >>>> >>>> On 18 Jan 2014 07:50, "Yufeng Zhang"

Re: Allow passing arrays in registers on AArch64

2014-01-17 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Fri, Jan 17, 2014 at 11:32 AM, Michael Hudson-Doyle > wrote: >> >> On 18 Jan 2014 07:50, "Yufeng Zhang" wrote: >>> >>> Also can you please try to add some new test(s)? It may not be that >>> straightforward t

Allow passing arrays in registers on AArch64

2014-01-17 Thread Michael Hudson-Doyle
supports compiling a language that can pass arrays by value on AArch64 yet. Cheers, mwh 2014-01-17 Michael Hudson-Doyle PR target/59799 * config/aarch64/aarch64.c (aarch64_pass_by_reference): The rules for passing arrays in registers are the same as

Re: [gofrontend-dev] libgo patch committed: Fix 32-bit memory allocation

2014-01-09 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > This patch to libgo fixes memory allocation on 32-bit systems when a lot > of memory has been allocated. The problem is described in this patch to > the master repository: https://codereview.appspot.com/49460043 . Here's a patch for the 4.8 branch if you are interest

Re: [gofrontend-dev] Go patch committed: Implement method values in reflect package

2013-12-12 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > On Thu, Dec 12, 2013 at 12:21 AM, Michael Hudson-Doyle > wrote: >> Ian Lance Taylor writes: >> >>> This patch to the Go frontend and libgo implements method values in the >>> reflect package. Working with method values and refle

Re: [gofrontend-dev] Go patch committed: Implement method values in reflect package

2013-12-12 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > This patch to the Go frontend and libgo implements method values in the > reflect package. Working with method values and reflect now works > correctly, at least on x86. Can you give me a test case? I can try it on a few other architectures tomorrow. Cheers, mwh >

Re: [patch] introduce aarch64 as a Go architecture

2013-12-01 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > I've gotten a patch from Michael Hudson-Doyle to set GOARCH to arm64 > on an Aarch64 system (https://codereview.appspot.com/34830045/). Haha, go us. > I've gotten a patch from Matthias Klose to set GOARCH to aarch64 on > such a system > (

backport fix for go hash function names to 4.8

2013-11-27 Thread Michael Hudson-Doyle
Hi, This patch brings the recent fix for the generated hash functions of types that are aliases for structures containing unexported fields to the 4.8 branch. Cheers, mwh diff --git a/gcc/go/gofrontend/types.cc b/gcc/go/gofrontend/types.cc index 59247d6..36383de 100644 --- a/gcc/go/gofrontend/ty

Backport reflect.Call fixes to 4.8 branch

2013-11-27 Thread Michael Hudson-Doyle
This patch brings the recent fix for calling a function or method that takes or returns an empty struct via reflection to the 4.8 branch. Cheers, mwh diff --git a/libgo/go/reflect/all_test.go b/libgo/go/reflect/all_test.go index 526f09b..eecc459 100644 --- a/libgo/go/reflect/all_test.go +++ b/lib

Backport syslist.go fixes to 4.8

2013-11-27 Thread Michael Hudson-Doyle
Hi, Recently, build.goosList and build.goarchList got fixed in mainline to be sensible, hard-coded, lists rather than odd autogenerated lists. This patch updates the 4.8 branch to match. Cheers, mwh diff --git a/libgo/Makefile.am b/libgo/Makefile.am index 957f23c..199b444 100644 --- a/libgo/Make

Re: [gofrontend-dev] Moved gccgo branch to mainline

2013-11-06 Thread Michael Hudson-Doyle
Ian Lance Taylor writes: > I removed the gccgo branch based on the GCC 4.8 branch, and then > recreated it as a copy of mainline. Future changes to the gccgo > branch will be merged from mainline. This is probably a silly question, but presuamably bug fixes to the 4.8 gccgo will continue to lan

[RESEND] Enable building of libatomic on AArch64

2013-10-17 Thread Michael Hudson-Doyle
Resending as the previous attempt went missing... 2013-10-04 Michael Hudson-Doyle * libatomic/configure.tgt (aarch64*): Remove code preventing build. * gcc/testsuite/lib/target-supports.exp (check_effective_target_sync_long_long): AArch64

Re: Enable building of libatomic on AArch64

2013-10-17 Thread Michael Hudson-Doyle
Ping? Michael Hudson-Doyle writes: > Marcus Shawcroft writes: > >> On 3 October 2013 23:43, Michael Hudson-Doyle >> wrote: >>> Hi, >>> >>> As libatomic builds for and the tests pass on AArch64 (built on x86_64 >>> but tested on

Enable building of libatomic on AArch64

2013-10-03 Thread Michael Hudson-Doyle
time posting to this list, let me know if I'm doing it wrong) 2013-10-04 Michael Hudson-Doyle * configure.tgt: Add AArch64 support. >From c01bc2acde08f21f23465dfd0d4d0e88adc6e214 Mon Sep 17 00:00:00 2001 From: Michael Hudson-Doyle Date: Thu, 12 Sep 2013 16:18:00 +1200