Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-03-11 Thread Marc Nieper-Wißkirchen
Hi Jeff and David, any news on this fix? Thanks, Marc Am Mo., 31. Jan. 2022 um 12:42 Uhr schrieb Marc Nieper-Wißkirchen : > > Attached to this email is the patch updated to the recent renaming from *.c > to *.cc. > > > Am So., 23. Jan. 2022 um 14:18 Uhr schrieb Marc

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-31 Thread Marc Nieper-Wißkirchen
Attached to this email is the patch updated to the recent renaming from *.c to *.cc. Am So., 23. Jan. 2022 um 14:18 Uhr schrieb Marc Nieper-Wißkirchen < m...@nieper-wisskirchen.de>: > Am Sa., 15. Jan. 2022 um 14:56 Uhr schrieb Marc Nieper-Wißkirchen > : > > > > Jeff, Dav

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-23 Thread Marc Nieper-Wißkirchen
Am Sa., 15. Jan. 2022 um 14:56 Uhr schrieb Marc Nieper-Wißkirchen : > > Jeff, David, do you need any more input from my side? > > -- Marc > > Am Sa., 8. Jan. 2022 um 17:32 Uhr schrieb Jeff Law : > > > > > > > > On 1/6/2022 6:53 AM, David Malcolm via Gcc-

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-15 Thread Marc Nieper-Wißkirchen
Jeff, David, do you need any more input from my side? -- Marc Am Sa., 8. Jan. 2022 um 17:32 Uhr schrieb Jeff Law : > > > > On 1/6/2022 6:53 AM, David Malcolm via Gcc-patches wrote: > > On Sun, 2021-12-19 at 22:30 +0100, Marc Nieper-Wißkirchen wrote: > >> This patch

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-08 Thread Marc Nieper-Wißkirchen
Thanks for replying so quickly! Am Do., 6. Jan. 2022 um 14:53 Uhr schrieb David Malcolm : [...] > Thanks for the patch. > > It looks correct to me, given that pass_manager::register_pass_name > does an xstrdup and puts the result in the map. > > That said: > - I'm not officially a reviewer for t

Re: [PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2022-01-08 Thread Marc Nieper-Wißkirchen
Am Do., 6. Jan. 2022 um 14:57 Uhr schrieb David Malcolm via Jit : > [...snip...] > > > > > > diff --git a/gcc/passes.c b/gcc/passes.c > > > index 4bea6ae5b6a..0c70ece5321 100644 > > > --- a/gcc/passes.c > > > +++ b/gcc/passes.c > > [...snip...] > > > > @@ -1943,7 +1944,7 @@ pass_manager::dump_prof

[PATCH] gcc: pass-manager: Fix memory leak. [PR jit/63854]

2021-12-19 Thread Marc Nieper-Wißkirchen
This patch fixes a memory leak in the pass manager. In the existing code, the m_name_to_pass_map is allocated in pass_manager::register_pass_name, but never deallocated. This is fixed by adding a deletion in pass_manager::~pass_manager. Moreover the string keys in m_name_to_pass_map are all dynam

Re: [PATCH] jit: Add support for global rvalue initialization and ctors

2021-12-10 Thread Marc Nieper-Wißkirchen via Gcc-patches
Hi, I would favor adding support for this kind of initialization to libgccjit. Does it also support the libgccjit equivalent of the following C module, which contains forward references in the struct initializers? struct bar bar; struct foo foo; struct foo { struct bar *b; }; struct bar {

Re: [PATCH][jit] Add thread-local globals to the libgccjit frontend

2019-01-08 Thread Marc Nieper-Wißkirchen
[...] 2019-01-08 Marc Nieper-Wißkirchen * docs/topics/compatibility.rst: Add LIBGCCJIT_ABI_11. * docs/topics/expressions.rst (Global variables): Add documentation of gcc_jit_lvalue_set_bool_thread_local. * docs/_build/texinfo/libgccjit.texi: Regenerate

Re: [PATCH][jit] Add thread-local globals to the libgccjit frontend

2019-01-08 Thread Marc Nieper-Wißkirchen
is my first patch I would like to contribute to GCC. You should have received a private email to get the legal matters done. ChangeLog 2019-01-05 Marc Nieper-Wißkirchen * docs/topics/compatibility.rst: Add LIBGCCJIT_ABI_11. * docs/topics/expressions.rst (Global variables

[PATCH][jit] Add thread-local globals to the libgccjit frontend

2019-01-05 Thread Marc Nieper-Wißkirchen
he GENERIC tree corresponding to the global. ChangeLog 2019-01-05 Marc Nieper-Wißkirchen * docs/topics/compatibility.rst: Add LIBGCCJIT_ABI_11. * docs/topics/expressions.rst (Global variables): Add documentation of gcc_jit_lvalue_set_bool_thread_local. * docs