> I checked it in for him with a small change in document. It
> should be `|' instead of '@|'.
Thanks a lot!
--
Maxim Kuznetsov
2013/4/29 Jakub Jelinek :
> Also, why are you handling just %{ and %}, and
> not also %| ? I mean, if you want to print say {|} into assembly for both
> dialects, don't you need:
> asm ("{dialect1%{%|%}|%{%|%}dialect2}");
> or similar? If you use just | instead of %|, it would be handled as
> sep
Jakub, Richard, thank you for your feedback!
> I wonder if it %{ and %} shouldn't be better handled in final.c
> for all #ifdef ASSEMBLER_DIALECT targets, rather than just for one specific.
I moved %{ and %} cases to output_asm_insn in final.c
> Also:
> *(p + 1)
> should be better written as p[1
>> For '}' case, can you simply just add
>>
>> /* Skip over any character after a percent sign. */
>> if (*p == '%' && *(p + 1))
>> {
>> p += 2;
>> continue;
>> }
>>
>> without changing the do-while loop to the while loop?
>
> Loop condition (*p++ != '}') must be moved to loop body for it to n
Ping
2013/4/3 Maksim Kuznetsov :
> Thank you for your feedback!
>
>> For '}' case, can you simply just add
>>
>> /* Skip over any character after a percent sign. */
>> if (*p == '%' && *(p + 1))
>> {
>> p += 2;
>>
Thank you for your feedback!
> For '}' case, can you simply just add
>
> /* Skip over any character after a percent sign. */
> if (*p == '%' && *(p + 1))
> {
> p += 2;
> continue;
> }
>
> without changing the do-while loop to the while loop?
Loop condition (*p++ != '}') must be moved to loop
> Thanks for the explanation, now I understand it. I fixed the patch
> according to your remarks. I removed %| support since we don't
> actually need it in i386 right now, it was added for the purpose of
> possible generalization.
>
> Updated patch is attached.
Ping
--
Maxim Kuznetsov
curly_bra
Ping.
Could someone please have a look?
--
Maxim Kuznetsov
> Thanks for the explanation, now I understand it. I fixed the patch
> according to your remarks. I removed %| support since we don't
> actually need it in i386 right now, it was added for the purpose of
> possible generalization.
>
> Upd
> There are two parts to it: the actual print_operand thing, that I say
> should be target-specific, since some targets already use those characters
> to mean different things; and of course the assembler dialects code needs
> to be fixed to not choke on escaped versions of the characters it is
> l
> There are four in-tree target architectures that already use %|. I think
> it would be better if you made these new escapes target-specific.
Escaped curly braces cannot be target-specific since
do_assembler_dialects() in final.c ignores any % and considers '{' and
'}' to be alternative delimete
10 matches
Mail list logo
