First, I think it is more readable with '== 1' instead of '<= 1' as == 0
cannot
occur. Second, I think that requires a comment why > 1 is ignored here.
iterator_count[i] can be 0 if there are maps with iterators present, but
the i'th map happens to not be using one (which
kFrom 5b76d307bc4328c9ee580cfadccd3225837dce37 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 10 Jul 2025 17:19:28 +0100
Subject: [PATCH] openmp, fortran: Fix ICE when the procedure name cannot be
found in declare variant directives [PR104428]
The result of searching for the procedure
-one, then freed after
the target code. allocate_omp_iterator_elems and free_omp_iterator_elems
are modified so that they work on a per-iterator basis rather than
per-clause.From a9236e9350dbe1c51d92c8301118fe7f36a371db Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Sat, 3 May 2025 21:10
This patch adds macros to refer to the fields of OpenMP iterators by
name rather than by index, as the number of items has increased to 10
and referring to them by index has become error-prone.From e09f6cba88e321e9da50e002b3e74ff36cf19865 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date
8c6a4e6536125d2c18a0a5016764b31fbdd23fd2 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Sat, 3 May 2025 21:03:33 +
Subject: [PATCH 10/11] openmp, fortran: Add iterator support for Fortran
deep-mapping of allocatables
gcc/fortran/
* trans-openmp.cc (gfc_omp_deep_mapping_map): Remove
element array after the loop has already been built, and
updates the clause iterator to point to the new array instead. This is
called each time a new clauses is created from an existing one.From c3444e54de724a7787701f39bd1f42c43e93bd3e Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 11
-end, the middle-end will
treat it the same as if the iterators were specified explicitly.
From 46a70c58505f6c0ee6af57997de81da94f0faa11 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 13 Jan 2025 13:08:07 +
Subject: [PATCH 09/11] openmp: Add support for using custom mappers with
iterators.From 14469e4793899babf038afaac90b9f7721922573 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Sat, 3 May 2025 20:36:21 +
Subject: [PATCH 04/11] openmp, fortran: Add support for map iterators in
OpenMP target construct (Fortran)
This adds support for iterators in map clauses within
607ceefb93136fd14471d0a9383464776228f074 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 12 Dec 2024 21:22:20 +
Subject: [PATCH 06/11] openmp: Add support for non-constant iterator
parameters in map, to and from clauses
This patch enables support for using non-constant expressions when specifying
reporting when dealing with extra modifiers.From 2211e8cebe99d693c87ef80979ff0426131f44d6 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:56:08 +
Subject: [PATCH 05/11] openmp, fortran: Add support for iterators in OpenMP
'target update' constructs (Fort
basically unchanged from v4.From 19dc39bbacb5d630df6dae78beb6871cbab7fcf8 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:51:34 +
Subject: [PATCH 03/11] openmp: Add support for iterators in 'target update'
clauses (C/C++)
This adds support for iterators i
largely unchanged from v4.
gimple_omp_target_iterator_loops_ptr now takes a gimple* rather than a
gomp_target* to avoid a couple of as_a casts in various places.From d3ad9940694b33a5428dbd5e52f46ec4da799419 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Sat, 3 May 2025 20:24:26 +
unchanged from the previous version.From dea003f55ae44822bf4db945966d105cb926f34d Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:49:12 +
Subject: [PATCH 01/11] openmp: Refactor handling of iterators
Move code to calculate the iteration size and to generate the
This is yet another revision of the patch series posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2024-November/670333.html
and incorporates the non-constant iterator bounds support posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2024-December/671630.html
Compared to the previous patch s
:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 11 Jun 2025 12:46:44 +0100
Subject: [PATCH] openmp: Allocate memory for private/firstprivate clauses as
directed by allocate clauses in target constructs [PR113436]
This patch generates calls to GOMP_alloc to allocate memory for firstprivate
and
I committed this patch to add my gcc username to MAINTAINERS in
accordance with the new format.
Kwok Yeung
From 45d82eb7b7389a7c668db29bf2d5ec4ed2bc4da0 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 28 Apr 2025 19:27:59 +0100
Subject: [PATCH] MAINTAINERS: Add my gcc.gnu.org
I have committed the following patches onto the devel/omp/gcc-14 OpenMP
development branch to implement support for iterators in mapping clauses
and in to/from clauses in 'target update' constructs:
76e5b71adb8 openmp: Refactor handling of iterators
28f09913235 openmp: Add support for iterators
moved around and removed at
that point.
KwokFrom d277a9539ad78fae9eb97a156949320623060a0d Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 12 Dec 2024 21:22:20 +
Subject: [PATCH] openmp: Add support for non-constant iterator parameters in
map, to and from clauses
This patch
(c)), while map clauses store it in
OMP_CLAUSE_ITERATORS (c).From a25a986ae707395b3bf31a7d3f08e0d04554aed3 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:49:12 +
Subject: [PATCH 1/5] openmp: Refactor handling of iterators
Move code to calculate the iteration size
This is a revised version of the patch series posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2024-October/664541.html
The previous version performed the expansion of the iterators into loops
at the omp-lowering stage, but that meant that the Gimplification of the
clauses with iterators w
This part of the patch is unchanged.From e761481eb3d9b322267b3a22773caa0f0270275f Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:56:08 +
Subject: [PATCH 5/5] openmp, fortran: Add support for iterators in OpenMP
'target update' constructs (Fortran)
When constructing an iterator with a subset of the original, the
original BLOCK_SUBBLOCKS is moved to the first new iterator. Otherwise
this part of the patchset is unchanged.From f40b72c1e750ec948ebf3ffd92da107679d0b702 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21
The target update clause decls and sizes are now Gimplified in
gimplify_scan_omp_clauses. The rest of the patch is mostly unchanged.From 79159cbf815d458114e7c6da8dbb138ce24b7df1 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:51:34 +
Subject: [PATCH 3/5] openmp
entry if not present. The variables in
the clause are then remapped to those in the new iterator.From ceb003984d80067ec1b92f70ac5bfe4ce2072d81 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 27 Nov 2024 21:49:32 +
Subject: [PATCH 2/5] openmp: Add support for iterators in map clauses (C
This patch adds parsing and translation of the 'to' and 'from' clauses
for the 'target update' construct in Fortran.From da8ab0cb38d2bc347cf902ec417b0397c28e24e2 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 4 Oct 2024 15:16:38 +0100
Subject: [P
in the context of
each iteration of the iterator).From a24aa032c2e23577d4fbc61df6da79345bae8292 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 4 Oct 2024 15:16:29 +0100
Subject: [PATCH 4/5] openmp, fortran: Add support for map iterators in OpenMP
target construct (Fortran)
Thi
This patch extends the previous patch to cover to/from clauses in
'target update'.From 1c8bf84ec99fe2fd371e345f012eb0d84a923153 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 4 Oct 2024 15:16:21 +0100
Subject: [PATCH 3/5] openmp: Add support for iterators in 'target u
, otherwise it will get out of
sync with the expected layout and the wrong variables will be picked up
by the target function.From 50557e513ca534ba32f50d1b056a07a6f671 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 4 Oct 2024 15:16:12 +0100
Subject: [PATCH 2/5] openmp: Add support
ator clause with a macro OMP_ITERATOR_DECL_P,
as it needs to be done frequently.From 34bf780b1e0395028ecdacfa1385238a8da13be6 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 4 Oct 2024 15:15:42 +0100
Subject: [PATCH 1/5] openmp: Refactor handling of iterators
Move code to calculate the
This is a further improved patch series to that posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662138.html
The main change is that the expansion of the iterators is pushed back
further to the omp-lowering stage. This is because the recently
committed deep-mapping support (a
This patch adds parsing and translation of the 'to' and 'from' clauses
for the 'target update' construct in Fortran.From cfb6b76da5bba038d854d510a4fd44ddf4fa8f1f Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 2 Sep 2024 19:34:29 +0100
Subject: [P
or the target, only the
address associated with the first map generated by an iterator is set
(as only a single slot in the data structure is allocated for each
iterator map).From f7cdf555e9d5c49b455a364a1eef2123c7bb76d1 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 2 Sep 2024 19
This patch extends the previous patch to cover to/from clauses in
'target update'.From c3dfc4a792610530a4ab729c3f250917b828e469 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 2 Sep 2024 19:34:09 +0100
Subject: [PATCH 3/5] openmp: Add support for iterators in 'target u
, inserting them into the list of
mappings at the point where iterator data occurred.From dd65c671dc9f5fb34290938a413c610eb0110ef6 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 2 Sep 2024 19:33:47 +0100
Subject: [PATCH 2/5] openmp: Add support for iterators in map clauses (C/C++)
This adds
ator clause with a macro OMP_ITERATOR_DECL_P,
as it needs to be done frequently.From d2cf47a312d9decc14d0cf37fa57ad358a96743d Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 2 Sep 2024 19:33:08 +0100
Subject: [PATCH 1/5] openmp: Refactor handling of iterators
Move code to calculate the
This is an improved version of the previous series that was posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2024-May/652680.html
Compared to the previous version, this version delays the gimplification
of iterators until the very end of gimplify_adjust_omp_clauses (instead
of doing it in
This patch extends the previous patch to cover to/from clauses in
'target update'.From 99addc124535307b50fbdeb66c4f90bb0cbeb041 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 15 Apr 2024 13:50:22 +0100
Subject: [PATCH 3/3] openmp: Add support for iterators in to/from cla
info array, inserting them into the list of
mappings at the point where iterator data occurred.From b2e8ff46929d5a2781781486ec942b344056d78b Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 12 Mar 2024 22:51:06 +
Subject: [PATCH 2/3] openmp: Add support for iterators in map clauses
erator clause with a macro OMP_ITERATOR_DECL_P,
as it needs to be done frequently.From 0439fce03c2b5fb2802eaf65831e28f548ca074b Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 12 Mar 2024 20:51:38 +
Subject: [PATCH 1/3] openmp: Refactor handling of iterators
Move code to calculate
This series of patches adds support for OpenMP iterators in the 'map'
clause of the 'target' construct (and it's derivatives such as 'target
enter data'), and the 'to' and 'from' constructs of the 'target update'
construct, currently for C and C++ only.
The approach in this patch differs from
Hi,
I have committed this patch to the libgomp documentation to reflect that
indirect calls in offloaded target regions are now supported in C, C++
and Fortran.
KwokFrom b3b3bd250f0a7c22b7d46d3522c8b94c6a35d22a Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 15 Feb 2024 21:22:26
69e0fd Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 5 Feb 2024 20:31:49 +
Subject: [PATCH] openmp, fortran: Add Fortran support for indirect clause on
the declare target directive
2024-02-05 Kwok Cheung Yeung
gcc/fortran/
* dump-parse-tree.cc
f6662a7bc76d400fecb5013ad6d6ab3b00b8a6e7 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 5 Feb 2024 20:31:49 +
Subject: [PATCH] openmp, fortran: Add Fortran support for indirect clause on
the declare target directive
2024-02-05 Kwok Cheung Yeung
gcc/fortran
Can you please akso update the comments to talk about hashtab instead of splay?
Hello
This version has the comments updated and removes a stray 'volatile' in
the #ifdefed out code.
Thanks
KwokFrom 5737298f4f5e5471667b05e207b22c9c91b94ca0 Mon Sep 17 00:00:00 2001
From: Kwok Ch
I have committed this to update my work email address in MAINTAINERS
(but forgot to change my git user.mail first - oops!).
Thanks
Kwok Yeung
From f3fdaa3eecd155dbdc78c1ec9a259dfa4e379ea4 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 29 Jan 2024 16:40:49 +
Subject: [PATCH
ed to Fortran
where appropriate.
Okay for mainline?
Thanks
KwokFrom 545bdb2c8ab9a43e79c7a3a2992bd9edc7d08a6f Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 11 Jan 2024 19:52:53 +
Subject: [PATCH 2/2] openmp, fortran: Add Fortran support for indirect clause
on the declare targe
e reached do
the initialisation. This removes the need for locking during initialisation.
Tested with offloading to NVPTX and GCN with a x86_64 host. Okay for master?
Thanks
KwokFrom 721ec33bec2fddc7ee37e227358e36fec923f8da Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 17 Jan 2024 16
xplicitly list such cases as gcc_unreachable (it might imply
that it can reach the ME, but just not at that particular point?) or not
though.
KwokFrom a56a693a74dd3bee71b1266b09dbd753694ace94 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 3 Jan 2024 14:34:39 +
Subject: [PATC
IDENTIFIER_POINTER (DECL_ASSEMBLER_NAME (decl)));
... maintain separate 'if' branches for 'FUNC_MAP' vs. 'IND_FUNC_MAP', so
that we're able to easily locate those with 'grep', for example.
From 6ae84729940acff598e1a7f49d7b381025082ceb Mon Sep 1
Yes, I believe that is the right fix. The version in
libgomp/config/accel/ should then override the version in libgomp/ for
accelerator targets.
I'll do a quick check that this works as expected and push it ASAP.
Sorry for breaking the build for so many targets!
Kwok
On 07/11/2023 9:51 pm,
ending successful testing (still in progress)?
Thanks
Kwok
Thanks,
Tobias
-
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201,
80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer:
Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft:
r mainline?
Thanks
KwokFrom 46129c254990a9fff4b6d8512f04ad8fa7d61f0e Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Sun, 8 Oct 2023 13:50:25 +0100
Subject: [PATCH] openmp: Add support for the 'indirect' clause in C/C++
This adds support for the 'indirect' clause in the 'declare target'
directive
Hello
I've made the suggested changes. Should I hold off on committing this
until GCC 13 has been branched off?
Kwok
On 01/03/2023 10:01 am, Andrew Stubbs wrote:
On 28/02/2023 23:01, Kwok Cheung Yeung wrote:
Hello
This patch implements the TARGET_VECTORIZE_BUILTIN_VECTORIZED_FUN
st for now - it is still useful to check that calls to
the correct functions are being made. The runtime correctness is still
covered by the libgomp test.
Okay for trunk?
Thanks
Kwok
From 69d13dc898ff7c70e80299a92dc895a89a9e679b Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 28 F
- The Fortran parse tree dump now shows clauses with 'present' applied.
- The reordering of OpenMP clauses has been moved to
gimplify_scan_omp_clauses, where the other clause reordering rules are
applied.
Thanks
KwokFrom 24b6225578bb08bbd745d6ec653aab60802dd220 Mon Sep 17 00:00:00 2001
Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 14 Feb 2023 21:24:19 +
Subject: [PATCH] openmp: Add support for 'present' modifier in the Fortran
parse tree dump
2023-02-14 Kwok Cheung Yeung
gcc/fortran/
* dump-parse-tree.cc (show_omp_namelist): Display
Hello
I've ported my patch for supporting the OpenMP 5.1 'present' modifier
and committed it to the devel/omp/gcc-12 development branch:
229b705862c openmp: Add support for the 'present' modifier
Tested with offloading on amdgcn and nvptx.
Kwok
ses.
Bootstrapped on x86-64, no regressions in GCC testsuite, libgomp tested
with x86-64 (no offloading), AMD GCN and NVPTX offloading. This is too
late for GCC 13 now, but will this be okay for GCC 14?
Thanks
KwokFrom ba9368f88514a27f374d84e53e36ce36fa9ac5bc Mon Sep 17 00:00:00 2001
From: Kwo
So this is the OG12-specific part (including metadirective and dynamic
context selectors) of the previous patch.
Once https://gcc.gnu.org/r13-4446-ge41b243302e996 is backported, is it
OK for OG12?
Looks good to me, thanks!
Kwok
Hello PA,
--- libgomp/config/gcn/selector.c
+++ libgomp/config/gcn/selector.c
@@ -36,7 +36,7 @@ GOMP_evaluate_current_device (const char *kind, const char
*arch,
if (kind && strcmp (kind, "gpu") != 0)
return false;
- if (arch && strcmp (arch, "gcn") != 0)
+ if (arch && (strcmp (arc
Hello
These additional patches were pushed onto the devel/omp/gcc-12 branch to
fix various issues with the SIMD math library:
ecf1603b7ad amdgcn: Fix expansion of GCN_BUILTIN_LDEXPV builtin
6c40e3f5daa amdgcn: Various fixes for SIMD math library
8e6c5b18e10 amdgcn: Fixed intermittent failure i
2001
From: Kwok Cheung Yeung
Date: Tue, 8 Nov 2022 14:38:23 +
Subject: [PATCH] amdgcn: Fix expansion of GCN_BUILTIN_LDEXPV builtin
2022-11-08 Kwok Cheung Yeung
gcc/
* config/gcn/gcn.cc (gcn_expand_builtin_1): Expand first argument
of GCN_BUILTIN_LDEXPV to V64DFmode
37f49b204d501327d0867b3e8a3f01b9445fb9bd Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 8 Nov 2022 11:59:58 +
Subject: [PATCH] amdgcn: Add builtins for vectorized native versions of abs,
floorf and floor
2022-11-08 Kwok Cheung Yeung
gcc/
* config/gcn/gcn
kFrom c0e74e01743cd3a3e0dcb2a071396e3a5751ff4c Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 3 Nov 2022 17:19:11 +
Subject: [PATCH] amdgcn: Fix instruction generation for exp2 and log2
operations
The GCN instructions for the exp2 and log2 operations are v_exp_* and v
Hello
I have committed the following patches onto the devel/omp/gcc-12
development branch:
863579c4e30 amdgcn: Enable SIMD vectorization of math functions
bd9a6106b95 amdgcn: Add SIMD versions of math routines to libgcc
d3a2a1cc424 amdgcn: Add builtins for vector floor/floorf
a3c04a367a9 amdgc
7 00:00:00 2001
From: Kwok Cheung Yeung
Date: Thu, 8 Sep 2022 17:37:26 +
Subject: [PATCH] amdgcn: Add support for additional natively supported
floating-point operations
This adds support for the following natively supported floating-point
operations, in scalar and vectorized modes:
floor,
(hsaco_attr_type: ... this.)
+ * config/gcn/mkoffload.c (SET_XNACK_ANY): New macro.
+ (TEST_XNACK): Delete.
+ (TEST_XNACK_ANY): New macro.
+ (TEST_XNACK_ON): New macro.
+ (main): Support the new -mxnack=on/off/any syntax.
+
2022-06-30 Kwok Cheung Yeung
ompatible with the "
+ "selected %<-foffload-memory%> option");
flag_offload_memory = OFFLOAD_MEMORY_UNIFIED;
}
else if (!strcmp (p, "dynamic_allocators"))
--
2.25.1
From e9ee746093bd989c33685e3197c75b
previous devel/omp/gcc-11
branch now joins the list of inactive OMP branches.
KwokFrom 0695e5e969eba730e517a6adbdf38b8774f89437 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 29 Jun 2022 22:32:39 +0100
Subject: [PATCH] Document devel/omp/gcc-12 branch
Also moves the old devel/omp/gcc-11
bly be treated separatedly.
I don’t know how difficult the bullet 2 above would be, but bullet 1 and
3 seem quite doable.From 3ed6eb1e38ad2a25c6eca18f9ff4d05d3f227db3 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 2 Mar 2022 17:09:45 +
Subject: [PATCH] openmp, fortran: Check that
On 28/02/2022 5:37 pm, Jakub Jelinek wrote:
On Mon, Feb 28, 2022 at 06:33:15PM +0100, Mikael Morin wrote:
It is true that the spots I saw in fortran/openmp.cc that test rank look
like:
if (!gfc_resolve_expr (el->expr)
|| el->expr->ts.type != BT_INTEGER || el->expr->rank !
On 28/02/2022 2:07 pm, Jakub Jelinek wrote:
On Mon, Feb 28, 2022 at 02:01:03PM +, Kwok Cheung Yeung wrote:
diff --git a/gcc/fortran/openmp.cc b/gcc/fortran/openmp.cc
index 19142c4d8d0..50a1c476009 100644
--- a/gcc/fortran/openmp.cc
+++ b/gcc/fortran/openmp.cc
@@ -531,9 +531,10
event handle during
parsing if it is any type of array, thereby preventing the situation
leading to an ICE in the first place.
Okay for trunk?
Thanks
KwokFrom 8ed3b8bd793298f94bdefbdff32f91eaea1a9d70 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 28 Feb 2022 12:34:22 +
Subject
This patch has been committed to the devel/omp/gcc-11 development branch:
249df772b70f7b9f50f68030d4ea9c25624cc578 openmp: Improve handling of
nested OpenMP metadirectives in C and C++
Kwok
rectives.
KwokFrom a9e4936b8476b97f11bb81b416ef3d28fa60cd37 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 18 Feb 2022 19:00:57 +
Subject: [PATCH] openmp: Improve handling of nested OpenMP metadirectives in C
and C++
This patch fixes a misparsing issue when encountering code
Hello
I have backported and committed the recent two fixes for Fortran
metadirective handling onto the devel/omp/gcc-11 development branch:
38ed9d83b893df0bbd098c7b44dbbeb56ed7dd1c openmp: Eliminate non-matching
metadirective variants early in Fortran front-end
(https://gcc.gnu.org/pipermai
adirective (i.e. just '!$omp
metadirective' with nothing else) is fixed.
Thanks
KwokFrom 153b8dbd19cf90b1869be7f409d55d1ab5ba81d5 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 11 Feb 2022 15:42:50 +
Subject: [PATCH 2/2] openmp: More Fortran front-end fixes for metadir
ost metadirective state to that
of 'program P' in order to find the proper end type, and not just one
level as it currently does.
Thanks
KwokFrom 5a7b109a014422a5b43e43669df1dc0d59e830cf Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Fri, 11 Feb 2022 11:20:18 +
Subject: [PA
because the expected wording of the error
message has changed. This fix is already in the version of the patch
posted at:
https://gcc.gnu.org/pipermail/gcc-patches/2022-January/589191.html
KwokFrom 23dd64c4715b2df2181aaf995e3040d54edba129 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon,
Hello
I have backported and committed the patch 'openmp: Add warning when
functions containing metadirectives with 'construct={target}' called
directly' to the devel/omp/gcc-11 development branch:
d6d82af7918 openmp: Add warning when functions containing metadirectives
with 'construct={targe
irective patches are done)?
Thanks
Kwok
On 26/07/2021 10:23 pm, Jakub Jelinek wrote:
On Mon, Jul 26, 2021 at 10:19:35PM +0100, Kwok Cheung Yeung wrote:
Yes, that is a target variant, but I'm pretty sure we've decided that
the target construct added for declare target is actual
Hello
Just noticed a bug in the ISA checking in the nvptx plugin - the minor
version should only be compared if the major version is equal, otherwise
it would reject an isa of sm_35 if the card is capable of supporting
sm_52, for example. This patch fixes the issue.
Thanks
Kwokdiff --git a/
Hello
I have backported and committed my metadirective patches onto the
current OpenMP development branch (devel/omp/gcc-11). These are:
f464df13a44b9814341659be631f051377a2ce25 openmp: Add C support for
parsing metadirectives
a238b6934b62ce3e8342047e41840c804d83b59d openmp: Add middle-end su
GCC 12 is released)?
Thanks
KwokFrom 2d2f00947783e1ecdf54943d9c499015ce61d267 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Wed, 24 Nov 2021 02:51:28 -0800
Subject: [PATCH] openmp: Add support for 'target_device' context selector set
2022-01-18 Kwok Cheung Yeung
gc
n't matter much, as GCC readily eliminates the resulting
'if ()' statements via constant folding.
These fixes should be merged into the original metadirective patches.
Thanks
KwokFrom 77f419aef8a608440789b0ebb4a08f11d69f00e2 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date:
This adds testcases for metadirectives.
KwokFrom d3f80b603298fb2f3501a28b888acfdbc02a64e7 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Tue, 7 Dec 2021 11:25:33 +
Subject: [PATCH 7/7] openmp: Add testcases for metadirectives
2021-12-10 Kwok Cheung Yeung
gcc/testsuite
n internal
implementation detail not visible to end users.
KwokFrom eed8a06fca397edd5fb451f08c8b1a6f7d67951a Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 6 Dec 2021 22:59:36 +
Subject: [PATCH 6/7] openmp, fortran: Add Fortran support for parsing
metadirectives
This adds s
This patch adds metadirective parsing support to the C++ parser. This is
basically just a straight port of the C code to the C++ front end.
KwokFrom e9bb138d4c3f560e48e408facce2361533685a98 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 6 Dec 2021 22:58:01 +
Subject: [PATCH 5
85826d05e029571fd003dd629aa04ce3e17d9c71 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 6 Dec 2021 22:56:07 +
Subject: [PATCH 4/7] openmp: Add support for streaming metadirectives and
resolving them after LTO
This patch adds support for streaming metadirective Gimple statements during
65ee7342256db3c81cc6741ce2c96e36dd4a9ca6 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 6 Dec 2021 22:49:23 +
Subject: [PATCH 3/7] openmp: Add support for resolving metadirectives during
parsing and Gimplification
This adds support for resolving metadirectives according to the OpenMP 5.1
to pass through the middle-end. GCC will emit an
ICE if it makes it through to the back-end though, as the metadirective
is supposed to be eliminated before it gets that far.
KwokFrom 1a2fcbb2191fd1dd694ea5730e54fab19d6465b4 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 6 Dec 202
x27;end ' form (apart from the
'nothing' directive), and in C/C++, the only directive that we support
with an end form is 'declare target', which we currently forbid since it
is declarative.
KwokFrom dc88559b0295104472a0cbf79de03b0549bd35f5 Mon Sep 17 00:00:00 2001
From:
Hello
This is my current patchset for OpenMP metadirectives support. It aims
to implement the specification from OpenMP 5.1, with dynamic selector
support (though currently only the dynamic user selector set is
supported), and supports the C, C++ and Fortran front ends.
The patch has been bo
Hello
It has been several months since I posted my WIP patch, and my current
patch set (which I will post separately) has evolved considerably since
then. I have added C++ and Fortran support, as well as dynamic selectors
from the OpenMP 5.1 spec (currently only the 'user={condition()}'
selec
From 38733234024697d2144613c4a992e970f40afad8 Mon Sep 17 00:00:00 2001
From: Kwok Cheung Yeung
Date: Mon, 18 Oct 2021 13:56:59 -0700
Subject: [PATCH] openmp: Add additional tests for declare variant in Fortran
Add tests to check that explicitly specifying the containing procedure as the
base name for declare va
From: Kwok Cheung Yeung
Date: Thu, 14 Oct 2021 09:29:13 -0700
Subject: [PATCH] openmp: Mark declare variant directive in documentation as
supported in Fortran
2021-10-14 Kwok Cheung Yeung
libgomp/
* libgomp.texi (OpenMP 5.0): Update entry for declare variant
directive.
--
On 26/07/2021 10:23 pm, Jakub Jelinek wrote:
On Mon, Jul 26, 2021 at 10:19:35PM +0100, Kwok Cheung Yeung wrote:
In that comment, Deepak says:
So, we decided to keep the target trait static, requiring that the declare
target directive must be explicit and that the function version must be
Hello
On 26/07/2021 8:56 pm, Jakub Jelinek wrote:
On Mon, Jul 26, 2021 at 08:28:16PM +0100, Kwok Cheung Yeung wrote:
In Section 1.2.2 of the OpenMP TR10 spec, 'target variant' is defined as:
A version of a device routine that can only be executed as part of a target
region.
Yes,
Hello
Thanks for your reply.
On 26/07/2021 3:29 pm, Jakub Jelinek wrote:
On Fri, Jul 09, 2021 at 12:16:15PM +0100, Kwok Cheung Yeung wrote:
3) In the OpenMP examples (version 5.0.1), section 9.7, the example
metadirective.3.c does not work as expected.
#pragma omp declare target
void
Ping? Does anyone have any opinions on how this issue should be resolved?
On 09/07/2021 12:16 pm, Kwok Cheung Yeung wrote:
3) In the OpenMP examples (version 5.0.1), section 9.7, the example
metadirective.3.c does not work as expected.
#pragma omp declare target
void exp_pi_diff(double *d
1 - 100 of 241 matches
Mail list logo
