r this fix and we are using this.
>
> I tried to implement a workaround to match lost discriminator in cases
> this is uniquely deterined, but it is not so easy to do.
> My plan is to figure out how to upstream it and then drop the lost
> discriminator workaround from match.
>
> Do you see warnings with -Wauto-profile?
Adding -Wauto-profile gets it to work. Let me look into this.
Thanks,
Kugan
stream file names only for public linkage symbols
> 3) instead of streaming filename of file containing the symbol
>stream filename of the corresponding translation unit.
>
> I would say that the advantage of profile id is probably shorter gcov
> files, advantage of streaming filename:symbol_name pairs is that the
> profile info is easier to read. What do you think?
Thanks for the clarification. Since LLVM has been using __uniq suffix and
this is optional (controlled by flag), IMO we could go with your patch.
Thanks,
Kugan
>
> Honza
profile::offline_external_functions()
../../gcc/gcc/auto-profile.cc:2032
0x22de0f3 execute
../../gcc/gcc/auto-profile.cc:4066
Here stmt is D.293641 = OBJ_TYPE_REF(_7;(const struct GEdge)from->57B) (from);
and set_call_location has call_location_ != UNKNOWN_LOCATION
Thanks,
Kugan
lvm.org/D73307
>
> All non-public functions gets theis symbol renamed from
> .__uniq.
How is __uniq. added to static symbols
in the profile?
Thanks,
Kugan
> Decadic is used since demanglers special case numerical suffixes.
> In addition debug info of all functions get DW_A
some lost AFDO profiles with LTO”
which introduces pass_ipa_auto_profile_offline. I dont think it does offline
functions !afdo_callsite_hot_enough_for_early_inline. However, it should be
easier now as the early_inline is moved out of auto-profile.
Thanks,
Kugan
e current master and when I try running as you
mentioned, it looks like PGO counters are not read. I am seeing
something like (fdo is always zero):
update_stmt.part.0/2212 bb 0 (cold) afdo 3400152 (guessed) scaled 0
(guessed) fdo 0 (precise) diff 0, +0.00%
update_stmt.part.0/2212 bb 4 (cold) afdo 3400
iles so we can spots bugs without having to debug performance
> regressions, but I am still travelling so I am not sure how soon I can
> look into implementing this.
We can look into this. We do compare manually the IR dumps from both and it is
not ideal.
What we should do is an additional (optional) pass that runs after auto-profile
to compare the annotations
using the profile-use. We will have to filter out any functions/path that runs
less than a threshold to reduce noise.
Functions that are fully inlined are also not having any profile.
Thanks,
Kugan
>
> Honza
sP8hash_mapI16rdwr_access_hash11attr_access21simple_hashmap_traitsI19default_hash_traitsIS0_ES1_EEP9tree_node
>> total:212 head:71
>> 2: 71
>> _Z22init_attr_rdwr_indicesP8hash_mapI16rdwr_access_hash11attr_access21simple_hashmap_traitsI19default_hash_traitsIS0_ES1_EEP9tree_node
auto-profile pass in the earlier implementation?
One unrelated question about scaling profiles. We seem to scale-up AFDO with
and_count_scale and scale down local_profile in some other cases. Should we
instead scale up AFDO profile to local_profile scale. Lot of the inlining and
other parameters seem to wo
>
> With part suffixes we also may want to merge specially, since the
> entry_count of the split part does not correspond to entry_count of the
> original function.
>
> I wonder, does partitioned function work with the google tool? I
> remember it had limitations in this respect.
>
Yes, Here a
> Given that this is tail-recursive, I feel like recursion is not necessary here
> and it would be more efficient to have this be a loop instead. The
> implementation looks okay as is, though.
IMO doing this in a loop would have to handle all the above cases and
Number of samples to get to the desrired percentile.
Should we also track the branch probability in GCOV. This should be easy to
calculate from perf profille. This may help disambiguate profile counts.
Thanks,
Kugan
>
> seems like useful info to handle autoFDO 0s more orrectly, so
Hi,
> On 17 Jun 2025, at 4:51 pm, Kugan Vivekanandarajah
> wrote:
>
> External email: Use caution opening links or attachments
>
>
>> On 17 Jun 2025, at 4:18 pm, Dhruv Chawla wrote:
>>
>> On 17/06/25 06:10, Kugan Vivekanandarajah wrote:
>>>
tialized. */
> struct cgraph_edge *new_edge
> - = indirect_edge->make_speculative (direct_call,
> -profile_count::uninitialized ());
> + = indirect_edge->make_speculative
> + (direct_call,
> +
> On 17 Jun 2025, at 4:18 pm, Dhruv Chawla wrote:
>
> On 17/06/25 06:10, Kugan Vivekanandarajah wrote:
>> External email: Use caution opening links or attachments
>> Hi,
>> As discusses earlier, get_original_name is used to match profile binary
>> names to
>
running autoprofiledbootstrap and tree-prof check that
exercises auto-profile pass.
gcc/ChangeLog:
* auto-profile.cc (isAsciiDigit): New.
(get_original_name): Strip suffixes only for compiler generated
names tat happens after auto-profile.
Thanks,
Kugan
0001-AutoFDO-Fix
ay?
>>
>> Splitting out inlining as its own phase also means that it can
>> eventually be handed off to ipa-inline to handle, thus making
>> auto-profile independent of early inline. This will simplify the code a
>> fair bit. Is this a good direction to go in?
>
n sticking to the one
> that gcc/configure* already uses (i.e. the one used for gcc/config/).
>
> It is incovenient that the toplevel doesn't have access to the logic
> used to set that variable though...
>
I changed it to:
+# Special case cpu_type for x86_64 as it shares AU
> On 9 Jun 2025, at 9:43 am, Kugan Vivekanandarajah
> wrote:
>
>
>
> > On 7 Jun 2025, at 3:30 pm, Kugan Vivekanandarajah
> > wrote:
> >
> > Hi,
> >
> >
> > > On 6 Jun 2025, at 4:15 pm, Kugan Vivekanandarajah
> > > wrote
one used for gcc/config/).
>
> It is incovenient that the toplevel doesn't have access to the logic
> used to set that variable though...
I changed it to:
+# Special case cpu_type for x86_64 as it shares AUTO_PROFILE from i386.
+if test "${cpu_type}" = "x86_64" ; then
+ cpu_type="i386"
+fs
Is this ok? Tested on x86_64 and aarch64 linux-gnu.
Thanks,
Kugan
>
> Richard
0001-AutoFDO-Fix-profile-bootstrap-for-x86_64.patch
Description: 0001-AutoFDO-Fix-profile-bootstrap-for-x86_64.patch
Hi Honza,
> On 6 Jun 2025, at 6:34 pm, Jan Hubicka wrote:
>
> External email: Use caution opening links or attachments
>
>
>> Kugan Vivekanandarajah writes:
>>> Add support for autoprofiledbootstrap in aarch64.
>>> This is similar to what is done for
Hi Andrew,
> On 6 Jun 2025, at 8:18 am, Andrew Pinski wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Wed, Jun 4, 2025 at 12:02 AM Kugan Vivekanandarajah
> wrote:
>>
>> This patch introduces a new testcase to verify the mergin
zero, preserve
quality info. */
- else if (count->nonzero_p ()
+ else if (!count->nonzero_p ()
+ || count->quality () == GUESSED_LOCAL
|| count->quality () == GUESSED)
*count = profile_count::zero ().afdo ();
}
Thanks,
Kugan
>
> Honza
>>
>> Thanks,
>> Kugan
:
* auto-profile.cc (autofdo_source_profile::read): Dump message
while merging profile.
* pass_manager.h (get_pass_auto_profile): New.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-prof/clone-merge-1.c: New test.
Is this OK?
Thanks,
Kugan
0001-AutoFDO_v2-Profile-merging-for-clone
roll "Peeled loop 2, 1 times”
I also noticed that some tests are only enabled for x86. I am also seeing:
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/pr66295.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/split-1.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/val-prof-10.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/val-prof-7.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/pr66295.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/split-1.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/val-prof-10.c
./gcc/testsuite/gcc/gcc.sum:UNSUPPORTED: gcc.dg/tree-prof/val-prof-7.c
Thanks,
Kugan
> Honza
elf. Private (static) functions
with the same name also will have the same issue.
Dhruv is working on an RFC for this.
Thanks,
Kugan
>
> Overwritting the data by the last clone is definitely bad, so the patch
> is OK, but we should figure out what happens in the cases above.
>
>
: Enable autofdo tests for aarch64.
Is this OK?
Thanks,
Kugan
0001-AUTOFDO-Enable-autofdo-tests-for-aarch64.patch
Description: 0001-AUTOFDO-Enable-autofdo-tests-for-aarch64.patch
> On 26 May 2025, at 2:47 pm, Kugan Vivekanandarajah
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> > On 26 May 2025, at 2:25 pm, Andrew Pinski wrote:
> >
> > External email: Use caution opening links or attachments
>
10:18.479228 1692721 symbol_map.cc:477] Adding loadable exec
> segment: offset=1000 vaddr=401000
>
> Did someone run SPEC recently? I made auto-FDO spec config and tested
> -Ofast with ipa-icf, ipa-cp-clone and ipa-sra disabled (to get rid of
> the clone merging). I get sort of com
es and only see if afdo
annotations are there.
Any thoughts?
Thanks,
Kugan
>
> Honza
> <0002-AUTOFDO-Merge-profiles-of-clones-before-annotating.patch>
> On 26 May 2025, at 2:25 pm, Andrew Pinski wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, May 20, 2025 at 3:09 AM Kugan Vivekanandarajah
> wrote:
>>
>> Thanks Richard for the review.
>>
>>> On 20 May
Ping?
Thanks,
Kugan
> On 9 May 2025, at 11:55 am, Kugan Vivekanandarajah
> wrote:
>
> ipa-split is not now run for auto-profile. IMO this was an oversight.
> This patch enables it similar to PGO runs.
>
> gcc/ChangeLog:
>
>* ipa-split.cc pass_feedback_spl
Ping?
Thanks,
Kugan
> On 9 May 2025, at 11:51 am, Kugan Vivekanandarajah
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> This patch fixes wrong annotation of profiles when call statement is
> de-duplicated. i.e., when we may have same st
Ping?
Thanks,
Kugan
> On 9 May 2025, at 11:54 am, Kugan Vivekanandarajah
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> This patch add support for merging profiles from multiple clones.
> That is, when optimized binaries have clones suc
Thanks Richard for the review.
> On 20 May 2025, at 2:47 am, Richard Sandiford
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> Kugan Vivekanandarajah writes:
>> diff --git a/Makefile.in b/Makefile.in
>> index b1ed67d3d4f..b5e3e5
> On 16 May 2025, at 12:10 am, Andi Kleen wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Wed, May 14, 2025 at 02:46:15AM +, Kugan Vivekanandarajah wrote:
>> Adding Eugene and Andi to CC as Sam suggested.
>>
>>> On 13 M
Adding Eugene and Andi to CC as Sam suggested.
> On 13 May 2025, at 12:57 am, Richard Sandiford
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> Kugan Vivekanandarajah writes:
>> diff --git a/configure.ac b/configure.ac
>> inde
new regression.
Also successfully done autoprofiledbootstrap with the relevant patch.
Is this OK for trunk?
Thanks,
Kugan
0004-AUTOFDO-AARCH64-Add-support-for-profilebootstrap.patch
Description: 0004-AUTOFDO-AARCH64-Add-support-for-profilebootstrap.patch
.
Regression tested on aarch64-linux-gnu with no new regression.
Also successfully done autoprofiledbootstrap with the relevant patch.
Is this OK for trunk?
Thanks,
Kugan
0002-AUTOFDO-Merge-profiles-of-clones-before-annotating.patch
Description: 0002-AUTOFDO-Merge-profiles-of-clones-before
annotate profile for GIMPLE_CALL stmt
and extract BB counts from edge counts.
Regression tested on aarch64-linux-gnu with no new regression.
Also successfully done autoprofiledbootstrap with the relevant patch.
Is this OK for trunk?
Thanks,
Kugan
0001-AUTOFDO-Fix-annotated-profile-for-de
Hi Richard,
I want to follow up on this and see if you have a fix for this.
Thanks,
Kugan
> On 29 Oct 2024, at 9:41 pm, Richard Sandiford
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> Kugan Vivekanandarajah writes:
>> Hi,
>
Ping?
Thanks,
Kugan
> On 2 Nov 2024, at 7:49 pm, Kugan Vivekanandarajah
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> > On 31 Oct 2024, at 7:29 pm, Jakub Jelinek wrote:
> >
> > External email: Use caution opening links or a
> On 31 Oct 2024, at 7:29 pm, Jakub Jelinek wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Oct 31, 2024 at 08:21:09AM +, Kugan Vivekanandarajah wrote:
>>
>>
>>> On 31 Oct 2024, at 6:18 pm, Jakub Jelinek wrote:
>
hen I
force the loop to unroll for x86. Thus, to keep it simple, moving the test to
gcc.target/aarch64.
Regression tested on aarch64-linux-gnu. Is this OK?
Thanks,
Kugan
0001-testsuite-Fix-bb-slp-77.c.patch
Description: 0001-testsuite-Fix-bb-slp-77.c.patch
> On 31 Oct 2024, at 6:18 pm, Jakub Jelinek wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Oct 29, 2024 at 05:01:40AM +, Kugan Vivekanandarajah wrote:
>> For param_vect_max_version_for_alias_checks of 15, the average code si
Hi Richard,
> On 29 Oct 2024, at 8:33 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Oct 29, 2024 at 9:24 AM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Richard,
>> Thanks for the review.
>>
&
Hi Richard,
Thanks for the review.
> On 28 Oct 2024, at 9:18 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Mon, Oct 28, 2024 at 9:35 AM Kugan Vivekanandarajah
> wrote:
>>
>> Hi,
>>
>> When ifcvt
Hi Richard,
Thanks for the review.
> On 25 Oct 2024, at 8:53 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Fri, Oct 25, 2024 at 12:22 AM Kugan Vivekanandarajah
> wrote:
>>
&g
different
from general dont_vectorize) specifically for loops versioned. BB vectorization
does not need to honour this and still can vectorize.
Bootstrapped and regression tested on aarch64-linux-gnu with no new regressions.
Is this OK?
Thanks,
Kugan
0001-PATCH-Fix-SLP-when-ifcvt-versioned-loop-is
f at teast 11 where as the current
default is 10.
Bootstrapped and regression tested on aarc64-linux-gnu with no new regressions.
Thanks,
Kugan
0001-RFC-PATCH-Adjust-param_vect_max_version_for_alias_ch.patch
Description: 0001-RFC-PATCH-Adjust-param_vect_max_version_for_alias_ch.patch
h one insm. Hence,
when the operands are equal, split after reload.
Bootstrapped and recession tested on aarch64-linux-gnu, Is this ok for trunk?
Thanks,
Kugan
0001-PATCH-AARCH64-PR115258-Fix-excess-moves.patch
Description: 0001-PATCH-AARCH64-PR115258-Fix-excess-moves.patch
Hi Richard,
Thanks for the review.
> On 8 Oct 2024, at 7:15 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Mon, Aug 5, 2024 at 7:05 AM Kugan Vivekanandarajah
> wrote:
>>
>>
>>
>>>
ping?
Thanks,
Kugan
From: Kugan Vivekanandarajah
Sent: Tuesday, 20 August 2024 6:18 PM
To: Jakub Jelinek
Cc: gcc-patches@gcc.gnu.org ;
richard.guent...@gmail.com ;
richard.sandif...@arm.com
Subject: Re: [PR middle-end/114635] Set OMP safelen handling to
Hi,
This patch Fixes absfloat16.c testcase to have the dg-add-options float16 at
the correct order. Due to this mixup, this test is failing for some arm
variants.
Is this OK for trunk?
Thanks,
Kugan
0001-Fix-absfloat16.c-testcase.patch
Description: 0001-Fix-absfloat16.c-testcase.patch
Hi Richard,
> On 17 Sep 2024, at 7:36 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Sep 17, 2024 at 10:31 AM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Richard,
>>
>>> On 10 Sep 2024, at 9:33
Hi Richard,
> On 10 Sep 2024, at 9:33 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Sep 5, 2024 at 3:19 AM Kugan Vivekanandarajah
> wrote:
>>
>> Thanks for the explanation.
>>
>>
>&g
Thanks for the explanation.
> On 2 Sep 2024, at 9:47 am, Andrew Pinski wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Sun, Sep 1, 2024 at 4:27 PM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Andrew.
>>
>>>
Hi Andrew.
> On 28 Aug 2024, at 2:23 pm, Andrew Pinski wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Aug 27, 2024 at 8:54 PM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Richard,
>>
>> Thanks for the reply.
>&
Hi Richard,
Thanks for the reply.
> On 27 Aug 2024, at 7:05 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Tue, Aug 27, 2024 at 8:23 AM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Richard,
>>
>>
Hi Richard,
> On 22 Aug 2024, at 10:34 pm, Richard Biener
> wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Wed, Aug 21, 2024 at 12:08 PM Kugan Vivekanandarajah
> wrote:
>>
>> Hi Richard,
>>
>>> On
Hi Richard,
> On 20 Aug 2024, at 6:09 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Fri, Aug 9, 2024 at 2:39 AM Kugan Vivekanandarajah
> wrote:
>>
>> Thanks for the comments.
>>
>>> On 2
ping? Any feedback.
Thanks,
Kugan
From: Kugan Vivekanandarajah
Sent: Monday, 5 August 2024 3:05 PM
To: Jakub Jelinek
Cc: gcc-patches@gcc.gnu.org ;
richard.guent...@gmail.com ;
richard.sandif...@arm.com
Subject: Re: [PR middle-end/114635] Set OMP safelen
Thanks for the comments.
> On 2 Aug 2024, at 8:36 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Fri, Aug 2, 2024 at 11:20 AM Kugan Vivekanandarajah
> wrote:
>>
>>
>>
>>> On 1 A
> On 15 Jul 2024, at 5:18 pm, Jakub Jelinek wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Mon, Jul 15, 2024 at 12:39:22AM +, Kugan Vivekanandarajah wrote:
>> OMP safelen handling is assigning backend provided max as an int even wh
> On 1 Aug 2024, at 10:46 pm, Richard Biener wrote:
>
> External email: Use caution opening links or attachments
>
>
> On Thu, Aug 1, 2024 at 5:31 AM Kugan Vivekanandarajah
> wrote:
>>
>>
>> On Mon, Jul 29, 2024 at 10:11 AM Andrew Pinski wrote:
&g
On Mon, Jul 29, 2024 at 10:11 AM Andrew Pinski wrote:
>
> On Mon, Jul 29, 2024 at 12:57 AM Kugan Vivekanandarajah
> wrote:
> >
> > On Thu, Jul 25, 2024 at 10:19 PM Richard Biener
> > wrote:
> > >
> > > On Thu, Jul 25, 2024 at 4:42 AM Kugan Vivekana
On Thu, Jul 25, 2024 at 10:19 PM Richard Biener
wrote:
>
> On Thu, Jul 25, 2024 at 4:42 AM Kugan Vivekanandarajah
> wrote:
> >
> > On Tue, Jul 23, 2024 at 11:56 PM Richard Biener
> > wrote:
> > >
> > > On Tue, Jul 23, 2024 at 10:27 AM Kugan Vivekana
On Tue, Jul 23, 2024 at 11:56 PM Richard Biener
wrote:
>
> On Tue, Jul 23, 2024 at 10:27 AM Kugan Vivekanandarajah
> wrote:
> >
> > On Tue, Jul 23, 2024 at 10:35 AM Andrew Pinski wrote:
> > >
> > > On Mon, Jul 22, 2024 at 5:26 PM Kugan Vivekanandaraja
On Tue, Jul 23, 2024 at 10:35 AM Andrew Pinski wrote:
>
> On Mon, Jul 22, 2024 at 5:26 PM Kugan Vivekanandarajah
> wrote:
> >
> > Revised based on the comment and moved it into existing patterns as.
> >
> > gcc/ChangeLog:
> >
> > * match.pd: Extend
Revised based on the comment and moved it into existing patterns as.
gcc/ChangeLog:
* match.pd: Extend A CMP 0 ? A : -A into (type)A CMP 0 ? A : -A.
Extend A CMP 0 ? A : -A into (type) A CMP 0 ? A : -A.
gcc/testsuite/ChangeLog:
* gcc.dg/tree-ssa/absfloat16.c: New test.
Signed-off-by: Kugan
.
Bootstrapped and regression tested on aarch64-linux-gnu. Is this OK for trunk.
Thanks,
Kugan
PR middle-end/114635
PR 114635
gcc/ChangeLog:
* omp-low.cc (lower_rec_input_clauses): Set INT_MAX
when safelen is not provided instead of using backend
provided
ee-ssa/absfloat16.c: New test.
Signed-off-by: Kugan Vivekanandarajah
0001-abs-for-half-float.patch
Description: 0001-abs-for-half-float.patch
Pushing to trunk.
Thanks,
Kugan
Signed-off-by: Kugan Vivekanandarajah
2024-07-11 Kugan Vivekanandarajah
* MAINTAINERS: Update my email address.
diff --git a/MAINTAINERS b/MAINTAINERS
index 762b91256c4..d27640708c5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -704,7 +704,7
Thanks Richard.
Created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115383
Thanks,
Kugan
On Fri, Jun 7, 2024 at 5:51 PM Richard Biener wrote:
>
> On Fri, 7 Jun 2024, Kugan Vivekanandarajah wrote:
>
> > Hi Richard,
> >
> > This seems to have introduced a regres
f you need a reduced testcase.
Thanks,
Kugan
Hi Richard,
Thanks for the review.
On Tue, 5 Nov 2019 at 23:08, Richard Biener wrote:
>
> On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah
> wrote:
> >
> > Hi,
> > Thanks for the review.
> >
> > On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote:
> >
Hi,
Thanks for the review.
On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote:
>
> On Sun, Nov 3, 2019 at 6:45 PM Kugan Vivekanandarajah
> wrote:
> >
> > Thanks for the reviews.
> >
> >
> > On Sat, 2 Nov 2019 at 02:49, H.J. Lu wrote:
> > >
> > &g
Thanks for the reviews.
On Sat, 2 Nov 2019 at 02:49, H.J. Lu wrote:
>
> On Thu, Oct 31, 2019 at 6:33 PM Kugan Vivekanandarajah
> wrote:
> >
> > On Wed, 30 Oct 2019 at 03:11, H.J. Lu wrote:
> > >
> > > On Sun, Oct 27, 2019 at 6:33 PM Kugan Vivekanand
On Wed, 30 Oct 2019 at 03:11, H.J. Lu wrote:
>
> On Sun, Oct 27, 2019 at 6:33 PM Kugan Vivekanandarajah
> wrote:
> >
> > Hi Richard,
> >
> > Thanks for the review.
> >
> > On Wed, 23 Oct 2019 at 23:07, Richard Biener
> > wrote:
Hi Bernhard,
Thanks for the review.
On Tue, 29 Oct 2019 at 08:52, Bernhard Reutner-Fischer
wrote:
>
> On Mon, 28 Oct 2019 11:53:06 +1100
> Kugan Vivekanandarajah wrote:
>
> > On Wed, 23 Oct 2019 at 23:07, Richard Biener
> > wrote:
>
> > > Did you try this
Hi Richard,
Thanks for the pointers.
On Fri, 11 Oct 2019 at 22:33, Richard Biener wrote:
>
> On Fri, Oct 11, 2019 at 6:15 AM Kugan Vivekanandarajah
> wrote:
> >
> > Hi Richard,
> > Thanks for the review.
> >
> > On Wed, 2 Oct 2019 at 20:41, Richard Bien
Hi Richard,
Thanks for the review.
On Wed, 2 Oct 2019 at 20:41, Richard Biener wrote:
>
> On Wed, Oct 2, 2019 at 10:39 AM Kugan Vivekanandarajah
> wrote:
> >
> > Hi,
> >
> > As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for
> > passing a
uot;:30 -1
(nil))
This looks like due to a typo in the md patterns. Attached patch fixes
this. Bootsrapped and regression tested on arm-linux-gnueabihf without
any regressions. Is this OK for trunk?
Thanks,
Kugan
gcc/ChangeLog:
2019-10-10 kugan.vivekanandarajah
* config/arm/vf
either adjusting partitioning according to flags or
emitting multiple object files from a single LTRANS CU. We could
consider this as a follow up.
Bootstrapped and regression tests on arm-linux-gcc. Is this OK for trunk?
Thanks,
Kugan
gcc/ChangeLog:
2019-10-02 kugan.vivekanandarajah
PR lto
00, Christophe Lyon
> wrote:
> > Committed on Kugan's behalf as rev 205891.
> >
> > On 11 December 2013 13:27, Marcus Shawcroft
> > wrote:
> > > On 10/12/13 20:23, Kugan wrote:
> > >
> > >> gcc/
> > >>
> > >>
Hi Richard,
Thanks for your comments.
On Thu, 16 May 2019 at 18:13, Richard Sandiford
wrote:
>
> kugan.vivekanandara...@linaro.org writes:
> > From: Kugan Vivekanandarajah
> >
> > Inorder to fix this PR.
> > * We need to change the whilelo pattern in backend
&
believe this is the only
way we can have GET_MODE_UNIT_SIZE of 0. Otherwise, we can check for
GET_MODE_UNIT_SIZE of zero.
Bootstrapped and regression tested attached patch on x86_64-linux-gnu
with no new regressions. Is this OK for trunk?
Thanks,
Kugan
gcc/ChangeLog:
2019-06-17 Kugan Vivekanandarajah
Hi Kyrill,
Thanks for the comments. Committed as you suggested.
Thanks,
Kugan
On Wed, 12 Jun 2019 at 18:07, Kyrill Tkachov
wrote:
>
> Hi Kugan,
>
> On 6/12/19 4:59 AM, Kugan Vivekanandarajah wrote:
> > AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error.
AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error.
Attached patch fixes this. I believe this falls under obvious
category. I will commit it after 48hrs unless comments should be
better worded.
Thanks,
Kugan
gcc/ChangeLog:
2019-06-12 Kugan Vivekanandarajah
* config
Hi Richard,
On Thu, 6 Jun 2019 at 22:07, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > Hi Richard,
> >
> > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford
> > wrote:
> >>
> >> Kugan Vivekanandarajah writes:
> >> >
Hi Richard,
On Thu, 6 Jun 2019 at 19:35, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > Hi Richard,
> >
> > Thanks for the review. Attached is the latest patch.
> >
> > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I
Thus, bailout when it is UNSPEC and MODEs are not compatible. */
+ if (GET_MODE_CLASS (mode) != GET_MODE_CLASS (GET_MODE (reg)))
+return false;
new_rtx = propagate_rtx (*loc, mode, reg, src,
optimize_bb_for_speed_p (BLOCK_FOR_INSN (use_insn)));
Thanks,
Kugan
On Mon,
Hi Richard,
Thanks for the review,
On Fri, 31 May 2019 at 19:43, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > @@ -609,8 +615,14 @@ vect_set_loop_masks_directly (struct loop *loop,
> > loop_vec_info loop_vinfo,
> >
> >/* Get the mask v
Hi Richard,
Thanks for the review.
On Tue, 28 May 2019 at 20:44, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > [...]
> > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c
> > index b3fae5b..c15b8a2 100644
> > --- a/gcc/tree-v
Hi Richard,
Thanks for the review.
On Sat, 25 May 2019 at 19:41, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c
> > index 77d3dac..d6452a1 100644
> > --- a/gcc/tree-vect-loop-manip.c
Hi Richard,
On Fri, 17 May 2019 at 18:47, Richard Sandiford
wrote:
>
> Kugan Vivekanandarajah writes:
> > [...]
> >> > +{
> >> > + struct mem_address parts = {NULL_TREE, integer_one_node,
> >> > + NULL
Hi,
Attached RFC patch attempts to use 32-bit WHILELO in LP64 mode to fix
the PR. Bootstarp and regression testing ongoing. In earlier testing,
I ran into an issue related to fwprop. I will tackle that based on the
feedback for the patch.
Thanks,
Kugan
From
for_doloop_p (struct loop *loop, tree niters)
> +{
> + tree type = TREE_TYPE (niters);
> + unsigned cost = 0;
> + bool speed = optimize_loop_for_speed_p (loop);
> + int regno = LAST_VIRTUAL_REGISTER + 1;
> + walk_tree (&niters, prepare_decl_rtl, ®no, NULL);
> + start_sequenc
Hi Richard,
On Thu, 16 May 2019 at 21:14, Richard Biener wrote:
>
> On Wed, May 15, 2019 at 4:40 AM wrote:
> >
> > From: Kugan Vivekanandarajah
> >
> > gcc/ChangeLog:
> >
> > 2019-05-15 Kugan Vivekanandarajah
> >
> >
Hi Richard,
On Wed, 15 May 2019 at 16:57, Richard Sandiford
wrote:
>
> Thanks for doing this.
>
> kugan.vivekanandara...@linaro.org writes:
> > From: Kugan Vivekanandarajah
> >
> > gcc/ChangeLog:
> >
> > 2019-05-15 Kugan Vivekanandarajah
> >
1 - 100 of 603 matches
Mail list logo
