Re: [Patch 0/X] HWASAN v3

2020-01-08 Thread Kostya Serebryany via gcc-patches
[asan/hwasan co-author here, with clearly biased opinions] On Android, HWASAN is already a fully usable testing tool. We apply it to the kernel, user space system libraries, and select apps. A phone with HWASAN-ified system is fully usable (I carry one as my primary device since March 2019). HWASA

Re: [Patch 0/X] [WIP][RFC][libsanitizer] Introduce HWASAN to GCC

2019-09-09 Thread Kostya Serebryany via gcc-patches
+Peter Collingbourne +Evgeniy Stepanov (the main developers of HWASAN in LLVM, FYI) Please note that Peter has recently implemented support for globals in LLVM's HWASAN. --kcc On Mon, Sep 9, 2019 at 8:55 AM Matthew Malcomson wrote: > > On 09/09/19 11:47, Martin Liška wrote: > > On 9/6/19 4:46 P

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
On Wed, Jul 18, 2018 at 12:29 PM H.J. Lu wrote: > > On Wed, Jul 18, 2018 at 11:45 AM, Kostya Serebryany wrote: > > On Wed, Jul 18, 2018 at 11:40 AM H.J. Lu wrote: > >> > >> On Wed, Jul 18, 2018 at 11:18 AM, Kostya Serebryany > >> wrote: > >> &g

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
On Wed, Jul 18, 2018 at 11:40 AM H.J. Lu wrote: > > On Wed, Jul 18, 2018 at 11:18 AM, Kostya Serebryany wrote: > > What's ENDBR and do we really need to have it in compiler-rt? > > When shadow stack from Intel CET is enabled, the first instruction of all > indirec

Re: [PATCH] Call REAL(swapcontext) with indirect_return attribute on x86

2018-07-18 Thread Kostya Serebryany via gcc-patches
What's ENDBR and do we really need to have it in compiler-rt? As usual, I am opposed to any gcc compiler-rt that bypass upstream. --kcc On Wed, Jul 18, 2018 at 8:37 AM H.J. Lu wrote: > > asan/asan_interceptors.cc has > > ... > int res = REAL(swapcontext)(oucp, ucp); > ... > > REAL(swapcontext

Re: Add support to trace comparison instructions and switch statements

2017-09-12 Thread Kostya Serebryany via gcc-patches
On Tue, Sep 12, 2017 at 7:32 AM, Dmitry Vyukov wrote: > On Thu, Sep 7, 2017 at 9:02 AM, 吴潍浠(此彼) wrote: >> Hi >> The trace-div and trace-gep options seems be used to evaluate corpus >> to trigger specific kind of bugs. And they don't have strong effect to >> coverage. These are used for what I c

Re: Add support to trace comparison instructions and switch statements

2017-07-14 Thread Kostya Serebryany via gcc-patches
On Fri, Jul 14, 2017 at 5:23 AM, Dmitry Vyukov wrote: > On Thu, Jul 13, 2017 at 11:18 PM, Kostya Serebryany wrote: >>> > Hi >>> > >>> > I wrote a test for "-fsanitize-coverage=trace-cmp" . >>> > >>> > Is there an

Re: Add fuzzing coverage support

2015-12-02 Thread Kostya Serebryany
On Wed, Dec 2, 2015 at 11:51 AM, Jakub Jelinek wrote: > On Wed, Dec 02, 2015 at 05:55:29PM +0100, Dmitry Vyukov wrote: >> Can you point to some concrete coding style violations (besides >> function comments)? >> >> >> > We seem to have no established process for deciding whether we want a new >> >

Re: [PATCH] Disable "ODR" checking in libsanitizer

2015-02-23 Thread Kostya Serebryany
23, 2015 at 3:02 PM, Kostya Serebryany wrote: > Looks good. > > I am not planing to work on the fix any time soon, co I encourage you or > someone else interested to send patches to fix the problem in LLVM. > Since you are also committing a test we should not accidentally remove th

Re: Revert libsanitizer patches or fix 59009

2013-11-18 Thread Kostya Serebryany
On Sat, Nov 16, 2013 at 7:59 AM, John David Anglin wrote: > As far as I can tell, libsanitizer works on hppa-linux. So, the change > could be added to the llvm tree. > However, I'm unlikely to test anything in the tree unless someone tells me > there's something to test. Submitted the hppa patch

Re: [PATCH]: backport fix for PR sanitizer/58994

2013-11-14 Thread Kostya Serebryany
t; x86_64-apple-darwin12 and x86_64-apple-darwin13. > Jack > ps Kostya, can you handled the commit? Thanks in advance. Will do (tomorrow) --kcc > > 2013-11-14 Kostya Serebryany > Jack Howarth > > libsanitizer/ > > PR saniti

Re: Revert libsanitizer patches or fix 59009

2013-11-13 Thread Kostya Serebryany
On Wed, Nov 13, 2013 at 9:21 AM, Michael Meissner wrote: > On Wed, Nov 13, 2013 at 10:45:54AM +0400, Kostya Serebryany wrote: >> Many thanks, Jakub. >> >> I don't want to appear in this situation again. >> Would you suggest a place to create a wiki page which wou

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
Many thanks, Jakub. I don't want to appear in this situation again. Would you suggest a place to create a wiki page which would list all required steps to test libsanitizer? libsanitizer is (unfortunately) a very system-dependent beast and our upstream commits will break other platforms regularly

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
On Tue, Nov 12, 2013 at 11:30 AM, Jakub Jelinek wrote: > On Tue, Nov 12, 2013 at 10:59:12AM -0800, Kostya Serebryany wrote: >> This is all dead code in gcc repo. This is why I am asking for any >> quick #ifdef. >> in clang repo this code is used by MemorySanitizer (and wi

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
On Tue, Nov 12, 2013 at 10:57 AM, Jakub Jelinek wrote: > On Tue, Nov 12, 2013 at 10:07:32AM -0800, Kostya Serebryany wrote: >> On Tue, Nov 12, 2013 at 10:04 AM, Michael Meissner >> wrote: >> > On Tue, Nov 12, 2013 at 09:43:38AM -0800, Kostya Serebryany wrote: >>

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
On Tue, Nov 12, 2013 at 10:04 AM, Michael Meissner wrote: > On Tue, Nov 12, 2013 at 09:43:38AM -0800, Kostya Serebryany wrote: >> or, alternatively, we can disable libsanitizer on PowerPC if the >> PowerPC community does not care enough about it being healthy. > > I think the

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
or, alternatively, we can disable libsanitizer on PowerPC if the PowerPC community does not care enough about it being healthy. On Tue, Nov 12, 2013 at 9:41 AM, Kostya Serebryany wrote: > [plain text] > So far I was not able to reproduce the compilation failure -- and I am > asking som

Re: Revert libsanitizer patches or fix 59009

2013-11-12 Thread Kostya Serebryany
be able to work on it again in nearest months, which means 4.9 will not get updated asan. How bad that is -- I don't know. --kcc On Tue, Nov 12, 2013 at 9:40 AM, Kostya Serebryany wrote: > So far I was not able to reproduce the compilation failure -- and I am > asking someone from

Re: [libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Kostya Serebryany
local dir is libsanitizer -- exit if it is not > 2) clean up the upstream directory after the merge is done. > > David > > > On Wed, Nov 21, 2012 at 10:25 AM, Kostya Serebryany wrote: >> Hi, >> >> A dummy script to help merging asan from upstream. >>

[libsanitizer] a script to help merging asan from upstream

2012-11-21 Thread Kostya Serebryany
Hi, A dummy script to help merging asan from upstream. Not 100% complete, but should be enough to complete the current merge. You suggestions on how to improve it (or how to do w/o it) are welcome, but I really wish to do the first merge tomorrow to unblock other folks. Thanks, --kcc merge.pat

Re: libsanitizer/README.gcc update

2012-11-21 Thread Kostya Serebryany
Done, thanks! --kcc On Wed, Nov 21, 2012 at 6:44 PM, Jakub Jelinek wrote: > On Wed, Nov 21, 2012 at 06:36:32PM +0400, Kostya Serebryany wrote: >> This patch updates libsanitizer/README.gcc. Ok? >> (This is the first time I am trying to commit to gcc trunk) >>

libsanitizer/README.gcc update

2012-11-21 Thread Kostya Serebryany
Kostya Serebryany +* README.gcc: Extend the README.gcc with mode details. + 2012-11-20 Konstantin Serebryany * sanitizer_common/sanitizer_linux.cc Index: README.gcc === --- README.gcc (revision 193693) +++ README.gcc

Re: Asan/Tsan Unit/Regression testing (was [asan] Emit GIMPLE direclty, small cleanups)

2012-11-07 Thread Kostya Serebryany
On Tue, Nov 6, 2012 at 4:26 PM, Xinliang David Li wrote: > > As asan/tsan functionality is getting into trunk, we need to set up > testings as soon as possible to avoid bitrot. > > Kostya can probably shed some lights on the test case requirements, > and we can continue discussions on how to exten

[google] AddressSanitizer for gcc, first attempt. (issue5272048)

2011-10-14 Thread Kostya Serebryany
| PROP_cfg | PROP_gimple_leh,/* properties_required */ + 0, /* properties_provided */ + 0,/* properties_destroyed */ + 0,/* todo_flags_start */ + TODO_verify_flow | TODO_verify_stmts