Re: [PATCH] PING implement pre-c++20 contracts

2021-05-28 Thread Jeff Chapman via Gcc-patches
Hello again :) Wanted to shoot a quick status update. Some github issues have been created for points of feedback, and we've been working on addressing them. A few changes have been pushed to the contracts-jac-alt branch, while there's also an active more in depth rewrite branch. Some specific com

Re: [PATCH] PING implement pre-c++20 contracts

2021-04-30 Thread Jeff Chapman via Gcc-patches
Hello! Looping back around to this. re: https://gcc.gnu.org/pipermail/gcc-patches/2021-March/567334.html On 3/25/21, Jason Merrill wrote: > On 3/1/21 8:12 AM, Jeff Chapman wrote: >> On 1/18/21, Jason Merrill wrote: >>> On 1/4/21 9:58 AM, Jeff Chapman wrote: Ping. re: https://gcc.gnu.or

Re: [PATCH] PING implement pre-c++20 contracts

2021-03-01 Thread Jeff Chapman via Gcc-patches
On 1/18/21, Jason Merrill wrote: > On 1/4/21 9:58 AM, Jeff Chapman wrote: >> Ping. re: >> https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html >> >> >> https://github.com/lock3/gcc/tree/contracts-jac-alt >>

[PATCH] PING implement pre-c++20 contracts

2021-01-04 Thread Jeff Chapman via Gcc-patches
Ping. re: https://gcc.gnu.org/pipermail/gcc-patches/2020-December/561135.html > OK, I'll start with -alt then, thanks. > > Andrew is exactly correct, contracts-jac-alt is still the current branch > we're focusing our upstreaming efforts on. > > It's trailing upstream master by a fair bit at this p

Re: [PATCH] implement pre-c++20 contracts

2020-12-04 Thread Jeff Chapman via Gcc-patches
> OK, I'll start with -alt then, thanks. Andrew is exactly correct, contracts-jac-alt is still the current branch we're focusing our upstreaming efforts on. It's trailing upstream master by a fair bit at this point. I'll get a merge pushed shortly. Please let me know if there's anything I can do

[PATCH 2/2] modules: c++: Fix cross module member redecl/add long distance friendship warning

2020-08-14 Thread Jeff Chapman via Gcc-patches
Attached is a patch adding a -Wlong-distance-friends flag to diagnose long distance (cross module) friendship. 2020-08-14 Jeff Chapman II gcc/c-family/ * c.opt (Wlong-distance-friends): New. gcc/cp/ * cp-tree.h (module_friendship_compatible): New. * friend.c (add_frie

[PATCH 1/2] modules: c++: Fix cross module member redecl/add long distance friendship warning

2020-08-14 Thread Jeff Chapman via Gcc-patches
Hello again, This is part one of a patchset to add an optional warning for long distance (cross module) friendship when the friendship has no useful/sensical meaning. Attached is a patch to error when trying to define a member function of a type owned by a different module. This also fixes an iss

[PATCH] modules: c++: Fix push_namespace ICE with modules

2020-08-14 Thread Jeff Chapman via Gcc-patches
Hello! Attached is a patch that fixes an ICE on the devel/c++-modules branch caused by a slot invalidation edge case in push_namespace. It's been sitting around for a while and I wasn't sure if I should use the original date or not. Feel free to adjust that to the commit date if that's what it sh

Re: [PATCH] implement pre-c++20 contracts

2020-07-28 Thread Jeff Chapman via Gcc-patches
Ping. Any feedback would be appreciated :) re: https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549868.html older reply: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545339.html On 7/10/20, Jeff Chapman wrote: > Hello again :) > > Attached is a new squashed revision of the patch sans Ch

Re: [PATCH] implement pre-c++20 contracts

2020-07-10 Thread Jeff Chapman via Gcc-patches
Hello again :) Attached is a new squashed revision of the patch sans ChangeLogs. The current work is now being done on github: https://github.com/lock3/gcc/tree/contracts-jac-alt Please let me know if there's a better way to share revisions. >>> + /* Check that assertions are null statements.

Re: [PATCH] implement pre-c++20 contracts

2020-05-07 Thread Jeff Chapman via Gcc-patches
Hello, On 12/10/19, Jason Merrill wrote: > On 11/13/19, Jeff Chapman wrote: >> Attached is a patch that implements pre-c++20 contracts. This comes >> from a long running development branch which included ChangeLog entries >> as we went, which are included in the patch itself. The repo and >> initi