Re: [PATCH] Fix overflow handling in std::align

2020-09-21 Thread Glen Fernandes via Gcc-patches
On Mon, Sep 14, 2020 at 5:44 PM Thomas Rodgers wrote: > > On Sep 14, 2020, at 7:30 AM, Ville Voutilainen wrote: > > > > On Mon, 14 Sep 2020 at 15:49, Glen Fernandes wrote: > >> Sounds like a good idea. Updated patch attached. > > > > Looks good to me. >

Re: [PATCH] Fix overflow handling in std::align

2020-09-14 Thread Glen Fernandes via Gcc-patches
On Mon, Sep 14, 2020 at 5:52 AM Ville Voutilainen wrote: > On Mon, 14 Sep 2020 at 12:51, Ville Voutilainen > wrote: > > On Mon, 14 Sep 2020 at 09:18, Glen Fernandes > wrote: > > > Edit; Correct patch this time. > > > > > > Fix overflow handling in align

[PATCH] Fix overflow handling in std::align

2020-09-13 Thread Glen Fernandes via Gcc-patches
Edit; Correct patch this time. Fix overflow handling in align 2020-09-12 Glen Joseph Fernandes * include/bits/align.h (align): Fix overflow handling. * testsuite/20_util/align/3.cc: New tests. Tested x86_64-pc-linux-gnu. Glen commit 1c560175f38c6b108f80ffcf94d4cd956ef66604 A

[PATCH] Fix overflow handling in std::align

2020-09-13 Thread Glen Fernandes via Gcc-patches
Fix overflow handling in align 2020-09-12 Glen Joseph Fernandes * include/bits/align.h (align): Fix overflow handling. * testsuite/20_util/align/3.cc: New tests. Tested x86_64-pc-linux-gnu. commit 1c560175f38c6b108f80ffcf94d4cd956ef66604 Author: Glen Joseph Fernandes Date:

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-07-19 Thread Glen Fernandes
On Thu, Jul 19, 2018 at 10:40 AM Jonathan Wakely wrote: > On 19/07/18 10:32 -0400, Glen Fernandes wrote: > >Attached: patch.txt > >Use __builtin_memmove for trivially copyable types > >2018-07-19 Glen Joseph Fernandes > >* include/bits/stl_algobase.h &

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-07-19 Thread Glen Fernandes
On Thu, Jul 19, 2018 at 10:40 AM Jonathan Wakely wrote: > On 19/07/18 10:32 -0400, Glen Fernandes wrote: > >Attached: patch.txt > >Use __builtin_memmove for trivially copyable types > >2018-07-19 Glen Joseph Fernandes > >* include/bits/stl_algobase.h &

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-07-19 Thread Glen Fernandes
On Thu, Jul 19, 2018 at 10:01 AM Glen Fernandes wrote: > > I was still unclear about that, but I forwarded you an e-mail from > Marshall with his answer when I asked whether libc++'s use of > TriviallyCopyAssignable here was incorrect. Let me know if it applies > here,

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-07-19 Thread Glen Fernandes
On Thu, Jul 19, 2018 at 9:25 AM Jonathan Wakely wrote: > Sorry for the delay in reviewing this properly, as I've only just > realised that this introduces undefined behaviour, doesn't it? > > It's undefined to use memmove for a type that is not trivially > copyable. All trivial types are trivially

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-07-19 Thread Glen Fernandes
commit 1af8d465545fda2451928fe100901db37c3e632c Author: Glen Fernandes Date: Thu Jul 19 07:40:17 2018 -0400 Use __builtin_memmove for trivially copy assignable types 2018-07-19 Glen Joseph Fernandes * include/bits/stl_algobase.h (__is_simple_copy_move): Defined

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-06-19 Thread Glen Fernandes
/20_util/specialized_algorithms/uninitialized_copy/1.cc: New test. * testsuite/25_algorithms/copy/58982.cc: Updated tests. * testsuite/25_algorithms/copy_n/58982.cc: Likewise. Attached: patch.txt Glen commit 521df588d7a83c662c833c0460d171663c62fd9a Author: Glen Fernandes Date: Fri Jun

Re: [PATCH] Use __builtin_memmove for trivially copy assignable types

2018-06-18 Thread Glen Fernandes
On Mon, Jun 18, 2018 at 6:12 PM Ville Voutilainen wrote: > On 16 June 2018 at 18:05, Marc Glisse wrote: > > On Sat, 16 Jun 2018, Glen Fernandes wrote: > > > >> Use __builtin_memmove for trivially copy assignable types > >> > >> 2018-06-14 Glen Joseph F

[PATCH] Use __builtin_memmove for trivially copy assignable types

2018-06-15 Thread Glen Fernandes
/copy/58982.cc: Updated tests. * testsuite/25_algorithms/copy_n/58982.cc: Likewise. Tested x86_64-pc-linux-gnu. Glen commit 7ace2ad91fe7d2253b086aef8bfdb99f85d81f31 Author: Glen Fernandes Date: Fri Jun 15 07:33:07 2018 -0400 Use __builtin_memmove for trivially copy assignable types

Re: [PATCH] Implement std::to_address for C++2a

2017-11-29 Thread Glen Fernandes
(Also added a new [_neg] test) Move static_assert for function pointers to __to_address 2017-11-28 Glen Joseph Fernandes * include/bits/ptr_traits.h (to_address): Moved static_assert. * testsuite/20_util/to_address/1_neg.cc: New test. Tested x86_64-pc-linux-gnu. commit 0081e

Re: [PATCH] Implement std::to_address for C++2a

2017-11-28 Thread Glen Fernandes
On Tue, Nov 28, 2017 at 9:24 AM, Jonathan Wakely wrote: > Thanks, Glen, I've committed this to trunk, with one small change to > fix the copyright dates in the new test, to be just 2017. Thanks! > Because my new hobby is finding uses for if-constexpr, I think we > could have used the detection id

Re: [PATCH] Implement std::to_address for C++2a

2017-11-25 Thread Glen Fernandes
(Just a minor update to the last patch to use is_function_v instead of is_function::value) Implement std::to_address for C++2a 2017-11-25 Glen Joseph Fernandes * include/bits/ptr_traits.h (to_address): Implement to_address. * testsuite/20_util/to_address/1.cc: New tests. Test

[PATCH] Implement std::to_address for C++2a

2017-11-17 Thread Glen Fernandes
Implement std::to_address for C++2a * include/bits/ptr_traits.h (to_address): Implement to_address. * testsuite/20_util/to_address/1.cc: New tests. Tested x86_64-pc-linux-gnu. commit fffc95183120866461b363b19fe04f269d5f9299 Author: Glen Fernandes Date: Fri Nov 17 15:43:19 2017

Re: [PATCH] Implement std::pointer_traits::to_address as per P0653R0

2017-07-20 Thread Glen Fernandes
On Thu, Jul 20, 2017 at 12:53 PM, Jonathan Wakely wrote: > We have a more general problem with this, which is that if it's only > available for C++2a mode then we can't use the new feature in most of > the library. Which would be very unfortunate. I want to use this! > > In order to clean up the va

[PATCH] Implement std::pointer_traits::to_address as per P0653R0

2017-07-16 Thread Glen Fernandes
pointer_traits specialization. * testsuite/20_util/pointer_traits/requirements/explicit_instantiation.cc: Define operator->. * testsuite/20_util/pointer_traits/to_address.cc: New tests. Tested i686-pc-linux-gnu. Glen commit 7180839baa6dff48dc7a1536a2de0688f79d38dc Author: Glen Fernan