Re: PING^3 [PATCH] rs6000: Adjust -fpatchable-function-entry* support for dual entry [PR112980]

2024-07-25 Thread Giuliano Belinassi
Pinging this again. Em seg, 2024-07-22 às 17:18 +0800, Kewen.Lin escreveu: > Hi, > > Gentle ping this patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/651025.html > > BR, > Kewen > > on 2024/7/12 00:15, Martin Jambor wrote: > > Hi, > > > > can I add myself to the bunch of people

Re: PING^1 [PATCH] rs6000: Adjust -fpatchable-function-entry* support for dual entry [PR112980]

2024-07-02 Thread Giuliano Belinassi
Hello, Em ter, 2024-07-02 às 16:46 +0800, Kewen.Lin escreveu: > Hi, > > Gentle ping this patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/651025.html > I am testing this patch on our Userspace Livepatching product and we found no issues so far. Thanks, Giuliano. > BR, > Kewen >

Re: [PATCH] PR105647 Update pr105169* so it does not fail on powerpc64le

2022-05-19 Thread Giuliano Belinassi via Gcc-patches
On Thu, 2022-05-19 at 06:34 +, Richard Biener wrote: > On Wed, 18 May 2022, Giuliano Belinassi wrote: > > > On powerpc64le, the tests related to pr105169 failed because the > > .localentry was not on a power of two address due to the extra nop > > instruction taking

Re: [PATCH v2] PR105169 Fix references to discarded sections

2022-05-17 Thread Giuliano Belinassi via Gcc-patches
On Mon, 2022-05-09 at 13:39 +0200, Richard Biener wrote: > On Sat, 7 May 2022, Giuliano Belinassi wrote: > > > When -fpatchable-function-entry= is enabled, certain C++ codes > > fails to > > link because of generated references to discarded sections in > > __patchabl

[PATCH v2] PR105169 Fix references to discarded sections

2022-05-09 Thread Giuliano Belinassi via Gcc-patches
--enable-vtable-verify enabled. This version compiles fine with it. 2022-05-06 Giuliano Belinassi PR c++/105169 * targhooks.cc (default_print_patchable_function_entry_1): Handle COMDAT case. * varasm.cc (switch_to_comdat_section): New (handle_vtv_comdat_section

Re: [PATCH] PR105169 Fix references to discarded sections

2022-05-06 Thread Giuliano Belinassi via Gcc-patches
Hi, On Tue, 2022-04-19 at 10:11 +0200, Richard Biener wrote: > On Thu, 14 Apr 2022, Giuliano Belinassi wrote: > > > When -fpatchable-function-entry= is enabled, certain C++ codes > > fails to > > link because of generated references to discarded sections in > > __pa

[PATCH] PR105169 Fix references to discarded sections

2022-04-14 Thread Giuliano Belinassi via Gcc-patches
for Stage4? 2022-04-13 Giuliano Belinassi PR c++/105169 * targhooks.cc (default_print_patchable_function_entry_1): Handle COMDAT case. * varasm.cc (handle_vtv_comdat_section): Rename to... (switch_to_comdat_section): Generalize to also cover

Re: [PATCH v3] Do not abort compilation when dump file is /dev/*

2021-11-22 Thread Giuliano Belinassi via Gcc-patches
On Sun, 2021-11-21 at 00:47 -0300, Alexandre Oliva wrote: > Hello, Giuliano, thanks for turning my suggestion into a patch! > > On Nov 19, 2021, Richard Biener wrote: > > > > +/* { dg-options "-fdump-ipa-clones -o /dev/null" } */ > > May I suggest actually checking that the ipa-clones dump file

[PATCH v3] Do not abort compilation when dump file is /dev/*

2021-11-19 Thread Giuliano Belinassi via Gcc-patches
2021-11-16 Giuliano Belinassi * gcc.c (process_command): Skip dumpdir override if file is a not_actual_file_p. (not_actual_file_p): Return true if file is /dev/zero as well. * doc/invoke.texi: Update -dumpdir documentation. gcc/testsuite/ChangeLog 2021-11-16 Giuliano

[PATCH v2] Do not abort compilation when dump file is /dev/*

2021-11-18 Thread Giuliano Belinassi via Gcc-patches
2021-11-16 Giuliano Belinassi * gcc.c (process_command): Skip dumpdir override on -o /dev/null or -o /dev/zero. gcc/testsuite/ChangeLog 2021-11-16 Giuliano Belinassi * gcc.dg/devnull-dump.c: New. Signed-off-by: Giuliano Belinassi --- gcc/doc/invoke.texi

Re: [PATCH] Do not abort compilation when dump file is /dev/*

2021-11-18 Thread Giuliano Belinassi via Gcc-patches
On Thu, 2021-11-18 at 10:43 +0100, Richard Biener wrote: > On Tue, 16 Nov 2021, Giuliano Belinassi wrote: > > > The `configure` scripts generated with autoconf often tests > > compiler > > features by setting output to `/dev/null`, which then sets the dump > >

[PATCH] Do not abort compilation when dump file is /dev/*

2021-11-16 Thread Giuliano Belinassi via Gcc-patches
lting with an error creating files in /dev/*. This commit fixes this issue by checking if the dump folder is /dev/. If yes, then it just informs the user and disables dumping, but does not halt the compilation and the compiler retuns 0 to the shell. gcc/ChangeLog 2021-11-16 Giuliano

Re: [PATCH] Fix PR 100944 - Array boundary misscalculation

2021-06-14 Thread Giuliano Belinassi via Gcc-patches
Hi, I will give an quick answer to this mail. I will analyze carefully what richi said when I have more time available. On Mon, 2021-06-14 at 15:55 -0600, Martin Sebor wrote: > On 6/13/21 11:00 AM, Giuliano Belinassi wrote: > > This patch proposes a fix to PR 100944 by improving

[PATCH] Fix PR 100944 - Array boundary misscalculation

2021-06-13 Thread Giuliano Belinassi via Gcc-patches
is found in the RECORD, simply fall back to: offset(array begin) - offset(RECORD_TYPE ends) We avoid doing this calculation if the RECORD_TYPE is actually an UNION_TYPE, once things get very complicated in this case. gcc/ChangeLog: 2021-13-08 Giuliano Belinassi PR middle-end/100944

Re: [PATCH] Try LTO partial linking. (Was: Speed of compiling gimple-match.c)

2021-06-12 Thread Giuliano Belinassi via Gcc-patches
Hi, all. Please CC me when I am mentioned into a mail. On Thu, 2021-05-20 at 15:16 +0200, Richard Biener via Gcc wrote: > On Thu, May 20, 2021 at 3:06 PM Martin Liška wrote: > > > > On 5/20/21 2:54 PM, Richard Biener wrote: > > > So why did you go from applying this per-file to multiple files?

Re: [PATCH 2/6] Implement a new partitioner for parallel compilation

2020-08-27 Thread Giuliano Belinassi via Gcc-patches
d_map partitioner. > > > > For 3. to work properly, we also had to modify > > lto_promote_cross_file_statics to handle this case. > > > > The parameters --param=promote-statics and --param=balance-partitions > > control 4. and 5., respectively > > > >

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-27 Thread Giuliano Belinassi via Gcc-patches
Hi, Honza. Thank you for your detailed review! On 08/27, Jan Hubicka wrote: > > diff --git a/gcc/cgraph.c b/gcc/cgraph.c > > index c0b45795059..22405098dc5 100644 > > --- a/gcc/cgraph.c > > +++ b/gcc/cgraph.c > > @@ -226,6 +226,22 @@ cgraph_node::delete_function_version_by_decl (tree > > decl) >

Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-24 Thread Giuliano Belinassi via Gcc-patches
Ho, Josh. On 08/24, Josh Triplett wrote: > On Sat, Aug 22, 2020 at 06:04:48PM -0300, Giuliano Belinassi wrote: > > Hi, Josh > > > > On 08/21, Josh Triplett wrote: > > > On Thu, Aug 20, 2020 at 07:00:13PM -0300, Giuliano Belinassi wrote: > > > > This pa

Re: [PATCH 1/6] Modify gcc driver for parallel compilation

2020-08-24 Thread Giuliano Belinassi via Gcc-patches
Hi, Richi. On 08/24, Richard Biener wrote: > On Fri, Aug 21, 2020 at 12:00 AM Giuliano Belinassi > wrote: > > > > Update the driver for parallel compilation. This process work as > > follows: > > > > When calling gcc, the driver will check if the flag >

Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-24 Thread Giuliano Belinassi via Gcc-patches
Hi, Richi. On 08/24, Richard Biener wrote: > On Fri, Aug 21, 2020 at 12:00 AM Giuliano Belinassi > wrote: > > > > This patch series add a new flag "-fparallel-jobs=" to control if the > > compiler should try to compile the current file in parallel. >

Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-22 Thread Giuliano Belinassi via Gcc-patches
Hi, Josh On 08/21, Josh Triplett wrote: > On Thu, Aug 20, 2020 at 07:00:13PM -0300, Giuliano Belinassi wrote: > > This patch series add a new flag "-fparallel-jobs=" to control if the > > compiler should try to compile the current file in parallel. > [...] > > B

[PATCH 4/6] Add `+' for Jobserver Integration

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
intl/ChageLog: libbacktrace/ChangeLog: libcpp/ChangeLog: libdecnumber/ChangeLog: libiberty/ChangeLog: zlib/ChangeLog: 2020-08-20 Giuliano Belinassi * Makefile.in: Use `+' on rule calling GCC. --- gcc/Makefile.in | 4 +- intl/Makefile.in | 2 +- li

[PATCH 2/6] Implement a new partitioner for parallel compilation

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
which are know for being very fast on set unite operations. For 3. to work properly, we also had to modify lto_promote_cross_file_statics to handle this case. The parameters --param=promote-statics and --param=balance-partitions control 4. and 5., respectively gcc/ChangeLog: 2020-

[PATCH 3/6] Implement fork-based parallelism engine

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
engine part. gcc/ChangeLog: 2020-08-20 Giuliano Belinassi * jobserver.cc: New file. * jobserver.h: New file. * cgraph.c (cgraph_node::maybe_release_dominators): New function. * cgraph.h (symtab_node::find_by_order): Declare. (symtab_node::find_by_name): Declare

[PATCH 5/6] Add invoke documentation

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
Add documentation about how to invoke GCC in order to use parallel compilation. gcc/ChangeLog: 20-08-2020 Giuliano Belinassi * doc/invoke.texi: Document -fparallel-jobs=. --- gcc/doc/invoke.texi | 32 +++- 1 file changed, 31 insertions(+), 1 deletion

[PATCH 6/6] New tests for parallel compilation feature

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
Adds new tests for testing the parallel compilation engine. They mainly test issues with regard to symbol promotion clash and incorrect early assembler output. 2020-08-20 Giuliano Belinassi * gcc.dg/parallel-early-constant.c: New test. * gcc.dg/parallel-static-1.c: New test

[PATCH 1/6] Modify gcc driver for parallel compilation

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
pping the compiler, so development of further features to the driver get faster for now on. gcc/ChangeLog 2020-08-20 Giuliano Belinassi * common.opt (fsplit-outputs): New flag. (fparallel-jobs): New flag. * gcc.c (extra_arg_storer): New class. (have_S): New

[PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
| 1.9x | Notice that we have a slowdown in some cases when it is enabled, that is why the parallelism feature is enabled with a flag for now. Bootstrapped and Regtested on Linux x86_64. Giuliano Belinassi (6): Modify gcc driver for parallel compilation Implement a new partitioner for

[PATCH] Refactor `execute` from gcc.c

2020-05-18 Thread Giuliano Belinassi via Gcc-patches
on Linux x86_64. - Refactor `execute' function to avoid exposing unnecessary details of how it works, encapsulating each important step into a function. gcc/ChangeLog 2020-05-18 Giuliano Belinassi * gcc.c (struct command): Move from execute. (await_commands_to_f

Re: [PATCH] Refactor tree-vrp.c

2020-05-12 Thread Giuliano Belinassi via Gcc-patches
Hi. On 05/11, Richard Biener wrote: > On Fri, May 8, 2020 at 7:11 PM Jeff Law via Gcc-patches > wrote: > > > > On Fri, 2020-05-08 at 13:06 -0300, Giuliano Belinassi via Gcc-patches wrote: > > > Hi, > > > > > > This patch Refactors tree-v

[PATCH] Refactor tree-vrp.c

2020-05-08 Thread Giuliano Belinassi via Gcc-patches
ing the function being compiled from the pass engine. Bootstrapped and ran the testsuite on Linux x86_64. gcc/ChangeLog 2020-05-08 Giuliano Belinassi * tree-vrp.c (class liveness): New. (insert_range_assertions): Move to class liveness. (dump_all_asserts): Same as ab

Re: [PATCH v3] [Stage1] Refactor tree-ssa-operands.c

2020-05-04 Thread Giuliano Belinassi via Gcc-patches
Sep 17 00:00:00 2001 From: Giuliano Belinassi Date: Mon, 4 May 2020 18:44:31 -0300 Subject: [PATCH v3] Refactor tree-ssa-operands.c Refactor tree-ssa-operands.c by wrapping the global variables into a class, and also removes unused code. gcc/ChangeLog: 2020-05-04 Giuliano Belinassi * tree-

Re: [PATCHv2] [Stage1] Refactor tree-ssa-operands.c

2020-04-23 Thread Giuliano Belinassi via Gcc-patches
avoid passing down these values to every function. Bootstrapped and ran the testsuite in Linux x86_64. gcc/ChangeLog: 2020-04-23 Giuliano Belinassi * tree-ssa-operands.c (operands_scanner): New class. (operands_bitmap_obstack): Remove. (n_initialized): Remove

[PATCH] [Stage1] Refactor tree-ssa-operands.c

2020-04-22 Thread Giuliano Belinassi via Gcc-patches
This patch refactors tree-ssa-operands.c by wrapping the global variables into a class, and also removes unused code. Just sending this for when Stage1 is back again. I ran the testsuite and bootstraped in a x86_64 linux machine and found no issues. gcc/ChangeLog: 2020-04-22 Giuliano Belinassi

Re: [PATCH V2] Refactor tree-loop-distribution for thread safety

2019-11-18 Thread Giuliano Belinassi
Hi, On 11/15, Richard Biener wrote: > On Thu, Nov 14, 2019 at 10:35 PM Giuliano Belinassi > wrote: > > > > Previously, the suggested patch removed all tree-loop-distributions.c global > > variables moving them into a struct and passing it aroung across the > > fun

Re: [PATCH V2] Refactor tree-loop-distribution for thread safety

2019-11-14 Thread Giuliano Belinassi
pointer. gcc/ChangeLog 2019-11-14 Giuliano Belinassi * cfgloop.c (get_loop_body_in_custom_order): New. * cfgloop.h (get_loop_body_in_custom_order): New prototype. * tree-loop-distribution.c (class loop_distribution): New. (bb_top_order_cmp): Remove

Re: [PATCH] Refactor tree-loop-distribution for thread safety

2019-11-12 Thread Giuliano Belinassi
Hi, Richard. On 11/12, Richard Biener wrote: > On Sat, Nov 9, 2019 at 3:26 PM Giuliano Belinassi > wrote: > > > > Hi all, > > > > This patch refactors tree-loop-distribution.c for thread safety without > > use of C11 __thread feature. All global variables

[PATCH] Refactor tree-loop-distribution for thread safety

2019-11-09 Thread Giuliano Belinassi
Hi all, This patch refactors tree-loop-distribution.c for thread safety without use of C11 __thread feature. All global variables were moved to a struct which is initialized at ::execute time. I can install this patch myself in trunk if it's OK. gcc/ChangeLog 2019-11-09 Giuliano Beli

[PATCH] Fix incorrect merge of conflictant names in `dump_graphviz`

2019-10-21 Thread Giuliano Belinassi
Is it ok for me to commit it in trunk as trivial? And is there something special that I should know before doing a commit into trunk? gcc/ChangeLog: 2019-07-22 Giuliano Belinassi * cgraph.c (dump_graphviz): Change name to dump_name Giuliano. diff --git gcc/cgraph.c gcc/cgraph.c in

Re: [PATCH] Communicate lto-wrapper and ld through a file

2019-10-17 Thread Giuliano Belinassi
Hi On 10/17, Richard Biener wrote: > On Wed, Oct 16, 2019 at 7:46 PM Giuliano Belinassi > wrote: > > > > Hi, > > > > Previously, the lto-wrapper communicates with ld by creating a pipe from > > lto-wrapper's stdout to ld's stdin. This patch us

[PATCH] Communicate lto-wrapper and ld through a file

2019-10-16 Thread Giuliano Belinassi
4, and found no issues so far. Do I need to write a testcase for this feature? Giuliano. gcc/ChangeLog 2019-10-16 Giuliano Belinassi * lto-wrapper.c (STATIC_LEN): New macro. (to_ld): New. (find_crtofftable): Print to file to_ld. (find_ld_list_file): New. (main): Check if to_ld

Re: [PATCH v2] Make lto-dump dump callgraph in DOT format

2019-07-12 Thread Giuliano Belinassi
Hi, It seems that this patch wasn't merged to trunk yet. Is there any problem to it? On 07/02, Jeff Law wrote: > On 7/2/19 6:36 AM, Giuliano Belinassi wrote: > > This patch makes lto-dump the symtab callgraph in graphviz DOT format. > > > > Previously, the suggeste

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-07-03 Thread Giuliano Belinassi
Hi, Jeff. On 07/02, Jeff Law wrote: > On 1/24/19 12:51 PM, Giuliano Belinassi wrote: > > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the functions > > 'expand_

[PATCH v2] Make lto-dump dump callgraph in DOT format

2019-07-02 Thread Giuliano Belinassi
This patch makes lto-dump the symtab callgraph in graphviz DOT format. Previously, the suggested patch had some minor and checkstyle issues that were fixed in this version. gcc/ChangeLog 2019-07-02 Giuliano Belinassi * cgraph.c (dump_graphviz): New function

Re: [PATCH] Make lto-dump dump symtab callgraph in graphviz format

2019-07-01 Thread Giuliano Belinassi
ange is less noisy because I just write the string with keeping in mind with what will be displayed in the terminal, and then print it. Of course this is my point of view and it is completely subjective. Any other style error suggested by the script were fixed. On 07/01, Martin Liška wrote: > On

Re: [PATCH] Make lto-dump dump symtab callgraph in graphviz format

2019-07-01 Thread Giuliano Belinassi
Hi, On 07/01, Martin Jambor wrote: > On Sat, Jun 29 2019, Giuliano Belinassi wrote: > > This patch makes lto-dump dump the symbol table callgraph in graphviz > > format. > > -ENOPATCH Sorry, I forgot the most important. Here it is. > > Martin > > > > &g

[PATCH] Make lto-dump dump symtab callgraph in graphviz format

2019-06-29 Thread Giuliano Belinassi
Giuliano Belinassi * cgraph.c (dump_graphviz): New function * cgraph.h (dump_graphviz): New function * symtab.c (dump_graphviz): New function * varpool.c (dump_graphviz): New function gcc/lto/ChangeLog 2019-06-29 Giuliano

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-06-19 Thread Giuliano Belinassi
Hi, Oh, I have completely forgotten about this patch On 06/19, Jeff Law wrote: > On 1/24/19 12:51 PM, Giuliano Belinassi wrote: > > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the

Re: [PATCH] Add simplification rule tanh (x) * cosh (x) -> sinh (x)

2019-05-04 Thread Giuliano Belinassi
Hi On 04/30, Jeff Law wrote: > On 4/30/19 8:00 AM, Jakub Jelinek wrote: > > On Tue, Apr 30, 2019 at 07:57:20AM -0600, Jeff Law wrote: > >>> Just curious, do we want to add math identities like above to match.pd ? > >> I'd think so. > >> > >> > >>> In practice, I am not sure how often we'd see "ta

Re: [PATCH] Fix PR89437

2019-02-21 Thread Giuliano Belinassi
I've just submitted a patch for this too :-P. Sorry about that. What is your nick in IRC, Wilco? On 02/21, Wilco Dijkstra wrote: > Fix PR89437. Fix the sinatan-1.c testcase to not run without > a C99 target system. Use nextafterl for long double initialization. > > Fix an issue with sinl (atan

[PATCH] Fix 89437, incorrect result for sinl ( atanl (x))

2019-02-21 Thread Giuliano Belinassi
A incorrect call to `nextafter` instead of `nextafterl` made the test `sinatan-1.c` pass, when it should have failed. The cause of the failure is pointed out in PR89437. This patch addresses the cause of failure, as well the issue in the test. gcc/ChangeLog: 2019-02-21 Giuliano Belinassi

Re: [PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-01-28 Thread Giuliano Belinassi
On 01/28, Richard Biener wrote: > On Thu, Jan 24, 2019 at 8:51 PM Giuliano Belinassi > wrote: > > > > This patch adds two variables named 'TV_CGRAPH_FUNC_EXPANSION' and > > 'TV_CGRAPH_IPA_PASSES' that count the elapsed time of the function

[PATCH] Wrap 'expand_all_functions' and 'ipa_passes' around timevars

2019-01-24 Thread Giuliano Belinassi
time when compiling the 'gimple-match.c' file, and therefore may also take a long time when compiling other large files. I also accept suggestions about how to improve this :-) ChangeLog: 2019-01-24 Giuliano Belinassi * cgraph_unit.c (compile): TV_CGRAPH_FUNC_EXPA

[PATCH] Update sinhatanh test

2019-01-10 Thread Giuliano Belinassi
Previously, the tests 'sinhatanh-2.c' and 'sinhatanh-3.c' did not count the number of functions found in the tree-dump. This patch address this issue. 2019-01-10 Giuliano Belinassi * gcc.dg/sinhatanh-2.c: Count the number of functions. * gcc.dg/sinhatanh-3

Re: [PATCH] Add sinh(tanh(x)) and cosh(tanh(x)) rules

2018-10-18 Thread Giuliano Belinassi
On 10/18, Jeff Law wrote: > On 10/17/18 4:21 PM, Giuliano Augusto Faulin Belinassi wrote: > > Oh, please note that the error that I'm talking about is the > > comparison with the result obtained before and after the > > simplification. It is possible that the result obtained after the > > simplific