Re: [PATCH 3/4] libbacktrace: work with aslr on windows

2023-01-21 Thread Gabriel Ravier via Gcc-patches
On 1/21/23 05:05, Eli Zaretskii wrote: Date: Fri, 20 Jan 2023 21:39:56 +0100 Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org From: Gabriel Ravier - using wide APIs with Windows is generally considered to be a best practice, even when not strictly needed (and in this case I can

Re: [PATCH 3/4] libbacktrace: work with aslr on windows

2023-01-20 Thread Gabriel Ravier via Gcc-patches
On 1/20/23 20:19, Eli Zaretskii wrote: Date: Fri, 20 Jan 2023 17:46:59 +0100 Cc: gcc-patches@gcc.gnu.org, g...@gcc.gnu.org From: Gabriel Ravier On 1/20/23 14:39, Eli Zaretskii via Gcc wrote: From: Björn Schäpers Date: Fri, 20 Jan 2023 11:54:08 +0100 @@ -856,7 +870,12 @@ coff_add (struct back

Re: [PATCH 3/4] libbacktrace: work with aslr on windows

2023-01-20 Thread Gabriel Ravier via Gcc-patches
On 1/20/23 14:39, Eli Zaretskii via Gcc wrote: From: Björn Schäpers Date: Fri, 20 Jan 2023 11:54:08 +0100 @@ -856,7 +870,12 @@ coff_add (struct backtrace_state *state, int descriptor, + (sections[i].offset - min_offset)); } - if (!backtrace_dwarf_add