Re: [PATCH] Fix crash with constant initializer caused by IPA

2025-06-01 Thread Eric Botcazou
es (once they reopen)? * tree-vect-data-refs.cc (vect_can_force_dr_alignment_p): Return false if the variable has no symtab node. -- Eric Botcazou diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index 9fd1ef29650..6e35f549a8c 100644 --- a/gcc/tree-vect-data-refs.cc +++

[PATCH] Fix crash with constant initializer caused by IPA

2025-05-29 Thread Eric Botcazou
at introduces a regression for g++.dg/ipa/devirt-39.C, because the vtable is preserved and in turn forces the method to be preserved, hence the special case for vtables. The test also renames the first process_references function in ipa.cc to clear the confusion with the second function in the

[Ada] Install ACATS 4.2 testsuite in acats-4 directory

2025-05-24 Thread Eric Botcazou
2578 # of unexpected failures0 Native configuration is x86_64-suse-linux-gnu Applied on the mainline. 2025-05-24 Eric Botcazou testsuite/ * ada/acats-4: Add ACATS 4.2 testsuite. -- Eric Botcazou

[Ada] Install ACATS 3.1 testsuite in acats-3 directory

2025-05-24 Thread Eric Botcazou
=== # of expected passes2421 # of unexpected failures0 Applied on the mainline. 2025-05-24 Eric Botcazou testsuite/ * ada/acats-3: Add ACATS 3.1 testsuite. -- Eric Botcazou

[Ada] Move ACATS 2.6 testsuite to acats-2 directory

2025-05-24 Thread Eric Botcazou
This is in preparation for the installation of the ACATS 4.2 testsuite. Tested on x86-64/Linux, applied on the mainline. 2025-05-24 Eric Botcazou ada/ * gcc-interface/Make-lang.in (ACATSDIR): Use acats-2 directory. testsuite/ * ada/acats/*: Rename into ada/acats-2

[testsuite] Remove obsolete ada/acats/overflow.lst file

2025-05-22 Thread Eric Botcazou
It is used to specify which files are compiled with -gnato, but the switch has been the default for at least a decade. Tested on x86-64/Linux, applied on the mainline. 2025-05-22 Eric Botcazou * ada/acats/overflow.lst: Delete. * ada/acats/run_all.sh: Do not process

[PATCH] Fix IPA-SRA issue with reverse SSO on specific pattern

2025-05-21 Thread Eric Botcazou
but the pattern is so specific, even in Ada, that patching earlier branches does not seem worth the hassle. 2025-05-21 Eric Botcazou * ipa-sra.cc (scan_expr_access): Also disqualify storage order barriers from splitting. * tree.h (storage_order_barrier_p): Al

Re: [PATCH] sparc: Avoid operandN variables in .md files

2025-05-21 Thread Eric Botcazou
> gcc/ > * config/sparc/sparc.md (zero_extendhisi2, zero_extendhidi2) > (extendhisi2, extendqihi2, extendqisi2, extendqidi2) > (extendhidi2): Use operands[0] and operands[1] instead of > operand0 and operand1. OK, thanks. -- Eric Botcazou

Re: [PATCH] Partially lift restriction from loc_list_from_tree_1

2025-05-18 Thread Eric Botcazou
> OK. Thanks. > Btw, can we try to add a "guality" for gnat.dg? Or are you making sure to > add coverage to the gdb testsuite? Yes, the GDB testsuite will get a testcase. -- Eric Botcazou

Re: [PATCH 1/4]middle-end: document pragma unroll n [PR116140]

2025-05-13 Thread Eric Botcazou
-funroll-loops either augment or use a multiple of the specified factor? -- Eric Botcazou

[PATCH] Partially lift restriction from loc_list_from_tree_1

2025-05-12 Thread Eric Botcazou
second part of the restriction, which helps for obscure cases of packed discriminated record types in Ada, although this requires the latest GDB sources. Tested on x86-64/Linux, OK for the mainline? 2025-05-12 Eric Botcazou * dwarf2out.cc (loc_list_from_tree_1) : Do not bail

[PATCH] Fix wrong optimization of complex boolean expression

2025-05-09 Thread Eric Botcazou
of vr-values.cc, leading to the same problematic outcome. Tested on x86-64/Linux, OK for the mainline, 15 and 14 branches? 2025-05-09 Eric Botcazou * vr-values.cc (simplify_using_ranges::simplify) : Do not call simplify_bit_ops_using_ranges for boolean types whos

[Ada] Fix PR ada/120104

2025-05-05 Thread Eric Botcazou
. 2025-05-05 Eric Botcazou PR ada/120104 * exp_ch3.adb (Expand_Freeze_Record_Type): For a controlled tagged type, freeze only the controlled primitives that are present. 2025-05-05 Eric Botcazou * gnat.dg/specs/finalizable1.ads: New test. -- Eric Botcazoudiff

[Ada] Fix PR ada/112958

2025-04-30 Thread Eric Botcazou
This fixes the long-standing build failure of GNAT for x86/FreeBSD. Applied on all active branches. 2025-04-30 Eric Botcazou PR ada/112958 * Makefile.rtl (LIBGNAT_TARGET_PAIRS) [x86 FreeBSD]: Add specific version of s-dorepr.adb. * libgnat/s

Re: [PATCH] gcc: For Windows x86-32, always attempt to realign stack regardless of SSE

2025-04-27 Thread Eric Botcazou
t; * config/i386/cygming.h (STACK_REALIGN_DEFAULT): Copy from sol2.h. FWIW looks good to me. -- Eric Botcazou

Re: [PATCH] Fix wrong optimization of conditional expression with enumeration type

2025-04-18 Thread Eric Botcazou
> I'd reword this to > > "Similarly, TYPE_UNSIGNED is false for components of vector masks and > possibly for boolean types in languages other than C." > > That is, the C/middle-end boolean_type_node is always unsigned. OK, thanks, I have installed the attached patch. -- Eric Botcazoudiff --gi

Re: [PATCH] Fix wrong optimization of conditional expression with enumeration type

2025-04-17 Thread Eric Botcazou
ents of vector masks, + although it is believed to be true for all boolean types built in the + front-ends of the various languages. */ DEFTREECODE (BOOLEAN_TYPE, "boolean_type", tcc_type, 0) /* Integer types in all languages, including char in C. -- Eric Botcazou

Re: [PATCH] Fix wrong optimization of conditional expression with enumeration type

2025-04-17 Thread Eric Botcazou
tcc_type, 0) /* Integer types in all languages, including char in C. -- Eric Botcazou

[PATCH] Fix wrong optimization of conditional expression with enumeration type

2025-04-16 Thread Eric Botcazou
Botcazou * tree-ssa-phiopt.cc (factor_out_conditional_operation): Do not bypass the int_fits_type_p test for boolean types whose precision is not 1. 2025-04-15 Eric Botcazou * gnat.dg/opt105.adb: New test. * gnat.dg/opt105_pkg.ads, gnat.dg/opt105_pkg.adb

Fix PR lto/119792

2025-04-14 Thread Eric Botcazou
branch), where the change is equally problematic, until a way out is devised for Ada. Tested on x86-64/Linux, applied on the 14 branch. 2025-04-14 Eric Botcazou PR lto/119792 Revert Backported from master: 2024-12-12 Martin Uecker PR c/113688

[Ada] Fix PR ada/119643

2025-04-12 Thread Eric Botcazou
to the wrong conclusion that it does not. Tested on x86-64/Linux, applied on the mainline. 2025-04-12 Eric Botcazou PR ada/119643 * sem_ch8.adb (Inherit_Renamed_Profile): Add guard against the peculiarities of Natural and Positive. 2025-04-12 Eric Botcazou

[PATCH] Fix PR target/119673

2025-04-11 Thread Eric Botcazou
Hi, this applies the same magic to config/i386/gthr-win32.h that was applied to gthr-posix.h (https://gcc.gnu.org/cgit/gcc/commit/?id=6a4d1c374eed17) for the sake of C++ modules (thanks to Andrew for the pointer!). Built for {i686,x86_64}-w64-mingw32, OK for the mainline? 2025-04-11 Eric

Re: [COMMITTED] gcc-15/changes: Document Ada changes

2025-04-08 Thread Eric Botcazou
> Thanks Fernando, Seconded. > I've pushed the attached changes. I have made a few subsequent tweaks (attached). -- Eric Botcazou diff --git a/htdocs/gcc-15/changes.html b/htdocs/gcc-15/changes.html index 8220d130..e29fca9d 100644 --- a/htdocs/gcc-15/changes.html +++ b/ht

[Ada] Fix wrong 'Access to aliased constrained array of controlled type

2025-04-07 Thread Eric Botcazou
ys is pointer-to-constrained-array and, therefore, its value must designate the array itself and not the bounds. Tested on x86-64/Linux, applied on the mainline (branches are not affected). 2025-04-07 Eric Botcazou ada/ * gcc-interface/utils.cc (convert) : Use fold_convert

Re: [PATCH] Further use of mod_scope in modified_type_die

2025-04-05 Thread Eric Botcazou
> Let's involve Eric here, I have no idea what was intended here. We discussed it with Tom internally and he makes the final decisions here. -- Eric Botcazou

Re: [PATCH] cse: Fix up delete_trivially_dead_insns [PR119594]

2025-04-04 Thread Eric Botcazou
if there is no previous use of REG: case REG: if (x == dest) { if (incr > 0 && counts[REGNO (x)] != 0) counts[REGNO (x)] += incr; } else counts[REGNO (x)] += incr; return; IIUC this would both fix the bug and preserve the deletion if insn 26 and 27 are swapped. -- Eric Botcazou

Re: [PATCH] cse: Fix up delete_trivially_dead_insns [PR119594]

2025-04-04 Thread Eric Botcazou
in the RTL stream, which is precisely the case that we may lead to wrong code. -- Eric Botcazou

[Ada] Fix thinko in Eigensystem for complex Hermitian matrices

2025-04-04 Thread Eric Botcazou
throughout the implementation, mostly in the commentary and without functional changes. Tested on x86-64/Linux, applied on all active branches. 2025-04-04 Eric Botcazou ada/ * libgnat/a-ngcoar.adb (Eigensystem): Adjust notation and fix the layout of the real symmetric matrix in

Fix too late initialization of tasking runtime with standalone library

2025-03-27 Thread Eric Botcazou
is idempotent. Tested on x86-64/Linux, applied on the mainline (branches are not affected). 2025-03-27 Eric Botcazou ada/ * libgnarl/s-tasini.adb (Tasking_Runtime_Initialize): Add pragma Linker_Constructor for the procedure. -- Eric Botcazoudiff --git a/gcc/ada

[Ada] Fix formatting of version message for gnat driver

2025-03-19 Thread Eric Botcazou
Like the main driver (as well as gccgo, gccrs, gcov, etc) the gnat driver prints the standard version message in response to the --version switch, but it is not properly formatted. Tested on x86-64/Linux, applied on the mainline. 2025-03-19 Eric Botcazou * gnatvsn.adb

[Ada] Fix misoptimization at -O2 in LTO mode

2025-03-19 Thread Eric Botcazou
mainline, 14 and 13 branches. 2025-03-19 Eric Botcazou * gcc-interface/decl.cc (gnat_to_gnu_entity) : Set the may_alias attribute if a specific GCC type is built. -- Eric Botcazoudiff --git a/gcc/ada/gcc-interface/decl.cc b/gcc/ada/gcc-interface/decl.cc index 1854c587543

[Ada] Fix spurious visibility error with partially parameterized formal package

2025-03-19 Thread Eric Botcazou
internal to Instantiate_Formal_Package, where a specific construct (the abbreviated instance) built for the nested formal package discombobulates the processing done for the outer formal package. Tested on x86-64/Linux, applied on the mainline, 14 and 13 branches. 2025-03-19 Eric Botcazou

[c-family] Fix PR ada/119265

2025-03-13 Thread Eric Botcazou
This plugs a small loophole in the pattern matching done by -fdump-ada-spec. Tested on x86-64/Linux, applied on mainline, 14 and 13 branches. 2025-03-13 Eric Botcazou PR ada/119265 * c-ada-spec.cc (dump_ada_node) : Deal with typedefs of unsigned __int128. -- Eric

Re: [PATCH] ifcvt: Fix ICE with (fix:SI (fix:DF (reg:DF))) [PR117712]

2025-02-28 Thread Eric Botcazou
tophe > tested this on arm, ok for trunk? > > 2025-02-27 Jakub Jelinek > > PR rtl-optimization/117712 > * expr.cc (force_operand): Handle {,UNSIGNED_}FIX with > FIX operand using expand_fix on the inner FIX operand. > > * gcc.dg/pr117712.c: New test. Looks good to me, thanks. -- Eric Botcazou

Re: [PATCH] arm: Remove inner 'fix:HF/SF/DF' from fixed-point patterns (PR 117712)

2025-02-19 Thread Eric Botcazou
from the middle-end change and papering over it in various back-ends should be the very last resort solution. -- Eric Botcazou

Re: [PATCH] i386: Change RTL representation of bt[lq] [PR118623]

2025-02-10 Thread Eric Botcazou
es the former variant with the CCC & CCXC modes. -- Eric Botcazou

Re: [PATCH] [testsuite] [sparc] select ultrasparc for fsmuld test

2025-02-06 Thread Eric Botcazou
also tested with gcc-14 targeting > leon3-elf with -mfix-ut699. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.target/sparc/vis3move-3.c: Select ultrasparc. Skip with > -mfix-ut699. OK. -- Eric Botcazou

Re: [PATCH] [testsuite] [sparc] skip sparc-ret-1 with -mfix-ut699

2025-02-06 Thread Eric Botcazou
99. Ok to install? > > > for gcc/testsuite/ChangeLog > > * gcc.target/sparc/sparc-ret-1.c: Skip on -mfix-ut699. OK. -- Eric Botcazou

Re: [PATCH] [testsuite] [sparc] skip tls tests if emulated

2025-02-06 Thread Eric Botcazou
* gcc.target/sparc/tls-ld-uint32.c: Likewise. > * gcc.target/sparc/tls-ld-uint8.c: Likewise. OK. -- Eric Botcazou

Re: [PATCH] [testsuite] [sparc] use -mtune in alignment tuning test

2025-02-06 Thread Eric Botcazou
gara7-align.c: Use -mtune. OK. -- Eric Botcazou

[Ada] Fix PR ada/118731

2025-02-04 Thread Eric Botcazou
It's just a missing test for the presence of a nonempty parameter. Tested on x86-64/Linux, applied on the mainline. 2025-02-04 Eric Botcazou PR ada/118731 * sem_aggr.adb (Resolve_Iterated_Association): Add missing guard. -- Eric Botcazoudiff --git a/gcc/ada/sem_aggr.

[Ada] Fix PR ada/118712

2025-02-01 Thread Eric Botcazou
branches. 2025-02-01 Eric Botcazou PR ada/118712 * sem_warn.adb (Check_References): Deal with small adjustments of references. 2025-02-01 Eric Botcazou * gnat.dg/warn33.adb: New test. * gnat.dg/warn33_pkg.ads: New helper. -- Eric Botcazoudiff --git a

Re: [PATCH 28/61] Fix wrong instruction in the delay slot

2025-02-01 Thread Eric Botcazou
n't ignore the empty > block when searching for the next active instruction. -- Eric Botcazou

[Ada] Fix wrong elaboration for allocator at library level of dynamic library

2025-01-31 Thread Eric Botcazou
The problem was preexisting for class-wide allocators, but now occurs for allocators of controlled types on the mainline, because of the recent overhaul of the finalization machinery. Tested on x86-64/Linux, applied on the mainline. 2025-01-31 Eric Botcazou * gcc-interface

Re: [COMMITTED] Regenerate sparc.opt.urls

2025-01-20 Thread Eric Botcazou
> things up. Indeed, I did not notice that the bot's outcome was "failed", thanks. -- Eric Botcazou

Re: [COMMITTED] Regenerate sparc.opt.urls

2025-01-19 Thread Eric Botcazou
> sparc added a -mvis3b option, but the sparc.opt.url file wasn't > regenerated. > > Fixes: d309844d6fe0 ("Fix bootstrap failure on SPARC with -O3 > -mcpu=niagara4") Thanks, but how is one supposed to detect this? Everything worked fine. -- Eric Botcazou

[Ada] Fix PR ada/118459

2025-01-14 Thread Eric Botcazou
This adds the missing support for the S/390 and RISC-V architectures to the object file reader present in the run-time library, fixing the regression. Tested on x86-64/Linux, applied on the mainline. 2025-01-13 Eric Botcazou PR ada/118459 * libgnat/s-objrea.ads (Object_Arch

Re: [PATCH] dwarf2out: Emit DWARF 6 DW_AT_language_{name,version}

2025-01-08 Thread Eric Botcazou
salvage the non-obsoleted parts of the above change? -- Eric Botcazou

Re: [Ada] Fix PR ada/118247

2025-01-07 Thread Eric Botcazou
eak something, so the simpler, the better. -- Eric Botcazou

[Ada] Fix PR ada/118247

2025-01-06 Thread Eric Botcazou
This is a regression introduced by https://gcc.gnu.org/pipermail/gcc-cvs/2024-July/405522.html in the form of a spurious relinking of the gnatbind executable for the install target of cross Ada compilers. Tested on x86-64/Linux, applied on the mainline. 2025-01-06 Eric Botcazou

[Ada] Fix PR ada/117936

2025-01-05 Thread Eric Botcazou
This just aligns the documentation with the code. Tested with 'make doc', applied on the mainline. 2025-01-06 Eric Botcazou PR ada/117936 * doc/gnat_rm/implementation_defined_pragmas.rst (Unimplemented_Unit): Adjust the description of the err

Re: [PATCH] Ada: Fix build for dummy s-taprop

2025-01-05 Thread Eric Botcazou
ful for bringing up a new target. Thanks, patch applied on all active branches although it lacks a Changelog: * libgnarl/s-taprop__dummy.adb: Remove use clause for System.Parameters. (Unlock): Remove Global_Lock formal parameter. (Write_Lock): Likewise. -- Eric Botcazou

Re: [PATCH 2/2] Ada: Fix GNU/Hurd maximum priority

2024-12-22 Thread Eric Botcazou
> gcc/ada/ChangeLog: > > * libgnat/system-gnu.ads: Set Max_Priority to 60. Likewise. -- Eric Botcazou

Re: [PATCH 1/2] Ada: Add GNU/Hurd glibc api bits

2024-12-22 Thread Eric Botcazou
_sigset. > [__GNU__]: Define PTHREAD_*SIZE Thanks, applied. -- Eric Botcazou

[SPARC] Fix PR target/118096

2024-12-18 Thread Eric Botcazou
This replaces the use of FAIL in the new vec_cmp[u] expanders by that of a predicate for the operator, which is (apparently) required for the optabs machinery to properly compute the set of supported vector comparisons. Tested on SPARC64/Solaris 11.4, applied on the mainline. 2024-12-18 Eric

Re: [PATCH v3] ada: PR target/117538 Traceback includes load address if executable is PIE.

2024-12-18 Thread Eric Botcazou
gt; > gcc/ada/Changelog: > > PR target/117538 > * libgnat/s-trasym.adb: Returns the traceback, with the program load address > if available. This is OK, thanks. Do you want me to apply it? -- Eric Botcazou

[Ada] Fix PR ada/117996

2024-12-12 Thread Eric Botcazou
This fixes a precondition failure triggered when the Eigenvalues routine of Ada.Numerics.Generic_Real_Arrays is instantiated with -gnata, beause it calls Sort_Eigensystem on an empty vector. Tested on x86-64/Linux, applied on all active branches. 2024-12-12 Eric Botcazou PR ada

Re: [PATCHv4 0/3] ada: Add GNU/Hurd x86_64 support

2024-12-11 Thread Eric Botcazou
> Yes, please, I don't have commit access. OK, done. -- Eric Botcazou

Re: [PATCHv4 0/3] ada: Add GNU/Hurd x86_64 support

2024-12-11 Thread Eric Botcazou
> Difference with v3: Refresh > > Samuel Thibault (3): > ada: Factorize bsd signal definitions > ada: Fix GNU/Hurd priority range > ada: Add GNU/Hurd x86_64 support Thanks, this looks good to me. Do you need me to merge it? -- Eric Botcazou

Re: [PATCHv3 3/3] ada: Add GNU/Hurd x86_64 support

2024-12-10 Thread Eric Botcazou
NIX_PAIRS) and the associated $(TRASYM_DWARF_UNIX_OBJS). -- Eric Botcazou

[SPARC] Add functional comments for VIS4B instructions

2024-12-07 Thread Eric Botcazou
Applied on the mainline. 2024-12-07 Eric Botcazou * config/sparc/sparc.md (VIS4B instructions): Add comments. -- Eric Botcazoudiff --git a/gcc/config/sparc/sparc.md b/gcc/config/sparc/sparc.md index 5fd18b3ca27..159518d4b8f 100644 --- a/gcc/config/sparc/sparc.md +++ b/gcc/config

Re: [PATCH v6 2/7] Drop targetm.promote_prototypes from C, C++ and Ada frontends

2024-12-06 Thread Eric Botcazou
> I'm conditionally approving this unless FE maintainers complain before > holidays (the effect of the hook is re-instantiated during RTL expansion in > 1/7). FWIW I'm all for removing this piece of code from FEs. -- Eric Botcazou

[SPARC] Fix PR target/117715

2024-11-24 Thread Eric Botcazou
the mnemonics to the version documented in the Oracle SPARC architecture 2015. Bootstrapped/regtested on SPARC64/Solaris 10.4, applied on the mainline. 2024-11-24 Eric Botcazou PR target/117715 * config/sparc/sparc-protos.h (sparc_expand_vcond): Rename to

Re: Ping [PATCH] ada: PR target/117538 Traceback includes load address if executable is PIE.

2024-11-23 Thread Eric Botcazou
t please remove the part fiddling with zeros and just concentrate on printing the load address. -- Eric Botcazou

[PATCH] Adjust error message for initialized variable in .bss

2024-11-22 Thread Eric Botcazou
default setting in Ada is -fno-zero-initialized-in-bss instead of -fzero-initialized-in-bss. Tested on x86-64/Linux, OK for the mainline? 2024-11-22 Eric Botcazou * doc/invoke.texi (-fno-zero-initialized-in-bss): Adjust for Ada. * arasm.cc (get_variable_section): Adjust t

[Ada] Enable symbolic backtraces on more Linux and BSD ports

2024-11-19 Thread Eric Botcazou
This enables symbolic backtraces on the ports listed in the Changelog. Applied on the mainline. 2024-11-19 Eric Botcazou PR ada/117538 * Makefile.rtl (GNU Hurd): Add $(TRASYM_DWARF_UNIX_OBJS). (x86-64 kfreebsd): Likewise. (aarch64 FreeBSD): Likewise

Re: [PATCH] ipa-cp: Fix constant dumping

2024-11-14 Thread Eric Botcazou
what was) an > print_ipcp_constant_value overload for polymorphic contexts which are > constructible from trees, so the source compiles, but of course are not > what we want. Another misfeature of C++ indeed! Thanks for fixing the problem. -- Eric Botcazou

[Ada] Backport fix for internal compiler error

2024-11-04 Thread Eric Botcazou
backported it onto the active release branches. -- Eric Botcazou

Re: [PATCH] match: Fix `a != 0 ? a - 1 : 0` pattern [PR117363]

2024-11-03 Thread Eric Botcazou
> --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -3396,10 +3396,11 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > simplify (X != 0 ? X + ~0 : 0) to (X - X != 0). */ The rightmost ( in the comment should be moved 2 tokens right. -- Eric Botcazou

Re: [PATCH] function: Call do_pending_stack_adjust in assign_parms [PR117296]

2024-10-30 Thread Eric Botcazou
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2024-10-30 Jakub Jelinek > > PR target/117296 > * function.cc (assign_parms): Call do_pending_stack_adjust. > > * gcc.target/i386/pr117296.c: New test. Looks good to me. -- Eric Botcazou

Fix PR rtl-optimization/117327

2024-10-29 Thread Eric Botcazou
moves the associated two lines of code: else if (LABEL_P (insn)) *plabel = as_a (insn); and otherwise contains just adjustments to the commentary. Bootstrapped/regtested on SPARC64/Solaris and applied on all active branches. 2024-10-29 Eric Botcazou PR rtl-optimizat

[Ada] Fix PR ada/62122

2024-10-26 Thread Eric Botcazou
This is an old glitch in the GNAT RM. Tested on x86-64/Linux, applied on the mainline. 2024-10-26 Eric Botcazou PR ada/62122 * doc/gnat_rm/implementation_defined_attributes.rst (Unrestricted_Access): Remove null exclusion. * gnat_rm.texi: Regenerate

Re: [PATCH] sparc: drop -mlra

2024-10-16 Thread Eric Botcazou
OK, thanks! (modulo the blank line in the ChangeLog) -- Eric Botcazou

ping: [PATCH] Fix crash with constant initializer

2024-10-13 Thread Eric Botcazou
The original submission patch is at: https://gcc.gnu.org/pipermail/gcc-patches/2024-September/664127.html Thanks in advance. -- Eric Botcazou

[Ada] Remove support for HP-UX 10

2024-10-09 Thread Eric Botcazou
The support was removed from the rest of the compiler two years ago. Applied on the mainline. 2024-10-09 Eric Botcazou * Makefile.rtl: Remove HP-UX 10 section. * libgnarl/s-osinte__hpux-dce.ads: Delete. * libgnarl/s-osinte__hpux-dce.adb: Likewise. * libgnarl

[Ada] PR ada/117038

2024-10-09 Thread Eric Botcazou
applied on the mainline. 2024-10-09 Eric Botcazou PR ada/117038 * fe.h (struct c_array): Add 'const' to declaration of pointer. (C_Source_Buffer): Use consistent formatting. * par-ch3.adb (P_Component_Items): Properly set Aliased_Present on

Re: [PING] [PATCH] i386: Implement Thread Local Storage on Windows

2024-10-08 Thread Eric Botcazou
By comparing what happens in 32-bit and 64-bit modes: the 32-bit code is !PIC whereas the 64-bit is PIC internally, so the processing in the various hooks legitimate_* and legitimize_* is subtly different between them. Anyway, let's continue the discussion in the audit trail of PR target/80881. -- Eric Botcazou

Re: [PING] [PATCH] i386: Implement Thread Local Storage on Windows

2024-10-07 Thread Eric Botcazou
can reproduce this at -O0: _gcov_indirect_call_profiler_v4.s: Assembler messages: _gcov_indirect_call_profiler_v4.s:288: Error: 4-byte relocation cannot be applied to 8-byte field but not at -O1 or -O2. -- Eric Botcazou

Re: [PING] [PATCH] i386: Implement Thread Local Storage on Windows

2024-10-07 Thread Eric Botcazou
Pmode, since the emitted assembly is broken when I > do that) Do you have a testcase for this particular issue? -- Eric Botcazou

Re: [PING] [PATCH] i386: Implement Thread Local Storage on Windows

2024-10-06 Thread Eric Botcazou
> Pinging https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662860.html > as it has been buried under several other patches. Is the patch ok for > master? No, you should modify it along the way I suggested privately, and a blocker is the missing support in the linker AFAICS.

[PATCH] Fix PR middle-end/116933

2024-10-05 Thread Eric Botcazou
. - the machinery attempts to initialize Out parameters, which is problematic. Tested on x86-64/Linux, OK for the mainline? 2024-10-05 Eric Botcazou PR middle-end/116933 * gimplify.cc (gimple_add_init_for_auto_var): Use the correct macro to fetch the source location of

[Ada] Fix PR ada/116430

2024-10-04 Thread Eric Botcazou
, applied on the 14 branch only. 2024-10-04 Eric Botcazou PR ada/116430 * exp_ch7.adb (Build_Finalizer.Create_Finalizer): For the insertion point of the finalizer, deal with package bodies that are subunits. -- Eric Botcazoudiff --git a/gcc/ada/exp_ch7.adb b/gcc/ada

[PATCH] Aarch64: Change stack checking method on Linux

2024-10-01 Thread Eric Botcazou
. Bootstrapped/regtested on Aarch64/Linux, OK for the mainline? 2024-10-01 Eric Botcazou * config/aarch64/aarch64-linux.h (STACK_CHECK_MOVING_SP): Define to 1. * config/aarch64/aarch64-protos.h (do_stack_clash_protection): Declare. * config/aarch64/aarch64.h

[PATCH] Aarch64: Define WIDEST_HARDWARE_FP_SIZE

2024-10-01 Thread Eric Botcazou
__multf3 U __trunctfsf2 to just T __floattisf The effect of the change on the second place can be seen on the attached Ada testcase, which fails without it and passes with it. Bootstrapped/regtested on Aarch64/Linux, OK for the mainline? 2024-10-01 Eric Botcaz

[PATCH] Fix wrong code out of NRV + RSO + inlining (take 2)

2024-10-01 Thread Eric Botcazou
during inlining. Tested on x86-64/Linux, OK for the mainline? 2024-10-01 Eric Botcazou * tree-inline.cc (expand_call_inline): Remove the store to the return slot if it is a global variable that is only written to. 2024-10-01 Eric Botcazou * gnat.dg/lto28.adb:

[PATCH] Fix crash with constant initializer

2024-09-30 Thread Eric Botcazou
at introduces a regression for g++.dg/ipa/devirt-39.C, because the vtable is preserved and in turn forces the method to be preserved, hence the special case for vtables. The test also renames the first process_references function in ipa.cc to clear the confusion with the second function in the

[PATCH] Fix small thinko in IPA mod/ref pass

2024-09-20 Thread Eric Botcazou
, if both the load and the store are made through the same SSA name, the store is overlooked. Tested on x86-64/Linux, OK for all active branches? 2024-09-20 Eric Botcazou * ipa-modref.cc (modref_eaf_analysis::analyze_ssa_name): Always process both the load and the store of a

Re: [PATCH] Fix wrong code out of NRV + RSO + inlining

2024-09-11 Thread Eric Botcazou
ed LHS? But NRV is only an example and not necessary, as you may read a RESULT_DECL in the callee. So the combination is actually just RSO + inlining if the callee happens to read RESULT_DECL. -- Eric Botcazou

[PATCH] Fix wrong code out of NRV + RSO + inlining

2024-09-11 Thread Eric Botcazou
from that point on. The proposed fix is to always clear the flag during inlining in the RSO case. Tested on x86-64/Linux, OK for the mainline? 2024-09-11 Eric Botcazou * tree-inline.cc (declare_return_variable): Clear writeonly flag on a global variable used directly as the

Re: [PATCH] ada: Fix gcc-interface/misc.cc compilation on SPARC

2024-09-06 Thread Eric Botcazou
> commit 72c6938f29cbeddb3220720e68add4cf09ffd794 > Author: Eric Botcazou > Date: Sun Aug 25 15:20:59 2024 +0200 > > ada: Streamline handling of low-level peculiarities of record field > layout > > broke the Ada build on SPARC: > > In

Re: [PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
nch) so any additional path would be uncovered. If we have evidences that it's not sufficient, then I'm ready to amend it, but at the moment it would be a bit of a shot in the dark. -- Eric Botcazou

[PATCH] Fix gimplification of ordering comparisons of arrays of bytes

2024-07-08 Thread Eric Botcazou
or aggregate types whose mode is not BLKmode and this processing deviates from the memcmp semantics when the target is little-endian. Tested on x86-64/Linux, OK for the mainline? 2024-07-08 Eric Botcazou * gimplify.cc (gimplify_scalar_mode_aggregate_compare): Add support

[RISC-V] Fix PR target/115591

2024-07-06 Thread Eric Botcazou
This is an ICE in the RISC-V back-end calling tree_to_uhwi on the DECL_SIZE of a global variable-length array. Fixed thusly, tested and approved by Jeff in the audit trail, and applied on the mainline. 2024-07-06 Eric Botcazou PR target/115591 * config/riscv/riscv.cc

Re: [PATCH] sparc: define SPARC_LONG_DOUBLE_TYPE_SIZE for vxworks [PR115739]

2024-07-02 Thread Eric Botcazou
> PR target/115739 > > gcc/ChangeLog: > > * config/sparc/vxworks.h (SPARC_LONG_DOUBLE_TYPE_SIZE): New define. OK, thanks! -- Eric Botcazou

Re: [PATCH] libffi: Fix 32-bit SPARC structure passing [PR115681]

2024-07-01 Thread Eric Botcazou
for trunk? Sure, thanks! -- Eric Botcazou

[SPARC] Fix PR target/115608

2024-06-25 Thread Eric Botcazou
This passes -m32 when -mv8plus is specified on Linux (like on Solaris). Applied to mainline and 14 branch. 2024-06-25 Eric Botcazou PR target/115608 * config/sparc/linux64.h (CC1_SPEC): Pass -m32 for -mv8plus. -- Eric Botcazoudiff --git a/gcc/config/sparc/linux64.h b/gcc

[c-family] Add minimal support for __bf16 to -fdump-ada-spec

2024-06-17 Thread Eric Botcazou
Tested on x86-64/Linux, applied on the mainline. 2024-06-17 Eric Botcazou c-family/ * c-ada-spec.cc (is_float16): New predicate. (dump_ada_node) : Call it. -- Eric Botcazoudiff --git a/gcc/c-family/c-ada-spec.cc b/gcc/c-family/c-ada-spec.cc index a41e93aeafb..e1b1b2a4b73

[PATCH] Implement wrap-around arithmetics in DWARF expressions

2024-06-03 Thread Eric Botcazou
sons in DWARF for the case where the type is smaller than the "generic type", as is the case here. Tested on x86-64/Linux, OK for the mainline? 2024-06-03 Eric Botcazou * dwarf2out.cc (loc_list_from_tree_1) ; Add const. : Use a signed comparison for small unsigned t

Re: [PATCH 51/52] sparc: New hook implementation sparc_c_mode_for_floating_type

2024-06-03 Thread Eric Botcazou
is for long double type, go with the > + default one for the others. */ > + > +static machine_mode > +sparc_c_mode_for_floating_type (enum tree_index ti) > +{ > + if (ti == TI_LONG_DOUBLE_TYPE) > +return SPARC_LONG_DOUBLE_TYPE_SIZE == 128 ? TFmode : DFmode; > + return

Re: [PATCH 01/52] ada: Replace use of LONG_DOUBLE_TYPE_SIZE

2024-06-03 Thread Eric Botcazou
cl.cc (gnat_to_gnu_entity): Use TYPE_PRECISION of > long_double_type_node to replace LONG_DOUBLE_TYPE_SIZE. OK, thanks. -- Eric Botcazou

  1   2   3   4   5   6   7   8   9   10   >