Re: [PATCH][PING] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2015-01-05 Thread Dimitris Papavasiliou
Ping! On 12/24/2014 07:28 PM, Dimitris Papavasiliou wrote: Hello, The attached patch fixes an issue reported a couple of years ago in Bug 51891 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51891). The problem is caused because classes without instance variables have no ivar list at all, so

[PATCH] libobjc: Properly handle classes without instance variables in class_copyIvarList ().

2014-12-24 Thread Dimitris Papavasiliou
test-case for this issue. I think that the ChangeLog entry should be something along the lines of: 2014-12-24 Dimitris Papavasiliou PR libobjc/51891 * libobjc/ivars.c: Add a check for classes without instance variables, which have a NULL ivar list pointer

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-13 Thread Dimitris Papavasiliou
On 05/12/2014 11:53 PM, Mike Stump wrote: I put in one small fix: Doing diffs in testsuite/objc.dg/ivar-visibility-4.m.~1~: --- testsuite/objc.dg/ivar-visibility-4.m.~1~ 2014-05-12 12:04:16.0 -0700 +++ testsuite/objc.dg/ivar-visibility-4.m 2014-05-12 13:50:53.0 -0700 @@

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Dimitris Papavasiliou
On 05/12/2014 07:24 PM, Mike Stump wrote: On Apr 28, 2014, at 3:35 AM, Dimitris Papavasiliou wrote: + a = private;/* { dg-warning "hides instance variable" "" { xfail *-*-* } } */ + a = protected; /* { dg-warning "hides instance variable" "&q

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Dimitris Papavasiliou
Ping! On 05/05/2014 10:35 AM, Dimitris Papavasiliou wrote: Ping! On 04/28/2014 01:35 PM, Dimitris Papavasiliou wrote: On 04/25/2014 07:50 PM, Mike Stump wrote: On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou wrote: --Wreturn-type -Wsequence-point -Wshadow @gol +-Wreturn-type -Wsequence

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-05 Thread Dimitris Papavasiliou
Ping! On 04/28/2014 01:35 PM, Dimitris Papavasiliou wrote: On 04/25/2014 07:50 PM, Mike Stump wrote: On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou wrote: --Wreturn-type -Wsequence-point -Wshadow @gol +-Wreturn-type -Wsequence-point -Wshadow -Wshadow-ivar @gol This has to be -Wno

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-28 Thread Dimitris Papavasiliou
On 04/25/2014 07:50 PM, Mike Stump wrote: On Apr 25, 2014, at 9:34 AM, Dimitris Papavasiliou wrote: --Wreturn-type -Wsequence-point -Wshadow @gol +-Wreturn-type -Wsequence-point -Wshadow -Wshadow-ivar @gol This has to be -Wno-shadow-ivar, we document the non-default… +@item -Wshadow

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-25 Thread Dimitris Papavasiliou
On 04/25/2014 04:07 AM, Mike Stump wrote: On Apr 24, 2014, at 4:09 PM, Dimitris Papavasiliou wrote: On 04/24/2014 07:00 PM, Mike Stump wrote: On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: This is a patch regarding a couple of Objective-C related dialect options and warning

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-25 Thread Dimitris Papavasiliou
On 04/25/2014 03:54 AM, Mike Stump wrote: On Apr 24, 2014, at 4:16 PM, Dimitris Papavasiliou wrote: On 04/24/2014 11:17 PM, Jakub Jelinek wrote: How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 39) +FAIL: obj-c++.dg/local-d

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
On 04/24/2014 11:17 PM, Jakub Jelinek wrote: How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 39) +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 41) +FAIL: obj-c++.dg/private-2.mm -fgnu-runtime (test for

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
On 04/24/2014 07:00 PM, Mike Stump wrote: On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: This is a patch regarding a couple of Objective-C related dialect options and warning switches. Ok. Committed revision 209753. If you could, please add documentation and a test case

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
Ping! Does anybody know the current record of longest ping? I'd like to at least break it before giving up. On 04/03/2014 06:32 PM, Dimitris Papavasiliou wrote: Still pinging. On 03/28/2014 11:58 AM, Dimitris Papavasiliou wrote: Ping! On 03/23/2014 03:20 AM, Dimitris Papavasiliou

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-03 Thread Dimitris Papavasiliou
Still pinging. On 03/28/2014 11:58 AM, Dimitris Papavasiliou wrote: Ping! On 03/23/2014 03:20 AM, Dimitris Papavasiliou wrote: Ping! On 03/13/2014 11:54 AM, Dimitris Papavasiliou wrote: Ping! On 03/06/2014 07:44 PM, Dimitris Papavasiliou wrote: Ping! On 02/27/2014 11:44 AM, Dimitris

Re: [PING^7][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-03-28 Thread Dimitris Papavasiliou
Ping! On 03/23/2014 03:20 AM, Dimitris Papavasiliou wrote: Ping! On 03/13/2014 11:54 AM, Dimitris Papavasiliou wrote: Ping! On 03/06/2014 07:44 PM, Dimitris Papavasiliou wrote: Ping! On 02/27/2014 11:44 AM, Dimitris Papavasiliou wrote: Ping! On 02/20/2014 12:11 PM, Dimitris Papavasiliou

Re: [PING^6][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-03-22 Thread Dimitris Papavasiliou
Ping! On 03/13/2014 11:54 AM, Dimitris Papavasiliou wrote: Ping! On 03/06/2014 07:44 PM, Dimitris Papavasiliou wrote: Ping! On 02/27/2014 11:44 AM, Dimitris Papavasiliou wrote: Ping! On 02/20/2014 12:11 PM, Dimitris Papavasiliou wrote: Hello all, Pinging this patch review request again

Re: [PING^4][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-03-13 Thread Dimitris Papavasiliou
Ping! On 03/06/2014 07:44 PM, Dimitris Papavasiliou wrote: Ping! On 02/27/2014 11:44 AM, Dimitris Papavasiliou wrote: Ping! On 02/20/2014 12:11 PM, Dimitris Papavasiliou wrote: Hello all, Pinging this patch review request again. See previous messages quoted below for details. Regards

Re: [PING^4][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-03-06 Thread Dimitris Papavasiliou
Ping! On 02/27/2014 11:44 AM, Dimitris Papavasiliou wrote: Ping! On 02/20/2014 12:11 PM, Dimitris Papavasiliou wrote: Hello all, Pinging this patch review request again. See previous messages quoted below for details. Regards, Dimitris On 02/13/2014 04:22 PM, Dimitris Papavasiliou wrote

Re: [PING^3][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-02-27 Thread Dimitris Papavasiliou
Ping! On 02/20/2014 12:11 PM, Dimitris Papavasiliou wrote: Hello all, Pinging this patch review request again. See previous messages quoted below for details. Regards, Dimitris On 02/13/2014 04:22 PM, Dimitris Papavasiliou wrote: Hello, Pinging this patch review request. Can someone

Re: [PING^2][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-02-20 Thread Dimitris Papavasiliou
Hello all, Pinging this patch review request again. See previous messages quoted below for details. Regards, Dimitris On 02/13/2014 04:22 PM, Dimitris Papavasiliou wrote: Hello, Pinging this patch review request. Can someone involved in the Objective-C language frontend have a quick look

Re: [PING][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-02-13 Thread Dimitris Papavasiliou
/2014 11:25 AM, Dimitris Papavasiliou wrote: Hello, This is a patch regarding a couple of Objective-C related dialect options and warning switches. I have already submitted it a while ago but gave up after pinging a couple of times. I am now informed that should have kept pinging until I got some

[PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-02-06 Thread Dimitris Papavasiliou
Hello, This is a patch regarding a couple of Objective-C related dialect options and warning switches. I have already submitted it a while ago but gave up after pinging a couple of times. I am now informed that should have kept pinging until I got someone's attention so I'm resending it.

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2013-07-02 Thread Dimitris Papavasiliou
owing this list. Thanks, Dimitris On 06/24/2013 03:04 PM, Dimitris Papavasiliou wrote: Ping! Would anybody care to comment on this? On 06/10/2013 12:44 AM, Dimitris Papavasiliou wrote: Hello, First, let me say that I have consciously broken most of the rules mentioned about patch sub

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2013-06-24 Thread Dimitris Papavasiliou
Ping! Would anybody care to comment on this? On 06/10/2013 12:44 AM, Dimitris Papavasiliou wrote: Hello, First, let me say that I have consciously broken most of the rules mentioned about patch submission at gcc.gnu.org but I have done so in order to spare myself from wasting time to provide

[PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2013-06-09 Thread Dimitris Papavasiliou
Hello, First, let me say that I have consciously broken most of the rules mentioned about patch submission at gcc.gnu.org but I have done so in order to spare myself from wasting time to provide a proper patch in case the implemented functionality is not deemed worthy of approval and adoption