RE: [PATCH] Fix uninitialised variable warning in tree-ssa-loop-ivcanon.c

2014-04-17 Thread Daniel Marjamäki
Hello! I am not against it.. However I think there is no danger. I see no potential use of uninitialized variable. The use of n_unroll is guarded by n_unroll_found. Best regards, Daniel Marjamäki

Re: [RFC] proof-of-concept: warning for a bit comparison that is always true/false

2014-04-16 Thread Daniel Marjamäki
check if a tree is a macro or template parameter somehow. I don't know if there are any false positives with macros/templates but it might be a good idea to skip warnings if the expression is a expanded macro or if any value is a template parameter. Best regards, Daniel Marjamäki 2014-

[RFC] proof-of-concept: warning for a bit comparison that is always true/false

2014-04-16 Thread Daniel Marjamäki
my experience this warning has a good signal/noise ratio. Best regards, Daniel Marjamäki Index: gcc/testsuite/c-c++-common/Wcondition-bitop.c === --- gcc/testsuite/c-c++-common/Wcondition-bitop.c (revision 0) +++ gcc/testsui