Re: [PATCH] aix: handle 64bit inodes for include directories

Hi everyone, Gentle ping Thanks, Clément From: CHIGOT, CLEMENT Sent: Tuesday, October 26, 2021 4:51 PM To: Jeff Law ; David Malcolm Cc: gcc-patches@gcc.gnu.org ; David Edelsohn Subject: Re: [PATCH] aix: handle 64bit inodes for include directories Hi everyone

Re: aix: Add FAT library support for libffi for AIX

> Even if GCC64 is able to boostrap without libffi being a > FAT library on AIX, the tests for "-maix32" are not working > without it. > > libffi/ChangeLog: > 2021-10-21  Clément Chigot   > >       * Makefile.am (tmake_file): Build and install AIX-style FAT >         libraries. >       * Makefil

Re: [PATCH] gcc: implement AIX-style constructors

> Hi David, > > Here is the new version of the patch. > I've moved the startup function in crtcdtors files. > > I'm just wondering if the part dealing with the > __init_aix_libgcc_cxa_atexit is needed. I'm adding it because > the destructor created in crtcxa.o is following GCC format and > thus

Re: [PATCH] gcc: implement AIX-style constructors

Hi David, Here is the new version of the patch. I've moved the startup function in crtcdtors files. I'm just wondering if the part dealing with the __init_aix_libgcc_cxa_atexit is needed. I'm adding it because the destructor created in crtcxa.o is following GCC format and thus won't be launched i

aix: Add FAT library support for libffi for AIX

Even if GCC64 is able to boostrap without libffi being a FAT library on AIX, the tests for "-maix32" are not working without it. libffi/ChangeLog: 2021-10-21  Clément Chigot           * Makefile.am (tmake_file): Build and install AIX-style FAT           libraries.         * Makefile.in: Regenerat

Re: [PATCH] aix: handle 64bit inodes for include directories

Hi everyone, Gentle ping on this patch. Clément From: CHIGOT, CLEMENT Sent: Tuesday, October 12, 2021 10:35 AM To: Jeff Law ; David Malcolm Cc: gcc-patches@gcc.gnu.org ; David Edelsohn Subject: Re: [PATCH] aix: handle 64bit inodes for include directories Hi

Re: [PATCH] gcc: implement AIX-style constructors

From: David Edelsohn Sent: Tuesday, October 19, 2021 10:14 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] gcc: implement AIX-style constructors Caution! External email. Do not open attachments or click links, unless this email comes from a known sender an

[PATCH] aix: ensure reference to __tls_get_addr is in text section.

The garbage collector of AIX linker might remove the reference to __tls_get_addr if it's added inside an unused csect, which can be the case of .data with very simple programs. gcc/ChangeLog: 2021-10-19  Clément Chigot           * config/rs6000/rs6000.c (rs6000_xcoff_file_end): Move         __tls

[PATCH] MAINTAINERS: Add myself for write after approval

ChangeLog: 2021-10-19 Clément Chigot * MAINTAINERS: Add myself for write after approval. From 13ddc381ea7bde6df9e48fb968d9324564f7a540 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Chigot?= Date: Tue, 19 Oct 2021 13:20:14 +0200 Subject: [PATCH] MAINTAINERS: Add myself for wri

[PATCH] gcc: implement AIX-style constructors

AIX linker now supports constructors and destructors detection. For such functions to be detected, their name must starts with __sinit or __sterm. and -bcdtors must be passed to linker calls. It will create "_cdtors" symbol which can be used to launch the initialization. This patch creates a new R

Re: [PATCH] aix: ensure reference to __tls_get_addr is in text section.

David Edelsohn Sent: Thursday, October 14, 2021 3:42 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] aix: ensure reference to __tls_get_addr is in text section. Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and yo

[PATCH] aix: ensure reference to __tls_get_addr is in text section.

The garbage collector of AIX linker might remove the reference to __tls_get_addr if it's added inside an unused csect. Clément Chigot ATOS Bull SAS 1 rue de Provence - 38432 Échirolles - France 0001-aix-ensure-reference-to-__tls_get_addr-is-in-text-se.patch Description: 0001-aix-ensure-referen

Re: [PATCH] aix: handle 64bit inodes for include directories

Hi Jeff, Any update on this patch ? As it's dealing with configure files, I would like to have it merged asap before any conflicts appear. Thanks, Clément

Re: [PATCH] aix: Add FAT library support for libffi

Sent: Wednesday, September 15, 2021 2:52 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] aix: Add FAT library support for libffi Caution! External email. Do not open attachments or click links, unless this email comes from a known sender and you know the content is safe. Cl

[PATCH] aix: Add FAT library support for libffi

Even if GCC64 is able to bootstrap without libffi being a FAT library on AIX, the tests for "-maix32" are not working without it. libffi/ChangeLog: 2021-09-10  Clément Chigot   * Makefile.am (tmake_file): Build and install AIX-style FAT  libraries. * Makefile.in: Regenera

aix: adjust installation directories for GCC64

As gcc on 64bit for AIX is built with "MULTILIB_MATCHES= .=maix32", "-print-multi-directory" and similar flags aren't returning the correct directory when used with -maix32: "." is returned instead of "ppc32". Libgcc installation script needs to be adjust to bypass this problem and correctly instal

Re: [PATCH] aix: handle 64bit inodes for include directories

>>> So my worry here is this is really a host property -- ie, this is >>> behavior of where GCC runs, not the target for which GCC is generating code. >>> >>> That implies that the change in aix.h is wrong. aix.h is for the >>> target, not the host -- you don't want to define something like >>> HO

Re: [PATCH] aix: handle 64bit inodes for include directories

Hi guys, Did you have a chance to take a look at the new version of this patch ? Thanks, Clément From: CHIGOT, CLEMENT Sent: Monday, June 28, 2021 9:16 AM To: Jeff Law ; David Malcolm Cc: gcc-patches@gcc.gnu.org ; David Edelsohn Subject: Re: [PATCH] aix

Re: [PATCH] aix: handle 64bit inodes for include directories

>On 6/23/2021 12:53 AM, CHIGOT, CLEMENT via Gcc-patches wrote: >> Hi David, >> >> Did you have a chance to take look at this patch ? >> >> Thanks, >> Clément >> >> >>> +DavidMalcolm >>> >>> Can you review this patch when

Re: [PATCH] aix: handle 64bit inodes for include directories

ith me, but you need to get approval for the >> incpath.c and cpplib.h parts of the patch from the appropriate >> maintainers. >> >> Thanks, David >> >> On Mon, May 17, 2021 at 7:44 AM CHIGOT, CLEMENT >> wrote: >> > >> > On AIX, stat wil

[PATCH] aix: add Power10 flag in ASM_CPU_SPEC

Changelog: 2021-06-09 Clément Chigot * config/rs6000/aix71.h (ASM_CPU_SPEC): Add entry for Power10. * config/rs6000/aix72.h (ASM_CPU_SPEC): Likewise. 0001-aix-add-Power10-flag-in-ASM_CPU_SPEC.patch Description: 0001-aix-add-Power10-flag-in-ASM_CPU_SPEC.patch

[PATCH] collect2: avoid failure when passing text files in an AIX archive

AIX ld allows archives to contain text files by simply ignoring them and printing a warning. This patch enables the same behavior for collect2. gcc/ChangeLog: 2021-05-20 Clément Chigot * collect2.c (scan_prog_file): Skip none-COFF files instead of raising an error. Maybe the

[PATCH] aix: handle 64bit inodes for include directories

On AIX, stat will store inodes in 32bit even when using LARGE_FILES. If the inode is larger, it will return -1 in st_ino. Thus, in incpath.c when comparing include directories, if several of them have 64bit inodes, they will be considered as duplicated. gcc/ChangeLog: 2021-05-06  Clément Chigot  

Re: [PATCH] libstdc++: implement locale support for AIX

>> * While you now define _GLIBCXX_C_LOCALE_XPG7 in >>  config/locale/xpg7/c_locale.h, config/os/aix/ctype_configure_char.cc >>   still tests the previous _GLIBCXX_C_LOCALE_IEEE_2008. > > Arf, I've missed that. it might not be the last patch then. > (I've made so much versions of it as I've tried

Re: [PATCH] libstdc++: implement locale support for AIX

> * There are minor formatting issues: > >   Should the linebreak in the extern inline definitions of strtof_l be >   after the return type, not before, matching GNU coding standards?  It >   may well be that the C++ style is different, though. > > Unrelated whitespace changes in xpg7/ctype_memb

Re: [PATCH] libstdc++: implement locale support for AIX

Hi everyone,  Here is a better version of the patch.  All tests are on Linux are passing. Few have been disabled as  they are working only with GNU model.  For AIX, few failures remains. I haven't XFAIL them yet, as I  want to know if they AIX only or related to the model itself.  A few part stil

Re: [PATCH] libstdc++: implement locale support for AIX

t;> that. I've made a first version with AC_CHECK_DECLS which allows extra >>> headers, but it didn't work too. I might know why though. >> >>Why would you need to? AC_CHECK_FUNCS just perform a link test to check >>if the functions are present in libc; no need to h

Re: [PATCH] libstdc++: implement locale support for AIX

Hi Rainer > > 3) POSIX 2017 and non-POSIX functions > > Many of the *_l functions being used in GNU or dragonfly models aren't > > POSIX 2008, but mainly POSIX 2017 or like strtof_l not POSIX at all. > > However, there are really useful in the code, thus I've made a double > > implementation based

Re: [PATCH] libstdc++: implement locale support for AIX

Hi everyone,  Here is a new version of the patch. I've tested on Linux and AIX. There are still some tests failing but it starts having a good shape !  However, I have few questions: 1) locale.name and syscalls locale.name() is returning a string having the description of each locale category. It

Re: [PATCH] libstdc++: implement locale support for AIX

> > However, is the C++ ABI not standard ? I don't have this test failing on > > AIX, AFAIK. Strange. > > Not really: the ABI tests rely on symbol versioning, which is only > available on Solaris and GNU ELF targets. Maybe it's normal then. > OTOH, I wondered if it wouldn't be better to start from

Re: [PATCH] libstdc++: implement locale support for AIX

Hi Rainer, > This alone makes the patch inacceptable in its present form: breaking > the libstdc++ ABI is a non-starter. However, I suspect this can be > avoided somehow. Thanks for having tried and I agree the patch isn't ready at all. I've just wanted to see how behave on other systems and it s

Re: [PATCH] libstdc++: implement locale support for AIX

> >Hi everyone,  > > > >I've reworked the patch to merged dragonfly and AIX > >models into the new one named "ieee_1003.1-2008".  > >It seems okay on the AIX part but if someone can test > >on Dragonfly and Freebsd I would be glad. Configure > >needs to be regenerated, first. > > Presumably it

Re: [PATCH] libstdc++: implement locale support for AIX

> And I don't know for the Changelog/Patch, how renamed > files must be handled ? I've retrieved my git commit with > "git format-patch --no-renames" and thus the Changelog > is made of "Removed" and "New File". Is it okay or is there > anything special to add ? I didn't find the answer quickly

Re: [PATCH] libstdc++: implement locale support for AIX

Hi everyone,  I've reworked the patch to merged dragonfly and AIX models into the new one named "ieee_1003.1-2008".  It seems okay on the AIX part but if someone can test on Dragonfly and Freebsd I would be glad. Configure needs to be regenerated, first. For now, I've used #ifdef inside the code

Re: [PATCH] libstdc++: implement locale support for AIX

>> Hi David, Clement, >> >>> The patch is local to libstdc++ AIX support, so I believe that I can >>> approve it. >> >>have you considered merging the dragonfly and aix trees? I'm asking >>because it seems prudent to try and avoid creating more and more >>almost-but-not-quite-similar configuratio

Re: [PATCH] libstdc++: implement locale support for AIX

Hi David, Alright, I'll see what I can do. Would "Skip if target = aix" be ok, especially for the few that I have absolutely no idea why they are failing ? Clément From: David Edelsohn Sent: Monday, January 11, 2021 4:03 PM To: CHIGOT, CLEMENT

[PATCH] libstdc++: implement locale support for AIX

Hi everyone,  This patch adds a partial locale support in libstdc++ for AIX.  The message_members part isn't yet implemented.  The tests have been launched in AIX7.2 and AIX7.1.  There are a few new tests failing (~20), but most of them weren't launched before and they don't seem too much relate

Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation

Hi Ian, Yes it is. Thanks, Clément From: Ian Lance Taylor Sent: Friday, December 11, 2020 6:58 PM To: CHIGOT, CLEMENT Cc: gcc-patches@gcc.gnu.org ; David Edelsohn ; gofrontend-dev Subject: Re: [PATCH] gcc: handle double quotes in symbol name during

Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation

Hi Ian, Any news about this bug ? It's not urgent even if it's breaking gcc builds with Go language, but I just want to know if you need any inputs/help from me. Thanks, Clément ____ From: CHIGOT, CLEMENT Sent: Wednesday, December 2, 2020 5:14 PM To:

Re: [PATCH] gcc: handle double quotes in symbol name during stabstrings generation

"set" aren't escaped. I didn't try to reproduce it on linux/amd64, but I did on linux/ppc64le and I don't think it's a ppc-only bug. Clément From: Ian Lance Taylor Sent: Wednesday, December 2, 2020 4:55 PM To: CHIGOT, CLEMENT Cc: gc

[PATCH] gcc: handle double quotes in symbol name during stabstrings generation

Hi Ian Since the new gccgo mangling scheme, libgo compilation is broken on AIX (or in Linux with -gstabs) because of a type symbol having a " in its name. I've made a patch (see attachment) in order to fix stabstring generation, because, IMO, it should be handled anyway. However, it happens onl

[PATCH] aix: remove libgomp and libatomic archives before creating FAT archives

libgomp and libatomic might be in use during the build. Thus, ar commands will failed to add new objetcs to it as the file is considered busy. Deleting it and recreating it with both architectures fixes that. libatomic/Changelog: 2020-08-17 Clement Chigot  * config/t-aix: Deleting libatomic befor

[PATCH] aix: add FAT library support for libstdc++fs.a

Knowing if --enable-libstdcxx-filesystem-ts has been passed to the configure in the AIX config Makefile would require a lot of change in libstdc++ Makefiles. Thus, it's easier to ignore errors when retrieving objects and check their existence before adding them. libstdc++/Changelog: 2020-09-22 Cl

[PATCH] aix: retrieve AR for configure for FAT library construction

Description: "ar" was changed to use AR value coming from configure, as several "ar" might be available. But all the -X flags must first be removed if the -r option is used. Otherwize, it might replace the wrong object files. libgcc/Changelog: 2020-09-22 Clement Chigot  * config/rs6000/t-slibgcc-

[PATCH] gcc: add GCC64 configuration for AIX 7.1

Description: This patch adds the support to build 64bit GCC applications on AIX 7.1 Changelog: 2020-07-24 Clement Chigot * config.gcc: Use t-aix64, biarch64 and default64 for cpu_is_64bit. * config/rs6000/aix71.h (ASM_SPEC): Remove aix64 option. (ASM_SPEC32): New.

[PATCH] libbacktrace: configure check linker support for DWARF-5

Description:   On AIX, the compiler is able to handle DWARF-5 but not the linker. Changelog: 2020-07-07 Clement Chigot  * configure.ac: Extend check to the linker for DWARF-5 support  * configure: Regenerate Please apply for me if approved. Could it be backported in gcc-10 branch too, please ?

[PATCH] libatomic/test: correctly handle multilib in blddir

Hi, This patch fixes how the variable blddir is computed inside libatomic testsuite in order to ensure that the multilib arguments are taken into account. Note that I'm not sure why DejaGNU function "get_multilibs" can correctly retrieve the multilib directory in some configurations and won't

gcc/testsuite/go: increase memory in issue4085b.go

Description: On aix/ppc64, it's possible to allocate an array of 1<<50 int, because of the wider address space. Thus, increase it to 1<<59 like in Golang toolchain in order to trigger the panic. Changelog: 2020-05-19 Clement Chigot * go.test/test/fixedbugs/issue4085b.go: increase the siz

[PATCH] gcc/config/rs6000: fix long double builtins for AIX

Descritpion: * This patch fixes the explicit call made by some C long double builtins when long doubles are on 64bit for AIX. Tests: * AIX 7.2, 7.1, 6.1: Build/Tests: OK Changelog: 2020-04-27 Clément Chigot gcc-10-gcc-config-rs6000-fix-long-double-builtins-for-AIX-V3.patch Description: gcc

[PATCH v2] gcc/config/rs6000: Add link with libc128 with -mlong-double-128 for AIX

Description: * AIX applications using 128-bit long double must be linked with libc128.a, in order to have 128-bit compatible routines. Tests: * AIX 7.2, 7.1, 6.1: Build/Tests: OK Changelog: 2020-04-03 Clément Chigot * config/rs6000/aix61.h (LIB_SPEC): Add -lc128 with -mlong-double-128. *

[PATCH] gcc/config/rs6000: Add link with libc128 with -mlong-double-128 for AIX

Description: * AIX applications using 128-bit long double must be linked with libc128.a, in order to have 128-bit compatible routines. Tests: * AIX 7.2, 7.1: Build/Tests: OK Changelog: * config/rs6000/aix61.h (LIB_SPEC): Add -lc128 with -mlong-double-128. * config/rs6000/aix71.h (LIB_SPEC:

[PATCH] libbacktrace: split test_elf into 32 and 64 bits version

Description: * This patch splits libbacktrace's test_elf into two new tests: test_elf_32 and test_elf_64. Tests: * AIX 7.2: Configure/Build: SUCCESS Changelog: * Makefile.am (BUILDTESTS): Remove test_elf, add test_elf_32 and test_elf_64. * Makefile.in: Regenerate. Index: libb

Re: [PATCH v2] go: disable mvsx and maltivec for aix/ppc

From: David Edelsohn > I have committed this patch. > > Thanks, David Thanks, I'll warn you if I ever understand what's wrong with it. Clément

[PATCH v2] go: disable mvsx and maltivec for aix/ppc

Description:    * This patch removes -mvsx and -maltivec for go aix/ppc.       These options don't seem compatible with Go stack layout.  Tests:    * AIX 7.2:  Configure/Build: SUCCESS Changelog:   * config/rs6000/aix71.h (SUBTARGET_OVERRIDE_OPTIONS): Remove OPTION_MASK_VSX       and OPTION_MASK_

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

On Tue, Apr 2, 2019 at 4:05 PM David Edelsohn wrote: > On Tue, Apr 2, 2019 at 10:01 AM CHIGOT, CLEMENT > wrote: > > On Tue, Apr 2, 2019 at 8:01 PM Ian Lance Taylor wrote: > > > On Mon, Apr 1, 2019 at 7:28 PM David Edelsohn wrote: > > > > On Mon, Apr 1,

Re: [PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

> > > > > On Mon, Apr 1, 2019 at 9:50 PM Ian Lance Taylor wrote: > > > > > > > > > > On Mon, Apr 1, 2019 at 12:43 AM CHIGOT, CLEMENT > > > > > wrote: > > > > > > > > > > > > Description: >

[PATCH,AIX] disables -flto on Go tests for AIX

Description: * This patches disables go tests with -flto on AIX. Tests: * AIX 7.2: Configure/Build: SUCCESS Changelog: * lib/go-torture.exp: add check for lto option Clément Chigot ATOS Bull SAS 1 rue de Provence - 38432 Échirolles - France Index: go-torture.exp =

[PATCH,AIX] go: disable mvsx and maltivec for aix/ppc

Description:    * This patch removes -mvsx and -maltivec for go aix/ppc.       These options don't seem compatible with Go stack layout.  Tests:    * AIX 7.2:  Configure/Build: SUCCESS Changelog:   * go/gospec.c (lang_specific_driver): disable -mvsx and -maltivec for aix/ppc.  Clément Chigot