Re: [PATCH] Make it possible to annotate the shared pointer operations in the std::thread implementation

2011-12-24 Thread Bart Van Assche
On Sat, Dec 24, 2011 at 12:05 PM, Jonathan Wakely wrote: > On 24 December 2011 11:46, Bart Van Assche wrote: >> Would it be acceptable to replace the >> _GLIBCXX_SYNCHRONIZATION_HAPPENS_BEFORE() and ..._AFTER() macros by >> something like this: >> >>  if (pf)

Re: [PATCH] Make it possible to annotate the shared pointer operations in the std::thread implementation

2011-12-24 Thread Bart Van Assche
On Sat, Dec 24, 2011 at 11:15 AM, Jonathan Wakely wrote: > On 24 December 2011 11:11, Jonathan Wakely wrote: >> Apart from that, I prefer to keep the thread-launching logic in the >> library rather than headers, as it allows us to change it more easily >> and for users to benefit just by linking t

Re: [PATCH] libstdc++: Make it possible to annotate the shared pointer operations in the std::thread implementation

2011-12-24 Thread Bart Van Assche
On Fri, Dec 23, 2011 at 5:04 PM, Paolo Carlini wrote: > First, do you have already a Copyright assignment on file? It's a > precondition for any non trivial contribution. I've just started the procedure to get a copyright assignment form filed. > That said, please leave alone the baselines. Oth

[PATCH] libstdc++: Make it possible to annotate the shared pointer operations in the std::thread implementation

2011-12-23 Thread Bart Van Assche
libstdc++ is inconvenient. So let's move the thread wrapper code from thread.cc into . See also: * http://gcc.gnu.org/onlinedocs/libstdc++/manual/debug.html. * http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51504. Signed-off-by: Bart Van Assche Index: libstdc++-v3/src/thre