I added it to bugzilla here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111396
Since this only reproduces part of the issue, please let me test again
with rustc_codegen_gcc after adding the missing fix.
I confirmed that the fix is in
https://github.com/antoyo/gcc/commit/9d5b6b20efa2082592619675
In the mean time, here's a (Rust) reproducer for the issue:
fn main() {
for _ in 0..5 {
let context = Context::default();
context.add_command_line_option("-flto");
context.set_optimization_level(OptimizationLevel::Aggressive);
context.add_driver_option("-nostdli
It seems to not be enough to fix the issue.
Let me find out what's missing from my patch.
On Tue, 2023-09-12 at 11:35 +0200, Richard Biener via Jit wrote:
> On Wed, Sep 6, 2023 at 3:41 PM David Malcolm via Gcc-patches
> wrote:
> >
> > As part of Antoyo's work on supporting LTO in rustc_codegen_g
Hi.
I'll do another test to make sure this is enough since I tested with a
few more finalize functions.
Thanks a lot for finding this!
On Wed, 2023-09-06 at 09:40 -0400, David Malcolm via Jit wrote:
> As part of Antoyo's work on supporting LTO in rustc_codegen_gcc, he
> noticed an ICE inside libgc
Since the tests in the PR for rustc_codegen_gcc
(https://github.com/rust-lang/rustc_codegen_gcc/pull/312) currently
fails, let's wait a bit before merging the patch, in case it would need
some fixes.
On Thu, 2023-08-17 at 20:09 +0200, Guillaume Gomez via Jit wrote:
> Quick question: do you plan to
I forgot to attach the patch.
Here it is.
On Sat, 2023-02-11 at 19:30 -0500, Antoni Boucher via Jit wrote:
> Hi.
> This patch adds support for machine-dependent builtins in libgccjit
> (bug 108762).
>
> There are two things I don't like in this patch:
>
> 1. There are a few functions copied fro
Hi.
This patch adds support for machine-dependent builtins in libgccjit
(bug 108762).
There are two things I don't like in this patch:
1. There are a few functions copied from the C frontend
(common_mark_addressable_vec and a few others).
2. Getting a target builtin only works from the second
Ping David:
Some more notes about the try/catch API:
I finally got unwinding implemented in rustc_codegen_gcc with the
following GCC patch:
https://github.com/antoyo/gcc/commit/fd603a3c715d3708f831cb637fbcc48bf4641859
It still requires clean-up, but you can have a look at it.
I'm still unsure for
Thanks!
In your patch, you're missing this line at the end of the commit
message:
Signed-off-by: Guillaume Gomez
On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote:
> Hi,
>
> This fixes bug 107999.
>
> Thanks in advance for the review.
Thanks!
David: you mentioned gcc 10. For now, I only intend to make changes to
the next release (13). Is this OK or should I backport all my fixes to
all active releases? (I'm not sure what are GCC policies here.)
On Tue, 2022-12-13 at 16:24 -0500, David Malcolm wrote:
> On Mon, 2022-12-12 at 21:
Hi.
This fixes bug 108078.
Thanks for the review.
From 016d23eeab1536e2ce0607d422fe4bb42b55c2dc Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri, 24 Jun 2022 21:05:29 -0400
Subject: [PATCH] libgccjit: Allow comparing vector types
gcc/jit/ChangeLog:
PR jit/108078
* jit-recording.h: Add ve
I'm posting the patch again so that you can double-check that I wrote
the DCO for the co-author correctly.
Does that look good?
Thanks.
On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote:
> On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote:
> > On Thu, 2022-12-01 at 10:25 -0500, David Ma
On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote:
> On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote:
> > On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote:
> > > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote:
> > > > Thanks, David.
> > > > Since we're not in phase 1 any
On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote:
> On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote:
> > Thanks, David.
> > Since we're not in phase 1 anymore, do we need an approval before I
> > merge like last year or can I merge immediately?
>
> I think it counts as a bug fix and
Thanks, David.
Since we're not in phase 1 anymore, do we need an approval before I
merge like last year or can I merge immediately?
I also have many other patches (all in jit) that I need to prepare and
post to this mailing list.
What do you think?
On Thu, 2022-12-01 at 09:28 -0500, David Malcolm
David: PING
On Sun, 2022-11-20 at 14:03 -0500, Antoni Boucher wrote:
> Hi.
> This fixes bug 107770.
> Thanks for the review.
Hi.
This fixes bug 107770.
Thanks for the review.
From 1112e92624d41ec96c366fdb60101e1040462522 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sun, 20 Nov 2022 10:22:53 -0500
Subject: [PATCH] libgccjit: Fix float vector comparison
Fix float vector comparison and add comparison tests didn't i
estsuite/jit.dg/test-asm.cc:160:11: error: typedef 'uint32_t'
is initialized (use 'decltype' instead)
Are you OK with me adding the stdint.h header?
On Tue, 2022-06-28 at 18:40 -0400, David Malcolm wrote:
> On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher via Gcc-patches
>
Thanks for the review.
Does this mean I can commit it, assuming the output of compare_tests is
good?
By the way, I wanted to mention that it was my first time playing with
the assembly generation, so I was not sure about my changes (even
though it makes the test case compile, I'm not sure it doesn
David: PING
On Wed, 2022-06-01 at 22:45 -0400, Antoni Boucher wrote:
> Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would need
> this line:
>
> #include
>
> Is this okay if I add it in this patch?
>
> On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote:
> > Hi.
> > The attache
Hi.
The attached patch fix bug 105829:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105829
Thanks for the review.
From 5d75fd342cdcea94a785312252be0c0046afdf43 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Wed, 4 May 2022 21:42:44 -0400
Subject: [PATCH] libgccjit: Support getting the size o
Sorry, forgot to attach the patch.
Here it is.
On Thu, 2022-06-02 at 21:20 -0400, Antoni Boucher via Jit wrote:
> Hi.
> The attached patch fix bug 105827:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105827
>
> I'm not sure how to test this, so please share ideas.
>
> Thanks for the review.
Hi.
The attached patch fix bug 105827:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105827
I'm not sure how to test this, so please share ideas.
Thanks for the review.
Also, the test gcc/testsuite/jit.dg/test-asm.cc fails and would need
this line:
#include
Is this okay if I add it in this patch?
On Wed, 2022-06-01 at 22:13 -0400, Antoni Boucher wrote:
> Hi.
> The attached patch fix bug 105812:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812
>
> I'm hav
Hi.
The attached patch fix bug 105812:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105812
I'm having an issue where contrib/check_GNU_style.sh doesn't seem to
work, i.e. it doesn't seem to do any checking.
Is there a new way to do that or am I missing something?
Thanks for the review.
From ef20b
Here's the updated patch.
On Fri, 2022-04-08 at 15:22 -0400, David Malcolm wrote:
> On Fri, 2022-01-21 at 18:41 -0500, Antoni Boucher wrote:
> > Hi.
> > Here's the updated patch.
> >
>
> Thanks. Review below:
>
> [...snip...]
>
> > diff --git a/gcc/jit/libgccjit.cc b/gcc/jit/libgccjit.cc
> >
Here's the updated patch.
On Fri, 2022-04-08 at 15:01 -0400, David Malcolm wrote:
> On Sun, 2022-01-30 at 20:38 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > Hi.
> > This patch adds support for setting the alignment of variables in
> > libgccjit.
>
>
On Fri, 2022-04-08 at 15:36 -0400, David Malcolm wrote:
> I'm excited to read that rustc_codegen_gcc, the libgccjit-based
> backend
> for rustc can now bootstrap rustc:
> https://blog.antoyo.xyz/rustc_codegen_gcc-progress-report-10
>
> I've been focusing on the analyzer, and so haven't been as o
14:53 +0200, Jakub Jelinek via Jit wrote:
> > > On Tue, May 18, 2021 at 08:23:56AM -0400, Antoni Boucher via Gcc-
> > > patches wrote:
> > > > Hello.
> > > > This patch add support for sized integer types.
> > > > Maybe it should check whether th
; >
> > > Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit :
> > > > On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-
> > > > patches
> > > > wrote:
> > > > > I missed the comment about the
Hi.
This patch adds support for setting the alignment of variables in
libgccjit.
I was wondering if I should change it so that it takes/returns bytes
instead of bits.
What do you think?
Thanks for the review.
From ebdb6905f23ddef28292a1d71081eebb7a2a9bb9 Mon Sep 17 00:00:00 2001
From: Antoni Bouc
See answers below.
Le lundi 24 janvier 2022 à 18:20 -0500, David Malcolm a écrit :
> On Sat, 2022-01-22 at 19:29 -0500, Antoni Boucher wrote:
> > Hi.
> >
> > Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit :
> > > On Mon, 2022-01-17 at 19:46 -0500,
at 19:46 -0500, Antoni Boucher via Gcc-patches
> > > wrote:
> > > > I missed the comment about the new define, so here's the
> > > > updated
> > > > patch.
> > >
> > > Thanks for the patch.
> > > >
> > >
Thanks for the review.
Here's the updated patch.
Le mardi 18 janvier 2022 à 18:22 -0500, David Malcolm a écrit :
> On Mon, 2022-01-17 at 21:02 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > Hi.
> > This option will be useful for rustc_codegen_gcc to hide the error
&g
Hi.
Le mardi 18 janvier 2022 à 18:49 -0500, David Malcolm a écrit :
> On Mon, 2022-01-17 at 19:46 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > I missed the comment about the new define, so here's the updated
> > patch.
>
> Thanks for the patch.
> >
&
Hi.
Here's the updated patch.
See comments below.
Le mardi 18 janvier 2022 à 18:06 -0500, David Malcolm a écrit :
> On Mon, 2022-01-17 at 19:30 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > I was missing the define, so I added it.
> > Here's the new patch with i
écrit :
> On Tue, 2021-05-18 at 14:53 +0200, Jakub Jelinek via Jit wrote:
> > On Tue, May 18, 2021 at 08:23:56AM -0400, Antoni Boucher via Gcc-
> > patches wrote:
> > > Hello.
> > > This patch add support for sized integer types.
> > > Maybe it should c
Also, I put the extern in gcc/system.h, but I'm not sure it's the right
place.
Where should I put it?
Le lundi 17 janvier 2022 à 19:46 -0500, Antoni Boucher via Jit a
écrit :
> I missed the comment about the new define, so here's the updated
> patch.
>
> Le lundi 17 janvier 2022 à 19:24 -0500, An
Hi.
This option will be useful for rustc_codegen_gcc to hide the error
about unsupported 128-bit integer types.
David, if you know of a better way to check if these types are
supported than creating such a type and checking if it causes an error,
I will not need this patch.
Thanks for the reviews
I missed the comment about the new define, so here's the updated patch.
Le lundi 17 janvier 2022 à 19:24 -0500, Antoni Boucher via Jit a
écrit :
> Hi.
> This patch add supports for register variables in libgccjit.
>
> It passes the JIT tests, but since I added a function in reginfo.c, I
> wonder
I was missing the define, so I added it.
Here's the new patch with it.
Le lundi 17 janvier 2022 à 17:18 -0500, Antoni Boucher via Jit a
écrit :
> Hi.
> This patch add support for bitcasts in libgccjit.
>
> It passes the JIT tests, but since I added a function in tree.c, I
> wonder if I should run
Hi.
This patch add supports for register variables in libgccjit.
It passes the JIT tests, but since I added a function in reginfo.c, I
wonder if I should run the whole testsuite.
Thanks for the review.
From 328eca2be438c4a05c21942b4b2c3650ff7de0eb Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Da
Hi.
This patch add support for bitcasts in libgccjit.
It passes the JIT tests, but since I added a function in tree.c, I
wonder if I should run the whole testsuite.
David, you can now disregard my question in my email about 128-bit
integers regarding my issue with initialize_sizetypes being calle
Hi, David!
One question below as I'm still not done with using this patch in
rustc_codegen_gcc.
Le jeudi 20 mai 2021 à 15:25 -0400, David Malcolm a écrit :
> On Tue, 2021-05-18 at 14:53 +0200, Jakub Jelinek via Jit wrote:
> > On Tue, May 18, 2021 at 08:23:56AM -0400, Antoni B
Oh, sorry, I meant when you have an array not in a local variable, and
you try to assign to an index of this array.
Something like:
gcc_jit_rvalue *ctor = gcc_jit_context_new_array_constructor
(ctxt,0,int50arr_type,6,values);
gcc_jit_block_add_assignment (block, 0,
gcc_jit_context_new_arra
I realized that trying to do an assignment to an array created by the
new array constructor API will result in a "gimplification failed"
error:
libgccjit.so: error: gimplification failed
0x7fa3a441e5d3 gimplify_expr(tree_node**, gimple**, gimple**, bool
(*)(tree_node*), int)
../../../gcc/g
Hi Petter.
I believe you have forgotten the line `global:` in the file
`gcc/jit/libgccjit.map`.
I'm not sure what this line does, but it is there for all other ABI.
David: What do you think?
Regards.
Le mardi 14 décembre 2021 à 17:22 +, Petter Tomner via Jit a
écrit :
> Hi!
>
> I have pushed
Also, the LIBGCCJIT_ABI_17 will need to be updated as I merged some of
my patches.
Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit :
> Hi!
>
> > s/an union/a union/
> > s/a rvalue/an rvalue/
>
> Heh no way ... and I though I knew English grammar :)
>
> Had to look that up to see
One thing I'm not sure if it is a code style issue, but worth
mentionning:
> @@ -1405,8 +1436,10 @@ private:
>
> private:
>enum gcc_jit_global_kind m_kind;
> + enum global_var_flags flags = GLOBAL_VAR_FLAGS_NONE;
^
Should it be named m_flags instead of flags?
Yes, this patch works for rustc_codegen_gcc perfectly.
It even fixes one issue that was in my patch, so that's nice!
Le samedi 11 décembre 2021 à 15:35 +, Petter Tomner a écrit :
> Hi!
>
> > s/an union/a union/
> > s/a rvalue/an rvalue/
>
> Heh no way ... and I though I knew English grammar
David: PING
In case you missed it, that's the last patch left to review for now.
Le dimanche 21 novembre 2021 à 16:44 -0500, Antoni Boucher a écrit :
> Thanks for the review!
> I updated the patch.
>
> See notes below.
>
> Le samedi 20 novembre 2021 à 13:50 -0500, David Malcolm a écrit :
> > On
Hi David!
I updated the patch to allow initializing global variables with values
of type array or struct.
I also fixed the bug I was talking in my previous message by using the
following workaround: I create a new memento for the action of setting
the global variable initial value and as such, bo
Thanks for the review!
I updated the patch.
See notes below.
Le samedi 20 novembre 2021 à 13:50 -0500, David Malcolm a écrit :
> On Sat, 2021-11-20 at 11:27 -0500, Antoni Boucher wrote:
> > Hi.
> > Here's the updated patch.
> > Thanks for the review!
>
> Thanks for the updated patch...
>
> >
>
Hi.
Here's the updated patch.
See comments below.
Thanks for your reviews!
Le jeudi 20 mai 2021 à 16:11 -0400, David Malcolm a écrit :
> On Tue, 2021-05-18 at 20:43 -0400, Antoni Boucher via Gcc-patches
> wrote:
> > Hello.
> > This patch adds support for TLS variables.
>
Hi.
Here's the updated patch.
See comments below.
Thanks for the review!
Le samedi 20 novembre 2021 à 11:20 -0500, David Malcolm a écrit :
> On Sat, 2021-11-20 at 00:58 -0500, Antoni Boucher wrote:
> > Thanks for your reviews!
> >
> > Here's the updated patch, ready for another review.
> > See co
Hi.
Here's the updated patch.
Thanks for the review!
Le jeudi 20 mai 2021 à 16:24 -0400, David Malcolm a écrit :
> On Mon, 2021-05-17 at 21:02 -0400, Antoni Boucher via Jit wrote:
> > Hello.
> > This patch fixes the issue with using atomic builtins in libgccjit.
> > Thanks to review it.
>
> [...s
Thanks for your reviews!
Here's the updated patch, ready for another review.
See comments/questions below.
I'll update the other patches over the weekend.
Le jeudi 20 mai 2021 à 15:29 -0400, David Malcolm a écrit :
> On Wed, 2021-05-19 at 20:32 -0400, Antoni Boucher via Jit wrote:
> > Hello.
> >
David: PING
Le mardi 12 octobre 2021 à 22:09 -0400, Antoni Boucher a écrit :
> David: PING
>
> Le lundi 27 septembre 2021 à 20:53 -0400, Antoni Boucher a écrit :
> > I fixed an issue (it would show an error message when
> > gcc_jit_type_dyncast_function_ptr_type was called on a type
> > different
David: PING
Le lundi 27 septembre 2021 à 20:53 -0400, Antoni Boucher a écrit :
> I fixed an issue (it would show an error message when
> gcc_jit_type_dyncast_function_ptr_type was called on a type different
> than a function pointer type).
>
> Here's the updated patch.
>
> Le vendredi 18 juin 20
I fixed an issue (it would show an error message when
gcc_jit_type_dyncast_function_ptr_type was called on a type different
than a function pointer type).
Here's the updated patch.
Le vendredi 18 juin 2021 à 16:37 -0400, David Malcolm a écrit :
> On Fri, 2021-06-18 at 15:41 -0400, Antoni Boucher
David: PING
Le jeudi 29 juillet 2021 à 08:59 -0400, Antoni Boucher a écrit :
> David: PING
>
> Le lundi 19 juillet 2021 à 12:10 -0400, Antoni Boucher a écrit :
> > I'm sending the patch once again for review/approval.
> >
> > I fixed the doc to use the new function names.
> >
> > Le vendredi 18
David: PING
Le lundi 19 juillet 2021 à 12:10 -0400, Antoni Boucher a écrit :
> I'm sending the patch once again for review/approval.
>
> I fixed the doc to use the new function names.
>
> Le vendredi 18 juin 2021 à 16:37 -0400, David Malcolm a écrit :
> > On Fri, 2021-06-18 at 15:41 -0400, Anton
I'm sending the patch once again for review/approval.
I fixed the doc to use the new function names.
Le vendredi 18 juin 2021 à 16:37 -0400, David Malcolm a écrit :
> On Fri, 2021-06-18 at 15:41 -0400, Antoni Boucher wrote:
> > I have write access now.
>
> Great.
>
> > I'm not sure how I'm supp
> > > > > > > > Le jeudi 13 mai 2021 à 18:13 -0400, David Malcolm a
> > > > > > > > écrit :
> > > > > > > > > On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via
> > > > > > > > > G
Hi.
I pushed a patch adding myself to the maintainers file.
From 93022946df2463ad49e3eaa2f6d43c47c16f31c0 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Fri, 18 Jun 2021 16:49:20 -0400
Subject: [PATCH] MAINTAINERS: Add myself for write after approval
ChangeLog:
2021-06-18 Antoni Boucher
not be needed in libgccjit.
> > > >
> > > > Should I just remove the condition, then?
> > >
> > > I think so.
> > >
> > > Thanks
> > > Dave
> > >
> > > >
> > > > Le jeudi 13 mai 2021 à 19:58 -0400, David Malc
I have write access now.
I'm not sure how I'm supposed to send my patches:
should I put it in personal branches and you'll merge them?
And for the MAINTAINERS file, should I just push to master right away,
after sending it to the mailing list?
Thanks for your help!
Le vendredi 18 juin 2021 à 12:
Le vendredi 11 juin 2021 à 14:00 -0400, David Malcolm a écrit :
> On Fri, 2021-06-11 at 08:15 -0400, Antoni Boucher wrote:
> > Thank you for your answer.
> > I attached the updated patch.
>
> BTW you (or possibly me) dropped the mailing lists; was that
> deliberate?
Oh, my bad.
> >
> > See my a
David: this one wasn't reviewed yet by you, so you can review it.
Le jeudi 20 mai 2021 à 21:27 -0400, Antoni Boucher a écrit :
> Hi.
>
> I made this patch to set an arbitrary value to a global variable.
>
> This patch suffers from the same issue as inline assembly
> (https://gcc.gnu.org/bugzilla
I chose option A, so everything is a size_t, now.
I also renamed the dyncast functions.
Here's the new patch.
Le jeudi 27 mai 2021 à 18:19 -0400, David Malcolm a écrit :
> On Tue, 2021-05-25 at 20:19 -0400, Antoni Boucher wrote:
> > @David: PING
> >
> > As far as I know, the only remaining questi
gt;
> > Le jeudi 13 mai 2021 à 19:58 -0400, David Malcolm a écrit :
> > > On Thu, 2021-05-13 at 19:31 -0400, Antoni Boucher wrote:
> > > > Thanks for your answer.
> > > >
> > > > See my answers below:
> > > >
> > > > Le jeudi 13 mai 2021 à 18:
Hi.
Here's the new patch with the fixes requested.
Le jeudi 20 mai 2021 à 16:24 -0400, David Malcolm a écrit :
> On Mon, 2021-05-17 at 21:02 -0400, Antoni Boucher via Jit wrote:
> > Hello.
> > This patch fixes the issue with using atomic builtins in libgccjit.
> > Thanks to review it.
>
> [...sni
@David: PING
As far as I know, the only remaining question is about using `ssize_t`
for the return type of some functions.
Here's why I use this type:
That seemed off to return NULL for the functions returning a
size_t to indicate an error. So I changed it to return -1 (and return
type to ssize_
> >
> > Le jeudi 13 mai 2021 à 18:13 -0400, David Malcolm a écrit :
> > > On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via Gcc-patches
> > > wrote:
> > > > Hi.
> > > > Thanks for your feedback!
> > > >
> > >
> &g
Hi.
I made this patch to set an arbitrary value to a global variable.
This patch suffers from the same issue as inline assembly
(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100380), i.e. it
segfaults if the `rvalue` is created after the global variable.
It seems to be a design issue so I'm not s
Hello.
This patch adds support to set the link section of global variables.
I used the ABI 18 because I submitted other patches up to 17.
Thanks for the review.
From c867732ee36003759d479497c85135ecfc4a0cf3 Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Wed, 12 May 2021 07:57:54 -0400
Subject
Hello.
This patch adds support for TLS variables.
One thing to fix before we merge it is the libgccjit.map file which
contains LIBGCCJIT_ABI_16 instead of LIBGCCJIT_ABI_17.
LIBGCCJIT_ABI_16 was added in one of my other patches.
Thanks for the review.
From 6092e3d347972d331ed9ac6cae153168e98ecd0d Mo
I had forgotten to update the documentation.
This new patch contains it.
Le mardi 18 mai 2021 à 08:23 -0400, Antoni Boucher a écrit :
> Hello.
> This patch add support for sized integer types.
> Maybe it should check whether the size of a byte for the current
> platform is 8 bits and do other chec
Hello.
This patch add support for sized integer types.
Maybe it should check whether the size of a byte for the current
platform is 8 bits and do other checks so that they're only available
when it makes sense.
What do you think?
Thanks.
From d194a03fe3f2e8164c39413b79da9c43e236cf37 Mon Sep 17 00:0
Hello.
This patch fixes the issue with using atomic builtins in libgccjit.
Thanks to review it.
From 0ce53d373ffba9f3f80a2d2b4e1a7d724ba31b7d Mon Sep 17 00:00:00 2001
From: Antoni Boucher
Date: Sun, 9 May 2021 20:14:37 -0400
Subject: [PATCH] Add support for types used by atomic builtins [PR96066]
Thanks for your reviews.
I attached the new patch to this email.
See answers below:
Le jeudi 13 mai 2021 à 17:30 -0400, David Malcolm a écrit :
> On Tue, 2020-11-03 at 17:13 -0500, Antoni Boucher wrote:
> > I was missing a check in gcc_jit_struct_get_field, I added it in
> > this
> > new patch.
Thanks for your answer.
See my answers below:
Le jeudi 13 mai 2021 à 18:13 -0400, David Malcolm a écrit :
> On Sat, 2021-02-20 at 17:17 -0500, Antoni Boucher via Gcc-patches
> wrote:
> > Hi.
> > Thanks for your feedback!
> >
>
> Sorry about the delay in resp
Hi.
Thanks for your feedback!
See answers below:
On Sat, Feb 20, 2021 at 11:20:35AM -0700, Tom Tromey wrote:
"Antoni" == Antoni Boucher via Gcc-patches writes:
Antoni> gcc/jit/
Antoni> PR target/95498
Antoni> * jit-playback.c: Add support to handle truncation a
Hi.
I'd like to know what's the status of the review for this patch.
(Same for my other patch 96889: add some reflection functions in the jit
C api)
Thanks.
On Tue, Jul 21, 2020 at 11:29:57PM +0200, Andrea Corallo wrote:
Hi Antoni,
a couple of nits and some thoughts.
Antoni Bouch
I was missing a check in gcc_jit_struct_get_field, I added it in this
new patch.
On Thu, Oct 15, 2020 at 05:52:33PM -0400, David Malcolm wrote:
On Thu, 2020-10-15 at 13:39 -0400, Antoni Boucher wrote:
Thanks. I updated the patch with these changes.
Thanks for patch; review below. Sorry if i
Hi.
Thanks for the review. See the comments below.
I attached the updated patch.
On Thu, Oct 15, 2020 at 05:52:33PM -0400, David Malcolm wrote:
On Thu, 2020-10-15 at 13:39 -0400, Antoni Boucher wrote:
Thanks. I updated the patch with these changes.
Thanks for patch; review below. Sorry if it
that work.
David, any more insight about whether this is the good solution for the
problem?
Thanks.
On Tue, Jul 21, 2020 at 11:29:57PM +0200, Andrea Corallo wrote:
Hi Antoni,
a couple of nits and some thoughts.
Antoni Boucher via Gcc-patches writes:
2020-07-12 Antoni Boucher
gc
Thanks. I updated the patch with these changes.
Is there any tool to automatically check the style?
On Thu, Oct 15, 2020 at 06:23:18PM +0200, Andrea Corallo wrote:
Antoni Boucher via Jit writes:
Hi Antoni,
Just had a quick look, please find some quite minor comments in line.
From b0edc9eb8
Hi.
I added all the functions I need in this new patch.
Please tell me if that looks good and I'll add documentation for those
functions.
Thanks.
On Fri, Oct 02, 2020 at 04:24:26PM -0400, David Malcolm wrote:
On Fri, 2020-10-02 at 16:17 -0400, David Malcolm wrote:
On Tue, 2020-09-01 at 21:01
By the way, that seemed off to return NULL for the function returning a
size_t to indicate an error. So I changed it to return -1 (and return
type to ssize_t). Is that the proper way to indicate an error?
I also wanted to mention that this patch is still a work-in-progress as
I'm adding a few
Hi.
Thanks for the review.
I attached the updated patch file.
I don't have a copyright assignment, but I'll look at that.
On Fri, Oct 02, 2020 at 04:24:26PM -0400, David Malcolm wrote:
On Fri, 2020-10-02 at 16:17 -0400, David Malcolm wrote:
On Tue, 2020-09-01 at 21:01 -0400, Antoni Boucher via
Hello.
This WIP patch implements new reflection functions in the C API as
mentioned in bug 96889.
I'm looking forward for feedbacks on this patch.
It's WIP because I'll probably add a few more reflection functions.
Thanks.
>From 23ab738c0d9202f6798a38fb4aa15edfcc67d11c Mon Sep 17 00:00:00 2001
F
Hello.
As mentioned in bug 95498, some conversions do not work. After
investigation, it turns out that it's caused by multiple casts on an
expression where it should do a truncation/extension.
I added a testcase, but for some reasons, the tests only pass when ran
via `./testsuite/jit/test-ca
93 matches
Mail list logo
