Re: [PATCH v2] MATCH: Simplify (a ? x : y) eq/ne (b ? x : y) [PR111150]

2024-07-25 Thread Adhemerval Zanella Netto
On 17/07/24 14:00, Andrew Pinski wrote: > On Wed, Jul 17, 2024 at 5:24 AM Richard Biener > wrote: >> >> On Tue, Jul 16, 2024 at 3:36 PM Eikansh Gupta >> wrote: >>> >>> This patch adds match pattern for `(a ? x : y) eq/ne (b ? x : y)`. >>> In forwprop1 pass, depending on the type of `a` and `b

Re: [PATCH] arm: Update fp16-aapcs-[24].c after insn_propagation patch

2024-07-23 Thread Adhemerval Zanella Netto
On 19/07/24 11:25, Richard Earnshaw (lists) wrote: > On 11/07/2024 19:31, Richard Sandiford wrote: >> These tests used to generate: >> >> bl swap >> ldr r2, [sp, #4] >> mov r0, r2 @ __fp16 >> >> but g:9d20529d94b23275885f380d155fe8671ab5353a means that we ca

Re: [to-be-committed][RISC-V][V3] DCE analysis for extension elimination

2024-07-10 Thread Adhemerval Zanella Netto
On 02/07/24 16:40, Jeff Law wrote: > [ Actually attaching the patch this time... ] > > The pre-commit testing showed that making ext-dce only active at -O2 and > above would require minor edits to the tests.  In some cases we had specified > -O1 in the test or specified no optimization level

Re: [PATCH] longlong.h: Do no use asm input cast for clang

2023-01-10 Thread Adhemerval Zanella Netto via Gcc-patches
On 12/12/22 20:52, Segher Boessenkool wrote: > On Mon, Dec 12, 2022 at 02:10:16PM -0300, Adhemerval Zanella Netto wrote: >> On 30/11/22 20:24, Segher Boessenkool wrote: >>> I understand that the casts should be no-ops on the asm side (maybe they >>> change the sign) a

Re: [PATCH] longlong.h: Do no use asm input cast for clang

2022-12-12 Thread Adhemerval Zanella Netto via Gcc-patches
On 30/11/22 20:24, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 30, 2022 at 03:16:25PM -0300, Adhemerval Zanella via Gcc-patches > wrote: >> clang by default rejects the input casts with: >> >> error: invalid use of a cast in a inline asm context requiring a

[PATCH] longlong.h: Do no use asm input cast for clang

2022-11-30 Thread Adhemerval Zanella via Gcc-patches
, 325 insertions(+), 259 deletions(-) diff --git a/include/ChangeLog b/include/ChangeLog index dda005335c0..747fc923ef5 100644 --- a/include/ChangeLog +++ b/include/ChangeLog @@ -1,3 +1,63 @@ +2022-11-30 Adhemerval Zanella + + * include/longlong.h: Modified. + [(__GNUC__) &&

Re: [PATCH 3/3] elf: Add _dl_find_eh_frame function

2021-11-23 Thread Adhemerval Zanella via Gcc-patches
On 17/11/2021 10:40, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> However the code is somewhat complex and I would like to have some feedback >> if gcc will be willing to accept this change (I assume it would require >> this code merge on glibc bef

Re: [PATCH 3/3] elf: Add _dl_find_eh_frame function

2021-11-16 Thread Adhemerval Zanella via Gcc-patches
On 03/11/2021 13:28, Florian Weimer via Gcc-patches wrote: > This function is similar to __gnu_Unwind_Find_exidx as used on arm. > It can be used to speed up the libgcc unwinder. Besides the terse patch description, the design seems ok to accomplish the lock-free read and update. There are som

Re: [PATCH 2/3] elf: Introduce GLRO (dl_libc_freeres), called from __libc_freeres

2021-11-15 Thread Adhemerval Zanella via Gcc-patches
Maybe add a comment why this is will be used. Reviewed-by: Adhemerval Zanella On 03/11/2021 13:27, Florian Weimer via Gcc-patches wrote: > --- > elf/Makefile | 2 +- > elf/dl-libc_freeres.c | 24 > elf/rtld.c | 1 + &

Re: [PATCH 1/3] nptl: Extract from pthread_cond_common.c

2021-11-15 Thread Adhemerval Zanella via Gcc-patches
ry. > > The debug output in nptl/tst-cond22 has been adjusted to print > the 32-bit values instead because it avoids a big-endian/little-endian > difference. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > bits/atomic_wide_counter.h | 35 &g

Re: [PATCH v6] aarch64: Add split-stack support

2018-02-27 Thread Adhemerval Zanella
Ping (with Szabolcs remarks fixed). On 07/02/2018 16:07, Adhemerval Zanella wrote: > Changes from previous version: > > - Changed the wait to call __morestack to use use a branch with link > instead of a simple branch. This allows use a call instruction and > avoid

Re: [PATCH] Add sanitizer support for AArch64 ILP32

2018-02-23 Thread Adhemerval Zanella
On 23/02/2018 11:39, Jakub Jelinek wrote: > On Fri, Feb 23, 2018 at 11:27:19AM -0300, Adhemerval Zanella wrote: >> This patch adds asan support for aarch64 ilp32. It is based on 'official' >> glibc support branch [1] (which is in turn based on Linux branch [2]

[PATCH] Add sanitizer support for AArch64 ILP32

2018-02-23 Thread Adhemerval Zanella
This patch adds asan support for aarch64 ilp32. It is based on 'official' glibc support branch [1] (which is in turn based on Linux branch [2]). Main changes for libsanitizer is the kernel ABI support for internal syscalls. Different than x32, ILP32 tries to leverage 32-bits syscalls with kernel

Re: [PATCH v6] aarch64: Add split-stack support

2018-02-15 Thread Adhemerval Zanella
On 13/02/2018 13:13, Szabolcs Nagy wrote: > On 07/02/18 18:07, Adhemerval Zanella wrote: >  5. The TCB support on GLIBC is meant to be included in version 2.28. >> > ... >> +/* -fsplit-stack uses a TCB field available on glibc-2.27.  GLIBC also >> +   exports symbol,

[PATCH v6] aarch64: Add split-stack support

2018-02-07 Thread Adhemerval Zanella
Changes from previous version: - Changed the wait to call __morestack to use use a branch with link instead of a simple branch. This allows use a call instruction and avoid possible issues with later optimization passes which might see a branch outside the instruction block (as noti

Re: [PATCH] Enable ifunc attribute by default for ARM GNU/Linux

2017-10-10 Thread Adhemerval Zanella
On 09/10/2017 19:20, Joseph Myers wrote: > On Mon, 9 Oct 2017, Adhemerval Zanella wrote: > >> *-*-linux*) >> case ${target} in >> -aarch64*-* | i[34567]86-* | powerpc*-* | s390*-* | sparc*-* | x86_64-*) >> +aarch64*-* | i[34567]86-* | powerpc*-*

[PATCH] Enable ifunc attribute by default for ARM GNU/Linux

2017-10-09 Thread Adhemerval Zanella
glibc patch to support using the attribute on ARM) with build-many-glibcs.py (with a patch to add a armv7 variant which enables multiarch). I have not run the GCC tests for ARM. Adhemerval Zanella * config.gcc (default_gnu_indirect_function): Default to yes for arm

Re: [PATCH v5] aarch64: Add split-stack initial support

2017-08-31 Thread Adhemerval Zanella
Ping. On 26/07/2017 16:08, Adhemerval Zanella wrote: > This is an update patch based on my previous submission [1]. The changes > from previous version are: > > - Update aarch64_supports_split_stack to return true an let the loader > to actually emit an error if it does

[PATCH v5] aarch64: Add split-stack initial support

2017-07-26 Thread Adhemerval Zanella
This is an update patch based on my previous submission [1]. The changes from previous version are: - Update aarch64_supports_split_stack to return true an let the loader to actually emit an error if it does not provide the required TCB field. The TCB field support is planed for GLIBC

[PATCH] sparc: Set noexecstack on mulsi3, divsi3, and modsi3

2017-05-10 Thread Adhemerval Zanella
A recent GLIBC fix for sparc [1] made some configuration to show an executable stack on ld.so (shown on elf/check-execstack testcase failure). It is because with generated sparc toolchain from build-many-glibcs.py (a GLIBC script to produce cross-compiling toolchains) the minimum supported sparc32

Re: [PATCH v4] aarch64: Add split-stack initial support

2017-03-06 Thread Adhemerval Zanella
Ping. On 15/02/2017 21:23, Adhemerval Zanella wrote: > This is an update patch from my previous version (v3) based mainly on > glibc comments on exported loader symbol [1]. The changes from previous > version are: > >- Remove __tcb_private_ss call on libgcc and emit

[PATCH v4] aarch64: Add split-stack initial support

2017-02-15 Thread Adhemerval Zanella
This is an update patch from my previous version (v3) based mainly on glibc comments on exported loader symbol [1]. The changes from previous version are: - Remove __tcb_private_ss call on libgcc and emit a data usage on glibc symbol when split-stack is used. This removes the runtime

[PATCH v3] aarch64: Add split-stack support

2017-02-13 Thread Adhemerval Zanella
Changes from previous version: - The split-stack are is now allocated before the thread pointer (instead of tcbhead_t which is positioned after it) as decribed in glibc patch [1]. It has the advantage to not require linker changes to take in consideration the new tcbhead_t size and

Re: [PATCH v2] aarch64: Add split-stack initial support

2017-01-31 Thread Adhemerval Zanella
On 25/01/2017 10:10, Jiong Wang wrote: > On 24/01/17 18:05, Adhemerval Zanella wrote: >> >> On 03/01/2017 13:13, Wilco Dijkstra wrote: >> >>> + /* If function uses stacked arguments save the old stack value so >>> morestack >>> + can

Re: [PATCH v2] aarch64: Add split-stack initial support

2017-01-24 Thread Adhemerval Zanella
On 03/01/2017 13:13, Wilco Dijkstra wrote: > Adhemerval Zanella wrote: > > Sorry for the late reply - but I think it's getting there. A few more > comments: No worries. > > + /* If function uses stacked arguments save the old stack value so morestack > + can

Re: [PATCH v2] aarch64: Add split-stack initial support

2016-11-25 Thread Adhemerval Zanella
On 15/11/2016 16:38, Wilco Dijkstra wrote: > > On 07/11/2016 16:59, Adhemerval Zanella wrote: >> On 14/10/2016 15:59, Wilco Dijkstra wrote: > >> There is no limit afaik on gold split stack allocation handling, >> and I think one could be added for each backend

Re: [PATCH v2] aarch64: Add split-stack initial support

2016-11-14 Thread Adhemerval Zanella
Ping. On 07/11/2016 16:59, Adhemerval Zanella wrote: > > > On 14/10/2016 15:59, Wilco Dijkstra wrote: >> Hi, >> > > Thanks for the thoughtful review and sorry for late response. > >>> Split-stack prologue on function entry is as follow (this goes

Re: [PATCH v2] aarch64: Add split-stack initial support

2016-11-07 Thread Adhemerval Zanella
s stores a random x30 value on the stack, what is the purpose of this? > Nothing can unwind > to here: > > + # Start using new stack > + stp x29, x30, [x0, -16]! > + mov sp, x0 > > Also we no longer need split_stack_arg_pointer_used_p () or any code that &g

[PATCH v3 2/2] aarch64: Add split-stack initial support

2016-10-17 Thread Adhemerval Zanella
From: Adhemerval Zanella Changes from previous version: * Add missing new function comments; * Using gen_rtx_fmt_ee instead of gen_rtx_IF_THEN_ELSE to create conditional jumps; * Some typos and withspace issues. -- This patch adds the split-stack support on aarch64 (PR #67877). As for

[PATCH 1/2] Fix GCC split-stack variadic argument tests

2016-10-17 Thread Adhemerval Zanella
This test adds the expect va_end after va_start on split-stack tests. gcc/ChangeLog: * gcc/testsuite/gcc.dg/split-3.c (down): Call va_end after va_start. * gcc/testsuite/gcc.dg/split-6.c (down): Likewise. --- gcc/ChangeLog | 5 + gcc/testsuite/gcc.dg/split-3.

Re: [PATCH v2] aarch64: Add split-stack initial support

2016-10-11 Thread Adhemerval Zanella
On 07/10/2016 05:28, Kyrill Tkachov wrote: > Hi Adhemerval, > > CC'ing the aarch64 maintainers/reviewers. > I have some comments inline, mostly about the GCC coding conventions. Thanks for the review. >> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >> index df6514d.

[PATCH v2] aarch64: Add split-stack initial support

2016-10-06 Thread Adhemerval Zanella
From: Adhemerval Zanella Changes from previous version: - Rewrite how to setup variadic argument: instead of using the hard_fp_offset value to setup the x10, save a fp value before stack allocation instead. This allows linker/gold to not require scan and change in case of split to

Re: [PATCH] aarch64: Add split-stack initial support

2016-08-18 Thread Adhemerval Zanella
On 08/08/2016 07:58, Jiong Wang wrote: > > Adhemerval Zanella writes: > >>> diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c >>> index e56398a..2cf239f 100644 >>> --- a/gcc/config/aarch64/aarch64.c >>> +++ b/gcc/con

Re: [PATCH] aarch64: Add split-stack initial support

2016-08-05 Thread Adhemerval Zanella
Ping. On 28/07/2016 17:36, Adhemerval Zanella wrote: > From: Adhemerval Zanella > > This patch adds the split-stack support on aarch64 (PR #67877). As for > other ports this patch should be used along with glibc and gold support. > > The support is done similar to othe

[PATCH] aarch64: Add split-stack initial support

2016-07-28 Thread Adhemerval Zanella
From: Adhemerval Zanella This patch adds the split-stack support on aarch64 (PR #67877). As for other ports this patch should be used along with glibc and gold support. The support is done similar to other architectures: a __private_ss field is added on TCB in glibc, a target-specific

Re: [PATCH 1/7] Libsanitizer merge from upstream r249633.

2015-10-14 Thread Adhemerval Zanella
On 14-10-2015 04:54, Jakub Jelinek wrote: > On Tue, Oct 13, 2015 at 07:54:33PM +0300, Maxim Ostapenko wrote: >> On 13/10/15 14:15, Maxim Ostapenko wrote: >>> This is the raw merge itself. I'm bumping SONAME to libasan.so.3. >>> >>> -Maxim >> >> I have just noticed that I've misused autoconf stuff

[PATCH] rs6000: Fix HTM tcheck assembly encoding

2015-02-20 Thread Adhemerval Zanella
gcc/ChangeLog: * config/rs6000/htm.md (tcheck): Fix assembly encoding. gcc/testsuite/ChangeLog * gcc.target/powerpc/htm-builtin-1.c: Fix tcheck expect value. --- diff --git a/gcc/config/rs6000/htm.md b/gcc/config/rs6000/htm.md index 2c4689f..79fb740 100644 --- a/gcc/config/rs60

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-09-04 Thread Adhemerval Zanella
On 03-09-2014 11:01, Maciej W. Rozycki wrote: > On Tue, 2 Sep 2014, Adhemerval Zanella wrote: > >> Ping. >> >> On 19-08-2014 13:54, Adhemerval Zanella wrote: >>> Ping. >>> >>> On 06-08-2014 17:21, Adhemerval Zanella wrote: >>>> On 01-

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-09-02 Thread Adhemerval Zanella
Ping. On 19-08-2014 13:54, Adhemerval Zanella wrote: > Ping. > > On 06-08-2014 17:21, Adhemerval Zanella wrote: >> On 01-08-2014 12:31, Joseph S. Myers wrote: >>> On Thu, 31 Jul 2014, David Edelsohn wrote: >>> >>>> Thanks for implementing the FENV supp

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-08-19 Thread Adhemerval Zanella
Ping. On 06-08-2014 17:21, Adhemerval Zanella wrote: > On 01-08-2014 12:31, Joseph S. Myers wrote: >> On Thu, 31 Jul 2014, David Edelsohn wrote: >> >>> Thanks for implementing the FENV support. The patch generally looks >>> good to me. >>> >>>

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-08-06 Thread Adhemerval Zanella
testcase patch is the same as before. Checked on both linux-powerpc64/powerpc64le and no regressions found. -- 2014-08-06 Adhemerval Zanella gcc: * config/rs6000/rs6000.c (rs6000_atomic_assign_expand_fenv): New function. gcc/testsuite: * gcc.dg/

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-07-16 Thread Adhemerval Zanella
Ping. On 03-07-2014 18:08, Adhemerval Zanella wrote: > This patch implements the TARGET_ATOMIC_ASSIGN_EXPAND_FENV for > powerpc-fpu. I have to adjust current c11-atomic-exec-5 testcase > because for IBM long double 0 += LDBL_MAX might generate > overflow/underflow in interna

[COMMITTED] Add myself to MAINTAINERS file

2014-07-16 Thread Adhemerval Zanella
Hi, This patch adds myself to the MAINTAINERS file. Commmitted as 212652. -- 2014-07-16 Adhemerval Zanella mailto:azanella%40linux.vnet.ibm.com>> * MAINTAINERS (Write After Approval): Add myself. --- --- trunk/MAINTAINERS 2014/07/16 14:21:34 212651 +++ trunk/MAINT

[PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-07-03 Thread Adhemerval Zanella
, checked on powerpc32-linux-fpu, powerpc64-linux, and powerpc64le-linux. -- 2014-07-03 Adhemerval Zanella gcc: * config/rs6000/rs6000.c (rs6000_atomic_assign_expand_fenv): New function. gcc/testsuite: * gcc.dg/atomic/c11-atomic-exec-5.c

Re: [PATCH, PR 57363] IBM long double: adding qNaN and number raises inexact exception

2013-11-20 Thread Adhemerval Zanella
On 20-11-2013 14:23, David Edelsohn wrote: > On Wed, Nov 20, 2013 at 9:11 AM, Adhemerval Zanella > wrote: > >> libgcc/ChangeLog: >> >> 2013-11-20 Adhemerval Zanella >> >> * config/rs6000/ibm-ldouble.c (__gcc_qadd): Fix add >> of n

Re: [PATCH, PR 57363] IBM long double: adding qNaN and number raises inexact exception

2013-11-20 Thread Adhemerval Zanella
Hi, This is a reformatted patch after Ulrich review: --- libgcc/ChangeLog: 2013-11-20 Adhemerval Zanella * config/rs6000/ibm-ldouble.c (__gcc_qadd): Fix add of normal number and qNaN to not raise an inexact exception. gcc/testsuite/ChangeLog: 2013-11-20 Adhemerval

Re: [PATCH, PR 57363] IBM long double: adding qNaN and number raises inexact exception

2013-11-18 Thread Adhemerval Zanella
On 18-11-2013 18:10, Ulrich Weigand wrote: > Adhemerval Zanella wrote: > >> 2013-11-15 Adhemerval Zanella * >> libgcc/config/rs6000/ibm-ldouble.c (__gcc_qadd): Fix add of normal number >> and qNaN to not raise an inexact exception. * >> gcc/testsuite/gcc.targ

Re: [PATCH, PR 57363] IBM long double: adding qNaN and number raises inexact exception

2013-11-18 Thread Adhemerval Zanella
he patch): > > Bye, > Ulrich > Here it is with updated ChangeLog. Tested on PPC32 and PPC64. The testcase fails at runtime without the fix with a FLoating-Point Exception. --- 2013-11-15 Adhemerval Zanella * libgcc/config/rs6000/ibm-ldouble.c (__gcc_qadd): Fix add of

[PATCH, PR 57363] IBM long double: adding qNaN and number raises inexact exception

2013-11-15 Thread Adhemerval Zanella
ACT_EXCEPTION), TEST_ff_f (nexttoward, 1.1L, qnan_value, qnan_value, NO_INEXACT_EXCEPTION), Fix tested on PPC32 and PPC64. --- 2013-11-15 Adhemerval Zanella * libgcc/config/rs6000/ibm-ldouble.c (__gcc_qadd): Fix add of normal number and sNaN to not raise an inexact exception. --- d