Re: [PATCH v2] gcov: Runtime configurable destination output

2016-06-04 Thread Aaron Conole
> It breaks profiledbootstrap: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71400 I am including a patch that should fix the issues introduced by my patch. I have confirmed behavior on my system, and built with profiledbootstrap as well as bootstrap. libgcc/ChangeLog: 2016-06-

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-06-03 Thread Aaron Conole
"H.J. Lu" writes: > On Mon, May 23, 2016 at 11:16 AM, Aaron Conole wrote: >> Nathan Sidwell writes: >> >>> On 05/19/16 14:40, Aaron Conole wrote: >>>> Nathan Sidwell writes: >>> >>>>>> +FILE *__gcov_error_file = NULL

Re: [PATCH v4] gcov: Runtime configurable destination output

2016-05-31 Thread Aaron Conole
Nathan Sidwell writes: > On 05/26/16 13:08, Aaron Conole wrote: >> The previous gcov behavior was to always output errors on the stderr channel. >> This is fine for most uses, but some programs will require stderr to be >> untouched by libgcov for certain tests. This chan

[PATCH v4] gcov: Runtime configurable destination output

2016-05-26 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be untouched by libgcov for certain tests. This change allows configuring the gcov output via an environment variable which will be used to open the app

[PATCH v3] gcov: Runtime configurable destination output

2016-05-23 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be untouched by libgcov for certain tests. This change allows configuring the gcov output via an environment variable which will be used to open the app

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-05-23 Thread Aaron Conole
Nathan Sidwell writes: > On 05/19/16 14:40, Aaron Conole wrote: >> Nathan Sidwell writes: > >>>> +FILE *__gcov_error_file = NULL; >>> >>> Unless I'm missing something, isn't this only accessed from this file? >>> (So could be stat

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-05-19 Thread Aaron Conole
Nathan Sidwell writes: > On 02/24/16 16:52, Aaron Conole wrote: >> The previous gcov behavior was to always output errors on the stderr channel. >> This is fine for most uses, but some programs will require stderr to be >> untouched by libgcov for certain tests. This chan

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-04-29 Thread Aaron Conole
Nathan Sidwell writes: > On 04/27/16 16:59, Aaron Conole wrote: >> Apologies for the top post. Pinging on this again. It still applies >> cleanly, so no need to resubmit, I think. Is there anything else missing >> or required before this can go in? > > I'm n

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-04-27 Thread Aaron Conole
Apologies for the top post. Pinging on this again. It still applies cleanly, so no need to resubmit, I think. Is there anything else missing or required before this can go in? Thanks, -Aaron Aaron Conole writes: > The previous gcov behavior was to always output errors on the stderr chan

Re: [PATCH v2] gcov: Runtime configurable destination output

2016-04-15 Thread Aaron Conole
Ping on this; what are the next steps? Thanks Aaron Conole writes: > The previous gcov behavior was to always output errors on the stderr channel. > This is fine for most uses, but some programs will require stderr to be > untouched by libgcov for certain tests. This change allows co

[PATCH v2] gcov: Runtime configurable destination output

2016-02-24 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be untouched by libgcov for certain tests. This change allows configuring the gcov output via an environment variable which will be used to open the app

Re: [PATCH] gcov: Configurable destination for error output

2016-02-23 Thread Aaron Conole
Nathan Sidwell writes: > On 02/22/16 14:35, Aaron Conole wrote: > >> D'oh, you're probably right. In my excitement to contribute, I forgot >> this was shared. I think 'w' should be correct, since this isn't >> intended to be read at all,

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Aaron Conole writes: > Nathan Sidwell writes: > >> On 02/22/16 13:11, Aaron Conole wrote: >>> Nathan Sidwell writes: >>> >>> Hi Nathan, thanks so much for looking at this! >>> >>>> On 02/22/16 12:03, Aaron Conole wrote: >>>&g

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: > On 02/22/16 13:11, Aaron Conole wrote: >> Nathan Sidwell writes: >> >> Hi Nathan, thanks so much for looking at this! >> >>> On 02/22/16 12:03, Aaron Conole wrote: >>>> The previous gcov behavior was to always output error

Re: [PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
Nathan Sidwell writes: Hi Nathan, thanks so much for looking at this! > On 02/22/16 12:03, Aaron Conole wrote: >> The previous gcov behavior was to always output errors on the stderr channel. >> This is fine for most uses, but some programs will require stderr to be >> sil

[PATCH] gcov: Configurable destination for error output

2016-02-22 Thread Aaron Conole
The previous gcov behavior was to always output errors on the stderr channel. This is fine for most uses, but some programs will require stderr to be silent for certain tests. This change allows configuring the gcov output by an environment variable which will be used to open the appropriate file.