Re: [Fortran, Patch, PR120711, v1] 1/(3) Fix out of bounds access in cleanup of array constructor

2025-07-08 Thread Harald Anlauf
Am 09.07.25 um 08:50 schrieb Andre Vehreschild: HI Harald, hi Mikael, why shall the testcase be invalid? The `list` is empty. Concatenating with it is valid in Fortran like in most other programming languages. The mapping of an empty list in gfortran is to have the array's data pointer set to NU

Re: [Fortran, Patch, PR120711, v1] 1/(3) Fix out of bounds access in cleanup of array constructor

2025-07-08 Thread Andre Vehreschild
HI Harald, hi Mikael, why shall the testcase be invalid? The `list` is empty. Concatenating with it is valid in Fortran like in most other programming languages. The mapping of an empty list in gfortran is to have the array's data pointer set to NULL and the ubound below the lbound. Current gfortr

[PATCH 2/2] tree-optimization/109893 - allow more backwards jump threading

2025-07-08 Thread Richard Biener
The following changes the percentage that determines how many stmts are allowed for backwards jump threading from 50 to 54, enabling the missed jump threading observed in PR109893. Bootstrapped and tested on x86_64-unknown-linux-gnu. It seems that at least backward threading is prone to profile m

[PATCH 1/2] Change how --param fsm-scale-path-stmts works

2025-07-08 Thread Richard Biener
Currently we scale the number of stmts allowed for forward jump threading to limit those for backwards jump threading by applying a factor of two to the counted stmts. That doesn't allow fine-grained adjustments, like by a single stmt as needed for PR109893. The following changes the factor to be

Re: [PATCH v2 3/3] middle-end/121005 Add checks for TREE_LANG_FLAG_*

2025-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2025 at 11:54:23PM -0600, Alex (Waffl3x) wrote: > --- a/gcc/tree.h > +++ b/gcc/tree.h > @@ -571,6 +571,15 @@ extern void omp_clause_range_check_failed (const_tree, > const char *, int, >TREE_CHECK6 (T, INTEGER_TYPE, ENUMERAL_TYPE, BOOLEAN_TYPE, REAL_TYPE, > \ >

[PATCH v2 3/3] middle-end/121005 Add checks for TREE_LANG_FLAG_*

2025-07-08 Thread Alex (Waffl3x)
From df25e9a27938123e4e3737f1532b402b0fd320e3 Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:52:05 -0600 Subject: [PATCH 3/3] middle-end/121005 Add checks for TREE_LANG_FLAG_* TREE_LANG_FLAG_* is only valid for tree codes that do not use other union fields in tree_base, previous

[PATCH v2 2/3] tree: Add 7 and 8 argument TREE_[NOT_]CHECK_*

2025-07-08 Thread Alex (Waffl3x)
From 979825e4528bebf5ed83b5580e3d39fb738f43b7 Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:28:12 -0600 Subject: [PATCH 2/3] tree: Add 7 and 8 argument TREE_[NOT_]CHECK_* I needed an 8 argument version of TREE_NOT_CHECK_*, it felt wrong to leave a gap so the other versions are

[PATCH v2 1/3] tree: Add TREE_NOT_RANGE_CHECK

2025-07-08 Thread Alex (Waffl3x)
Fixed some very obvious errors that should have been fixed before I submitted v1, lesson learned this time I hope. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? From 32fa771d65eeca675d268bcf96b654fe5ac64eaf Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:25:20 -0600

[PATCH v1] RISCV: Remove the v extension requirement for sat scalar run test

2025-07-08 Thread pan2 . li
From: Pan Li The sat scalar run test should not require the v extension, thus take rv32 || rv64 instead of riscv_v for the requirement. The below test suites are passed for this patch series. * The rv64gcv fully regression test. * The rv32gcv fully regression test. gcc/testsuite/ChangeLog:

Re: [AutoFDO] Fix get_original_name to strip only names that are generated after auto-profile

2025-07-08 Thread Kugan Vivekanandarajah
Hi Honza, > On 28 Jun 2025, at 1:04 pm, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > HI, > I have tested your patch on exchange2 and noticed multiple problems: > 1) with LTO the translation from dwarf names to symbol names is disabled > since we fr

RE: [PATCH V3] x86: Enable separate shrink wrapping

2025-07-08 Thread Cui, Lili
> -Original Message- > From: Segher Boessenkool > Sent: Wednesday, July 9, 2025 1:13 AM > To: Cui, Lili > Cc: ubiz...@gmail.com; gcc-patches@gcc.gnu.org; Liu, Hongtao > ; richard.guent...@gmail.com; Michael Matz > > Subject: Re: [PATCH V3] x86: Enable separate shrink wrapping > > Hi! >

[PATCH 1/3] tree: Add TREE_NOT_RANGE_CHECK

2025-07-08 Thread Alex (Waffl3x)
From d7107c64189f944adfb64f9e8acfb7ed2cbfe796 Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:25:20 -0600 Subject: [PATCH 1/3] tree: Add TREE_NOT_RANGE_CHECK There was no inverted counterpart to TREE_RANGE_CHECK, this adds one. gcc/ChangeLog: * tree.cc (tree_not_range_check_fa

[PATCH 3/3] middle-end/121005 Add checks for TREE_LANG_FLAG_*

2025-07-08 Thread Alex (Waffl3x)
From 11f2b46bb882c427f45f194196d89b22ec470240 Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:52:05 -0600 Subject: [PATCH 3/3] middle-end/121005 Add checks for TREE_LANG_FLAG_* TREE_LANG_FLAG_* is only valid for tree codes that do not use other union fields in tree_base, previous

[PATCH 2/3] tree: Add 7 and 8 argument TREE_CHECK_* and TREE_NOT_CHECK_*

2025-07-08 Thread Alex (Waffl3x)
From 0403104f65dd8cce4c71270d492d0922a7f2702c Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Tue, 8 Jul 2025 19:28:12 -0600 Subject: [PATCH 2/3] tree: Add 7 and 8 argument TREE_CHECK_* and TREE_NOT_CHECK_* I needed an 8 argument version of TREE_NOT_CHECK_*, it felt wrong to leave a gap so the oth

[PATCH 0/3] middle-end/121005 Add checks for TREE_LANG_FLAG_*

2025-07-08 Thread Alex (Waffl3x)
This set of patches are not tested quite yet, I'm going to start it as soon as I finish this e-mail. I would really like to implement the multiple argument tree_check* and tree_not_check* as a variadic template. I know how to do it in such a way that would limit the amount of instantiations, and

[PATCH 2/2] lra: Reallow reloading user hard registers if the insn is not asm [PR 120983]

2025-07-08 Thread Xi Ruoyao
The PR 87600 fix has disallowed reloading user hard registers to resolve earlyclobber-induced conflict. However before reload, recog completely ignores the constraints of insns, so the RTL passes may produce insns where some user hard registers violate an earlyclobber. Then we'll get an ICE witho

[COMMITTED, PATCH] libstdc++: Update some baseline_symbols.txt (x32)

2025-07-08 Thread H.J. Lu
* config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt: Updated. -- H.J. From 98d20df2accfa045f1ad694b0b0d94855d7a75f3 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 9 Jul 2025 09:43:52 +0800 Subject: [PATCH] libstdc++: Update some baseline_symbols.txt (x32) * config/abi/post/x86_64

[PATCH 1/2] testsuite: Enable the PR 87600 tests for LoongArch

2025-07-08 Thread Xi Ruoyao
I'm going to refine a part of the PR 87600 fix which seems triggering PR 120983 that LoongArch is particularly suffering. Enable the PR 87600 tests so I'll not regress PR 87600. gcc/testsuite/ChangeLog: PR rtl-optimization/87600 PR rtl-optimization/120983 * gcc.dg/pr87600

[PATCH 0/2] Fix PR120983

2025-07-08 Thread Xi Ruoyao
Bootstrapped and regtested on aarch64-linux-gnu, loongarch64-linux-gnu, and x86_64-linux-gnu. Ok for trunk? Xi Ruoyao (2): testsuite: Enable the PR 87600 tests for LoongArch lra: Reallow reloading user hard registers if the insn is not asm [PR 120983] gcc/lra-constraints.cc |

Re: [PATCH] c++, libstdc++, v2: Implement C++26 P3068R5 - constexpr exceptions [PR117785]

2025-07-08 Thread Jason Merrill
On 6/6/25 9:17 AM, Jakub Jelinek wrote: On Wed, Jun 04, 2025 at 02:03:17PM +0200, Jakub Jelinek wrote: You mean also check TREE_NOTHROW (fndecl) which we currently propagate conservatively (if we can prove something never throws, we set it) or something else? If TREE_NOTHROW, that would be twice

RE: [PATCH v1] RISC-V: Disable uint128_t testcase of SAT_MUL when rv32

2025-07-08 Thread Li, Pan2
> It looks like there's ~200 uses of risc_v in dg-do run clauses in the > "sat" subdirectory tests. Should those be adjusted as well? Yes, I will take care of that soon. Pan -Original Message- From: Jeff Law Sent: Tuesday, July 8, 2025 9:47 PM To: Li, Pan2 ; gcc-patches@gcc.gnu.org C

[committed] libstdc++: Fix double free in new pool resource test [PR118681]

2025-07-08 Thread Jonathan Wakely
This was supposed to free p1 and p2, not free p2 twice. libstdc++-v3/ChangeLog: PR libstdc++/118681 * testsuite/20_util/unsynchronized_pool_resource/118681.cc: Fix deallocate argument. --- Tested x86_64-linux. Pushed to trunk. Thanks to Daniel Boles for noticing this.

libgo patch committed: Avoid libc memmove and memclr for pointers

2025-07-08 Thread Ian Lance Taylor
This libgo patch avoids the libc memmove and memclr functions when the type being moved or cleared may contain pointer values. This is necessary to ensure that Go's concurrent garbage collector doesn't see corrupt pointer values. The libc memmove and memclr don't reliably operate on full memory wo

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-08 Thread Qing Zhao
> On Jul 8, 2025, at 17:46, Siddhesh Poyarekar wrote: > > On 2025-07-08 17:17, Qing Zhao wrote: >> Are the above the correct and efficient updates to the .ACCESS_WITH_SIZE to >> resolve both PR121000 and the issue >> we have with counted_by for pointers? > > I don't know about PR121000, but f

Re: [PATCH] x86-64: Add --enable-x86-64-mfentry

2025-07-08 Thread Sam James
Uros Bizjak writes: > On Thu, Jul 3, 2025 at 12:01 PM H.J. Lu wrote: >> >> When profiling is enabled with shrink wrapping, the mcount call may not >> be placed at the function entry after >> >> pushq %rbp >> movq %rsp,%rbp >> >> As the result, the profile data may be skewed which makes PGO less

Re: [PATCH v2 1/1] contrib: add bpf-vmtest-tool to test BPF programs

2025-07-08 Thread David Faust
Hi Piyush, On 7/3/25 06:32, Piyush Raj wrote: > This patch adds the bpf-vmtest-tool subdirectory under contrib which tests > BPF programs under a live kernel using a QEMU VM. It automatically > builds the specified kernel version with eBPF support enabled > and stores it under "~/.bpf-vmtest-tool

libgo patch committed: Pass correct pointer to system call in recvmsgRaw

2025-07-08 Thread Ian Lance Taylor
This libgo patch passe the correct pointer to the system call in recvmsgRaw. The code in recvmsgRaw, introduced in CL 384695 (https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590289.html), incorrectly passed &rsa to the recvmsg system call. But in recvmsgRaw rsa is already a pointer passed b

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Robert Dubner
> -Original Message- > From: James K. Lowden > Sent: Tuesday, July 8, 2025 17:11 > To: Robert Dubner > Cc: Richard Biener ; Rainer Orth > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > On Tue, 8 Jul 2025 14:11:19 -0500 (CDT) > Robert Dubner

[to-be-committed][RISC-V] Avoid propagating constant AVL for theadvector

2025-07-08 Thread Jeff Law
AVL propagation currently assumes that it can propagate a constant AVL into any vector insn and trips an assert if the insn fails to recognize after such a propagation. However, for xtheadvector that is not a correct assumption; xtheadvector does not allow the vector length to be a constant

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-08 Thread Siddhesh Poyarekar
On 2025-07-08 17:17, Qing Zhao wrote: Are the above the correct and efficient updates to the .ACCESS_WITH_SIZE to resolve both PR121000 and the issue we have with counted_by for pointers? I don't know about PR121000, but for counted_by with pointers, I think the REF_TO_OBJ (and the result_typ

[PATCH] libstdc++: Do not use list-initialization in std::span members [PR120997]

2025-07-08 Thread Jonathan Wakely
As the bug report shows, for span the return statements of the form `return {data(), count};` will use the new C++26 constructor, span(initializer_list). Although the conversions from data() to bool and count to bool are narrowing and should be ill-formed, in system headers the narrowing diagnosti

Re: [PATCH] x86: Keep non all 0s/1s redundant vector loads on AMD znverN

2025-07-08 Thread H.J. Lu
On Tue, Jul 8, 2025 at 7:26 PM Richard Biener wrote: > > On Tue, Jul 8, 2025 at 12:48 PM H.J. Lu wrote: > > > > aba3b9d3a48a0703fd565f7c5f0caf604f59970b is the first bad commit > > commit aba3b9d3a48a0703fd565f7c5f0caf604f59970b > > Author: H.J. Lu > > Date: Fri May 9 07:17:07 2025 +0800 > > >

[PATCH] libstdc++: Fix __uninitialized_default for constexpr case

2025-07-08 Thread Jonathan Wakely
We should not use the std::fill optimization for trivial types during constant evaluation, because we need to begin the lifetime of all objects, even trivially default constructible ones. This fixes a bug that Clang diagnosed: include/c++/16.0.0/bits/stl_algobase.h:925:11: note: assignment to obj

[PATCH] libstdc++: Add more template keywords to for Clang

2025-07-08 Thread Jonathan Wakely
This fixes: include/c++/16.0.0/mdspan:1182:33: error: use 'template' keyword to treat 'mapping' as a dependent template name 1182 | const typename _OLayout::mapping<_OExtents>&> |^ include/c++/16.0.0/mdspan:1185:31: error: use 'template

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-08 Thread Qing Zhao
Hi, Jakub, Thanks a lot for your comments and suggestions. Please see my questions below: > On Jul 7, 2025, at 17:47, Jakub Jelinek wrote: > > On Mon, Jul 07, 2025 at 09:18:53PM +, Qing Zhao wrote: >> From OLD: >> >> _2 = &a->c; >> _3 = &a->count; >> _1 = .ACCESS_WITH_SIZE (_2, _3, 1, 0, -

Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread James K. Lowden
On Tue, 8 Jul 2025 14:11:19 -0500 (CDT) Robert Dubner wrote: > But I have other requirements. I apologize if I keep repeating > myself, but I am being forced to. > > I want to be able to, for example, > > CXXFLAGS='-ggdb -O0' > CXXFLAGS_FOR_COBOL="-Wsomething_or_other" ../configure

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Robert Dubner
> -Original Message- > From: Andreas Schwab > Sent: Tuesday, July 8, 2025 10:01 > To: Robert Dubner > Cc: Rainer Orth ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > There is already $(CFLAGS-$@) to add extra flags for a particular > target. Thi

[PATCH] libstdc++: Implement std::chrono::current_zone() for Windows

2025-07-08 Thread Björn Schäpers
From: Björn Schäpers I have based this on my previous (not yet landed) patch, but it only reuses the #ifdef to include . Since std::array isn't used anywhere else I thought that was the right place to put it. I hope the formatting is okay. I've used wide strings for the Windows zone name and te

[PATCH 1/1] aarch64: AND/BIC combines for unpacked SVE FP comparisons

2025-07-08 Thread Spencer Abson
This patch extends the splitting patterns for combining FP comparisons with predicated logical operations such that they cover all of SVE_F. gcc/ChangeLog: * config/aarch64/aarch64-sve.md (*fcm_and_combine): Extend from SVE_FULL_F to SVE_F. (*fcmuo_and_combine): Likewise.

[PATCH 0/1] aarch64: AND/BIC combines for unpacked SVE FP comparisons

2025-07-08 Thread Spencer Abson
Hi all, I'd like to commit this instead of the OK'd patch 05/14 from the unpacked FP series [1], as I later realised that: * I can use the existing unpacked_fcm_1.c file to test these splitting patterns, since the stores to out[i] are conditional on the comparison result a

[PATCH] c++: optional template after :: causing error [PR119838]

2025-07-08 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Found while working on Reflection where we currently reject: constexpr auto r = ^^::template C::type; which should work, because "::template C::" should match the nested-name-specifier template(opt) simple-template-id ::

Re: [Fortran, Patch, PR120711, v1] 1/(3) Fix out of bounds access in cleanup of array constructor

2025-07-08 Thread Harald Anlauf
Am 05.07.25 um 14:55 schrieb Mikael Morin: Hello Andre, I get a regression on this testcase with a patch that is otherwise regression-free. I think the testcase is invalid. It does:     type(container), allocatable :: list(:)     list = [list, new_elem(5)] so it's using the variable 'list

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-08 Thread Qing Zhao
I just updated PR121000: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=121000. Yes, the root cause is exactly what you mentioned in the other email: “ The IL must clearly use the value (the size of the element), otherwise DCE or other passes will happily optimize it away, they don't keep some expr

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Robert Dubner
> -Original Message- > From: Richard Biener > Sent: Tuesday, July 8, 2025 14:22 > To: Robert Dubner > Cc: Rainer Orth ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > On Tue, Jul 8, 2025 at 12:46 AM Robert Dubner wrote: > > > > > > > > > -Orig

Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Richard Biener
On Tue, Jul 8, 2025 at 12:46 AM Robert Dubner wrote: > > > > > -Original Message- > > From: Rainer Orth > > Sent: Monday, July 7, 2025 18:08 > > To: Robert Dubner > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > > > Hi Robert, > > > > > I

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Robert Dubner
> -Original Message- > From: Richard Biener > Sent: Tuesday, July 8, 2025 09:54 > To: Robert Dubner > Cc: Andreas Schwab ; Rainer Orth bielefeld.de>; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > On Tue, Jul 8, 2025 at 3:45 PM Robert Dubner wrot

Re: [PATCH] libstdc++: Add smart ptr owner_equals and owner_hash structs and members for P1901R2

2025-07-08 Thread Paul Keir
Thanks Jonathan. From: Jonathan Wakely Sent: 08 July 2025 1:37 PM To: Paul Keir Cc: gcc-patches@gcc.gnu.org; libstd...@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Add smart ptr owner_equals and owner_hash structs and members for P1901R2 Warning: Do no

Re: [PATCH v2] xtensa: Fix B[GE/LT]UI instructions with immediate values of 32768 or 65536 not being emitted

2025-07-08 Thread Max Filippov
On Mon, Jul 7, 2025 at 7:40 AM Takayuki 'January June' Suwa wrote: > > This is because in canonicalize_comparison() in gcc/expmed.cc, the COMPARE > rtx_cost() for the immediate values in the title does not change between > the old and new versions. This patch fixes that. > > (note: Currently, thi

Re: [PATCH] libstdc++: Make debug iterator pointer sequence const [PR116369]

2025-07-08 Thread François Dumont
Now fixed as trivial, I set you as author. François On 08/07/2025 13:55, Jonathan Wakely wrote: On Mon, 7 Jul 2025 at 11:12, Jonathan Wakely wrote: On Sat, 5 Jul 2025 at 14:03, François Dumont wrote: On 01/07/2025 22:51, Jonathan Wakely wrote: On Mon, 16 Jun 2025 at 18:36, François Dumont

Re: [PATCH V3] x86: Enable separate shrink wrapping

2025-07-08 Thread Segher Boessenkool
Hi! On Tue, Jul 08, 2025 at 08:51:30AM +, Cui, Lili wrote: > > rs6000 does not *have* a hard frame pointer! > > Oh, I see. The handling of HARD_FRAME_POINTER_REGNUM seems redundant for > rs6000. The Power Architecture, Power ISA, nor any of our ABIs has a frame pointer. GCC generic code r

[PATCH] libstdc++: Implement _Escaping_sink to avoid construction of string [PR119820]

2025-07-08 Thread Tomasz Kamiński
This patch implements _Escaping_sink, that stores characters in the local (stack) buffer, and when filled escapes the range to underlying sink. To support that we define __write_escaped_unicode_part functions, that takes the __str and __prev_esc by reference. The __prev_esc value is updated based

Re: [PATCH] c++: Implement part of C++26 P2686R4 - constexpr structured bindings [PR117784]

2025-07-08 Thread Jason Merrill
On 6/19/25 8:13 AM, Jakub Jelinek wrote: Hi! The following patch implements the constexpr structured bindings part of the P2686R4 paper, so the [dcl.pre], [dcl.struct.bind], [dcl.constinit] and first hunk in [dcl.constexpr] changes. The paper doesn't have a feature test macro and the constexpr s

Re: [PATCH] libstdc++: Make debug iterator pointer sequence const [PR116369]

2025-07-08 Thread François Dumont
Ah sorry, a problem of last minute change. I'll fix it if not done already. On 08/07/2025 13:55, Jonathan Wakely wrote: On Mon, 7 Jul 2025 at 11:12, Jonathan Wakely wrote: On Sat, 5 Jul 2025 at 14:03, François Dumont wrote: On 01/07/2025 22:51, Jonathan Wakely wrote: On Mon, 16 Jun 2025 at

Re: [PATCH v4] c++: Unwrap type traits defined in terms of builtins within diagnostics [PR117294]

2025-07-08 Thread Jason Merrill
On 5/30/25 11:22 PM, Nathaniel Shead wrote: On Fri, May 30, 2025 at 11:10:08AM -0400, Patrick Palka wrote: On Fri, 30 May 2025, Patrick Palka wrote: On Fri, 30 May 2025, Nathaniel Shead wrote: On Wed, May 28, 2025 at 02:14:06PM -0400, Patrick Palka wrote: On Tue, 27 May 2025, Nathaniel Shea

Re: [PATCH] testsuite: arm: Update function body for scheduler

2025-07-08 Thread Christophe Lyon
On Tue, 8 Jul 2025 at 17:17, Torbjörn SVENSSON wrote: > > Ok for trunk and releases/gcc-15? > > -- > > The scheduler allows the `and` instruction to be placed at 3 different > locations. Update the function body to contain all 3 locations. > Also, armv8.1-m.main can use `ldr` instead of `pop` to r

Re: [PATCH] [libiberty] PR other/108662 Replace explicit linking to GlobalMemoryStatusEx() with implicit linking

2025-07-08 Thread Jan Dubiec
BUMP

Re: [PATCH] c++/modules: Support re-streaming TU_LOCAL_ENTITYs [PR120412]

2025-07-08 Thread Jason Merrill
On 5/23/25 9:00 PM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk/15? -- >8 -- When emitting a primary module interface, we must re-stream any TU-local entities that we saw in a partition. This patch adds the missing members from core_vals. As a drive-

Re: [PATCH v2 2/2] libstdc++: Better CTAD for span and mdspan [PR120914].

2025-07-08 Thread Tomasz Kaminski
On Tue, Jul 8, 2025 at 6:18 PM Luc Grosheintz wrote: > > > On 7/8/25 17:11, Tomasz Kaminski wrote: > > This was merged. Thanks for working on it. > > > > However, the constant_wrapper paper accepted in Sofia, modifies the > concept: > > https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p27

Re: [PATCH] c, c++: Fix unused result for empty types [PR82134]

2025-07-08 Thread Jason Merrill
On 6/9/25 9:00 PM, Jeremy Rifkin wrote: Hi, This fixes PR c/82134 which concerns gcc emitting an incorrect unused result diagnostic for empty types. This diagnostic is emitted from tree-cfg.cc because of a couple code paths which attempt to avoid copying empty types, resulting in GIMPLE that isn'

Re: [PATCH v2 2/2] libstdc++: Better CTAD for span and mdspan [PR120914].

2025-07-08 Thread Luc Grosheintz
On 7/8/25 17:11, Tomasz Kaminski wrote: This was merged. Thanks for working on it. However, the constant_wrapper paper accepted in Sofia, modifies the concept: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2781r8.html Interesting! I'll go hiking for 3 days, then I'll look at thi

Re: [PATCH] c++: bogus error with union in qualified name [PR83469]

2025-07-08 Thread Jason Merrill
On 7/8/25 11:32 AM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- While working on Reflection I noticed that we reject: union U { int i; }; constexpr auto r = ^^typename ::U; which is due to PR83469. Andrew P. posted a patch in 2021: https://

Re: [PATCH] c++: P2036R3 - Change scope of lambda trailing-return-type [PR102610]

2025-07-08 Thread Jason Merrill
On 7/7/25 4:52 PM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- This patch is an attempt to implement P2036R3 along with P2579R0, fixing build breakages caused by P2036R3. The simplest example is: auto counter1 = [j=0]() mutable -> decltype(j) {

Re: [PATCH] Check backend when setting DECL_ALIGN for PARM_DECL

2025-07-08 Thread Jason Merrill
On 7/8/25 9:44 AM, Richard Biener wrote: On Tue, Jul 8, 2025 at 3:25 PM Jason Merrill wrote: On 7/8/25 4:35 AM, Richard Biener wrote: On Mon, Jul 7, 2025 at 11:33 PM H.J. Lu wrote: On Tue, Jul 8, 2025 at 5:02 AM H.J. Lu wrote: On Mon, Jul 7, 2025 at 11:08 PM Jason Merrill wrote: On 7

Re: [PATCH 3/7] aarch64: Handle DImode BCAX operations

2025-07-08 Thread Richard Sandiford
Kyrylo Tkachov writes: > Thanks for your comments, do you mean something like the following? Yeah, the patch LGTM, thanks. Richard > Or do you mean to have separate alternatives with each one individually tying > one of operands 2 or 3 to r0? > > Kyrill > > >> >> Thanks, >> Tamar >> >>> Than

Re: [PATCH v1 3/3] libstdc++: Implement aligned_accessor from mdspan.

2025-07-08 Thread Tomasz Kaminski
On Thu, Jul 3, 2025 at 12:38 PM Luc Grosheintz wrote: > This commit completes the implementation of P2897R7 by implementing and > testing the template class aligned_accessor. > > libstdc++-v3/ChangeLog: > > * include/bits/version.def (aligned_accessor): Add. > * include/bits/versi

[PATCH] c++: bogus error with union in qualified name [PR83469]

2025-07-08 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- While working on Reflection I noticed that we reject: union U { int i; }; constexpr auto r = ^^typename ::U; which is due to PR83469. Andrew P. posted a patch in 2021: https://gcc.gnu.org/pipermail/gcc-patches/2021-Decemb

Re: [PATCH v1 1/1] libiberty: add common methods for type-sensitive doubly linked lists

2025-07-08 Thread Richard Sandiford
Matthieu Longo writes: > Those methods's implementation is relying on duck-typing at compile > time. > The structure corresponding to the node of a doubly linked list needs > to define attributes 'prev' and 'next' which are pointers on the type > of a node. > The structure wrapping the nodes and o

Re: [PATCH][15.2] nr2.0: late: Correctly initialize funny_error member

2025-07-08 Thread Arthur Cohen
Pushed to the gcc-15 branch today. Thanks, Arthur On 4/29/25 9:20 AM, arthur.co...@embecosm.com wrote: From: Arthur Cohen Hi everyone, We noticed inconsistent errors when running name-resolution 2.0 on certain files, where an invalid error was triggered and the message was from the `funny_i

[PATCH] RISC-V: Enable zvfh for vector-scalar half-float run tests

2025-07-08 Thread Paul-Antoine Arras
zvfh is not enabled at the testsuite level. It has to be enabled on a testcase by testcase basis. This was correctly done for compile tests but not for run tests. This patch fixes it. Also, to ensure correct results with half-precision floats, MAX_RELATIVE_DIFF is set according to the type. gcc/te

[PATCH] testsuite: arm: Update function body for scheduler

2025-07-08 Thread Torbjörn SVENSSON
Ok for trunk and releases/gcc-15? -- The scheduler allows the `and` instruction to be placed at 3 different locations. Update the function body to contain all 3 locations. Also, armv8.1-m.main can use `ldr` instead of `pop` to return. gcc/testsuite/ChangeLog: * gcc.target/arm/unsigned-e

Re: [PATCH v2 2/2] libstdc++: Better CTAD for span and mdspan [PR120914].

2025-07-08 Thread Tomasz Kaminski
This was merged. Thanks for working on it. However, the constant_wrapper paper accepted in Sofia, modifies the concept: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p2781r8.html On Tue, Jul 8, 2025 at 1:01 PM Tomasz Kaminski wrote: > Maybe adding a negative test for the error when c

Re: [PATCH v1 2/3] libstdc++: Prepare test code for default_accessor for reuse.

2025-07-08 Thread Tomasz Kaminski
On Thu, Jul 3, 2025 at 12:36 PM Luc Grosheintz wrote: > All test code of default_accessor can be reused. This commit moves > the reuseable code into a file generic.cc and prepares the tests for > reuse with aligned_accessor. > > The AllocatorTrait creates a unified interface for creating both > d

Re: [PATCH v1 1/3] libstdc++: Implement is_sufficiently_aligned.

2025-07-08 Thread Tomasz Kaminski
On Thu, Jul 3, 2025 at 12:36 PM Luc Grosheintz wrote: > This commit implements and tests the function is_sufficiently_aligned > from P2897R7. > > libstdc++-v3/ChangeLog: > > * include/bits/align.h (is_sufficiently_aligned): New function. > * include/bits/version.def (is_sufficient

[COMMITTED] s390: Always compute address of stack protector guard

2025-07-08 Thread Stefan Schulze Frielinghaus
Computing the address of the thread pointer on s390 involves multiple instructions and therefore bears the risk that the address of the canary or intermediate values of it are spilled after prologue in order to be reloaded for the epilogue. Since there exists no mechanism to ensure that a value is

Re: [PATCH] tree-optimization/120929: Limit MEM_REF handling to .ACCESS_WITH_SIZE

2025-07-08 Thread Qing Zhao
Hi, > On Jul 8, 2025, at 01:18, Jakub Jelinek wrote: >> >>>5th argument ACCESS_MODE: >>> -1: Unknown access semantics >>> 0: none >>> 1: read_only >>> 2: write_only >>> 3: read_write >>>6th argument: A constant 0 with the pointer TYPE to the original flexible >>>

Re: [PATCH] libgfortran: add fallback for trigonometric pi-based functions

2025-07-08 Thread Yuao Ma
On 7/8/2025 2:03 AM, Steve Kargl wrote: On Sun, Jul 06, 2025 at 09:09:53PM +0800, Yuao Ma wrote: Hi Tobias, On 7/6/2025 6:34 PM, Tobias Burnus wrote: As that commit is from 2020 and 2.69 in from 2012, it seems as if your autoconf is too new. Can you re-check that the right version is at the

Re: [PATCH] arm_neon.h: remove useless push/pop pragmas

2025-07-08 Thread Richard Earnshaw (lists)
On 27/05/2025 07:33, Christophe Lyon wrote: > On Mon, 26 May 2025 at 18:14, Christophe Lyon > wrote: >> >> Remove #pragma GCC target ("arch=armv8.2-a+bf16") and preceding >> target and is thus useless. > I guess this should read: > Remove #pragma GCC target ("arch=armv8.2-a+bf16") since it matches

Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Andreas Schwab
There is already $(CFLAGS-$@) to add extra flags for a particular target. This could easily be extended by adding $(CFLAGS-$(@D)) to add flags for all targets in a directory. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "An

Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Richard Biener
On Tue, Jul 8, 2025 at 3:45 PM Robert Dubner wrote: > > > -Original Message- > > From: Andreas Schwab > > Sent: Tuesday, July 8, 2025 03:16 > > To: Robert Dubner > > Cc: Rainer Orth ; gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > > > On Jul 07

Re: [PATCH] riscv: allow zero in zacas subword atomic cas

2025-07-08 Thread Andreas Schwab
Please fix your git to remove the subject prefix. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v1] RISC-V: Disable uint128_t testcase of SAT_MUL when rv32

2025-07-08 Thread Jeff Law
On 7/7/25 9:48 PM, Li, Pan2 wrote: Is that correct? Don't you need to be testing that the platform has vector in addition to being rv64? It is riscv.exp test, so I think vector extension is not required here. Oh, I see. We're not actually turning on RVV anywhere. OK for the trunk. It lo

Re: [PATCH v4 0/6] Implement mdspan.

2025-07-08 Thread Tomasz Kaminski
All patches were merged. I will double check that we got all the papers listed and the issue, and close it. Thanks again for your submissions. On Tue, Jul 8, 2025 at 10:26 AM Luc Grosheintz wrote: > Patches 1/5 ... 4/5 aren't sent because corresponding commits from v3 > should be used. The chang

Re: [PATCH] Check backend when setting DECL_ALIGN for PARM_DECL

2025-07-08 Thread Richard Biener
On Tue, Jul 8, 2025 at 3:25 PM Jason Merrill wrote: > > On 7/8/25 4:35 AM, Richard Biener wrote: > > On Mon, Jul 7, 2025 at 11:33 PM H.J. Lu wrote: > >> > >> On Tue, Jul 8, 2025 at 5:02 AM H.J. Lu wrote: > >>> > >>> On Mon, Jul 7, 2025 at 11:08 PM Jason Merrill wrote: > > On 7/1/25 5:

RE: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL.

2025-07-08 Thread Robert Dubner
> -Original Message- > From: Andreas Schwab > Sent: Tuesday, July 8, 2025 03:16 > To: Robert Dubner > Cc: Rainer Orth ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] cobol: Implement CXXFLAGS_FOR_COBOL. > > On Jul 07 2025, Robert Dubner wrote: > > > Furthermore, even if this method did

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Tomasz Kaminski
On Sat, Jul 5, 2025 at 1:12 AM Jonathan Wakely wrote: > For allocations with size > alignment and size % alignment != 0 we were > sometimes returning pointers that did not meet the requested aligment. > For example, allocate(24, 16) would select the pool for 24-byte objects > and the second alloc

Re: [PATCH 3/7] aarch64: Handle DImode BCAX operations

2025-07-08 Thread Kyrylo Tkachov
> On 8 Jul 2025, at 12:39, Tamar Christina wrote: > >> -Original Message- >> From: Richard Sandiford >> Sent: Tuesday, July 8, 2025 10:07 AM >> To: Tamar Christina >> Cc: Kyrylo Tkachov ; GCC Patches > patc...@gcc.gnu.org>; Richard Earnshaw ; Alex >> Coplan ; Andrew Pinski >> Subject

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Tomasz Kaminski
On Tue, Jul 8, 2025 at 3:24 PM Jonathan Wakely wrote: > On Tue, 8 Jul 2025 at 14:12, Tomasz Kaminski wrote: > > > > > > > > On Tue, Jul 8, 2025 at 2:48 PM Jonathan Wakely > wrote: > >> > >> On Tue, 8 Jul 2025 at 13:31, Tomasz Kaminski > wrote: > >> > > >> > > >> > > >> > On Sat, Jul 5, 2025 at

Re: [PATCH] riscv: allow zero in zacas subword atomic cas

2025-07-08 Thread Jeff Law
On 7/8/25 5:08 AM, Andreas Schwab wrote: gcc: PR target/120995 * config/riscv/sync.md (zacas_atomic_cas_value_strong): Allow op3 to be zero. gcc/testsuite: PR target/120995 * gcc.target/riscv/amo/zabha-zacas-atomic-cas.c: New test. Thanks. I didn't se

Re: [PATCH] Check backend when setting DECL_ALIGN for PARM_DECL

2025-07-08 Thread Jason Merrill
On 7/8/25 4:35 AM, Richard Biener wrote: On Mon, Jul 7, 2025 at 11:33 PM H.J. Lu wrote: On Tue, Jul 8, 2025 at 5:02 AM H.J. Lu wrote: On Mon, Jul 7, 2025 at 11:08 PM Jason Merrill wrote: On 7/1/25 5:36 PM, H.J. Lu wrote: On Tue, Jul 1, 2025 at 9:37 PM Jason Merrill wrote: On 6/30/25

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Jonathan Wakely
On Tue, 8 Jul 2025 at 14:12, Tomasz Kaminski wrote: > > > > On Tue, Jul 8, 2025 at 2:48 PM Jonathan Wakely wrote: >> >> On Tue, 8 Jul 2025 at 13:31, Tomasz Kaminski wrote: >> > >> > >> > >> > On Sat, Jul 5, 2025 at 1:12 AM Jonathan Wakely wrote: >> >> >> >> For allocations with size > alignment

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Jonathan Wakely
On Tue, 8 Jul 2025 at 14:12, Tomasz Kaminski wrote: > > > > On Tue, Jul 8, 2025 at 2:48 PM Jonathan Wakely wrote: >> >> On Tue, 8 Jul 2025 at 13:31, Tomasz Kaminski wrote: >> > >> > >> > >> > On Sat, Jul 5, 2025 at 1:12 AM Jonathan Wakely wrote: >> >> >> >> For allocations with size > alignment

Re: [PATCH] Avoid IPA opts around guality plumbing

2025-07-08 Thread Jakub Jelinek
On Tue, Jul 08, 2025 at 03:17:39PM +0200, Richard Biener wrote: > The following avoids inlining the actual main() (renamed to > guality_main) into the guality plumbing. This can cause > jump threading opportunities to appear and generally increase > the chance what we actually test isn't what we t

[PATCH] Avoid IPA opts around guality plumbing

2025-07-08 Thread Richard Biener
The following avoids inlining the actual main() (renamed to guality_main) into the guality plumbing. This can cause jump threading opportunities to appear and generally increase the chance what we actually test isn't what we think. Likewise make guality_check noipa instead of just noinline. Boot

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Tomasz Kaminski
On Tue, Jul 8, 2025 at 2:48 PM Jonathan Wakely wrote: > On Tue, 8 Jul 2025 at 13:31, Tomasz Kaminski wrote: > > > > > > > > On Sat, Jul 5, 2025 at 1:12 AM Jonathan Wakely > wrote: > >> > >> For allocations with size > alignment and size % alignment != 0 we were > >> sometimes returning pointers

Re: [PATCH] RISC-V: Ignore non-types in builtin function hash.

2025-07-08 Thread Jeff Law
On 7/8/25 6:21 AM, Robin Dapp wrote: Hi, if a user passes a string that doesn't represent a variable we still try to compute a hash for its type.  Its tree does not represent a type but just an exceptional, though.  This patch just ignores it, leaving the error to the checking code later. Re

Re: [PATCH] RISC-V: Do not use vsetivli for THeadVector.

2025-07-08 Thread Jeff Law
On 7/8/25 6:21 AM, Robin Dapp wrote: Hi, in emit_vlmax_insn_lra we use a vsetivli for an immediate AVL. XTHeadVector does not support this, so guard appropriately. Regtested on rv64gcv_zvl512b. Regards Robin PR target/120461 gcc/ChangeLog: * config/riscv/riscv-v.cc (emit_vlmax_

Re: [PATCH] libstdc++: Ensure pool resources meet alignment requirements [PR118681]

2025-07-08 Thread Jonathan Wakely
On Tue, 8 Jul 2025 at 13:31, Tomasz Kaminski wrote: > > > > On Sat, Jul 5, 2025 at 1:12 AM Jonathan Wakely wrote: >> >> For allocations with size > alignment and size % alignment != 0 we were >> sometimes returning pointers that did not meet the requested aligment. >> For example, allocate(24, 16

Re: [PATCH] libstdc++: Fix attribute order on __normal_iterator friends [PR120949]

2025-07-08 Thread Jonathan Wakely
On Tue, 8 Jul 2025 at 13:26, Tomasz Kaminski wrote: > > > > On Sat, Jul 5, 2025 at 1:27 AM Jonathan Wakely wrote: >> >> In r16-1911-g6596f5ab746533 I claimed to have reordered some attributes >> for compatibility with Clang, but it looks like I got the Clang >> restriction backwards and put them

Re: [PATCH] libstdc++: Add smart ptr owner_equals and owner_hash structs and members for P1901R2

2025-07-08 Thread Jonathan Wakely
On Tue, 8 Jul 2025 at 13:24, Jonathan Wakely wrote: > > On Tue, 8 Jul 2025 at 12:54, Paul Keir wrote: > > > > Let me know if this needs a refresh. > > The patch fails to apply: > > error: patch failed: libstdc++-v3/include/bits/shared_ptr_base.h:1715 > error: libstdc++-v3/include/bits/shared_ptr_

Re: [PATCH 0/1] [RFC][AutoFDO]: Source filename tracking in GCOV

2025-07-08 Thread Jan Hubicka
> Hi Honza, > > > On 8 Jul 2025, at 2:26 am, Jan Hubicka wrote: > > > > External email: Use caution opening links or attachments > > > > > > Hi, > > as discussed also on the autofdo pull request, LLVM solves the same > > problem using -funique-internal-linkage-names > > https://reviews.llvm.or

  1   2   >