[COMMITTED 005/146] gccrs: Rename some PathIdentSegment functions

2025-03-22 Thread arthur . cohen
From: Owen Avery This makes PathIdentSegment more similar to other classes used to represent path segments. gcc/rust/ChangeLog: * ast/rust-path.h (PathIdentSegment::is_super_segment): Rename to... (PathIdentSegment::is_super_path_seg): ...here. (PathIdentSegment:

Re: [PATCH] c++: Don't mix timevar_start and auto_cond_timevar for TV_NAME_LOOKUP [PR116681]

2025-03-22 Thread Simon Martin
Hi, On Sat Sep 14, 2024 at 10:00 AM CEST, Jason Merrill wrote: > On 9/13/24 1:31 PM, Simon Martin wrote: >> We currently ICE upon the following testcase when using -ftime-report >> >> === cut here === >> template < int> using __conditional_t = int; >> template < typename _Iter > >> concept random

[PATCH] libstdc++: Fix std::vector::append_range for overlapping ranges

2025-03-22 Thread Jonathan Wakely
Unlike insert_range and assign_range, the append_range function does not have a precondition that the range doesn't overlap *this. That means we need to avoid relocating the existing elements until after copying from the range. This means I need to revert r15-8488-g3e1d760bf49d0e which made the fro

Re: [patch] make vhdl known to the PPC backend

2025-03-22 Thread Richard Biener
On Wed, Mar 19, 2025 at 6:39 PM Matthias Klose wrote: > > For building ghdl, the compiler needs to be patched to know the "vhdl" > language. Could that patch be applied to the upstream GCC, so that not > everybody needs to patch GCC to build ghdl? I would suggest, since with LTO all languages ar

Re: [PATCH] inliner: Silently drop musttail flag on calls during inlining unless the inlined routine was musttail called [PR119376]

2025-03-22 Thread Richard Biener
On Fri, 21 Mar 2025, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, some packages fail to build because they use > musttail attribute on calls in functions which we inline, and if they > are inlined into a middle of the function, that results in an error > because we have a musttail call

[PATCH] lra, v2: emit caller-save register spills before call insn [PR116028]

2025-03-22 Thread Jakub Jelinek
Hi! Here is an updated version of Surya's PR116028 fix from August, which got reverted because it caused bootstrap failures on aarch64, later on bootstrap comparison errors there as well and problems on other targets as well. The changes compared to the https://gcc.gnu.org/pipermail/gcc-patches/2

New French PO file for 'gcc' (version 15.1-b20250316)

2025-03-22 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the French team of translators. The file is available at: https://translationproject.org/latest/gcc/fr.po (This file, 'gcc-15.1-b20250316.fr.po',

RE: [PATCH] cobol: Address some iconv issues.

2025-03-22 Thread Robert Dubner
You're correct: I didn't understand what was going on. I still don't. As a matter of fact: Although the relevant code in charmaps.cc is my coding style, I frankly don't recognize it. I remember doing that conversion with my own tables and routines at one point, but apparently I decided, or w

Re: [Fortran, Patch, PR119349, v1] Fix regression of polymorphic dummy sourced from array constructors.

2025-03-22 Thread Paul Richard Thomas
Hi Andre, I am reasonably familiar with the mess that is gfc_conv_procedure_call :-) So in spite of you having a hard time explaining things today, I see your patch as verging on 'obvious' and is certainly the best that can be done without refactoring the whole thing. OK fo mainline. Thanks for

Re: [PATCH][RFC] [cobol] change cbl_field_data_t::etc_t::value from _Float128 to tree

2025-03-22 Thread Richard Biener
On Thu, 20 Mar 2025, Richard Biener wrote: > The following removes the main instance of _Float128 use in the cobol > frontend and replaces it with a tree for cbl_field_data_t::etc_t::value > and with REAL_VALUE_TYPE in some helpers. > > The default value is changed to a float128_type_node zero fr

[PATCH] PR118442: Don't instrument exit edges after musttail

2025-03-22 Thread Andi Kleen
From: Andi Kleen When -fprofile-generate is used musttail often fails because the compiler adds instrumentation after the tail calls. This patch prevents adding exit extra edges after musttail because for a tail call the execution leaves the function and can never come back even on a unwind or e

[PATCH] c++: Fix ICE when template lambdas call with default parameters in unevaluated context

2025-03-22 Thread yxj-github-437
This patch would like to avoid the ICE when template lambdas call with default parameters in unevaluated context. For example as blow: 1 │ template 2 │ void foo(T x) { 3 │ sizeof [](T=x) { return 0; }(); 4 │ } 5 │ 6 │ void test { 7 │ foo(0); 8 │

[PATCH] libstdc++: Ensure that std::vector allocator has bool value_type

2025-03-22 Thread Jonathan Wakely
This is the subject of LWG 4228 which notes that libstdc++ doesn't enforce this requirement. That's just a bug because I forgot to add it to vector when adding it elsewhere. For consistency with the other containers we should not allow incorrect allocator types for strict -std=c++NN modes, but it

Re: [PATCH] change cbl_field_data_t::etc_t::value from _Float128 to tree

2025-03-22 Thread Paul Koning
> On Mar 21, 2025, at 11:44 PM, Robert Dubner wrote: > > [I am going to try to maintain a grip on my professionalism. A > professional does not give in to the urge to say, "I told you so".] > > This program, compiled with the most recent level of patching, is > generating the result > >

[COMMITTED] libgfortran/intrinsics: Fix build for targets with int32_t=long int

2025-03-22 Thread Hans-Peter Nilsson
Not many newlib targets (AFAIK the only targets where GFC_INTEGER_4 alias int32_t is a typedef of long int) build libgfortran. These breaks happen from time to time. I wish there was a method to stop int32_t (and its typedef-alias GFC_INTEGER_4) being type-compatible with int. The commit message

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-03-22 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 18:30, Christophe Lyon wrote: > > On Fri, 21 Mar 2025 at 16:51, Richard Earnshaw (lists) > wrote: > > > > On 21/03/2025 15:15, Christophe Lyon wrote: > > > On Fri, 21 Mar 2025 at 15:25, Richard Earnshaw (lists) > > > wrote: > > >> > > >> On 21/03/2025 14:05, Christophe Lyo

[PATCH] cobol: Rename COB_{BLOCK,UNSIGNED,SIGNED} to {BLOCK,UNSIGNED,SIGNED}_kw for consistency

2025-03-22 Thread Jakub Jelinek
On Wed, Mar 19, 2025 at 06:03:24PM -0400, James K. Lowden wrote: > Elsewhere in the parser where there was a conflict like that, I renamed > the token. For example, the COBOL word TRUE uses a token named > TRUE_kw. I don't mind either way; your solution has less impact on the > parser. I think

[patch,avr,applied] Use "avr-peep2-after-fuse-move" for the 2nd run of peephole2.

2025-03-22 Thread Georg-Johann Lay
AVR: Use "avr-peep2-after-fuse-move" for the 2nd run of peephole2. This patch uses a name for the dump file that makes it clear where in the pass chain the 2nd run of peephole2 is located. gcc/ * config/avr/avr.c (avr_option_override): Use "avr-peep2-after-fuse-move" as dump name

[PING][PATCH v3 0/4] Fix data races with sub-longword accesses on Alpha

2025-03-22 Thread Maciej W. Rozycki
On Tue, 11 Mar 2025, Maciej W. Rozycki wrote: > This is v3 of the series comprising the final 4 outstanding changes. I > note that the corresponding v2 patches have been approved, but concerns > were discussed, which this update has addressed. Ping for:

[COMMITTED 144/146] gccrs: derive(Clone): Implement derive clone for enum struct variants

2025-03-22 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * expand/rust-derive-clone.cc (DeriveClone::clone_enum_struct): New function for deriving enum struct variants. (DeriveClone::visit_enum): Call into the new function. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude:

[COMMITTED 074/146] gccrs: hir: Lower lang-item paths

2025-03-22 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * hir/rust-ast-lower-type.cc (ASTLowerTypePath::translate): Adapt to handle lang item paths. (ASTLowerTypePath::visit): Likewise. (ASTLowerTypePath::translate_type_path): New. (ASTLowerTypePath::translate_lang_item_ty

Re: [PATCH v2 2/2] PR119376: Disable clang musttail

2025-03-22 Thread Jakub Jelinek
On Thu, Mar 20, 2025 at 09:19:02AM -0700, Andi Kleen wrote: > The inlining was just one of the issue, there are some related to > different semantics of escaped locals. gcc always errors out while > LLVM declares it undefined. > > But maybe we can fix that one too. I have 3 patches to be tested,

[PING^2][PATCH] Alpha: Fix base block alignment calculation regression

2025-03-22 Thread Maciej W. Rozycki
On Tue, 25 Feb 2025, Maciej W. Rozycki wrote: > Address this issue by recursing into COMPONENT_REF tree nodes until the > outermost one has been reached, which is supposed to be a MEM_REF one, > accumulating the offset as we go, fixing a commit e0dae4da4c45 ("Alpha: > Also use tree information

Re: [PATCH 2/1] c++/modules: Handle gnu_inline, again [PR119154]

2025-03-22 Thread Nathaniel Shead
On Mon, Mar 17, 2025 at 09:42:13AM -0400, Jason Merrill wrote: > On 3/14/25 9:28 AM, Nathaniel Shead wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > > > Alternatively, could still mark gnu_inline functions as non-vague, we > > just need to do so more aggressively; b

Re: [avr] libgcc: Properly exclude some object files for avrtiny

2025-03-22 Thread Denis Chertykov
сб, 22 мар. 2025 г. в 18:42, Georg-Johann Lay : > > The condition to exclude some object files for AVRrc reduced core > did not work properly since it was too strict. > > LibF7 didn't exclude its objects at all. > > This patch uses $(findstring avrtiny,$(MULTIDIR)) in the condition. > > No new regr

New Croatian PO file for 'gcc' (version 15.1-b20250316)

2025-03-22 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Croatian team of translators. The file is available at: https://translationproject.org/latest/gcc/hr.po (This file, 'gcc-15.1-b20250316.hr.po

Re: [patch, avr] PR119421: Optimize more bit operations

2025-03-22 Thread Denis Chertykov
Georg-Johann Lay writes: > There are occasions where knowledge about nonzero bits makes some > optimizations possible. For example, > >Rd |= Rn << Off > > can be implemented as > >SBRC Rn, 0 >ORI Rd, 1 << Off > > when Rn in { 0, 1 }, i.e. nonzero_bits (Rn) == 1. This patch adds som

Re: COBOL: Implementation of STOP RUN / GOBACK

2025-03-22 Thread James K. Lowden
On Fri, 21 Mar 2025 11:50:19 +0100 "Jose E. Marchesi" wrote: > > > Am 20.03.2025 um 21:50 schrieb James K. Lowden: > >> On Mar 13, 2025, at 8:04 AM, Simon Sobisch > >> wrote: > >>> > >>> exit() allows us to "pass to the operating system" directly; but > >>> it doesn't directly say "success" or

[committed] d: Add C++23 to CppStdRevision enum

2025-03-22 Thread Iain Buclaw
Hi, This patch merges the D front-end with upstream dmd 94950cae58. D front-end changes: - The compiler now accepts `-fextern-std=c++23' Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * dmd/MERGE: Me

[avr] libgcc: Properly exclude some object files for avrtiny

2025-03-22 Thread Georg-Johann Lay
The condition to exclude some object files for AVRrc reduced core did not work properly since it was too strict. LibF7 didn't exclude its objects at all. This patch uses $(findstring avrtiny,$(MULTIDIR)) in the condition. No new regressions. Ok to apply? Johann -- AVR: libgcc: Properly exclu

Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-22 Thread Thomas Schwinge
Hi Arthur! On 2025-03-22T15:48:18+0100, Arthur Cohen wrote: > Thanks for testing that commit. I think a partial revert is not > necessary, as I'm currently > working on our milestone to make all Rust code compile with a Rust > 1.49 toolchain. > > I think pushing a partial revert upstream would ju

Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-22 Thread Arthur Cohen
Hi Thomas! Thanks for testing that commit. I think a partial revert is not necessary, as I'm currently working on our milestone to make all Rust code compile with a Rust 1.49 toolchain. I think pushing a partial revert upstream would just create some confusion when the correct version of the code

Re: [COMMITTED 136/145] gccrs: Fix nightly rustc warnings

2025-03-22 Thread Thomas Schwinge
Hi! On 2025-03-17T16:33:34+0100, arthur.co...@embecosm.com wrote: > From: Kushal Pal > > libgrust/ChangeLog: > > * libformat_parser/Cargo.toml: > Used crate-type instead of depricated crate_type. > * libformat_parser/generic_format_parser/src/lib.rs: > Remove dead code. >

[PATCH v2] aarch64, Darwin: Initial implementation of Apple cores [PR113257].

2025-03-22 Thread Iain Sandoe
0. Sorry this has taken some time to close off; partly because of waiting for input, but mostly that I've been stretched with other work. 1. As per the commit message, the apparent non-conformance with 8.5/6 because FEAT_SPECRES returns 0, is a result of the query operating at user priv.

[committed] d: Bump front-end language version to v2.111.0-rc.1.

2025-03-22 Thread Iain Buclaw
Hi, This patch merges the D front-end with upstream dmd 032e24446b. The language version is now v2.111.0-rc.1. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 032e24446b.

[committed] libphobos: Fix IEEE typo in std.numeric link

2025-03-22 Thread Iain Buclaw
Hi, This patch merges libphobos with upstream phobos d4c9efef1. Regards, Iain. --- libphobos/ChangeLog: * src/MERGE: Merge upstream phobos d4c9efef1. Reviewed-on: https://github.com/dlang/phobos/pull/10700 --- libphobos/src/MERGE | 2 +- libphobos/src/std/numeric.d | 2 +- 2 f

[pushed] Darwin: We do not need libdl, it is provided in libSystem.

2025-03-22 Thread Iain Sandoe
Tested on x86_64-darwin21, x86_64-linux, pushed to trunk, thanks Iain --- 8< --- Darwin provides this support as part of libSystem which is always linked with user-space DSOs (including exes). gcc/ChangeLog: * config/darwin.h (DL_LIBRARY): New. Signed-off-by: Iain Sandoe --- gcc/conf

[committed] d: Indexing a cast(AA) yields no lvalue anymore

2025-03-22 Thread Iain Buclaw
Hi, This patch merges the D front-end with upstream dmd 8db14cf846. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 8db14cf846. Reviewed-on: https://github.com/dlang/dmd/pull/21

[COMMITTED 079/146] gccrs: Made changes to AST::TraitImpl constructor for TypePath

2025-03-22 Thread arthur . cohen
From: Sri Ganesh Thota gcc/rust/ChangeLog: * ast/rust-item.h: I have changed helper constructor for typepath to be a delegating constructor. Signed-off-by: Sri Ganesh Thota --- gcc/rust/ast/rust-item.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff -

[committed] d: Improve UFCS/property error message

2025-03-22 Thread Iain Buclaw
Hi, This patch merges the D front-end with upstream dmd 9d2f034398. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 9d2f034398. Reviewed-on: https://github.com/dlang/dmd/pull/21

Re: [PATCH] cobol: Address some iconv issues.

2025-03-22 Thread Iain Sandoe
Hello Robert. I fear we might be at cross-purposes here ... > On 22 Mar 2025, at 02:34, Robert Dubner wrote: > > I can't comment on what happens on Apple systems. I've never tried it. > > I chose CP1252 because it seemed to have the greatest coverage for much of > western Europe. It also has

Re: [PATCH] change cbl_field_data_t::etc_t::value from _Float128 to tree

2025-03-22 Thread Jakub Jelinek
On Fri, Mar 21, 2025 at 08:25:10PM +0100, Richard Biener wrote: > Hmm, but I see that digits_from_float128 from > > (gdb) p debug (value) > 1.0e+0 > > produces via real_to_integer zero: > > (gdb) s > real_to_integer (r=0x7fff69a0, fail=0x7fff685f, precision=128) > at ../../src/gcc/gc

Re: [PATCH] cobol: Make CXXFLAGS_FOR_TARGET available to the libgcobol build.

2025-03-22 Thread Richard Biener
> Am 21.03.2025 um 22:21 schrieb Robert Dubner : > > This gets frustrating at times. > > I tracked down that > > EXTRA_TARGET_FLAGS does indeed include > > 'CXXFLAGS=$$(CXXFLAGS_FOR_TARGET)' \ > > And I tried including what looks like the boilerplate for > > AM_MAKEFLAGS

[COMMITTED 073/146] gccrs: nr1.0: Resolve lang item paths properly.

2025-03-22 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * resolve/rust-ast-resolve-item.cc (ResolveItem::visit): Adapt resolver to lang item paths. * resolve/rust-ast-resolve-type.h: Likewise. --- gcc/rust/resolve/rust-ast-resolve-item.cc | 30 +-- gcc/rust/resolve/ru

cobol: default iconv encoding (was: [PATCH] cobol: Address some iconv issues.)

2025-03-22 Thread Simon Sobisch
> Secondly, using Windows code page 1252 as a default seems overly restrictive. >-static const char standard_internal[] = "CP1252//"; >+static const char standard_internal[] = >+#if __APPLE__ >+"ISO8859-1"; >+#else >+"CP1252//"; >+#endif I'd highly suggest to go with ISO8859-15 in general (=drop

Re: [PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Andreas Schwab
On Mär 22 2025, Jakub Jelinek wrote: > I think it must be exgettext and something in the option processing at the > same time. Yes, optc-gen.awk would need to apply the same quoting. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC

Re: [PATCH v2 2/2] PR119376: Disable clang musttail

2025-03-22 Thread Jakub Jelinek
On Fri, Mar 21, 2025 at 08:31:35AM -0400, Jason Merrill wrote: > > Not sure I like this, but if others (e.g. Richi, Joseph, Jason) are ok with > > it I can live with it. But we'd need a good documentation, ideally some > > some new warning about it (perhaps enabled in -Wextra) and testcase > > cov

Re: [PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Andreas Schwab
On Mär 22 2025, Jakub Jelinek wrote: > I think just the c.opt change needs an explanation, the "" in the > description is simply eaten up somewhere during the option processing and exgettext could do the quoting itself, obviating the need for doing it explicitly and eliminating an easy to make er

[PATCH] LoongArch: Support Q suffix for __float128.

2025-03-22 Thread Lulu Cheng
In r14-3635 supports `__float128`, but does not support the 'q/Q' suffix. PR target/119408 gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_c_mode_for_suffix): New. (TARGET_C_MODE_FOR_SUFFIX): Define. gcc/testsuite/ChangeLog: * gcc.target/loonga

RE: [PATCH] cobol: Address some iconv issues.

2025-03-22 Thread Robert Dubner
I can't comment on what happens on Apple systems. I've never tried it. I chose CP1252 because it seemed to have the greatest coverage for much of western Europe. It also has very close to a one-to-one correspondence with the EBCDIC CP1140. At the present time I personally am not prepared to go

[COMMITTED 061/146] gccrs: constant evaluation like these are coercion sites

2025-03-22 Thread arthur . cohen
From: Philip Herron The code here was wrongly assuming the decl type from the folding of the expression would be the type of the constant decl. This is not the case for unsized coercions for slices, where the expression here is a reference to an array then we require the coercion to fix the resul

Re: [patch, avr] Add "used" attribute to code in .initN and .finiN

2025-03-22 Thread Denis Chertykov
Georg-Johann Lay writes: > For code in .initN and .finiN there are no calls, hence let the > compiler add "used" attribute. > > Ok for trunk? Ok. Denis > > Johann > > -- > > AVR: Add attribute "used" for code in .initN and .initN sections. > > Code in .initN and .initN sections is never called

[PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Jakub Jelinek
Hi! Given the recent PR119406 I've tried to grep for concatenated string literals without space at the end of one line and at the start of next line, unless it was obviously intentional. Furthermore, I've then looked through gcc.pot looking for 2 adjacent spaces and looking back if that wasn't the

Re: [PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Jakub Jelinek
On Sat, Mar 22, 2025 at 08:18:27AM +0100, Andreas Schwab wrote: > On Mär 22 2025, Jakub Jelinek wrote: > > > I think just the c.opt change needs an explanation, the "" in the > > description is simply eaten up somewhere during the option processing and > > exgettext could do the quoting itself, o