[PATCH v2] ira: Add a target hook for callee-saved register cost scale

2025-02-02 Thread H.J. Lu
commit 3b9b8d6cfdf59337f4b7ce10ce92a98044b2657b Author: Surya Kumari Jangala Date: Tue Jun 25 08:37:49 2024 -0500 ira: Scale save/restore costs of callee save registers with block frequency scales the cost of saving/restoring a callee-save hard register in epilogue and prologue with the en

Re: [PATCH v2 6/7] Enable vectorization for input.cc find_end_of_line function

2025-02-02 Thread Andi Kleen
On Tue, Jan 28, 2025 at 09:50:41AM +0100, Richard Biener wrote: > On Mon, Jan 27, 2025 at 9:59 PM David Malcolm wrote: > > > > On Sat, 2025-01-25 at 23:31 -0800, Andi Kleen wrote: > > > From: Andi Kleen > > > > > > This is the hot function in input.cc > > > > > > The vectorizer can vectorize it n

Re: [PATCH v2 4/7] Add a cache of recent lines

2025-02-02 Thread Andi Kleen
> > If I reading this right, calls to get_next_line lead to insertions into > the ring buffer whilst the buffer is empty or the last line in the ring > buffer cache is m_line_num - 1. > > There are a few places where we update m_line_num, but this caching > code doesn't seem to touch those places

Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-02-02 Thread Andi Kleen
On Sun, Feb 02, 2025 at 09:35:52PM -0800, Andi Kleen wrote: > > Patch 7 is OK otherwise, and I'm taking a look at the rest of the > > patches now; thanks. > > Any comments on the other patches? nm. I see you already commented. somehow i missed that. -Andi

Re: [PATCH v2 7/7] Add a unit test for random access in the file cache

2025-02-02 Thread Andi Kleen
> Patch 7 is OK otherwise, and I'm taking a look at the rest of the > patches now; thanks. Any comments on the other patches? Thanks, -Andi

[PATCH v2] c++: Add tree walk case to reach A pack from B in ...B> [PR118265]

2025-02-02 Thread A J Ryan Solutions Ltd
This version has all the updates as per feedback from version 1. It makes a minor correction to the code styling, reformats the commit message and moves the test into the cpp1z directory. In addition I've updated the test to conform with c++17 for better coverage. Andrew Pinski had put one up on

Re: [PATCH] gcc: Add tree walk case to reach A pack from B in ...B>. [PR118265]

2025-02-02 Thread A J Ryan Solutions Ltd
On Monday, 27 January 2025 at 19:48, Jason Merrill - jason at redhat.com wrote: > > On 1/27/25 1:26 PM, Patrick Palka wrote: > > > On Wed, 1 Jan 2025, A J Ryan Solutions Ltd wrote: > > > > > Hi and happy new year, this patch is to fix a compiler seg-fault as > > > encountered in the following ex

[PATCH] arm: testsuite: Adapt mve-vabs.c to improved codegen

2025-02-02 Thread Thiago Jung Bauermann
Since commit r15-491-gc290e6a0b7a9de this failure happens on on armv8l-linux-gnueabihf and arm-eabi: Running gcc:gcc.target/arm/simd/simd.exp ... gcc.target/arm/simd/mve-vabs.c: memmove found 0 times FAIL: gcc.target/arm/simd/mve-vabs.c scan-assembler-times memmove 3 In PR PR target/116010, Andre

Patch held up in gcc-patches due to size

2025-02-02 Thread Thomas Koenig
Hi, I sent https://gcc.gnu.org/pipermail/fortran/2025-February/061670.html to gcc-patches also, as normal, but got back an e-mail that it was too large. and that a moderator would look at it. Maybe the limits can be increased a bit, sometimes patches can be quite large, especially if they contai

[PATCH] c++: Fix up pedwarn for capturing structured bindings in lambdas [PR118719]

2025-02-02 Thread Jakub Jelinek
Hi! As mentioned in the PR, this pedwarni is desirable for the implicit or explicit capturing of structured bindings in C++17, but in the case of init-captures the initializer is just some expression and that can include structured bindings. So, the following patch limits the warning to non-expli

Re: [PATCH] ira: Cap callee-saved register cost scale to 300

2025-02-02 Thread H.J. Lu
On Sun, Feb 2, 2025 at 4:20 PM Richard Biener wrote: > > > > > Am 02.02.2025 um 08:59 schrieb H.J. Lu : > > > > On Sun, Feb 2, 2025 at 3:33 PM Richard Biener > > wrote: > >> > >> > >> > Am 02.02.2025 um 08:00 schrieb H.J. Lu : > >>> > >>> Don't increase callee-saved register cost by 1000x,

Re: [PATCH] ira: Cap callee-saved register cost scale to 300

2025-02-02 Thread Richard Biener
> Am 02.02.2025 um 08:59 schrieb H.J. Lu : > > On Sun, Feb 2, 2025 at 3:33 PM Richard Biener > wrote: >> >> >> Am 02.02.2025 um 08:00 schrieb H.J. Lu : >>> >>> Don't increase callee-saved register cost by 1000x, which leads to that >>> callee-saved registers aren't used to preserve

Re: [PATCH] ira: Cap callee-saved register cost scale to 300

2025-02-02 Thread H.J. Lu
On Sun, Feb 2, 2025 at 3:33 PM Richard Biener wrote: > > > > > Am 02.02.2025 um 08:00 schrieb H.J. Lu : > > > > Don't increase callee-saved register cost by 1000x, which leads to that > > callee-saved registers aren't used to preserve local variable values > > across calls, by capping the scale t