[PATCH] Fortran: Added support for locality specs in DO CONCURRENT (Fortran 2018/23)

2024-09-21 Thread Anuj Mohite
gcc/fortran/ChangeLog: * dump-parse-tree.cc (show_code_node): Updated to use c->ext.concur.forall_iterator instead of c->ext.forall_iterator. Added support for dumping DO CONCURRENT locality specifiers. * frontend-passes.cc (index_interchange, gfc_code_walker): Upda

Re: [PATCH v3 03/12] libgomp: runtime support for target_device selector

2024-09-21 Thread Tobias Burnus
On Sunday, September 22, 2024, Sandra Loosemore wrote: > […] I think the predicate of the more general case for > > target_device={device_num (NUM), kind(KIND), arch(ARCH), isa(ISA)} > > can be expressed (using GCC statement expression syntax) as > > ({ >int matches; >#pragma omp target de

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-21 Thread Jakub Jelinek
On Sat, Sep 21, 2024 at 08:08:29PM -0600, Sandra Loosemore wrote: > On 9/20/24 01:41, Jakub Jelinek wrote: > > > + > > > + /* Check for unknown properties. */ > > > if (omp_ts_map[ts_code].valid_properties == NULL) > > > continue; > > > - > > > > Why? > > Why what? I

[PATCH 1/2] JSON Dumping of GENERIC trees

2024-09-21 Thread 4444-thor
From: thor This is the second revision of: https://gcc.gnu.org/pipermail/gcc-patches/2024-September/662849.html I've incorporated the feedback given both by Richard and David - I didn't find any memory leaks when testing in valgrind :) As before: This patch allows the compiler to dump GENERI

[PATCH 2/2] HTML Dumping of trees from gdb

2024-09-21 Thread 4444-thor
From: thor This patch allows one to dump a tree as HTML from within gdb by invoking, i.e, htlml-tree tree gcc/ChangeLog: * gcc/gdbhooks.py: Rudimentary dumping of GENERIC trees as html through one new python function (jsonNodeToHtml) and one new gdb command (html-tree). There

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-21 Thread Sandra Loosemore
On 9/20/24 01:41, Jakub Jelinek wrote: + + /* Check for unknown properties. */ if (omp_ts_map[ts_code].valid_properties == NULL) continue; - Why? Why what? I made this change because when I added another check in this loop I was temporarily confused about the

Re: [PATCH v3 03/12] libgomp: runtime support for target_device selector

2024-09-21 Thread Sandra Loosemore
On 9/9/24 04:46, Tobias Burnus wrote: I wonder whether we should do something like the following. [The following is a mix between compile code and generated code, for illustrative purpose.] Inside the compiler do: #ifndef ACCEL_COMPILER intr = 0; if (targetm.omp.device_kind_arch_isa != NULL

[Patch] OpenMP: Add support for 'self_maps' to the 'require' directive

2024-09-21 Thread Tobias Burnus
Add support of the 'self_maps' clause in 'omp requires', an OpenMP 6 feature but added here mostly as part of the on-going improvement of the unified-shared memory (USM) handling. Comments, remarks concerns before I commit it? * * * Regarding USM, there is on one hand the hardware: - some hard

Re: [PATCH] libstdc++: operator new/delete are transaction_safe

2024-09-21 Thread Jonathan Wakely
On Sat, 21 Sept 2024, 14:24 Jason Merrill, wrote: > Tested x86_64-pc-linux-gnu, OK for trunk? > All those macros already make them cluttered so this doesn't make them any more unreadable! OK, thanks > -- 8< -- > > With the changes to #pragma system_header, g++.dg/tm/pr46270.C was > failing be

[PATCH] opts: Fix up regenerate-opt-urls dependencies

2024-09-21 Thread Jakub Jelinek
Hi! It seems that we currently require 1) enabling at least c,c++,fortran,d in --enable-languages 2) first doing make html before one can successfully regenerate-opt-urls, otherwise without 2) one gets make regenerate-opt-urls make: *** No rule to make target '/home/jakub/src/gcc/obj12x/gcc/HTML/

Re: *PING* [PATCH v3 10/10] fortran: Add -finline-intrinsics flag for MINLOC/MAXLOC [PR90608]

2024-09-21 Thread Jakub Jelinek
On Sat, Sep 21, 2024 at 04:32:38PM +0200, Mikael Morin wrote: > Thanks for the tip. > The Makefile dependencies seem to be incomplete. > Here is what I get: AFAIK right now one needs to configure at least c,c++,fortran,d in --enable-languages (or some superset thereof) and make -C gcc html make -C

Re: *PING* [PATCH v3 10/10] fortran: Add -finline-intrinsics flag for MINLOC/MAXLOC [PR90608]

2024-09-21 Thread Mikael Morin
Le 21/09/2024 à 16:32, Mikael Morin a écrit : Le 19/09/2024 à 23:24, Jakub Jelinek a écrit : (...) Just note lang.opt.urls will need to be updated, either you do it right away with make regenerate-opt-urls or commit, wait for a nag-mail from CI and commit incrementally the patch it creates.

Re: [PATCH] c++: compile time evaluation of prvalues [PR116416]

2024-09-21 Thread Jakub Jelinek
On Fri, Sep 20, 2024 at 07:03:45PM -0400, Jason Merrill wrote: > > The CALL_EXPR case in cp_fold uses !flag_no_inline instead, that makes more > > sense to me. > > Because checking "noinline" attribute (which means don't inline this > > function) on current_function_decl rather than on functions be

Re: *PING* [PATCH v3 10/10] fortran: Add -finline-intrinsics flag for MINLOC/MAXLOC [PR90608]

2024-09-21 Thread Mikael Morin
Le 19/09/2024 à 23:24, Jakub Jelinek a écrit : On Mon, Sep 16, 2024 at 10:52:43AM +0200, Mikael Morin wrote: While I understand the intent of 'positive form' vs 'negative form', the above might be clearer as Usage of intrinsics can be implemented either by generating a call to the lib

[PATCH v1 2/2] RISC-V: Add testcases for form 3 of signed vector SAT_ADD

2024-09-21 Thread pan2 . li
From: Pan Li Form 3: #define DEF_VEC_SAT_S_ADD_FMT_3(T, UT, MIN, MAX) \ void __attribute__((noinline)) \ vec_sat_s_add_##T##_fmt_3 (T *out, T *op_1, T *op_2, unsigned limit) \ {

[PATCH v1 1/2] Match: Support form 3 for vector signed integer .SAT_ADD

2024-09-21 Thread pan2 . li
From: Pan Li This patch would like to support the form 3 of the vector signed integer .SAT_ADD. Aka below example: Form 3: #define DEF_VEC_SAT_S_ADD_FMT_3(T, UT, MIN, MAX) \ void __attribute__((noinline)) \ vec_sat_s_add_##T##_fmt_

[PATCH] libstdc++: operator new/delete are transaction_safe

2024-09-21 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, OK for trunk? -- 8< -- With the changes to #pragma system_header, g++.dg/tm/pr46270.C was failing because didn't implement the N4514 change to [new.delete] that says "The library versions of the global allocation and deallocation functions are declared transaction_saf

Re: [wwwdocs][Patch] gcc-15: Fortran - mention -funsigned + PowerPC Darwin IEEE module support

2024-09-21 Thread Gerald Pfeifer
On Fri, 20 Sep 2024, Tobias Burnus wrote: > Comments, remarks to, approval of the attached wwwdocs patch? + Experimental support for unsigned integers; enabled by the + -funsigned, see https://gcc.gnu.org/onlinedocs/gfortran/Experimental-features-for-Fortran-202Y.html"; + >gfortran docu

Re: [PATCH v2 1/2] c++/coro: prevent ICV_STATEMENT diagnostics in temp promotion [PR116502]

2024-09-21 Thread Arsen Arsenović
Arsen Arsenović writes: > Okay, these patch should work correctly in all cases, at least all I > could think of. The first patch is unchanged, the second one is simpler > than it was before, I think. Ah, and of course: tested on x86_64-pc-linux-gnu, OK for trunk? -- Arsen Arsenović signature

[PATCH v2 1/2] c++/coro: prevent ICV_STATEMENT diagnostics in temp promotion [PR116502]

2024-09-21 Thread Arsen Arsenović
Okay, these patch should work correctly in all cases, at least all I could think of. The first patch is unchanged, the second one is simpler than it was before, I think. -- >8 -- If such a diagnostic is necessary, it has already been emitted, otherwise, it is not correct and emitti

[PATCH v2 2/2] c++: simplify handling implicit INDIRECT_REF and co_await in convert_to_void

2024-09-21 Thread Arsen Arsenović
convert_to_void has, so far, when converting a co_await expression to void altered the await_resume expression of a co_await so that it is also converted to void. This meant that the type of the await_resume expression, which is also supposed to be the type of the whole co_await expression, was no

Re: [PATCH v3] libstdc++: implement concatenation of strings and string_views

2024-09-21 Thread Giuseppe D'Angelo
On 31/07/2024 00:19, Jonathan Wakely wrote: One more thing that I missed last time, sorry: +#if __glibcxx_string_view >= 202403L + // const string & + string_view + template +_GLIBCXX_NODISCARD _GLIBCXX20_CONSTEXPR +inline basic_string<_CharT, _Traits, _Alloc> +operator+(const basi

[PATCH] libstdc++: improve std::atomic compatibility with Clang

2024-09-21 Thread Giuseppe D'Angelo
Hello, The attached patch modifies std::atomic's primary template. The goal is to improve compatibility with Clang, while also possibly making it more complaint with the changes introduced by P0883 / C++20. Simplifying, std::atomic has a `T t = T()` NDSMI and a defaulted default constructor.

Re: [COMMITTED] testsuite: debug: fix dejagnu directive syntax

2024-09-21 Thread Thomas Schwinge
Hi Andrew, Sam! On 2024-09-20T14:21:33-0700, Andrew Pinski wrote: > On Fri, Sep 20, 2024 at 1:53 AM Thomas Schwinge > wrote: >> On 2024-09-20T05:12:19+0100, Sam James wrote: >> > In this case, they were all harmless in reality (no diff in test logs). >> >> > -/* { dg-do compile ) */ >> > +/*