[PATCH 2/2] arm: Add cortex-m52 doc

2024-01-07 Thread Chung-Ju Wu
Hi, This is the patch to add cortex-m52 in the Arm-related options sections of the gcc invoke.texi documentation. Is it OK for trunk? Regards, jasonwucjFrom b7ce3d499d4bf087ec54a5f834876c9108d46c3d Mon Sep 17 00:00:00 2001 From: Chung-Ju Wu Date: Thu, 7 Dec 2023 11:26:25 +0800 Subject: [PATCH

[PATCH 1/2] arm: Add cortex-m52 core

2024-01-07 Thread Chung-Ju Wu
Hi, Recently, Arm announced the Cortex-M52, delivering increased performance in DSP and ML along with a range of other features and benefits. For the completeness of Arm ecosystem, we hope that cortex-m52 support could be available in gcc-14. Attached is the patch to support cortex-m52 cpu with

[committed] RISC-V: Fix testsuite

2024-01-07 Thread Kito Cheng
Don't use assert, it not work well with multilib testing. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/partial/single_rgroup-3.h: Use check + abort rather than assert. --- .../riscv/rvv/autovec/partial/single_rgroup-3.h | 8 ++-- 1 file changed, 6 inserti

Re: [PATCH] Add __cow_string C string constructor

2024-01-07 Thread François Dumont
On 07/01/2024 21:53, Jonathan Wakely wrote: On Sun, 7 Jan 2024 at 18:50, François Dumont wrote: On 07/01/2024 17:34, Jonathan Wakely wrote: On Sun, 7 Jan 2024 at 12:57, François Dumont wrote: Hi While working on the patch to use the cxx11 abi in gnu version namespace mode I got a small p

[PING 3][PATCH v3] rs6000/p8swap: Fix incorrect lane extraction by vec_extract() [PR106770]

2024-01-07 Thread Surya Kumari Jangala
Ping On 28/11/23 6:24 pm, Surya Kumari Jangala wrote: > Ping > > On 10/11/23 12:27 pm, Surya Kumari Jangala wrote: >> Ping >> >> On 03/11/23 1:14 pm, Surya Kumari Jangala wrote: >>> Hi Segher, >>> I have incorporated changes in the code as per the review comments provided >>> by you >>> for ver

Re: [PATCH] i386: [APX] Add missing document for APX

2024-01-07 Thread Hongtao Liu
On Mon, Jan 8, 2024 at 11:09 AM Hongyu Wang wrote: > > Hi, > > The supported sub-features for APX was missing in option document and > target attribute section. Add those missing ones. > > Ok for trunk? Ok. > > gcc/ChangeLog: > > * config/i386/i386.opt: Add supported sub-features. >

Re: [PATCH] Add a late-combine pass [PR106594]

2024-01-07 Thread Jeff Law
On 1/5/24 10:35, Richard Sandiford wrote: Jeff Law writes: On 10/24/23 12:49, Richard Sandiford wrote: This patch adds a combine pass that runs late in the pipeline. There are two instances: one between combine and split1, and one after postreload. So have you done any investigation on cas

Re: [PATCH v4] RISC-V: Adds the prefix "th." for the instructions of XTheadVector.

2024-01-07 Thread juzhe.zhong
I am on vacation today. I will back tomorrow or late tonight.  I think we can land theadvector before spring festival as long as it is not invasive to RVV1.0 Replied Message FromjoshuaDate01/08/2024 11:17 ToKito Cheng Ccjuzhe.zh...@rivai.ai,jeffreyalaw,gcc-patches,Jim Wilson,palmer,andrew,p

Re: [committed] RISC-V: Clean up testsuite for multi-lib testing [NFC]

2024-01-07 Thread Kito Cheng
ack, I am fixing this, and running a few more tests, thanks for reporting this! On Sat, Jan 6, 2024 at 10:06 AM 钟居哲 wrote: > > Hi, kito. > > This patch causes these following regression FAILs: > > FAIL: gcc.target/riscv/rvv/autovec/partial/single_rgroup_run-3.c (test for > excess errors) > FAIL:

Re: Re: [PATCH v4] RISC-V: Adds the prefix "th." for the instructions of XTheadVector.

2024-01-07 Thread Kito Cheng
It depends on the timing when you send out the v1 patch to the mailing list, not the timing of when to merge, but of course it's case by case, I would say no IF it's still not ready when time is the end of Feb for this kind of big patch set. On Mon, Jan 8, 2024 at 11:17 AM joshua wrote: > > Hi Ki

Re:Re: [PATCH v4] RISC-V: Adds the prefix "th." for the instructions of XTheadVector.

2024-01-07 Thread joshua
Hi Kito, Thank you for your support. So even during stage 4, we can merge this for GCC 14? -- 发件人:Kito Cheng 发送时间:2024年1月8日(星期一) 11:06 收件人:joshua 抄 送:"juzhe.zh...@rivai.ai"; jeffreyalaw; "gcc-patches"; Jim Wilson; palmer; and

[PATCH] i386: [APX] Add missing document for APX

2024-01-07 Thread Hongyu Wang
Hi, The supported sub-features for APX was missing in option document and target attribute section. Add those missing ones. Ok for trunk? gcc/ChangeLog: * config/i386/i386.opt: Add supported sub-features. * doc/extend.texi: Add description for target attribute. --- gcc/config/i

Re: Disable FMADD in chains for Zen4 and generic

2024-01-07 Thread Hongtao Liu
On Thu, Dec 14, 2023 at 12:03 AM Jan Hubicka wrote: > > > > The diffrerence is that Cores understand the fact that fmadd does not need > > > all three parameters to start computation, while Zen cores doesn't. > > > > > > Since this seems noticeable win on zen and not loss on Core it seems like >

Re: Re: [PATCH v4] RISC-V: Adds the prefix "th." for the instructions of XTheadVector.

2024-01-07 Thread Kito Cheng
I am ok with merging this for GCC 14, as we discussed several times in the RISC-V GCC sync up meeting, I think at least we reach consensus among Jeff Law, Palmer Dabbelt and me. But please be careful: don't break anything for standard vector stuff. On Mon, Jan 8, 2024 at 10:11 AM joshua wrote: >

[PATCH] rs6000: Make copysign (x, -1) back to -abs (x) for IEEE128 float [PR112606]

2024-01-07 Thread Kewen.Lin
Hi, I noticed that commit r14-6192 can't help PR112606 #c3 as it only takes care of SF/DF but TF/KF can still suffer the issue. Similar to commit r14-6192, this patch is to take care of copysign3 with IEEE128 as well. Bootstrapped and regtested on powerpc64-linux-gnu P8/P9 and powerpc64le-linux-

[PATCH] rs6000: Eliminate zext fed by vclzlsbb [PR111480]

2024-01-07 Thread Kewen.Lin
Hi, As PR111480 shows, commit r14-4079 only optimizes the case of vctzlsbb but not for the similar vclzlsbb. This patch is to consider vclzlsbb as well and avoid the failure on the reported test case. It also simplifies the patterns with iterator and attribute. Bootstrapped and regtested on pow

[PATCH] testsuite, rs6000: Adjust pcrel-sibcall-1.c with noipa [PR112751]

2024-01-07 Thread Kewen.Lin
Hi, As PR112751 shows, commit r14-5628 caused pcrel-sibcall-1.c to fail as it enables ipa-vrp which makes return values of functions {x,y,xx} as known and propagated. This patch is to adjust it with noipa to make it not fragile. Tested well on powerpc64-linux-gnu P8/P9 and powerpc64le-linux-gnu

[PATCH] strub: Only unbias stack point for SPARC_STACK_BOUNDARY_HACK [PR113100]

2024-01-07 Thread Kewen.Lin
Hi, As PR113100 shows, the unbiasing introduced by r14-6737 can cause the scrubbing to overrun and screw some critical data on stack like saved toc base consequently cause segfault on Power. By checking PR112917, IMHO we should keep this unbiasing guarded under SPARC_STACK_BOUNDARY_HACK (TARGET_A

Re:Re: [PATCH v4] RISC-V: Adds the prefix "th." for the instructions of XTheadVector.

2024-01-07 Thread joshua
Hi Juzhe, Stage 3 will close today and there are still some patches that haven't been reviewed left.  So is it possible to get xtheadvector merged in GCC-14? We emailed Kito regarding this, but haven't got any reply yet. Joshua ---

Re: [x86_64 PATCH] PR target/112992: Optimize mode for broadcast of constants.

2024-01-07 Thread Hongtao Liu
On Sun, Jan 7, 2024 at 6:53 AM Roger Sayle wrote: > > Hi Hongtao, > > Many thanks for the review. This revised patch implements several > of your suggestions, specifically to use pshufd for V4SImode and > punpcklqdq for V2DImode. These changes are demonstrated by the > examples below: > > typede

Re: [PATCH v2] libstdc++: Add Unicode-aware width estimation for std::format

2024-01-07 Thread Jonathan Wakely
On Mon, 8 Jan 2024 at 01:22, Jonathan Wakely wrote: > > On Mon, 8 Jan 2024 at 01:13, Jonathan Wakely wrote: > > > > This V2 patch failed CI: > > https://patchwork.sourceware.org/project/gcc/patch/20240106151802.3356059-1-jwak...@redhat.com/ > > > > But that's because the UTF-8 characters in the p

[PATCH v2 0/4] Adjust option handling code

2024-01-07 Thread Yang Yujie
This patchset performs some code cleanup, and is bootstrapped and regtested on loongarch64-linux-gnu. Changes from v1 -> v2: * Replaced all TARGET_ macros from .opt. * Fixed definition of ISA_HAS_LAMCAS. Yang Yujie (4): LoongArch: Handle ISA evolution switches along with other options LoongAr

[PATCH v2 2/4] LoongArch: Rename ISA_BASE_LA64V100 to ISA_BASE_LA64

2024-01-07 Thread Yang Yujie
LoongArch ISA manual v1.10 suggests that software should not depend on the ISA version number for marking processor features. The ISA version number is now defined as a collective name of individual ISA evolutions. Since there is a independent ISA evolution mask now, we can drop the version inform

[PATCH v2 1/4] LoongArch: Handle ISA evolution switches along with other options

2024-01-07 Thread Yang Yujie
gcc/ChangeLog: * config/loongarch/genopts/genstr.sh: Prepend the isa_evolution variable with the common la_ prefix. * config/loongarch/genopts/loongarch.opt.in: Mark ISA evolution flags as saved using TargetVariable. * config/loongarch/loongarch.opt: Same.

[committed 1/2] libstdc++: Implement P2905R2 "Runtime format strings" for C++20

2024-01-07 Thread Jonathan Wakely
Tested x86_64-linux and aarch64-linux. Pushed to trunk. -- >8 -- This change makes std::make_format_args refuse to create dangling references to temporaries. This makes the std::vformat API safer. This was approved in Kona 2023 as a DR for C++20 so the change is implemented unconditionally. libs

[PATCH v2 4/4] LoongArch: Simplify -mexplicit-reloc definitions

2024-01-07 Thread Yang Yujie
Since we do not need printing or manual parsing of this option, (whether in the driver or for target attributes to be supported later) it can be handled in the .opt file framework. gcc/ChangeLog: * config/loongarch/genopts/loongarch-strings: Remove explicit-reloc argument string d

[PATCH v2 3/4] LoongArch: Use enums for constants

2024-01-07 Thread Yang Yujie
Target features constants from loongarch-def.h are currently defined as macros. Switch to enums for better look in the debugger. gcc/ChangeLog: * config/loongarch/loongarch-def.h: Define constants with enums instead of Macros. --- gcc/config/loongarch/loongarch-def.h | 115 ++

[committed 2/2] libstdc++: Implement P2918R0 "Runtime format strings II" for C++26

2024-01-07 Thread Jonathan Wakely
Tested x86_64-linux and aarch64-linux. Pushed to trunk. -- >8 -- This adds std::runtime_format for C++26. These new overloaded functions enhance the std::format API so that it isn't necessary to use the less ergonomic std::vformat and std::make_format_args (which are meant to be implementation de

[committed] libstdc++: Implement P2909R4 ("Dude, where's my char?") for C++20

2024-01-07 Thread Jonathan Wakely
Tested x86_64-linux and aarch64-linux. Pushed to trunk. -- >8 -- This change ensures that char and wchar_t arguments are formatted consistently when using integer presentation types. This avoids non-portable std::format output that depends on whether char and wchar_t happen to be signed or unsign

[PATCH] libstdc++: atomic: Add missing clear_padding in __atomic_float constructor

2024-01-07 Thread xndcn
Hi, I found __atomic_float constructor does not clear padding, while __compare_exchange assumes it as zeroed padding. So it is easy to reproducing a infinite loop in X86-64 with long double type like: --- -O0 -std=c++23 -mlong-double-80 #include #include #define T long double int main() { st

[committed] RISC-V: Fix avl-type operand index error for ZVBC

2024-01-07 Thread Feng Wang
This patch fix the rtl-checking error for crypto vector. The root cause is the avl-type index of zvbc ins is error,it should be operand[8] not operand[5]. gcc/ChangeLog: * config/riscv/vector.md: Modify avl_type operand index of zvbc ins. --- gcc/config/riscv/vector.md | 4 ++-- 1 file ch

[PATCH] RISC-V: Also handle sign extension in branch costing

2024-01-07 Thread Maciej W. Rozycki
Complement commit c1e8cb3d9f94 ("RISC-V: Rework branch costing model for if-conversion") and also handle extraneous sign extend operations that are sometimes produced by `noce_try_cmove_arith' instead of zero extend operations, making branch costing consistent. It is unclear what the condition

Re: [RFA] [V3] new pass for sign/zero extension elimination

2024-01-07 Thread Jeff Law
On 1/3/24 05:07, Richard Sandiford wrote: + + if (GET_CODE (x) == ZERO_EXTRACT) + { + /* If either the size or the start position is unknown, +then assume we know nothing about what is overwritten. +This is overly conservative, but

[PATCH v8 5/4] c++: P0847R7 (deducing this) - CWG2586. [PR102609]

2024-01-07 Thread waffl3x
Bootstrapped and tested on x86_64-linux with no regressions. Not as hard as I thought it would be! As noted in the commit message, I believe this makes explicit object member functions feature complete.From a5f947d411b5e19ce7efbb4d766a2792b02c9626 Mon Sep 17 00:00:00 2001 From: Waffl3x Date: Sun,

Re: Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]

2024-01-07 Thread 钟居哲
Since in the previous review from Robin, he have ever asked me change std::max into MAX, I thought the policy is preferring MAX instead of std::max. I change the codes to make them consistent but it seems I am wrong. So is it reasonable that I change all RVV-related codes back to use std::max/m

[PATCH] Fortran: SIZE optional DIM argument having OPTIONAL+VALUE attributes [PR113245]

2024-01-07 Thread Harald Anlauf
Dear all, the attached, actually rather obvious patch fixes an issue when an optional dummy with the value attribute was passed as DIM argument to the SIZE intrinsic. Instead of some hand-crafted, incomplete presence check for the argument, it makes more sense to rely on gfc_conv_expr_present().

Re: [PATCH] Add __cow_string C string constructor

2024-01-07 Thread Jonathan Wakely
On Sun, 7 Jan 2024 at 18:50, François Dumont wrote: > > > On 07/01/2024 17:34, Jonathan Wakely wrote: > > On Sun, 7 Jan 2024 at 12:57, François Dumont wrote: > >> Hi > >> > >> While working on the patch to use the cxx11 abi in gnu version namespace > >> mode I got a small problem with this missin

Re: [PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-07 Thread Patrick Palka
On Sun, 7 Jan 2024, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > -- >8 -- > > The recursively defined constraints on _Variadic_union's user-defined > destructor (necessary for maintaining trivial destructibility of the > variant iff all of its alternativ

[PATCH] libstdc++: reduce std::variant template instantiation depth

2024-01-07 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- The recursively defined constraints on _Variadic_union's user-defined destructor (necessary for maintaining trivial destructibility of the variant iff all of its alternatives are) effectively require a template instantiation dep

[patch,avr,applied] Fix some avr test cases

2024-01-07 Thread Georg-Johann Lay
The patch below fixes some obvious problems in gcc.target/avr: * Remove duplicate -mmcu= * Skip tests with address spaces on Reduced Tiny which does not support address spaces at all. * Address spaces are GNU-C, but some tests were missing -std=gnu* * Don't test address-space __flash1 on dev

Re: [libgfortran, patch] PR113223 NAMELIST internal write missing leading blank character

2024-01-07 Thread Harald Anlauf
Hi Jerry! On 1/7/24 19:40, Jerry D wrote: Committed as simple and obvious. Initial patch thanks to Steve. When using git gcc-commit-mklog how does one add in the coauthor? % git help gcc-commit-mklog ... --co CO Add Co-Authored-By trailer (comma separated) However, I usually

[Patch] GCN: Add pre-initial support for gfx1100

2024-01-07 Thread Tobias Burnus
ROCm meanwhile supports also some consumer cards; besides the semi-new gfx1030, support for gfx1100 was added more recently (in ROCm 5.7.1 for "Ubuntu 22.04 only" and without parenthesis since ROCm 6.0.0). GCC has already very limited support for gfx1030 - whose multlib support is - on purpose

Re: [Committed] RISC-V: Use MAX instead of std::max [VSETVL PASS]

2024-01-07 Thread Jeff Law
On 1/6/24 17:36, Juzhe-Zhong wrote: Obvious fix, Committed. gcc/ChangeLog: * config/riscv/riscv-vsetvl.cc: replace std::max by MAX. Curious why you made this change -- in general we're moving to std::{min,max,swap} and away from macro-ized min/max/swap. Jeff

Re: [PATCH]middle-end: thread through existing LCSSA variable for alternative exits too [PR113237]

2024-01-07 Thread Toon Moene
On 1/7/24 18:29, Tamar Christina wrote: gcc/ChangeLog: PR tree-optimization/113237 * tree-vect-loop-manip.cc (slpeel_tree_duplicate_loop_to_edge_cfg): Use existing LCSSA variable for exit when all exits are early break. Might that be the same error as I got here when b

Re: [patch, testsuite, applied] PR52641 Fix more fallout from sloppy tests.

2024-01-07 Thread Jeff Law
On 1/7/24 10:17, Georg-Johann Lay wrote: Am 07.01.24 um 17:45 schrieb Jeff Law: On 1/7/24 08:53, Georg-Johann Lay wrote: Made some tests more generic so they can pass on more targets. Johann -- testsuite/52641: Fix fallout from sloppy tests. gcc/testsuite/  PR testsuite/52641    

Re: [PATCH] Add __cow_string C string constructor

2024-01-07 Thread François Dumont
On 07/01/2024 17:34, Jonathan Wakely wrote: On Sun, 7 Jan 2024 at 12:57, François Dumont wrote: Hi While working on the patch to use the cxx11 abi in gnu version namespace mode I got a small problem with this missing constructor. I'm not sure that the main patch will be integrated in gcc 14

[libgfortran, patch] PR113223 NAMELIST internal write missing leading blank character

2024-01-07 Thread Jerry D
Committed as simple and obvious. Initial patch thanks to Steve. When using git gcc-commit-mklog how does one add in the coauthor? The master branch has been updated by Jerry DeLisle : https://gcc.gnu.org/g:add995ec117d756e61d207041cd32f937c1a1cd9 commit r14-6986-gadd995ec117d756e61d207041cd32f

[PATCH]middle-end: thread through existing LCSSA variable for alternative exits too [PR113237]

2024-01-07 Thread Tamar Christina
Hi All, Builing on top of the previous patch, similar to when we have a single exit if we have a case where all exits are considered early exits and there are existing non virtual phi then in order to maintain LCSSA we have to use the existing PHI variables. We can't simply clear them and just re

Re: [patch, testsuite, applied] PR52641 Fix more fallout from sloppy tests.

2024-01-07 Thread Georg-Johann Lay
Am 07.01.24 um 17:45 schrieb Jeff Law: On 1/7/24 08:53, Georg-Johann Lay wrote: Made some tests more generic so they can pass on more targets. Johann -- testsuite/52641: Fix fallout from sloppy tests. gcc/testsuite/  PR testsuite/52641  * gcc.dg/torture/pr110838.c: Use proper sh

Re: [PATCH 6/4] libbacktrace: Add loaded dlls after initialize

2024-01-07 Thread Eli Zaretskii
> Date: Sun, 7 Jan 2024 17:07:06 +0100 > Cc: i...@google.com, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org > From: Björn Schäpers > > > That was about GetModuleHandle, not about GetModuleHandleEx. For the > > latter, all Windows versions that support it also support "wide" APIs. > > So my suggestio

[committed] Fix typo in last change

2024-01-07 Thread Jeff Law
Tester started complaining about this change as soon as it went in. Clearly there's an extraneous "short" in the testcase. Pushed to the trunk. Jeff commit 66d82874d2254bcb0124f77e6be220d299eab5f1 Author: Jeff Law Date: Sun Jan 7 09:52:44 2024 -0700 Fix typo in last change gc

Re: [PATCH RFC] c++: mangle function template constraints

2024-01-07 Thread Jonathan Wakely
On Sun, 7 Jan 2024 at 16:40, Patrick Palka wrote: > > On Tue, 5 Dec 2023, Jonathan Wakely wrote: > > > On Wed, 22 Nov 2023 at 14:50, Jonathan Wakely wrote: > > > > > > On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > > > > > > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any com

Re: [patch, testsuite, applied] PR52641 Fix more fallout from sloppy tests.

2024-01-07 Thread Jeff Law
On 1/7/24 08:53, Georg-Johann Lay wrote: Made some tests more generic so they can pass on more targets. Johann -- testsuite/52641: Fix fallout from sloppy tests. gcc/testsuite/ PR testsuite/52641 * gcc.dg/torture/pr110838.c: Use proper shift offset to get MSB or int. * gcc

Re: [PATCH RFC] c++: mangle function template constraints

2024-01-07 Thread Patrick Palka
On Tue, 5 Dec 2023, Jonathan Wakely wrote: > On Wed, 22 Nov 2023 at 14:50, Jonathan Wakely wrote: > > > > On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > > > > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any comments > > > before I > > > push this? > > > > The library parts a

Re: [PATCH] Add __cow_string C string constructor

2024-01-07 Thread Jonathan Wakely
On Sun, 7 Jan 2024 at 12:57, François Dumont wrote: > > Hi > > While working on the patch to use the cxx11 abi in gnu version namespace > mode I got a small problem with this missing constructor. I'm not sure > that the main patch will be integrated in gcc 14 so I think it is better > if I propose

Re: [x86 PATCH] PR target/113231: Improved costs in Scalar-To-Vector (STV) pass.

2024-01-07 Thread Uros Bizjak
On Sat, Jan 6, 2024 at 2:30 PM Roger Sayle wrote: > > > This patch improves the cost/gain calculation used during the i386 backend's > SImode/DImode scalar-to-vector (STV) conversion pass. The current code > handles loads and stores, but doesn't consider that converting other > scalar operations

Re: [PATCH 6/4] libbacktrace: Add loaded dlls after initialize

2024-01-07 Thread Björn Schäpers
Am 07.01.2024 um 15:46 schrieb Eli Zaretskii: [I re-added the other addressees, as I don' think you meant to make this discussion private between the two of us.] Yeah, that was a mistake. Date: Sun, 7 Jan 2024 12:58:29 +0100 From: Björn Schäpers Am 07.01.2024 um 07:50 schrieb Eli Zaretskii

[patch, testsuite, applied] PR52641 Fix more fallout from sloppy tests.

2024-01-07 Thread Georg-Johann Lay
Made some tests more generic so they can pass on more targets. Johann -- testsuite/52641: Fix fallout from sloppy tests. gcc/testsuite/ PR testsuite/52641 * gcc.dg/torture/pr110838.c: Use proper shift offset to get MSB or int. * gcc.dg/torture/pr112282.c: Use at least 3

Re: [PATCH 1/8] OpenMP: lvalue parsing for map/to/from clauses (C++)

2024-01-07 Thread Tobias Burnus
Am 05.01.24 um 13:23 schrieb Julian Brown: On Wed, 20 Dec 2023 15:31:15 +0100 Tobias Burnus wrote: Here's a rebased/retested version which fixes those bits (I haven't adjusted the libgomp.texi bit you noted yet, though). How does this look now? --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@

Re: [PATCH 6/4] libbacktrace: Add loaded dlls after initialize

2024-01-07 Thread Eli Zaretskii
[I re-added the other addressees, as I don' think you meant to make this discussion private between the two of us.] > Date: Sun, 7 Jan 2024 12:58:29 +0100 > From: Björn Schäpers > > Am 07.01.2024 um 07:50 schrieb Eli Zaretskii: > >> Date: Sat, 6 Jan 2024 23:15:24 +0100 > >> From: Björn Schäpers

Re: [PATCH] c++/modules: Prevent overwriting arguments for duplicates [PR112588]

2024-01-07 Thread Nathaniel Shead
On Sat, Jan 06, 2024 at 05:32:37PM -0500, Nathan Sidwell wrote: > I;m not sure about this, there was clearly a reason I did it the way it is, > but perhaps that reasoning became obsolete -- something about an existing > declaration and reading in a definition maybe? > > nathan So I took a bit of

[PATCH] Add __cow_string C string constructor

2024-01-07 Thread François Dumont
Hi While working on the patch to use the cxx11 abi in gnu version namespace mode I got a small problem with this missing constructor. I'm not sure that the main patch will be integrated in gcc 14 so I think it is better if I propose this patch independently.     libstdc++: Add __cow_string c

Re: [PATCH 1/8] OpenMP: metadirective tree data structures and front-end interfaces

2024-01-07 Thread Tobias Burnus
Hi Sandra, Tobias Burnus wrote: (I have now an errant to do - and will continue later with the review.) First, something a bit unrelated to this patch but affecting related code (quoting old, existing code): int omp_context_selector_matches (tree ctx) ... case O

[patch,testsuite,applied] PR52641: Fix more fallout from sloppy tests.

2024-01-07 Thread Georg-Johann Lay
This patch rectifies more tests that make assumptions on sizeof(int), sizeof(void*), etc. Johann -- testsuite/52641: Fix fallout from sloppy tests. gcc/testsuite/ PR testsuite/52641 * gcc.dg/memchr-3.c [avr]: Anticipate -Wbuiltin-declaration-mismatch. * gcc.dg/pr103207.

Re: [PATCH 3/8] libgomp: runtime support for target_device selector

2024-01-07 Thread Tobias Burnus
Tobias Burnus wrote: Sandra Loosemore wrote: From: Kwok Cheung Yeung This patch implements the libgomp runtime support for the dynamic target_device selector via the GOMP_evaluate_target_device function. ... +GOMP_evaluate_target_device (int device_num, const char *kind, +