Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578]

2023-11-22 Thread chenglulu
在 2023/11/23 下午3:11, Xi Ruoyao 写道: On Thu, 2023-11-23 at 14:35 +0800, chenglulu wrote: Hi,   I don’t quite understand this part. Is it because define_insn would be duplicated with the above implementation, so define_insn_and_split is used? Yes, but if you think duplicating the above implem

Re: Propagate value ranges of return values

2023-11-22 Thread Andrew Pinski
On Tue, Nov 21, 2023 at 6:07 AM Jan Hubicka wrote: > > > After this patch in addition to the problem already reported about > > vlda1.c and return-value-range-1.c, we have noticed these regressions > > on aarch64: > > Running gcc:gcc.target/aarch64/aarch64.exp ... > > FAIL: gcc.target/aarch64/movk

Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578]

2023-11-22 Thread Xi Ruoyao
On Thu, 2023-11-23 at 14:35 +0800, chenglulu wrote: > Hi, > >   I don’t quite understand this part. Is it because define_insn would be > duplicated with the above implementation, > > so define_insn_and_split is used? Yes, but if you think duplicating the above implementation is better I can dup

Re: [PATCH] gimple-vr-values:Add constraint for gimple-cond optimization

2023-11-22 Thread Andrew Pinski
On Wed, Nov 22, 2023 at 10:07 PM Feng Wang wrote: > > This patch add another condition for gimple-cond optimization. Refer to > the following test case. > int foo1 (int data, int res) > { > res = data & 0xf; > res |= res << 4; > if (res < 0x22) > return 0x22; > return res; > } > with t

Re: [PATCH v3 1/5] LoongArch: Fix usage of LSX and LASX frint/ftint instructions [PR112578]

2023-11-22 Thread chenglulu
在 2023/11/20 上午8:47, Xi Ruoyao 写道: The usage LSX and LASX frint/ftint instructions had some problems: 1. These instructions raises FE_INEXACT, which is not allowed with -fno-fp-int-builtin-inexact for most C2x section F.10.6 functions (the only exceptions are rint, lrint, and llrint).

Re: [PATCH] gimple-vr-values:Add constraint for gimple-cond optimization

2023-11-22 Thread Andrew Pinski
On Wed, Nov 22, 2023 at 10:07 PM Feng Wang wrote: > > This patch add another condition for gimple-cond optimization. Refer to > the following test case. > int foo1 (int data, int res) > { > res = data & 0xf; > res |= res << 4; > if (res < 0x22) > return 0x22; > return res; > } > with t

[PATCH] i386: Fix AVX512 and AVX10 option issues

2023-11-22 Thread Haochen Jiang
Hi all, This patch should be able to fix the current issue mentioned in PR112643. Also, I fixed some legacy issues in code related to AVX512/AVX10. Ok for trunk? Thx, Haochen gcc/ChangeLog: PR target/112643 * config/i386/driver-i386.cc (check_avx10_avx512_features): Re

[PATCH] gimple-vr-values:Add constraint for gimple-cond optimization

2023-11-22 Thread Feng Wang
This patch add another condition for gimple-cond optimization. Refer to the following test case. int foo1 (int data, int res) { res = data & 0xf; res |= res << 4; if (res < 0x22) return 0x22; return res; } with the compilation flag "-march=rv64gc_zba_zbb -mabi=lp64d -O2", before this pa

Re: [PATCH v2] ifcvt: Remove obsolete code for subreg handling in noce_convert_multiple_sets

2023-11-22 Thread Philipp Tomsich
Applied to master, thanks! Philipp, On Thu, 23 Nov 2023 at 04:48, Jeff Law wrote: > > > > On 11/21/23 11:04, Manolis Tsamis wrote: > > This code used to handle SUBREG for register replacement when ifcvt was > > doing > > the replacements manually. This special handling is not needed anymore > >

[PATCH v2] aarch64: Add support for Ampere-1B (-mcpu=ampere1b) CPU

2023-11-22 Thread Philipp Tomsich
This patch adds initial support for Ampere-1B core. The Ampere-1B core implements ARMv8.7 with the following (compiler visible) extensions: - CSSC (Common Short Sequence Compression instructions), - MTE (Memory Tagging Extension) - SM3/SM4 gcc/ChangeLog: * config/aarch64/aarch64-cores

Re: [PATCH] LoongArch: Fix runtime error in a gcc build with --with-build-config=bootstrap-ubsan

2023-11-22 Thread Xi Ruoyao
On Thu, 2023-11-23 at 11:05 +0800, Guo Jie wrote: > gcc/ChangeLog: > > * config/loongarch/loongarch.cc (loongarch_split_plus_constant): > avoid left shift of negative value -0x8000. > --- >  gcc/config/loongarch/loongarch.cc | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v2] LoongArch: Optimize the loading of immediate numbers with the same high and low 32-bit values

2023-11-22 Thread Xi Ruoyao
On Thu, 2023-11-23 at 11:04 +0800, Guo Jie wrote: > For the following immediate load operation in > gcc/testsuite/gcc.target/loongarch/imm-load1.c: > > long long r = 0x0101010101010101; > > Before this patch: > > lu12i.w     $r15,16842752>>12 > ori     $r15,$r15,257 >

[PATCH] LoongArch: Fix runtime error in a gcc build with --with-build-config=bootstrap-ubsan

2023-11-22 Thread Guo Jie
gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_split_plus_constant): avoid left shift of negative value -0x8000. --- gcc/config/loongarch/loongarch.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/lo

[PATCH v2] LoongArch: Optimize the loading of immediate numbers with the same high and low 32-bit values

2023-11-22 Thread Guo Jie
For the following immediate load operation in gcc/testsuite/gcc.target/loongarch/imm-load1.c: long long r = 0x0101010101010101; Before this patch: lu12i.w $r15,16842752>>12 ori $r15,$r15,257 lu32i.d $r15,0x10101>>32 lu52i.d $r1

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-22 Thread Kewen.Lin
on 2023/11/22 18:25, Richard Biener wrote: > On Wed, Nov 22, 2023 at 10:31 AM Kewen.Lin wrote: >> >> on 2023/11/17 20:55, Alexander Monakov wrote: >>> >>> On Fri, 17 Nov 2023, Kewen.Lin wrote: > I don't think you can run cleanup_cfg after sched_init. I would suggest > to put it early in sc

Re: Re: [PATCH 0/5] Add support for operand-specific alignment requirements

2023-11-22 Thread 钟居哲
Hi, Richard. Current define_mode_attr can only map an attribute for a mode. I wonder whether we can map a mode to multiple attributes ? E.g. (define_mode_attr dest_constraint [(V16QI "&vr")]) But I want it to be: (define_mode_attr dest_constraint [(V16QI (TARGET_MIN_VLEN <= 128 "vr") (TARGET_M

[PATCH] c++: alias template of non-template class [PR112633]

2023-11-22 Thread Patrick Palka
Bootstrapped and regtested on x86-64-pc-linux-gnu, does this look OK for trunk/13? -- >8 -- The entering_scope adjustment in tsubst_aggr_type assumes if an alias is dependent, then so is the aliased type (and therefore it has template info) but that's not true for the dependent alias template spe

Re: [PATCH] AArch64/testsuite: Use non-capturing parentheses with ccmp_1.c

2023-11-22 Thread Richard Earnshaw (lists)
On 22/11/2023 15:21, Maciej W. Rozycki wrote: > Use non-capturing parentheses for the subexpressions used with > `scan-assembler-times', to avoid a quirk with double-counting. > > gcc/testsuite/ > * gcc.target/aarch64/ccmp_1.c: Use non-capturing parentheses > with `scan-assembl

Re: [RFA] New pass for sign/zero extension elimination

2023-11-22 Thread Jeff Law
On 11/20/23 11:56, Dimitar Dimitrov wrote: On Sun, Nov 19, 2023 at 05:47:56PM -0700, Jeff Law wrote: ... +/* Process uses in INSN. Set appropriate bits in LIVENOW for any chunks of + pseudos that become live, potentially filtering using bits from LIVE_TMP. + + If MODIFIED is true, then o

Re: [PATCH] c++, v4: Implement C++26 P2741R3 - user-generated static_assert messages [PR110348]

2023-11-22 Thread Jason Merrill
On 11/22/23 05:00, Jakub Jelinek wrote: On Tue, Nov 21, 2023 at 10:51:36PM -0500, Jason Merrill wrote: Actually, let's go back to the previous message, but change the tf_nones above to 'complain' so that we see those errors and then this explanation. Likewise with the conversion checks later in

Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Kito Cheng
I am less worry about the thead vector combined with other zv extension, instead we should reject those combinations at all. My reason is thead vector is transitional products, they won't have any further new products with that longer, also it's not compatible with all other zv extension in theory

Adjust 'libgomp.c/declare-variant-{3,4}-[...]' for inter-procedural value range propagation (was: Propagate value ranges of return values)

2023-11-22 Thread Thomas Schwinge
Hi! On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > this is updated version which also adds testuiste compensation > I lost earlier while maintaining the patch in my testing tree. > There are quite few testcases that use constant return values to hide > something from optimizer. One more: comm

Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Christoph Müllner
On Wed, Nov 22, 2023 at 11:48 PM Kito Cheng wrote: > > I am less worry about the thead vector combined with other zv extension, > instead we should reject those combinations at all. > > My reason is thead vector is transitional products, they won't have any > further new products with that longe

Re: [PATCH #2/4] c++: mark short-enums as packed

2023-11-22 Thread Jason Merrill
On 11/22/23 13:12, Jason Merrill wrote: On 11/22/23 03:17, Alexandre Oliva wrote: On Nov 20, 2023, Jason Merrill wrote: I think the warning is wrong here. Interesting...  Yeah, your analysis makes perfect sense. Still, we're left with a divergence WRT the TYPE_PACKED status of enum types b

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread Jason Merrill
On 11/22/23 15:46, waffl3x wrote: On Tuesday, November 21st, 2023 at 8:22 PM, Jason Merrill wrote: On 11/21/23 08:04, waffl3x wrote: /* Nonzero for FUNCTION_DECL means that this decl is a non-static - member function. */ + member function, use DECL_IOBJ_MEMBER_FUNC_P instead. */ #define DECL

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread waffl3x
On Wednesday, November 22nd, 2023 at 2:38 PM, Jason Merrill wrote: > > > On 11/22/23 15:46, waffl3x wrote: > > > On Tuesday, November 21st, 2023 at 8:22 PM, Jason Merrill ja...@redhat.com > > wrote: > > > > > On 11/21/23 08:04, waffl3x wrote: > > > > > > > /* Nonzero for FUNCTION_DE

Re: [committed] d: Merge upstream dmd ff57fec515, druntime ff57fec515, phobos 17bafda79.

2023-11-22 Thread Iain Buclaw
Excerpts from Rainer Orth's message of November 21, 2023 5:03 pm: > Rainer Orth writes: > >> either this patch or the previous one broke D bootstrap with GCC 9. On >> both i386-pc-solaris2.11 with gdc 9.4.0 and sparc-sun-solaris2.11 with >> gdc 9.3.0, stage 1 d21 fails to link with >> >> Undefin

Re: [PATCH v3 02/11] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Florian Weimer wrote: > This test looks like it intends to pass a small struct argument > through both a non-variadic and variadic argument, but due to > the typo, it does not achieve that. > > gcc/testsuite/ > > * gcc.target/aarch64/aapcs64/ice_1.c (foo): Call named.

Re: [PATCH v2] ifcvt: Remove obsolete code for subreg handling in noce_convert_multiple_sets

2023-11-22 Thread Jeff Law
On 11/21/23 11:04, Manolis Tsamis wrote: This code used to handle SUBREG for register replacement when ifcvt was doing the replacements manually. This special handling is not needed anymore because simplify_replace_rtx is used for the replacements and it properly handles these cases. gcc/Chan

Re: [PATCH] c: Add __builtin_stdc_bit_{width,floor,ceil} builtins

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Jakub Jelinek wrote: > On Mon, Nov 20, 2023 at 04:03:07PM +0100, Jakub Jelinek wrote: > > > Note that stdc_bit_ceil now has defined behavior (return 0) on overflow: > > > CD2 comment FR-135 was accepted for the DIS at the June WG14 meeting. > > > This affects both the docum

Re: [PATCH] c++: alias template of non-template class [PR112633]

2023-11-22 Thread Jason Merrill
On 11/22/23 12:26, Patrick Palka wrote: Bootstrapped and regtested on x86-64-pc-linux-gnu, does this look OK for trunk/13? OK. -- >8 -- The entering_scope adjustment in tsubst_aggr_type assumes if an alias is dependent, then so is the aliased type (and therefore it has template info) but tha

Re: [PATCH 2/2] bugzilla: remove `gcc-bugs@` mailing list address

2023-11-22 Thread Xi Ruoyao
On Wed, 2023-11-22 at 20:57 -0500, Ben Boeckel wrote: > Is there a version of autoconf I should use? I have 2.71 laying around > but see that these were generated with 2.69. If you want me to regen > with 2.71, I'll do that as separate prep commits so that this diff is > sensible. Or I can try and

[pushed] wwwdocs: faq: Refer to gcc-testresults instead of buildstat.html

2023-11-22 Thread Gerald Pfeifer
This is the last obsolete reference to buildstat.html shared by Thomas and per my own `grep -r`. Pushed. Gerald --- htdocs/faq.html | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/htdocs/faq.html b/htdocs/faq.html index 203661dc..5c713a70 100644 --- a/htdocs/faq.html +

Re: [PATCH v2 5/6] libgomp, nvptx: Cuda pinned memory

2023-11-22 Thread Tobias Burnus
(I have not fully thought about the 2/6, 3/6 and 4/6 patches, but I think except for some patch apply issues, 1/6 + this 5/6 can be both committed without needing 2-4.) On 23.08.23 16:14, Andrew Stubbs wrote: Use Cuda to pin memory, instead of Linux mlock, when available. There are two advantag

[PATCH] c++: Implement P2582R1, CTAD from inherited constructors

2023-11-22 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- This patch implements C++23 class template argument deduction from inherited constructors, which is specified in terms of C++20 alias CTAD which we already fully support. The rule for transforming the return

[PATCH, v4] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Harald Anlauf
Hi Mikael! On 11/22/23 10:36, Mikael Morin wrote: (...) diff --git a/gcc/fortran/error.cc b/gcc/fortran/error.cc index 2ac51e95e4d..be715b50469 100644 --- a/gcc/fortran/error.cc +++ b/gcc/fortran/error.cc @@ -980,7 +980,11 @@ char const*  notify_std_msg(int std)  { -  if (std & GFC_STD_F2018_

Re: [PATCH #2/4] c++: mark short-enums as packed

2023-11-22 Thread Jason Merrill
On 11/22/23 03:17, Alexandre Oliva wrote: On Nov 20, 2023, Jason Merrill wrote: I think the warning is wrong here. Interesting... Yeah, your analysis makes perfect sense. Still, we're left with a divergence WRT the TYPE_PACKED status of enum types between C and C++. It sort of kind of mak

Re: [PATCH v5] Introduce attribute sym_alias

2023-11-22 Thread Joseph Myers
Is it OK to apply this attribute to a (file-scope or block-scope) static variable or function in C (and if it is, what's the linkage of the resulting alias)? That doesn't seem very clear to me from the documentation, and I'd also expect a testcase of this, whatever the answer is. What's the i

Re: Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread 钟居哲
I prefer ASM_OUTPUT_OPCODE or assembler dialect to %^ and I don't want to see any change of vector.md. %^ will cause high burden for future maintainment. Besides, ASM_OUTPUT_OPCODE can the whole string. My patch is just a draft. We can exlude for example, in zvbb, we can exclude appending "th."

Re: [PATCH 1/2] testsuite/unroll-8: Avoid triggering undefined behavior

2023-11-22 Thread Jeff Law
On 11/21/23 16:27, Palmer Dabbelt wrote: I was poking around with this test failure and noticed it was exercising undefined behavior. The return type doesn't matter for what's being tested, so just mark it as void. gcc/testsuite/ChangeLog: * gcc.dg/unroll-8.c: Remove UB. I just revi

Re: [RFA] New pass for sign/zero extension elimination

2023-11-22 Thread Jeff Law
On 11/20/23 11:26, Richard Sandiford wrote: + +/* If we know the destination of CODE only uses some low bits + (say just the QI bits of an SI operation), then return true + if we can propagate the need for just the subset of bits + from the destination to the sources. */ + +static bool

Re: [PATCH, v3] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Steve Kargl
On Wed, Nov 22, 2023 at 10:36:00AM +0100, Mikael Morin wrote: > > OK with this fixed (and the previous comments as you wish), if Steve has no > more comments. > No further comments. Thanks for your patients, Harald. As side note, I found John Reid's "What's new" document where it is noted that

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-22 Thread Jonathan Yong
On 11/22/23 12:34, Costas Argyris wrote: Attached a new patch. A couple things to note: 1) I changed your host_extra_objs=utf8-mingw32.o to host_extra_objs_mingw=utf8-mingw32.o to match the other two, since I believe that's what you meant. 2) This approach has the complication that the var

Re: [PATCH v3 01/11] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Florian Weimer wrote: > * config/aarch64/linux-unwind.h > (aarch64_fallback_frame_state): Add cast to the expected type > in sc assignment. OK in the absence of AArch64 maintainer objections within 48 hours. -- Joseph S. Myers jos...@codesourcery.com

[committed] hppa: Define MAX_FIXED_MODE_SIZE

2023-11-22 Thread John David Anglin
Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11. Committed to trunk. Fixes FAIL: c-c++-common/pr111309-1.c ICE. Dave --- hppa: Define MAX_FIXED_MODE_SIZE Replace default define. We support TImode when TARGET_64BIT is true. 2023-11-22 John David Anglin gcc/ChangeLog: PR

[PATCH, testsuite, fortran] fix invalid testcases (missing MOLD argument to NULL)

2023-11-22 Thread Harald Anlauf
Dear all, testcases assumed_rank_8.f90 and assumed_rank_10.f90 are invalid: NULL() is passed without MOLD to an assumed-rank dummy argument. This is detected by NAG, but not yet by gfortran (see pr104819). gfortran even ignores the MOLD argument; the dump-tree is identical if MOLD is there or not

Re: [PATCH v3 03/11] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Florian Weimer wrote: > gcc/testsuite/ > > * gm2/link/externalscaffold/pass/scaffold.c (m2pim_M2RTS_Terminate): > Declare. OK in the absence of Modula-2 maintainer objections within 48 hours. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH 2/2] bugzilla: remove `gcc-bugs@` mailing list address

2023-11-22 Thread Ben Boeckel
On Wed, Nov 22, 2023 at 23:15:56 +, Joseph Myers wrote: > On Mon, 20 Nov 2023, Ben Boeckel wrote: > > > Bugzilla is preferred today. > > > > ChangeLog: > > > > * config-ml.in: Replace gcc-bugs@ with Bugzilla link. > > * symlink-tree: Replace gcc-bugs@ with Bugzilla link. > > I don't

Re: [PATCH 1/2] testsuite/unroll-8: Avoid triggering undefined behavior

2023-11-22 Thread Andrew Pinski
On Tue, Nov 21, 2023 at 3:29 PM Palmer Dabbelt wrote: > > I was poking around with this test failure and noticed it was exercising > undefined behavior. The return type doesn't matter for what's being > tested, so just mark it as void. Just a quick note, this is NOT undefined behavior in C to re

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-22 Thread Florian Weimer
* Jeff Law: > On 11/20/23 02:55, Florian Weimer wrote: >> This revision addresses Marek's comment about handing >> -Wdeclaration-missing-parameter-type properly in conjunction with >> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >> demonstrates the expected behavior. I added a te

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-22 Thread Jeff Law
On 11/20/23 02:55, Florian Weimer wrote: This revision addresses Marek's comment about handing -Wdeclaration-missing-parameter-type properly in conjunction with -fpermissive. A new test (permerror-fpermissive-nowarning.c) demonstrates the expected behavior. I added a test for -std=gnu89 -fno

[PATCH 1/2] c-family: -Waddress-of-packed-member and casts

2023-11-22 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, OK for trunk? -- 8< -- -Waddress-of-packed-member, in addition to the documented warning about taking the address of a packed member, also warns about casting from a pointer to a TYPE_PACKED type to a pointer to a type with greater alignment. This wrongly warns if the

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread waffl3x
On Tuesday, November 21st, 2023 at 8:22 PM, Jason Merrill wrote: > > > On 11/21/23 08:04, waffl3x wrote: > > > Bootstrapped and tested on x86_64-linux with no regressions. > > > > Hopefully this patch is legible enough for reviewing purposes, I've not > > been feeling the greatest so it w

Re: [PATCH, v3] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Harald Anlauf
Hi Steve, On 11/22/23 19:03, Steve Kargl wrote: On Wed, Nov 22, 2023 at 10:36:00AM +0100, Mikael Morin wrote: OK with this fixed (and the previous comments as you wish), if Steve has no more comments. No further comments. Thanks for your patients, Harald. As side note, I found John Reid's

[committed] hppa: Fix integer REG+D address reloads

2023-11-22 Thread John David Anglin
Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11. Fixes testcase in PR. Committed to trunk. Dave --- hppa: Fix integer REG+D address reloads I made a mistake in the previous change to integer_store_memory_operand. There is no support pa_emit_move sequence to handle secondary reloads of

Re: [PATCH 2/2] bugzilla: remove `gcc-bugs@` mailing list address

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Ben Boeckel wrote: > Bugzilla is preferred today. > > ChangeLog: > > * config-ml.in: Replace gcc-bugs@ with Bugzilla link. > * symlink-tree: Replace gcc-bugs@ with Bugzilla link. I don't think we should use a URL that redirects (i.e. https://gcc.gnu.org/bugzill

[pushed] wwwdocs: branching: No longer refer to buildstat.html

2023-11-22 Thread Gerald Pfeifer
Thomas spotted this (among others) not being necessary any longer and kindly reported it. Pushed. --- htdocs/branching.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/htdocs/branching.html b/htdocs/branching.html index 0d48dce1..23ff92e8 100644 --- a/htdocs/branching.html +++ b/htdocs

Re: [PATCH] Clean up by_pieces_ninsns

2023-11-22 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi, > > on 2023/11/15 10:26, HAO CHEN GUI wrote: >> Hi, >> This patch cleans up by_pieces_ninsns and does following things. >> 1. Do the length and alignment adjustment for by pieces compare when >> overlap operation is enabled. >> 2. Remove unnecessary mov_optab checks. >>

[PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits

2023-11-22 Thread Sandra Loosemore
This patch introduces enumerators to represent trait-set names and trait names, which makes it easier to use tables to control other behavior and for switch statements to dispatch on the tags. The tags are stored in the same place in the TREE_LIST structure (OMP_TSS_ID or OMP_TS_ID) and are encode

[PATCH 2/2] c-family: rename warn_for_address_or_pointer_of_packed_member

2023-11-22 Thread Jason Merrill
Following the last patch, let's rename the functions to reflect the change in behavior. gcc/c-family/ChangeLog: * c-warn.cc (check_address_or_pointer_of_packed_member): Rename to check_address_of_packed_member. (check_and_warn_address_or_pointer_of_packed_member):

[pushed] wwwdocs: releasing: No longer refer to buildstat.html

2023-11-22 Thread Gerald Pfeifer
That's the counterpart to the branching.html change I just made, also reported by Thomas. Pushed. Gerald --- htdocs/releasing.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/htdocs/releasing.html b/htdocs/releasing.html index 1cd56f72..c7365e64 100644 --- a/htdocs/releasing.html +++

Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Jeff Law
On 11/22/23 07:24, Christoph Müllner wrote: On Wed, Nov 22, 2023 at 2:52 PM 钟居哲 wrote: I am totally ok to approve theadvector on GCC-14 before stage 3 close as long as it doesn't touch the current RVV codes too much and binutils supports theadvector. I have provided the draft approach: ht

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread waffl3x
> > > > /* Nonzero for FUNCTION_DECL means that this decl is a non-static > > > > - member function. */ > > > > + member function, use DECL_IOBJ_MEMBER_FUNC_P instead. */ > > > > #define DECL_NONSTATIC_MEMBER_FUNCTION_P(NODE) \ > > > > (TREE_CODE (TREE_TYPE (NODE)) == METHOD_TYPE) > > > > > > > >

RE: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Li, Pan2
Committed, thanks all. Pan -Original Message- From: Richard Sandiford Sent: Thursday, November 23, 2023 2:39 AM To: Li, Pan2 Cc: Richard Biener ; juzhe.zh...@rivai.ai; Wang, Yanzhang ; kito.ch...@gmail.com; Jeff Law ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH v4] DSE: Allow vector

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 01:21:12PM +0100, Jakub Jelinek wrote: > So, pedantically perhaps just assuming TRY_CATCH_EXPR where second argument > is not STATEMENT_LIST to be the CATCH_EXPR/EH_FILTER_EXPR case could work > for C++, but there are other FEs and it would be fragile (and weird, given > tha

[PATCHv2] Clean up by_pieces_ninsns

2023-11-22 Thread HAO CHEN GUI
Hi, This patch cleans up by_pieces_ninsns and does following things. 1. Do the length and alignment adjustment for by pieces compare when overlap operation is enabled. 2. Replace unnecessary mov_optab checks with gcc assertions. Compared to last version, the main change is to replace unnecessa

Re: [committed] d: Merge upstream dmd ff57fec515, druntime ff57fec515, phobos 17bafda79.

2023-11-22 Thread Iain Buclaw
Excerpts from Rainer Orth's message of November 21, 2023 4:59 pm: > Hi Iain, > >> This patch merges the D front-end and runtime library with upstream dmd >> ff57fec515, and the standard library with phobos 17bafda79. >> >> Synchronizing with the upstream release candidate of v2.106.0. >> >> D fron

Re: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Richard Sandiford
"Li, Pan2" writes: >> It looks like Jeff approved the patch? > > Yes, just would like to double check the way of this patch is expected as > following the suggestion of Richard S. Yeah, it looks good to me, thanks. Richard > Pan > > -Original Message- > From: Richard Biener > Sent: W

Re: [PATCH 2/2] testsuite/unroll-8: Disable vectorization for varibale-factor targets

2023-11-22 Thread Jeff Law
On 11/21/23 16:27, Palmer Dabbelt wrote: The vectorizer picks up these loops and disables unrolling on targets with variable vector factors. That result in better code here, but it trips up the unrolling tests. So just disable vectorization for these. gcc/testsuite/ChangeLog: PR ta

[PATCH] AArch64/testsuite: Use non-capturing parentheses with ccmp_1.c

2023-11-22 Thread Maciej W. Rozycki
Use non-capturing parentheses for the subexpressions used with `scan-assembler-times', to avoid a quirk with double-counting. gcc/testsuite/ * gcc.target/aarch64/ccmp_1.c: Use non-capturing parentheses with `scan-assembler-times'. --- Hi, Here's another one. I realised

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Simon Wright
> On 22 Nov 2023, at 15:03, Iain Sandoe wrote: > > > >> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: >> >> >> >>> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >>> >> #if defined (__APPLE__) >> -#include > > If removing unistd.h is intentional (i.e. you determined th

Re: [PATCH v3 2/8] Unify implementations of print_hard_reg_set()

2023-11-22 Thread Vladimir Makarov
On 11/22/23 06:14, Maxim Kuvyrkov wrote: We currently have 3 implementations of print_hard_reg_set() (all with the same name!) in ira-color.cc, ira-conflicts.cc, and sel-sched-dump.cc. This patch generalizes implementation in ira-color.cc, and uses it in all other places. The declaration is a

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: > > > >> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >> > #if defined (__APPLE__) > -#include If removing unistd.h is intentional (i.e. you determined that it’s no longer needed for Darwin), then we should ma

Re: [PATCH RFC] c++: mangle function template constraints

2023-11-22 Thread Jonathan Wakely
On Wed, 22 Nov 2023 at 14:50, Jonathan Wakely wrote: > > On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any comments before I > > push this? > > The library parts are OK. > > The variable template is_trivially_copyable_v just uses

[pushed] testsuite: Update path to intl include.

2023-11-22 Thread Iain Sandoe
Tested on i686, x86_64 and aarch64 Darwin, aarch64 and x86_64 Linux, pushed to master as obvious, thanks Iain --- 8< --- When we are building libintl in-tree, we need to pass the path to the generated libintl.h include to the plugin tests. This path has changed with the use of gettext directly.

Re: [PATCH v3] aarch64: SVE/NEON Bridging intrinsics

2023-11-22 Thread Richard Sandiford
Richard Ball writes: > ACLE has added intrinsics to bridge between SVE and Neon. > > The NEON_SVE Bridge adds intrinsics that allow conversions between NEON and > SVE vectors. > > This patch adds support to GCC for the following 3 intrinsics: > svset_neonq, svget_neonq and svdup_neonq > > gcc/Chan

Re: [PATCH RFC] c++: mangle function template constraints

2023-11-22 Thread Jonathan Wakely
On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any comments before I > push this? The library parts are OK. The variable template is_trivially_copyable_v just uses __is_trivially_copyable so should be just as efficient, and the change

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: > #if defined (__APPLE__) -#include >>> >>> If removing unistd.h is intentional (i.e. you determined that it’s no longer >>> needed for Darwin), then we should make that a separate patch. >> >> I thought that I’d had to include uni

Re: [PATCH 01/11] rtl-ssa: Support for inserting new insns

2023-11-22 Thread Alex Coplan
On 21/11/2023 11:51, Richard Sandiford wrote: > Alex Coplan writes: > > N.B. this is just a rebased (but otherwise unchanged) version of the > > same patch already posted here: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633348.html > > > > this is the only unreviewed dependency

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Paul Koning
> On Nov 22, 2023, at 8:54 AM, Simon Wright wrote: > > On 21 Nov 2023, at 23:13, Iain Sandoe wrote: > >>> #if defined (__APPLE__) >>> -#include >> >> If removing unistd.h is intentional (i.e. you determined that it’s no longer >> needed for Darwin), then we should make that a separate patc

[PATCH] tree-optimization/112344 - wrong final value replacement

2023-11-22 Thread Richard Biener
When performing final value replacement chrec_apply that's used to compute the overall effect of niters to a CHREC doesn't consider that the overall increment of { -2147483648, +, 2 } doesn't fit in a signed integer when the loop iterates until the value of the IV of 20. The following fixes this m

[PATCH] libgcc: mark __hardcfr_check_fail as always_inline

2023-11-22 Thread Jose E. Marchesi
The function __hardcfr_check_fail in hardcfr.c is internal and static inline. It receives many arguments, which require more than five registers to be passed in bpf-none-unknown targets. BPF is limited to that number of registers to pass arguments, and therefore libgcc fails to build in that targ

[committed] amdgcn: Fix vector TImode reload loop

2023-11-22 Thread Andrew Stubbs
This patch fixes a reload bug that's hard to reproduce reliably (so far I've only observed it on the OG13 branch, with testcase gcc.c-torture/compile/pr70355.c), but causes an infinite loop in reload when it fails. For some reason it wants to save a value from AVGPRs to memory, this can't hap

Re: [PATCH v2 1/6] libgomp: basic pinned memory on Linux

2023-11-22 Thread Tobias Burnus
Hi Andrew, Side remark: -#define MEMSPACE_CALLOC(MEMSPACE, SIZE) \ - calloc (1, (((void)(MEMSPACE), (SIZE This fits a bit more to previous patch, but I wonder whether that should use (MEMSPACE, NMEMB, SIZE) instead - to fit to the actual calloc arguments. I think the main/only difference

Re: Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Christoph Müllner
On Wed, Nov 22, 2023 at 2:52 PM 钟居哲 wrote: > > I am totally ok to approve theadvector on GCC-14 before stage 3 close > as long as it doesn't touch the current RVV codes too much and binutils > supports theadvector. > > I have provided the draft approach: > https://gcc.gnu.org/pipermail/gcc-patche

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Sebastian Huber
On 22.11.23 15:22, Christophe Lyon wrote: On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: On 21.11.23 11:46, Jakub Jelinek wrote: On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: On 21.11.23 11:34, Jakub Jelinek wrote: --- a/gcc/tree-profile.cc +++ b/gcc/tree-profile.cc

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Christophe Lyon
Hi, On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: > > On 21.11.23 11:46, Jakub Jelinek wrote: > > On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: > >> > >> On 21.11.23 11:34, Jakub Jelinek wrote: > --- a/gcc/tree-profile.cc > +++ b/gcc/tree-profile.cc > @@ -

Re: [PATCH v2] A new copy propagation and PHI elimination pass

2023-11-22 Thread Filip Kastl
Hi Richard, > Can you name the new file gimple-ssa-sccopy.cc please? Yes, no problem. Btw, I thought that it is standard that gimple ssa passes have the tree-ssa- prefix. Do I understand it correctly that this is not true and many tree-ssa-*.cc passes should actually be named gimple-ssa-*.cc but

Re: [PATCH v4] Introduce strub: machine-independent stack scrubbing

2023-11-22 Thread Richard Biener
On Mon, Nov 20, 2023 at 1:40 PM Alexandre Oliva wrote: > > On Oct 26, 2023, Alexandre Oliva wrote: > > >> This is a refreshed and improved version of the version posted back in > >> June. https://gcc.gnu.org/pipermail/gcc-patches/2023-June/621936.html > > > Ping? https://gcc.gnu.org/pipermail/gc

[pushed] [PR112610] [IRA]: Fix using undefined dump file in IRA code during insn scheduling

2023-11-22 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112610 The patch was successfully tested and bootstrapped on x86-64. commit 95f61de95bbcc2e4fb7020e27698140abea23788 Author: Vladimir N. Makarov Date: Wed Nov 22 09:01:02 2023 -0500 [IRA]: Fix using undefined dump fi

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Arnaud Charlet
> >> #if defined (__APPLE__) > >> -#include > > > > If removing unistd.h is intentional (i.e. you determined that it’s no longer > > needed for Darwin), then we should make that a separate patch. > > I thought that I’d had to include unistd.h for the first patch in this > thread; clearly not! >

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Simon Wright
On 21 Nov 2023, at 23:13, Iain Sandoe wrote: >> #if defined (__APPLE__) >> -#include > > If removing unistd.h is intentional (i.e. you determined that it’s no longer > needed for Darwin), then we should make that a separate patch. I thought that I’d had to include unistd.h for the first patch

Re: Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread 钟居哲
I am totally ok to approve theadvector on GCC-14 before stage 3 close as long as it doesn't touch the current RVV codes too much and binutils supports theadvector. I have provided the draft approach: https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637349.html which turns out doesn't need

Re: [PATCH v5] Introduce attribute sym_alias (was: Last call for bikeshedding on attribute sym/exalias/reverse_alias)

2023-11-22 Thread Jan Hubicka
Hi, it seems that interface to symbol table is fairly minimal here reduced to... > (create_sym_alias_decl, create_sym_alias_decls): New. > * cgraphunit.cc (cgraph_node::analyze): Create alias_target > node if needed. called from here... > (analyze_functions): Fixup visibilit

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-22 Thread Costas Argyris
Attached a new patch. A couple things to note: 1) I changed your host_extra_objs=utf8-mingw32.o to host_extra_objs_mingw=utf8-mingw32.o to match the other two, since I believe that's what you meant. 2) This approach has the complication that the variables in configure.ac need to be set befor

Re: [PATCH] RISC-V: Fix incorrect use of vcompress in permutation auto-vectorization

2023-11-22 Thread juzhe.zh...@rivai.ai
Committed as it is obvious bug fix. juzhe.zh...@rivai.ai From: Juzhe-Zhong Date: 2023-11-22 18:53 To: gcc-patches CC: kito.cheng; kito.cheng; jeffreyalaw; rdapp.gcc; Juzhe-Zhong Subject: [PATCH] RISC-V: Fix incorrect use of vcompress in permutation auto-vectorization This patch fixes followin

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 01:06:28PM +0100, Jakub Jelinek wrote: > Looking at a trivial example > void bar (); > void > foo (void) > { > try { bar (); } catch (int) {} > } > it seems it is even more complicated, because what e.g. the gimplification > sees is not TRY_CATCH_EXPR with CATCH_EXPR secon

Re: [PATCH v5] Introduce attribute sym_alias

2023-11-22 Thread Richard Biener
On Mon, Nov 20, 2023 at 1:54 PM Alexandre Oliva wrote: > > On Sep 20, 2023, Alexandre Oliva wrote: > > > This patch introduces an attribute to add extra asm names (aliases) > > for a decl when its definition is output. > > Ping? > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630971.ht

Gcc

2023-11-22 Thread Suma Luther
Hi Gcc, I'm following up to confirm if you are interested in acquiring the Registrants/Attendees/Members list. * CMAA Annual Conference (Washington, USA, Oct 29-31, 2023) * 1,000+ Contacts Let me know your thoughts so that I can share the price & more infor

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 11:32:10AM +, Richard Biener wrote: > > hack in gcc 13 and triggered on hundreds of tests there within just 5 > > seconds of running make check-g++ -j32 (and in cases I looked at had nothing > > to do with the r14-5086 backports), so I believe this is just bad > > assump

  1   2   >